MdeModulePkg/Include/Guid/TtyTerm.h | 13 + .../BootMaintenanceManager.h | 12 +- .../BootMaintenanceManagerStrings.uni | 10 +- .../ConsoleOption.c | 35 +-- .../BootMaintenanceManagerUiLib/Data.c | 16 +- MdeModulePkg/MdeModulePkg.dec | 4 + .../Universal/Console/TerminalDxe/Terminal.c | 17 +- .../Universal/Console/TerminalDxe/Terminal.h | 37 ++- .../Console/TerminalDxe/TerminalConIn.c | 281 ++++++++++++++++-- .../Console/TerminalDxe/TerminalConOut.c | 4 + .../Console/TerminalDxe/TerminalDxe.inf | 6 +- 11 files changed, 375 insertions(+), 60 deletions(-)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2186 Putty is a very popular terminal tool in windows. So add the whole support terminal keyboard type for it. The new introduced type is Linux, XtermR6, VT400 and SCO. And enhance the support for VT100+. This patch set only add the support of function key. Refer to the link: https://www.ssh.com/ssh/putty/putty-manuals/0.68/Chapter4.html#config-funkeys V2: Fix typo. Merge the type guid defination into TtyTerm.h. Cc: Jian J Wang <jian.j.wang@intel.com> Cc: Hao A Wu <hao.a.wu@intel.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Laszlo Ersek <lersek@redhat.com> Cc: Liming Gao <liming.gao@intel.com> Signed-of-by: Zhichao Gao <zhichao.gao@intel.com> Zhichao Gao (3): MdeModulePkg: Extend the support keyboard type of Terminal console MdeModulePkg/TerminalDxe: Extend the terminal console support types MdeModulePkg/BM_UI: Add the new terminal types to related menu MdeModulePkg/Include/Guid/TtyTerm.h | 13 + .../BootMaintenanceManager.h | 12 +- .../BootMaintenanceManagerStrings.uni | 10 +- .../ConsoleOption.c | 35 +-- .../BootMaintenanceManagerUiLib/Data.c | 16 +- MdeModulePkg/MdeModulePkg.dec | 4 + .../Universal/Console/TerminalDxe/Terminal.c | 17 +- .../Universal/Console/TerminalDxe/Terminal.h | 37 ++- .../Console/TerminalDxe/TerminalConIn.c | 281 ++++++++++++++++-- .../Console/TerminalDxe/TerminalConOut.c | 4 + .../Console/TerminalDxe/TerminalDxe.inf | 6 +- 11 files changed, 375 insertions(+), 60 deletions(-) -- 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47340): https://edk2.groups.io/g/devel/message/47340 Mute This Topic: https://groups.io/mt/34173528/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Tue, 17 Sep 2019 at 07:22, Gao, Zhichao <zhichao.gao@intel.com> wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2186 > > Putty is a very popular terminal tool in windows. So add the whole support > terminal keyboard type for it. The new introduced type is Linux, XtermR6, > VT400 and SCO. And enhance the support for VT100+. > This patch set only add the support of function key. Refer to the link: > https://www.ssh.com/ssh/putty/putty-manuals/0.68/Chapter4.html#config-funkeys > > V2: > Fix typo. > Merge the type guid defination into TtyTerm.h. > Hello Zhichao, Since you already pushed the broken patch, you should really be posting an updated patch with just the fix. In any case, this makes me wonder how you tested this code, since it won't even build. Could you elaborate? -- Ard. > Cc: Jian J Wang <jian.j.wang@intel.com> > Cc: Hao A Wu <hao.a.wu@intel.com> > Cc: Ray Ni <ray.ni@intel.com> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Cc: Laszlo Ersek <lersek@redhat.com> > Cc: Liming Gao <liming.gao@intel.com> > Signed-of-by: Zhichao Gao <zhichao.gao@intel.com> > > Zhichao Gao (3): > MdeModulePkg: Extend the support keyboard type of Terminal console > MdeModulePkg/TerminalDxe: Extend the terminal console support types > MdeModulePkg/BM_UI: Add the new terminal types to related menu > > MdeModulePkg/Include/Guid/TtyTerm.h | 13 + > .../BootMaintenanceManager.h | 12 +- > .../BootMaintenanceManagerStrings.uni | 10 +- > .../ConsoleOption.c | 35 +-- > .../BootMaintenanceManagerUiLib/Data.c | 16 +- > MdeModulePkg/MdeModulePkg.dec | 4 + > .../Universal/Console/TerminalDxe/Terminal.c | 17 +- > .../Universal/Console/TerminalDxe/Terminal.h | 37 ++- > .../Console/TerminalDxe/TerminalConIn.c | 281 ++++++++++++++++-- > .../Console/TerminalDxe/TerminalConOut.c | 4 + > .../Console/TerminalDxe/TerminalDxe.inf | 6 +- > 11 files changed, 375 insertions(+), 60 deletions(-) > > -- > 2.21.0.windows.1 > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47344): https://edk2.groups.io/g/devel/message/47344 Mute This Topic: https://groups.io/mt/34173528/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Ard: Thanks for your quick report. The break is caused by the patch [edk2-devel] [PATCH 2/2] MdeModulePkg/SerialDxe: Update the file Guid in SerialDxe.inf. This patch updates FILE_GUID only. But, its GUID value format is wrong. I just send the fix for it. Thanks Liming >-----Original Message----- >From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >Sent: Tuesday, September 17, 2019 2:29 PM >To: Gao, Zhichao <zhichao.gao@intel.com> >Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Wang, Jian J ><jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray ><ray.ni@intel.com>; Laszlo Ersek <lersek@redhat.com>; Gao, Liming ><liming.gao@intel.com> >Subject: Re: [edk2-devel] [PATCH V2 0/3] MdeModulePkg/TerminalConsole: >Extend the support terminal types > >On Tue, 17 Sep 2019 at 07:22, Gao, Zhichao <zhichao.gao@intel.com> wrote: >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2186 >> >> Putty is a very popular terminal tool in windows. So add the whole support >> terminal keyboard type for it. The new introduced type is Linux, XtermR6, >> VT400 and SCO. And enhance the support for VT100+. >> This patch set only add the support of function key. Refer to the link: >> https://www.ssh.com/ssh/putty/putty- >manuals/0.68/Chapter4.html#config-funkeys >> >> V2: >> Fix typo. >> Merge the type guid defination into TtyTerm.h. >> > >Hello Zhichao, > >Since you already pushed the broken patch, you should really be >posting an updated patch with just the fix. > >In any case, this makes me wonder how you tested this code, since it >won't even build. Could you elaborate? > >-- >Ard. > > >> Cc: Jian J Wang <jian.j.wang@intel.com> >> Cc: Hao A Wu <hao.a.wu@intel.com> >> Cc: Ray Ni <ray.ni@intel.com> >> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> >> Cc: Laszlo Ersek <lersek@redhat.com> >> Cc: Liming Gao <liming.gao@intel.com> >> Signed-of-by: Zhichao Gao <zhichao.gao@intel.com> >> >> Zhichao Gao (3): >> MdeModulePkg: Extend the support keyboard type of Terminal console >> MdeModulePkg/TerminalDxe: Extend the terminal console support types >> MdeModulePkg/BM_UI: Add the new terminal types to related menu >> >> MdeModulePkg/Include/Guid/TtyTerm.h | 13 + >> .../BootMaintenanceManager.h | 12 +- >> .../BootMaintenanceManagerStrings.uni | 10 +- >> .../ConsoleOption.c | 35 +-- >> .../BootMaintenanceManagerUiLib/Data.c | 16 +- >> MdeModulePkg/MdeModulePkg.dec | 4 + >> .../Universal/Console/TerminalDxe/Terminal.c | 17 +- >> .../Universal/Console/TerminalDxe/Terminal.h | 37 ++- >> .../Console/TerminalDxe/TerminalConIn.c | 281 ++++++++++++++++-- >> .../Console/TerminalDxe/TerminalConOut.c | 4 + >> .../Console/TerminalDxe/TerminalDxe.inf | 6 +- >> 11 files changed, 375 insertions(+), 60 deletions(-) >> >> -- >> 2.21.0.windows.1 >> >> >> >> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47347): https://edk2.groups.io/g/devel/message/47347 Mute This Topic: https://groups.io/mt/34173528/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Thanks Liming to clarify my confusion. I just want to know which broken patch is in my patch set. > -----Original Message----- > From: Gao, Liming > Sent: Tuesday, September 17, 2019 2:48 PM > To: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Gao, Zhichao > <zhichao.gao@intel.com> > Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Wang, Jian J > <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray > <ray.ni@intel.com>; Laszlo Ersek <lersek@redhat.com> > Subject: RE: [edk2-devel] [PATCH V2 0/3] MdeModulePkg/TerminalConsole: > Extend the support terminal types > > Ard: > Thanks for your quick report. The break is caused by the patch [edk2-devel] > [PATCH 2/2] MdeModulePkg/SerialDxe: Update the file Guid in SerialDxe.inf. > This patch updates FILE_GUID only. But, its GUID value format is wrong. I > just send the fix for it. > > Thanks > Liming > >-----Original Message----- > >From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > >Sent: Tuesday, September 17, 2019 2:29 PM > >To: Gao, Zhichao <zhichao.gao@intel.com> > >Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Wang, Jian J > ><jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray > ><ray.ni@intel.com>; Laszlo Ersek <lersek@redhat.com>; Gao, Liming > ><liming.gao@intel.com> > >Subject: Re: [edk2-devel] [PATCH V2 0/3] MdeModulePkg/TerminalConsole: > >Extend the support terminal types > > > >On Tue, 17 Sep 2019 at 07:22, Gao, Zhichao <zhichao.gao@intel.com> wrote: > >> > >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2186 > >> > >> Putty is a very popular terminal tool in windows. So add the whole > >> support terminal keyboard type for it. The new introduced type is > >> Linux, XtermR6, > >> VT400 and SCO. And enhance the support for VT100+. > >> This patch set only add the support of function key. Refer to the link: > >> https://www.ssh.com/ssh/putty/putty- > >manuals/0.68/Chapter4.html#config-funkeys > >> > >> V2: > >> Fix typo. > >> Merge the type guid defination into TtyTerm.h. > >> > > > >Hello Zhichao, > > > >Since you already pushed the broken patch, you should really be posting > >an updated patch with just the fix. > > > >In any case, this makes me wonder how you tested this code, since it > >won't even build. Could you elaborate? I usually build the patch on my local machine. I didn't catch that fault because my code base isn't up to date. And I have already ported it to a real platform to verify the new introduced terminal type's function key. It works fine. Here is the common steps: 1. Apply this patch set to the edk repo 2. change the BdsBootMaintainUI lib of the platform (some platform add this to its own setup driver) to support the new terminal type 3. change the PlatformBds library to make the whole terminal type legal because some platform only judge the types in PcAnsi.h as legal ones 4. register F1 to F12 at the UiApp entry point (for test only) 5. build bios image and flash to the platform 6. boot to setup and change the console terminal type 7. boot the SUT(system under test) with a UART connect to the host 8. open Putty in the host and change the terminal keyboard type to match with the setting in the setup 9. type function key to view if it can recognize the function correctly 10. go to 6 to verify the other terminal type Thanks, Zhichao > > > >-- > >Ard. > > > > > >> Cc: Jian J Wang <jian.j.wang@intel.com> > >> Cc: Hao A Wu <hao.a.wu@intel.com> > >> Cc: Ray Ni <ray.ni@intel.com> > >> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > >> Cc: Laszlo Ersek <lersek@redhat.com> > >> Cc: Liming Gao <liming.gao@intel.com> > >> Signed-of-by: Zhichao Gao <zhichao.gao@intel.com> > >> > >> Zhichao Gao (3): > >> MdeModulePkg: Extend the support keyboard type of Terminal console > >> MdeModulePkg/TerminalDxe: Extend the terminal console support > types > >> MdeModulePkg/BM_UI: Add the new terminal types to related menu > >> > >> MdeModulePkg/Include/Guid/TtyTerm.h | 13 + > >> .../BootMaintenanceManager.h | 12 +- > >> .../BootMaintenanceManagerStrings.uni | 10 +- > >> .../ConsoleOption.c | 35 +-- > >> .../BootMaintenanceManagerUiLib/Data.c | 16 +- > >> MdeModulePkg/MdeModulePkg.dec | 4 + > >> .../Universal/Console/TerminalDxe/Terminal.c | 17 +- > >> .../Universal/Console/TerminalDxe/Terminal.h | 37 ++- > >> .../Console/TerminalDxe/TerminalConIn.c | 281 ++++++++++++++++-- > >> .../Console/TerminalDxe/TerminalConOut.c | 4 + > >> .../Console/TerminalDxe/TerminalDxe.inf | 6 +- > >> 11 files changed, 375 insertions(+), 60 deletions(-) > >> > >> -- > >> 2.21.0.windows.1 > >> > >> > >> > >> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47352): https://edk2.groups.io/g/devel/message/47352 Mute This Topic: https://groups.io/mt/34173528/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi Ard, That's my mistake to push the broken patch(0d85e67714e31e0dbe4241ab2ebb7c423aba174d). This patch only updates the file guid, which I thought has no risk. So I didn’t check the build result. I should double check the new guid used in the file. Liming has help send a patch to fix this issue. Thanks, Shenglei > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Ard Biesheuvel > Sent: Tuesday, September 17, 2019 2:29 PM > To: Gao, Zhichao <zhichao.gao@intel.com> > Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Wang, Jian J > <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray > <ray.ni@intel.com>; Laszlo Ersek <lersek@redhat.com>; Gao, Liming > <liming.gao@intel.com> > Subject: Re: [edk2-devel] [PATCH V2 0/3] MdeModulePkg/TerminalConsole: > Extend the support terminal types > > On Tue, 17 Sep 2019 at 07:22, Gao, Zhichao <zhichao.gao@intel.com> wrote: > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2186 > > > > Putty is a very popular terminal tool in windows. So add the whole support > > terminal keyboard type for it. The new introduced type is Linux, XtermR6, > > VT400 and SCO. And enhance the support for VT100+. > > This patch set only add the support of function key. Refer to the link: > > https://www.ssh.com/ssh/putty/putty- > manuals/0.68/Chapter4.html#config-funkeys > > > > V2: > > Fix typo. > > Merge the type guid defination into TtyTerm.h. > > > > Hello Zhichao, > > Since you already pushed the broken patch, you should really be > posting an updated patch with just the fix. > > In any case, this makes me wonder how you tested this code, since it > won't even build. Could you elaborate? > > -- > Ard. > > > > Cc: Jian J Wang <jian.j.wang@intel.com> > > Cc: Hao A Wu <hao.a.wu@intel.com> > > Cc: Ray Ni <ray.ni@intel.com> > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > Cc: Laszlo Ersek <lersek@redhat.com> > > Cc: Liming Gao <liming.gao@intel.com> > > Signed-of-by: Zhichao Gao <zhichao.gao@intel.com> > > > > Zhichao Gao (3): > > MdeModulePkg: Extend the support keyboard type of Terminal console > > MdeModulePkg/TerminalDxe: Extend the terminal console support types > > MdeModulePkg/BM_UI: Add the new terminal types to related menu > > > > MdeModulePkg/Include/Guid/TtyTerm.h | 13 + > > .../BootMaintenanceManager.h | 12 +- > > .../BootMaintenanceManagerStrings.uni | 10 +- > > .../ConsoleOption.c | 35 +-- > > .../BootMaintenanceManagerUiLib/Data.c | 16 +- > > MdeModulePkg/MdeModulePkg.dec | 4 + > > .../Universal/Console/TerminalDxe/Terminal.c | 17 +- > > .../Universal/Console/TerminalDxe/Terminal.h | 37 ++- > > .../Console/TerminalDxe/TerminalConIn.c | 281 ++++++++++++++++-- > > .../Console/TerminalDxe/TerminalConOut.c | 4 + > > .../Console/TerminalDxe/TerminalDxe.inf | 6 +- > > 11 files changed, 375 insertions(+), 60 deletions(-) > > > > -- > > 2.21.0.windows.1 > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47353): https://edk2.groups.io/g/devel/message/47353 Mute This Topic: https://groups.io/mt/34173528/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Tue, 17 Sep 2019 at 08:17, Zhang, Shenglei <shenglei.zhang@intel.com> wrote: > > Hi Ard, > > That's my mistake to push the broken patch(0d85e67714e31e0dbe4241ab2ebb7c423aba174d). > This patch only updates the file guid, which I thought has no risk. So I didn’t check the build result. > I should double check the new guid used in the file. Liming has help send a patch to fix this issue. > I understand. Please don't push changes without making sure they actually build. Thanks, Ard. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47356): https://edk2.groups.io/g/devel/message/47356 Mute This Topic: https://groups.io/mt/34173528/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Tue, Sep 17, 2019 at 07:17:27AM +0000, Zhang, Shenglei wrote: > That's my mistake to push the broken patch(0d85e67714e31e0dbe4241ab2ebb7c423aba174d). > This patch only updates the file guid, which I thought has no risk. So I didn’t check the build result. > I should double check the new guid used in the file. Determining what affects build and not is something humans are very bad at and computers are very good at. So you should build check every patch you submit to the list, no matter how trivial. In normal circumstances, so should the maintainers before pushing the patch. We now have a commit in the tree known to break the build of pretty much all ARM/AARCH64 platforms. This will be very unpleasant for future bisect. Best Regards, Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47359): https://edk2.groups.io/g/devel/message/47359 Mute This Topic: https://groups.io/mt/34173528/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Leif: > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Tuesday, September 17, 2019 5:15 PM > To: devel@edk2.groups.io; Zhang, Shenglei <shenglei.zhang@intel.com> > Cc: ard.biesheuvel@linaro.org; Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; > Laszlo Ersek <lersek@redhat.com>; Gao, Liming <liming.gao@intel.com>; Gao, Zhichao <zhichao.gao@intel.com> > Subject: Re: [edk2-devel] [PATCH V2 0/3] MdeModulePkg/TerminalConsole: Extend the support terminal types > > On Tue, Sep 17, 2019 at 07:17:27AM +0000, Zhang, Shenglei wrote: > > That's my mistake to push the broken patch(0d85e67714e31e0dbe4241ab2ebb7c423aba174d). > > This patch only updates the file guid, which I thought has no risk. So I didn’t check the build result. > > I should double check the new guid used in the file. > > Determining what affects build and not is something humans are very > bad at and computers are very good at. > > So you should build check every patch you submit to the list, no > matter how trivial. > > In normal circumstances, so should the maintainers before pushing the > patch. I push this change. I should double confirm its test result. I will improve my rule. > > We now have a commit in the tree known to break the build of pretty > much all ARM/AARCH64 platforms. This will be very unpleasant for > future bisect. I agree the build break is the big impact. I expect we can speed up to enable EDK II Continuous Integration. If so, we can avoid such break again. Thanks Liming > > Best Regards, > > Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47376): https://edk2.groups.io/g/devel/message/47376 Mute This Topic: https://groups.io/mt/34173528/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.