Armada 7k8k SPI flash driver improvements

[edk2-devel] [edk2-platforms: PATCH 0/2] Armada 7k8k SPI flash driver improvements

Posted by Patryk Duda 5 years, 2 months ago

Hi,

This patchset contains progress bar implementation for MvSpiFlash driver and
small fix in calculating number of sectors to write.

Progress bar implementation was mostly borrowed from TFTP module.
During implementation it turned out that when size is multiplication of
sector size, then last sector was not copied because remainder was 0.
This was fixed by increasing number of sectors to write.

I'm looking forward to your comments or remarks.

Best regards,
Patryk

Patryk Duda (2):
  Marvell/Drivers: MvSpiFlashDxe: Fix sector number obtaining
  Marvell/Drivers: MvSpiFlashDxe: Implement progress bar

 Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.inf |  1 +
 Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.h   |  1 +
 Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.c   | 59 ++++++++++++++++----
 3 files changed, 51 insertions(+), 10 deletions(-)

-- 
2.21.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47052): https://edk2.groups.io/g/devel/message/47052
Mute This Topic: https://groups.io/mt/34085587/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms: PATCH 0/2] Armada 7k8k SPI flash driver improvements

Posted by Marcin Wojtas 5 years, 2 months ago

pon., 9 wrz 2019 o 17:52 Patryk Duda <pdk@semihalf.com> napisał(a):
>
> Hi,
>
> This patchset contains progress bar implementation for MvSpiFlash driver and
> small fix in calculating number of sectors to write.
>
> Progress bar implementation was mostly borrowed from TFTP module.
> During implementation it turned out that when size is multiplication of
> sector size, then last sector was not copied because remainder was 0.
> This was fixed by increasing number of sectors to write.
>
> I'm looking forward to your comments or remarks.
>
> Best regards,
> Patryk
>
> Patryk Duda (2):
>   Marvell/Drivers: MvSpiFlashDxe: Fix sector number obtaining
>   Marvell/Drivers: MvSpiFlashDxe: Implement progress bar
>
>  Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.inf |  1 +
>  Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.h   |  1 +
>  Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.c   | 59 ++++++++++++++++----
>  3 files changed, 51 insertions(+), 10 deletions(-)
>

Tested-by: Marcin Wojtas <mw@semihalf.com>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47065): https://edk2.groups.io/g/devel/message/47065
Mute This Topic: https://groups.io/mt/34085587/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms: PATCH 0/2] Armada 7k8k SPI flash driver improvements

Posted by Patryk Duda 5 years, 2 months ago

Hi,

Do you have any remarks to the patchset?

Best regards,
Patryk

wt., 10 wrz 2019 o 08:23 Marcin Wojtas <mw@semihalf.com> napisał(a):

> pon., 9 wrz 2019 o 17:52 Patryk Duda <pdk@semihalf.com> napisał(a):
> >
> > Hi,
> >
> > This patchset contains progress bar implementation for MvSpiFlash driver
> and
> > small fix in calculating number of sectors to write.
> >
> > Progress bar implementation was mostly borrowed from TFTP module.
> > During implementation it turned out that when size is multiplication of
> > sector size, then last sector was not copied because remainder was 0.
> > This was fixed by increasing number of sectors to write.
> >
> > I'm looking forward to your comments or remarks.
> >
> > Best regards,
> > Patryk
> >
> > Patryk Duda (2):
> >   Marvell/Drivers: MvSpiFlashDxe: Fix sector number obtaining
> >   Marvell/Drivers: MvSpiFlashDxe: Implement progress bar
> >
> >  Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.inf |  1 +
> >  Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.h   |  1 +
> >  Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.c   | 59
> ++++++++++++++++----
> >  3 files changed, 51 insertions(+), 10 deletions(-)
> >
>
> Tested-by: Marcin Wojtas <mw@semihalf.com>
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#48225): https://edk2.groups.io/g/devel/message/48225
Mute This Topic: https://groups.io/mt/34085587/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-