[edk2-devel] [PATCH v2] DebugFeaturePkg: Remove white space and update the ending format

Zhang, Shenglei posted 1 patch 23 weeks ago
Failed in applying to current master (apply log)
Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c | 3 +--
Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc   | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)

[edk2-devel] [PATCH v2] DebugFeaturePkg: Remove white space and update the ending format

Posted by Zhang, Shenglei 23 weeks ago
Remove white space in AcpiDebug.c.
The original end of last line in DebugFeaturePkg.dsc is '/r'.
Now update it to '/r/n'.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
v2: In v1 the patch remove the '/r'. In v2 it is updated to '/r/n'.
    The v1 patch is "DebugFeaturePkg: Remove white space and white ending line".

 Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c | 3 +--
 Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc   | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c b/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
index f9cd8bcb..5ad8d259 100644
--- a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
+++ b/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
@@ -487,7 +487,7 @@ InitializeAcpiDebugSmm (
   if (EFI_ERROR (Status)) {
     return Status;
   }
-  
+
   Status = SmmBase2->InSmm (SmmBase2, &InSmm);
   ASSERT_EFI_ERROR (Status);
   if (EFI_ERROR (Status)) {
@@ -519,4 +519,3 @@ InitializeAcpiDebugSmm (
 
   return Status;
 }
-
diff --git a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
index 30f57d5d..8e5ff4c9 100644
--- a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
+++ b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
@@ -98,4 +98,4 @@
   DebugFeaturePkg/AcpiDebug/AcpiDebugSmm.inf
 
 [BuildOptions]
-  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
\ No newline at end of file
+  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
-- 
2.18.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#46983): https://edk2.groups.io/g/devel/message/46983
Mute This Topic: https://groups.io/mt/33169036/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2] DebugFeaturePkg: Remove white space and update the ending format

Posted by Philippe Mathieu-Daudé 21 weeks ago
On 9/6/19 7:16 PM, Zhang, Shenglei wrote:
> Remove white space in AcpiDebug.c.
> The original end of last line in DebugFeaturePkg.dsc is '/r'.
> Now update it to '/r/n'.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> v2: In v1 the patch remove the '/r'. In v2 it is updated to '/r/n'.
>     The v1 patch is "DebugFeaturePkg: Remove white space and white ending line".
> 
>  Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c | 3 +--
>  Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc   | 2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c b/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> index f9cd8bcb..5ad8d259 100644
> --- a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> +++ b/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> @@ -487,7 +487,7 @@ InitializeAcpiDebugSmm (
>    if (EFI_ERROR (Status)) {
>      return Status;
>    }
> -  
> +
>    Status = SmmBase2->InSmm (SmmBase2, &InSmm);
>    ASSERT_EFI_ERROR (Status);
>    if (EFI_ERROR (Status)) {
> @@ -519,4 +519,3 @@ InitializeAcpiDebugSmm (
>  
>    return Status;
>  }
> -
> diff --git a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> index 30f57d5d..8e5ff4c9 100644
> --- a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> +++ b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> @@ -98,4 +98,4 @@
>    DebugFeaturePkg/AcpiDebug/AcpiDebugSmm.inf
>  
>  [BuildOptions]
> -  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> \ No newline at end of file
> +  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> 

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47843): https://edk2.groups.io/g/devel/message/47843
Mute This Topic: https://groups.io/mt/33169036/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2] DebugFeaturePkg: Remove white space and update the ending format

Posted by Dong, Eric 23 weeks ago
Reviewed-by: Eric Dong <eric.dong@intel.com>

> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Saturday, September 7, 2019 1:16 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH v2] DebugFeaturePkg: Remove white space and update the
> ending format
> 
> Remove white space in AcpiDebug.c.
> The original end of last line in DebugFeaturePkg.dsc is '/r'.
> Now update it to '/r/n'.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> v2: In v1 the patch remove the '/r'. In v2 it is updated to '/r/n'.
>     The v1 patch is "DebugFeaturePkg: Remove white space and white ending
> line".
> 
>  Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c | 3 +--
>  Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc   | 2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> b/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> index f9cd8bcb..5ad8d259 100644
> --- a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> +++ b/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> @@ -487,7 +487,7 @@ InitializeAcpiDebugSmm (
>    if (EFI_ERROR (Status)) {
>      return Status;
>    }
> -
> +
>    Status = SmmBase2->InSmm (SmmBase2, &InSmm);
>    ASSERT_EFI_ERROR (Status);
>    if (EFI_ERROR (Status)) {
> @@ -519,4 +519,3 @@ InitializeAcpiDebugSmm (
> 
>    return Status;
>  }
> -
> diff --git a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> index 30f57d5d..8e5ff4c9 100644
> --- a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> +++ b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> @@ -98,4 +98,4 @@
>    DebugFeaturePkg/AcpiDebug/AcpiDebugSmm.inf
> 
>  [BuildOptions]
> -  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES \ No
> newline at end of file
> +  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> --
> 2.18.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47010): https://edk2.groups.io/g/devel/message/47010
Mute This Topic: https://groups.io/mt/33169036/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2] DebugFeaturePkg: Remove white space and update the ending format

Posted by Zhang, Shenglei 21 weeks ago
For this patch, I'll update the file format of AcpiDebug.c to Dos format when pushing the patch.

Thanks,
Shenglei

> -----Original Message-----
> From: Dong, Eric
> Sent: Monday, September 9, 2019 8:36 AM
> To: Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: RE: [PATCH v2] DebugFeaturePkg: Remove white space and update
> the ending format
> 
> Reviewed-by: Eric Dong <eric.dong@intel.com>
> 
> > -----Original Message-----
> > From: Zhang, Shenglei
> > Sent: Saturday, September 7, 2019 1:16 AM
> > To: devel@edk2.groups.io
> > Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
> > Subject: [PATCH v2] DebugFeaturePkg: Remove white space and update
> the
> > ending format
> >
> > Remove white space in AcpiDebug.c.
> > The original end of last line in DebugFeaturePkg.dsc is '/r'.
> > Now update it to '/r/n'.
> >
> > Cc: Eric Dong <eric.dong@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > ---
> > v2: In v1 the patch remove the '/r'. In v2 it is updated to '/r/n'.
> >     The v1 patch is "DebugFeaturePkg: Remove white space and white
> ending
> > line".
> >
> >  Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c | 3 +--
> >  Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc   | 2 +-
> >  2 files changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> > b/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> > index f9cd8bcb..5ad8d259 100644
> > --- a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> > +++ b/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> > @@ -487,7 +487,7 @@ InitializeAcpiDebugSmm (
> >    if (EFI_ERROR (Status)) {
> >      return Status;
> >    }
> > -
> > +
> >    Status = SmmBase2->InSmm (SmmBase2, &InSmm);
> >    ASSERT_EFI_ERROR (Status);
> >    if (EFI_ERROR (Status)) {
> > @@ -519,4 +519,3 @@ InitializeAcpiDebugSmm (
> >
> >    return Status;
> >  }
> > -
> > diff --git a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> > b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> > index 30f57d5d..8e5ff4c9 100644
> > --- a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> > +++ b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> > @@ -98,4 +98,4 @@
> >    DebugFeaturePkg/AcpiDebug/AcpiDebugSmm.inf
> >
> >  [BuildOptions]
> > -  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES \ No
> > newline at end of file
> > +  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> > --
> > 2.18.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47806): https://edk2.groups.io/g/devel/message/47806
Mute This Topic: https://groups.io/mt/33169036/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-