[edk2-devel] [patch] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid

Dandan Bi posted 1 patch 2 weeks ago
Failed in applying to current master (apply log)
MdeModulePkg/Include/Protocol/FormBrowserEx.h | 1 -
MdeModulePkg/MdeModulePkg.dec                 | 1 -
2 files changed, 2 deletions(-)

[edk2-devel] [patch] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid

Posted by Dandan Bi 2 weeks ago
gEfiFormBrowserExProtocolGuid is not used in edk2,
and it can be replaced by gEdkiiFormBrowserExProtocolGuid.
So remove gEfiFormBrowserExProtocolGuid to avoid confusion.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 MdeModulePkg/Include/Protocol/FormBrowserEx.h | 1 -
 MdeModulePkg/MdeModulePkg.dec                 | 1 -
 2 files changed, 2 deletions(-)

diff --git a/MdeModulePkg/Include/Protocol/FormBrowserEx.h b/MdeModulePkg/Include/Protocol/FormBrowserEx.h
index c36aa6bdf1..e7e7cd18ab 100644
--- a/MdeModulePkg/Include/Protocol/FormBrowserEx.h
+++ b/MdeModulePkg/Include/Protocol/FormBrowserEx.h
@@ -141,10 +141,9 @@ struct _EDKII_FORM_BROWSER_EXTENSION_PROTOCOL {
   REGISTER_HOT_KEY       RegisterHotKey;
   REGISTER_EXIT_HANDLER  RegiserExitHandler;
   SAVE_REMINDER          SaveReminder;
 };
 
-extern EFI_GUID gEfiFormBrowserExProtocolGuid;
 extern EFI_GUID gEdkiiFormBrowserExProtocolGuid;
 
 #endif
 
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 19935c88fa..ab29a279b1 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -529,11 +529,10 @@ [Protocols]
 
   ## Include/Protocol/LockBox.h
   gEfiLockBoxProtocolGuid        = { 0xbd445d79, 0xb7ad, 0x4f04, { 0x9a, 0xd8, 0x29, 0xbd, 0x20, 0x40, 0xeb, 0x3c }}
 
   ## Include/Protocol/FormBrowserEx.h
-  gEfiFormBrowserExProtocolGuid = { 0x1f73b18d, 0x4630, 0x43c1, { 0xa1, 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } }
   gEdkiiFormBrowserExProtocolGuid = { 0x1f73b18d, 0x4630, 0x43c1, { 0xa1, 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } }
 
   ## Include/Protocol/EbcVmTest.h
   gEfiEbcVmTestProtocolGuid = { 0xAAEACCFD, 0xF27B, 0x4C17, { 0xB6, 0x10, 0x75, 0xCA, 0x1F, 0x2D, 0xFB, 0x52 } }
 
-- 
2.18.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#46865): https://edk2.groups.io/g/devel/message/46865
Mute This Topic: https://groups.io/mt/33150373/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [patch] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid

Posted by Dong, Eric 2 weeks ago
Reviewed-by: Eric Dong <eric.dong@intel.com>

> -----Original Message-----
> From: Bi, Dandan
> Sent: Thursday, September 5, 2019 12:54 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [patch] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid
> 
> gEfiFormBrowserExProtocolGuid is not used in edk2, and it can be replaced by
> gEdkiiFormBrowserExProtocolGuid.
> So remove gEfiFormBrowserExProtocolGuid to avoid confusion.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  MdeModulePkg/Include/Protocol/FormBrowserEx.h | 1 -
>  MdeModulePkg/MdeModulePkg.dec                 | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> b/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> index c36aa6bdf1..e7e7cd18ab 100644
> --- a/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> +++ b/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> @@ -141,10 +141,9 @@ struct
> _EDKII_FORM_BROWSER_EXTENSION_PROTOCOL {
>    REGISTER_HOT_KEY       RegisterHotKey;
>    REGISTER_EXIT_HANDLER  RegiserExitHandler;
>    SAVE_REMINDER          SaveReminder;
>  };
> 
> -extern EFI_GUID gEfiFormBrowserExProtocolGuid;  extern EFI_GUID
> gEdkiiFormBrowserExProtocolGuid;
> 
>  #endif
> 
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec index 19935c88fa..ab29a279b1 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -529,11 +529,10 @@ [Protocols]
> 
>    ## Include/Protocol/LockBox.h
>    gEfiLockBoxProtocolGuid        = { 0xbd445d79, 0xb7ad, 0x4f04, { 0x9a, 0xd8,
> 0x29, 0xbd, 0x20, 0x40, 0xeb, 0x3c }}
> 
>    ## Include/Protocol/FormBrowserEx.h
> -  gEfiFormBrowserExProtocolGuid = { 0x1f73b18d, 0x4630, 0x43c1, { 0xa1,
> 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } }
>    gEdkiiFormBrowserExProtocolGuid = { 0x1f73b18d, 0x4630, 0x43c1, { 0xa1,
> 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } }
> 
>    ## Include/Protocol/EbcVmTest.h
>    gEfiEbcVmTestProtocolGuid = { 0xAAEACCFD, 0xF27B, 0x4C17, { 0xB6, 0x10,
> 0x75, 0xCA, 0x1F, 0x2D, 0xFB, 0x52 } }
> 
> --
> 2.18.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#46873): https://edk2.groups.io/g/devel/message/46873
Mute This Topic: https://groups.io/mt/33150373/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-