> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zeng, Star
> Sent: Wednesday, August 28, 2019 8:48 AM
> To: devel@edk2.groups.io; Ni, Ray
> Cc: Zeng, Star
> Subject: Re: [edk2-devel] [PATCH 0/2] move
> PcdRealTimeClockUpdateTimeout from MdeModulePkg to PcAtChipsetPkg
>
> Both XXXPkg.uni need to be updated as the PCD movement.
Agree.
> With that, Reviewed-by: Star Zeng <star.zeng@intel.com>
Found that the PCD was introduced by commit f8ea30263c. At that time, the
PcatRealTimeClockRuntimeDxe driver was still in MdeModulePkg. Then commit
345e5a6556 moved the driver to PcAtChipsetPkg but forgot to move the PCD.
With Star's comment addressed, for the series:
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Also, please help to hold the patch after the upcoming stable tag, thanks.
Best Regards,
Hao Wu
>
> Thanks,
> Star
>
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Ni,
> > Ray
> > Sent: Wednesday, August 28, 2019 7:27 AM
> > To: devel@edk2.groups.io
> > Subject: [edk2-devel] [PATCH 0/2] move PcdRealTimeClockUpdateTimeout
> > from MdeModulePkg to PcAtChipsetPkg
> >
> >
> > Ray Ni (2):
> > PcAtChipsetPkg: add PcdRealTimeClockUpdateTimeout
> > MdeModulePkg: Remove PcdRealTimeClockUpdateTimeout
> >
> > MdeModulePkg/MdeModulePkg.dec | 4 ----
> > PcAtChipsetPkg/PcAtChipsetPkg.dec | 6 +++++-
> > .../PcatRealTimeClockRuntimeDxe.inf | 5 ++---
> > 3 files changed, 7 insertions(+), 8 deletions(-)
> >
> > --
> > 2.21.0.windows.1
> >
> >
> >
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#46516): https://edk2.groups.io/g/devel/message/46516
Mute This Topic: https://groups.io/mt/33051692/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-