MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf | 3 +- MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 171 +++++- MdePkg/Include/IndustryStandard/Scsi.h | 48 +- MdePkg/Include/Library/UefiScsiLib.h | 126 +++- MdePkg/Include/Protocol/ScsiIo.h | 9 +- MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c | 5 +- MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 614 +++++++++++++++++++- MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 17 +- MdePkg/Library/UefiScsiLib/UefiScsiLib.c | 205 ++++++- 9 files changed, 1157 insertions(+), 41 deletions(-)
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1546 V5 changes: Split MdeModulePkg changes into separate patches. Add ReinstallProtocol calls for StorageSecurityCommand Protocol. Restore original MediaPresent and ReadCapacity behavior, with new implementation for WLUN type media. Clear temporary aligned buffers before freeing them. V4 changes: Add SSC Protocol in addition to BlockIo instead of in place of BlockIo. Add error handling for (BlockSize == 0) in Read and WriteBlocks commands to handle partitions that do not support ReadCapacity(). V3 changes: Initialize AlignedBuffer variable in ScsiDiskReceiveData and ScsiDiskSendData functions. Remove redundant input validation and debug message in ScsiDiskSendData. V2 changes: Split the patch into separate commits for separate packages. To support RPMB access on UFS devices, support must be added to the ScsiDiskDxe driver for the Storage Security Command Protocol. Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Jiewen Yao <jiewen.yao@intel.com> Cc: Jian J Wang <jian.j.wang@intel.com> Cc: Liming Gao <liming.gao@intel.com> Cc: Hao A Wu <hao.a.wu@intel.com> Christopher J Zurcher (4): MdePkg: Implement SCSI commands for Security Protocol In/Out MdeModulePkg/UfsPassThruDxe: Check for RPMB W-LUN (SecurityLun) MdeModulePkg/ScsiBusDxe: Clean up Peripheral Type check MdeModulePkg/ScsiDiskDxe: Support Storage Security Command Protocol MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf | 3 +- MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 171 +++++- MdePkg/Include/IndustryStandard/Scsi.h | 48 +- MdePkg/Include/Library/UefiScsiLib.h | 126 +++- MdePkg/Include/Protocol/ScsiIo.h | 9 +- MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c | 5 +- MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 614 +++++++++++++++++++- MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 17 +- MdePkg/Library/UefiScsiLib/UefiScsiLib.c | 205 ++++++- 9 files changed, 1157 insertions(+), 41 deletions(-) -- 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46237): https://edk2.groups.io/g/devel/message/46237 Mute This Topic: https://groups.io/mt/32994941/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
> -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zurcher, Christopher J > Sent: Friday, August 23, 2019 6:02 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D; Yao, Jiewen; Wang, Jian J; Gao, Liming; Wu, Hao A > Subject: [edk2-devel] [PATCH v5 0/4] Add SCSI Support for Storage Security > Command Protocol > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1546 > > V5 changes: > Split MdeModulePkg changes into separate patches. Add ReinstallProtocol > calls for StorageSecurityCommand Protocol. Restore original MediaPresent > and ReadCapacity behavior, with new implementation for WLUN type media. > Clear temporary aligned buffers before freeing them. Thanks for the series. Please grant me some time for reviewing the patches, I will give my feedbacks before the end of next week. Best Regards, Hao Wu > > V4 changes: > Add SSC Protocol in addition to BlockIo instead of in place of BlockIo. > Add error handling for (BlockSize == 0) in Read and WriteBlocks commands > to handle partitions that do not support ReadCapacity(). > > V3 changes: > Initialize AlignedBuffer variable in ScsiDiskReceiveData and > ScsiDiskSendData functions. Remove redundant input validation and debug > message in ScsiDiskSendData. > > V2 changes: > Split the patch into separate commits for separate packages. > > To support RPMB access on UFS devices, support must be added to > the ScsiDiskDxe driver for the Storage Security Command Protocol. > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Jiewen Yao <jiewen.yao@intel.com> > Cc: Jian J Wang <jian.j.wang@intel.com> > Cc: Liming Gao <liming.gao@intel.com> > Cc: Hao A Wu <hao.a.wu@intel.com> > > Christopher J Zurcher (4): > MdePkg: Implement SCSI commands for Security Protocol In/Out > MdeModulePkg/UfsPassThruDxe: Check for RPMB W-LUN (SecurityLun) > MdeModulePkg/ScsiBusDxe: Clean up Peripheral Type check > MdeModulePkg/ScsiDiskDxe: Support Storage Security Command Protocol > > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf | 3 +- > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 171 +++++- > MdePkg/Include/IndustryStandard/Scsi.h | 48 +- > MdePkg/Include/Library/UefiScsiLib.h | 126 +++- > MdePkg/Include/Protocol/ScsiIo.h | 9 +- > MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c | 5 +- > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 614 > +++++++++++++++++++- > MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 17 +- > MdePkg/Library/UefiScsiLib/UefiScsiLib.c | 205 ++++++- > 9 files changed, 1157 insertions(+), 41 deletions(-) > > -- > 2.16.2.windows.1 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46250): https://edk2.groups.io/g/devel/message/46250 Mute This Topic: https://groups.io/mt/32994941/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
> -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zurcher, Christopher J > Sent: Friday, August 23, 2019 6:02 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D; Yao, Jiewen; Wang, Jian J; Gao, Liming; Wu, Hao A > Subject: [edk2-devel] [PATCH v5 0/4] Add SCSI Support for Storage Security > Command Protocol > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1546 Hello, One general comment: Please help to add the above BZ reference information in the commit log message of every patch in the proposed series. Thanks. Best Regards, Hao Wu > > V5 changes: > Split MdeModulePkg changes into separate patches. Add ReinstallProtocol > calls for StorageSecurityCommand Protocol. Restore original MediaPresent > and ReadCapacity behavior, with new implementation for WLUN type media. > Clear temporary aligned buffers before freeing them. > > V4 changes: > Add SSC Protocol in addition to BlockIo instead of in place of BlockIo. > Add error handling for (BlockSize == 0) in Read and WriteBlocks commands > to handle partitions that do not support ReadCapacity(). > > V3 changes: > Initialize AlignedBuffer variable in ScsiDiskReceiveData and > ScsiDiskSendData functions. Remove redundant input validation and debug > message in ScsiDiskSendData. > > V2 changes: > Split the patch into separate commits for separate packages. > > To support RPMB access on UFS devices, support must be added to > the ScsiDiskDxe driver for the Storage Security Command Protocol. > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Jiewen Yao <jiewen.yao@intel.com> > Cc: Jian J Wang <jian.j.wang@intel.com> > Cc: Liming Gao <liming.gao@intel.com> > Cc: Hao A Wu <hao.a.wu@intel.com> > > Christopher J Zurcher (4): > MdePkg: Implement SCSI commands for Security Protocol In/Out > MdeModulePkg/UfsPassThruDxe: Check for RPMB W-LUN (SecurityLun) > MdeModulePkg/ScsiBusDxe: Clean up Peripheral Type check > MdeModulePkg/ScsiDiskDxe: Support Storage Security Command Protocol > > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf | 3 +- > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 171 +++++- > MdePkg/Include/IndustryStandard/Scsi.h | 48 +- > MdePkg/Include/Library/UefiScsiLib.h | 126 +++- > MdePkg/Include/Protocol/ScsiIo.h | 9 +- > MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c | 5 +- > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 614 > +++++++++++++++++++- > MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 17 +- > MdePkg/Library/UefiScsiLib/UefiScsiLib.c | 205 ++++++- > 9 files changed, 1157 insertions(+), 41 deletions(-) > > -- > 2.16.2.windows.1 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46404): https://edk2.groups.io/g/devel/message/46404 Mute This Topic: https://groups.io/mt/32994941/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.