[v5] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config

[edk2-devel] [Patch V5 00/11] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config

Posted by Michael D Kinney 4 years, 8 months ago

New in V5
=========
* Update author to be Andrew Fish for XCODE5 fixes
* Split patch #7 into two patches
* Break up long line in build.sh into multiple lines

New in V4 (Resolve XCODE5 issues)
==================================
* Disable inline if SecGdbScriptBreak() for XCODE5 issues
* Disable XCODE5 compiler optimizations of Unix/Host
* Fix Host output location for XCODE5 X64 builds
* Update lldb scripts for XCODE5 symbiolic debugging
* Clean up BrekelyPlacketFilter.c for uninitialized variable and old debug code.
* Remove TftpDynamicCommand and LogoDxe modules from XCODE5 builds.  These 
  modules use HII section in a PE/COFF resource sections that is not currently
  supported by XCODE5 builds.
* EmulatorPkg/Sec - Move declaration of PpiArray[10] to beginning of function
  so storage is for entire lifetime of the function.  Delaractrion in the 
  middle of the function in {} cause corruption and exceptions in XCODE5 builds.
* Add -gdwarf flag to tols_def.template for XCODE5 X64 for symbolic debug.

New in V3
==========
* Fix size value used in call to AsciiStrCpyS() in PosixFileSystem.c
* Fix XCODE5 safe string function build failure in BerkleyPacketFilter.c
* Add NOOPT build target to DSC file.

New in V2
=========
* Fix size values in safe string function calls.
* Update POSIX sources to use AsciiStrCpyS() and AsciiStrCatS().
* Verify that no exceptions occur if EMU_MAGIC_PAGE() can not be mapped.  An
  error message is generated and the host app exits normally.
* Update EmulatorPkg DEC file with a new PcdPeiServicesTablePage default value
  that works for Windows/POSIX hosts for both IA32 and X64.

https://bugzilla.tianocore.org/show_bug.cgi?id=162
https://bugzilla.tianocore.org/show_bug.cgi?id=2055
https://bugzilla.tianocore.org/show_bug.cgi?id=2056

* Fix VS20xx IA32 boot failure
* Remove UNIX_SEC_BUILD/WIN_SEC_BUILD
* Add -D DISABLE_NEW_DEPRECATED_INTERFACES

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>

Andrew Fish (7):
  EmulatorPkg/Unix/Host: Disable inline/optimizations
  EmulatorPkg: Fix XCODE5 lldb issues
  EmulatorPkg/Unix/Host: Initialize field in BerkeleyPacketFilter.c
  EmulatorPkg/Unix/Host: Remove debug code from BerkeleyPacketFilter.c
  EmulatorPkg: Disable TftpDynamicCommand and LogoDxe for XCODE5
  EmulatorPkg/Sec: Change scope of PpiArray[10]
  BaseTools/tools_def.template: Add -gdwarf to XCODE5 X64

Michael D Kinney (4):
  EmulatorPkg: Fix VS20xx IA32 boot failure
  EmulatorPkg: Remove UNIX_SEC_BUILD/WIN_SEC_BUILD
  EmulatorPkg: Add -D DISABLE_NEW_DEPRECATED_INTERFACES
  EmulatorPkg: Add support for NOOPT target

 BaseTools/Conf/tools_def.template             |   4 +-
 EmulatorPkg/EmuBusDriverDxe/EmuBusDriverDxe.c |   9 +-
 EmulatorPkg/EmulatorPkg.dec                   |   4 +-
 EmulatorPkg/EmulatorPkg.dsc                   |  38 +++---
 EmulatorPkg/EmulatorPkg.fdf                   |   4 +
 EmulatorPkg/FlashMapPei/FlashMapPei.c         |   8 +-
 EmulatorPkg/Library/SmbiosLib/SmbiosLib.c     |   4 +-
 .../ThunkProtocolList/ThunkProtocolList.c     |  11 +-
 EmulatorPkg/Readme.md                         |   8 +-
 EmulatorPkg/Sec/Sec.c                         |  16 ++-
 EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c  |  15 +--
 EmulatorPkg/Unix/Host/Host.c                  |   3 +
 EmulatorPkg/Unix/Host/Host.inf                |   4 +-
 EmulatorPkg/Unix/Host/PosixFileSystem.c       |  80 ++++++++----
 EmulatorPkg/Unix/Host/X11GraphicsWindow.c     |   4 +-
 EmulatorPkg/Unix/lldbefi.py                   |   8 +-
 EmulatorPkg/Win/Host/WinFileSystem.c          | 116 ++++++++++++------
 EmulatorPkg/Win/VS2017/BuildVS.bat            |   2 +-
 EmulatorPkg/build.sh                          |  29 ++---
 19 files changed, 231 insertions(+), 136 deletions(-)

-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45953): https://edk2.groups.io/g/devel/message/45953
Mute This Topic: https://groups.io/mt/32918474/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch V5 00/11] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config

Posted by Jordan Justen 4 years, 8 months ago

On 2019-08-16 17:57:04, Michael D Kinney wrote:
> 
> Andrew Fish (7):
>   EmulatorPkg/Unix/Host: Disable inline/optimizations

Maybe add XCODE5 in commit message subject?

Acked-by: Jordan Justen <jordan.l.justen@intel.com>

>   EmulatorPkg: Fix XCODE5 lldb issues

There was another long line in the EmulatorPkg/Unix/lldbefi.py change.

Acked-by: Jordan Justen <jordan.l.justen@intel.com>

>   EmulatorPkg/Unix/Host: Initialize field in BerkeleyPacketFilter.c

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

>   EmulatorPkg/Unix/Host: Remove debug code from BerkeleyPacketFilter.c

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

>   EmulatorPkg: Disable TftpDynamicCommand and LogoDxe for XCODE5

Acked-by: Jordan Justen <jordan.l.justen@intel.com>

>   EmulatorPkg/Sec: Change scope of PpiArray[10]

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

>   BaseTools/tools_def.template: Add -gdwarf to XCODE5 X64

Acked-by: Jordan Justen <jordan.l.justen@intel.com>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#46020): https://edk2.groups.io/g/devel/message/46020
Mute This Topic: https://groups.io/mt/32918474/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch V5 00/11] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config

Posted by Michael D Kinney 4 years, 8 months ago

Hi Jordan,

Thank you for the reviews.  I have addressed the two issues 
you raised in my local branch and I verified that the lldbefi.py
script behaves the same after breaking up the long line.

Best regards,

Mike


> -----Original Message-----
> From: Justen, Jordan L
> Sent: Sunday, August 18, 2019 7:43 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>;
> devel@edk2.groups.io
> Cc: Andrew Fish <afish@apple.com>; Ni, Ray
> <ray.ni@intel.com>
> Subject: Re: [Patch V5 00/11] EmulatorPkg: Fix VS20xx
> IA32 boot and simplify build config
> 
> On 2019-08-16 17:57:04, Michael D Kinney wrote:
> >
> > Andrew Fish (7):
> >   EmulatorPkg/Unix/Host: Disable inline/optimizations
> 
> Maybe add XCODE5 in commit message subject?
> 
> Acked-by: Jordan Justen <jordan.l.justen@intel.com>
> 
> >   EmulatorPkg: Fix XCODE5 lldb issues
> 
> There was another long line in the
> EmulatorPkg/Unix/lldbefi.py change.
> 
> Acked-by: Jordan Justen <jordan.l.justen@intel.com>
> 
> >   EmulatorPkg/Unix/Host: Initialize field in
> BerkeleyPacketFilter.c
> 
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
> 
> >   EmulatorPkg/Unix/Host: Remove debug code from
> BerkeleyPacketFilter.c
> 
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
> 
> >   EmulatorPkg: Disable TftpDynamicCommand and LogoDxe
> for XCODE5
> 
> Acked-by: Jordan Justen <jordan.l.justen@intel.com>
> 
> >   EmulatorPkg/Sec: Change scope of PpiArray[10]
> 
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
> 
> >   BaseTools/tools_def.template: Add -gdwarf to XCODE5
> X64
> 
> Acked-by: Jordan Justen <jordan.l.justen@intel.com>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#46044): https://edk2.groups.io/g/devel/message/46044
Mute This Topic: https://groups.io/mt/32918474/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-