[edk2-devel] [edk2-platforms: PATCH v2 0/2] Platforms/RPi3: Device Tree driver improvements

Pete Batard posted 2 patches 4 years, 8 months ago
Failed in applying to current master (apply log)
Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c   | 78 +++++++++++++++-----
Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.inf |  5 +-
Platform/RaspberryPi/RPi3/RPi3.dec                  |  8 +-
Platform/RaspberryPi/RPi3/RPi3.fdf                  |  6 +-
4 files changed, 77 insertions(+), 20 deletions(-)
[edk2-devel] [edk2-platforms: PATCH v2 0/2] Platforms/RPi3: Device Tree driver improvements
Posted by Pete Batard 4 years, 8 months ago
Changes from v1:
- Break down DEBUB output embellishments from the other code changes.
- Use GUIDs that are explicitly named after each platform/model rather than
  generic ones.
- Drop the use of a GUID table/index and use a single GUID variable instead.
- Add additional fallback in case the required internal Device Tree cannot
  be located (e.g. missing from the FDF).
- Ensures that all of the Device Tree selection and fallback can be set up
  in the .dec (FdtDxe reusability).
- Add premilinary Raspberry Pi 4 support (FdtDxe reusability).

Note: Since the changes required to support the Raspberry Pi 4 are a direct
byproduct of the changes required for multiple Device Tree support, I did
not feel the need to break them down into a separate patch.

Pete Batard (2):
  Platforms/RPi3: Improve debug output in FdtDxe
  Platforms/RPi3: Add multiple embedded Device Tree selection

 Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c   | 78 +++++++++++++++-----
 Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.inf |  5 +-
 Platform/RaspberryPi/RPi3/RPi3.dec                  |  8 +-
 Platform/RaspberryPi/RPi3/RPi3.fdf                  |  6 +-
 4 files changed, 77 insertions(+), 20 deletions(-)

-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45813): https://edk2.groups.io/g/devel/message/45813
Mute This Topic: https://groups.io/mt/32896985/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms: PATCH v2 0/2] Platforms/RPi3: Device Tree driver improvements
Posted by Leif Lindholm 4 years, 8 months ago
On Fri, Aug 16, 2019 at 11:00:07AM +0100, Pete Batard wrote:
> Changes from v1:
> - Break down DEBUB output embellishments from the other code changes.
> - Use GUIDs that are explicitly named after each platform/model rather than
>   generic ones.
> - Drop the use of a GUID table/index and use a single GUID variable instead.
> - Add additional fallback in case the required internal Device Tree cannot
>   be located (e.g. missing from the FDF).
> - Ensures that all of the Device Tree selection and fallback can be set up
>   in the .dec (FdtDxe reusability).
> - Add premilinary Raspberry Pi 4 support (FdtDxe reusability).
> 
> Note: Since the changes required to support the Raspberry Pi 4 are a direct
> byproduct of the changes required for multiple Device Tree support, I did
> not feel the need to break them down into a separate patch.

For the series,
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as 591f0c39589c..7da906bfcd03.

Thanks!

> Pete Batard (2):
>   Platforms/RPi3: Improve debug output in FdtDxe
>   Platforms/RPi3: Add multiple embedded Device Tree selection
> 
>  Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c   | 78 +++++++++++++++-----
>  Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.inf |  5 +-
>  Platform/RaspberryPi/RPi3/RPi3.dec                  |  8 +-
>  Platform/RaspberryPi/RPi3/RPi3.fdf                  |  6 +-
>  4 files changed, 77 insertions(+), 20 deletions(-)
> 
> -- 
> 2.21.0.windows.1
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45830): https://edk2.groups.io/g/devel/message/45830
Mute This Topic: https://groups.io/mt/32896985/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-