[edk2-devel] [PATCH 0/3] Move MdeModulePkg/Include/Protocol/Dpc.h to NetworkPkg

Zhang, Shenglei posted 3 patches 1 week ago
Failed in applying to current master (apply log)
MdeModulePkg/MdeModulePkg.dec                       | 3 ---
NetworkPkg/DpcDxe/DpcDxe.inf                        | 1 -
{MdeModulePkg => NetworkPkg}/Include/Protocol/Dpc.h | 0
NetworkPkg/Library/DxeDpcLib/DxeDpcLib.inf          | 1 -
NetworkPkg/NetworkPkg.dec                           | 4 ++++
5 files changed, 4 insertions(+), 5 deletions(-)
rename {MdeModulePkg => NetworkPkg}/Include/Protocol/Dpc.h (100%)

[edk2-devel] [PATCH 0/3] Move MdeModulePkg/Include/Protocol/Dpc.h to NetworkPkg

Posted by Zhang, Shenglei 1 week ago
The file MdeModulePkg/Include/Protocol/Dpc.h is consumed
by the modules in NetworkPkg.
Hence, this protocol header file should be moved into NetworkPkg.
https://bugzilla.tianocore.org/show_bug.cgi?id=1949

Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Shenglei Zhang (3):
  NetworkPkg: Add Dpc protocol
  NetworkPkg: Move Dpc.h from MdeModulePkg to NetworkPkg
  MdeModulePkg/MdeModulePkg.dec: Remove gEfiDpcProtocolGuid

 MdeModulePkg/MdeModulePkg.dec                       | 3 ---
 NetworkPkg/DpcDxe/DpcDxe.inf                        | 1 -
 {MdeModulePkg => NetworkPkg}/Include/Protocol/Dpc.h | 0
 NetworkPkg/Library/DxeDpcLib/DxeDpcLib.inf          | 1 -
 NetworkPkg/NetworkPkg.dec                           | 4 ++++
 5 files changed, 4 insertions(+), 5 deletions(-)
 rename {MdeModulePkg => NetworkPkg}/Include/Protocol/Dpc.h (100%)

-- 
2.18.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45416): https://edk2.groups.io/g/devel/message/45416
Mute This Topic: https://groups.io/mt/32838742/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/3] Move MdeModulePkg/Include/Protocol/Dpc.h to NetworkPkg

Posted by Wu, Hao A 1 week ago
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Monday, August 12, 2019 4:37 PM
> To: devel@edk2.groups.io
> Cc: Fu, Siyuan; Wu, Jiaxin; Wang, Jian J; Wu, Hao A
> Subject: [PATCH 0/3] Move MdeModulePkg/Include/Protocol/Dpc.h to
> NetworkPkg
> 
> The file MdeModulePkg/Include/Protocol/Dpc.h is consumed
> by the modules in NetworkPkg.
> Hence, this protocol header file should be moved into NetworkPkg.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1949
> 
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Shenglei Zhang (3):
>   NetworkPkg: Add Dpc protocol
>   NetworkPkg: Move Dpc.h from MdeModulePkg to NetworkPkg
>   MdeModulePkg/MdeModulePkg.dec: Remove gEfiDpcProtocolGuid


I would recommend the below sequence:
Patch 1 (NetworkPkg): Duplicate the Dpc.h file in NetworkPkg, update NetworkPkg.dec
Patch 2 (NetworkPkg): Update the INF files in NetworkPkg to remove MdeModulePkg dependency
Patch 3 (MdeModulePkg): Remove the Dpc.h file in MdeModulePkg, update MdeModulePkg.dec

But if other reviewers are fine with the current series, I am okay with
the current one:
For patch 3/3 (MdeModulePkg part),
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


> 
>  MdeModulePkg/MdeModulePkg.dec                       | 3 ---
>  NetworkPkg/DpcDxe/DpcDxe.inf                        | 1 -
>  {MdeModulePkg => NetworkPkg}/Include/Protocol/Dpc.h | 0
>  NetworkPkg/Library/DxeDpcLib/DxeDpcLib.inf          | 1 -
>  NetworkPkg/NetworkPkg.dec                           | 4 ++++
>  5 files changed, 4 insertions(+), 5 deletions(-)
>  rename {MdeModulePkg => NetworkPkg}/Include/Protocol/Dpc.h (100%)
> 
> --
> 2.18.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45476): https://edk2.groups.io/g/devel/message/45476
Mute This Topic: https://groups.io/mt/32838742/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-