Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression

[edk2-devel] [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression

Posted by Michael D Kinney 4 years, 8 months ago

The following commit removed the call to SetupInfo() from
SystemConfigExtractConfig().  This caused the BIOS, Processor,
Platform, and Memory information strings from being filled
in with their proper values.

https://github.com/tianocore/edk2-platforms/commit/6738c654c8eddccc2a1230a4541bc2cb74c10ea5

The call to SetupInfo() is added back.

Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Gary Lin <glin@suse.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 .../Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c  | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
index 7a4987f656..f3850b2aff 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
+++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
@@ -150,6 +150,7 @@ SystemConfigExtractConfig (
   OUT EFI_STRING                             *Results
   )
 {
+  SetupInfo();
   return EFI_UNSUPPORTED;
 }
 
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45291): https://edk2.groups.io/g/devel/message/45291
Mute This Topic: https://groups.io/mt/32814191/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression

Posted by Sun, Zailiang 4 years, 8 months ago

Reviewed-by: Zailiang Sun <Zailiang.sun@intel.com>

-----Original Message-----
From: Kinney, Michael D 
Sent: Saturday, August 10, 2019 3:34 AM
To: devel@edk2.groups.io
Cc: Sun, Zailiang <zailiang.sun@intel.com>; Gary Lin <glin@suse.com>
Subject: [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression

The following commit removed the call to SetupInfo() from
SystemConfigExtractConfig().  This caused the BIOS, Processor,
Platform, and Memory information strings from being filled
in with their proper values.

https://github.com/tianocore/edk2-platforms/commit/6738c654c8eddccc2a1230a4541bc2cb74c10ea5

The call to SetupInfo() is added back.

Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Gary Lin <glin@suse.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 .../Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c  | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
index 7a4987f656..f3850b2aff 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
+++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
@@ -150,6 +150,7 @@ SystemConfigExtractConfig (
   OUT EFI_STRING                             *Results
   )
 {
+  SetupInfo();
   return EFI_UNSUPPORTED;
 }
 
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45319): https://edk2.groups.io/g/devel/message/45319
Mute This Topic: https://groups.io/mt/32814191/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression

Posted by Gary Lin 4 years, 8 months ago

On Fri, Aug 09, 2019 at 12:34:03PM -0700,  Kinney, Michael D  wrote:
> The following commit removed the call to SetupInfo() from
> SystemConfigExtractConfig().  This caused the BIOS, Processor,
> Platform, and Memory information strings from being filled
> in with their proper values.
> 
> https://github.com/tianocore/edk2-platforms/commit/6738c654c8eddccc2a1230a4541bc2cb74c10ea5
> 
> The call to SetupInfo() is added back.
> 
The system info is back after applying this patch.

Tested-by: Gary Lin <glin@suse.com>

> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Gary Lin <glin@suse.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  .../Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c  | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
> index 7a4987f656..f3850b2aff 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
> @@ -150,6 +150,7 @@ SystemConfigExtractConfig (
>    OUT EFI_STRING                             *Results
>    )
>  {
> +  SetupInfo();
>    return EFI_UNSUPPORTED;
>  }
>  
> -- 
> 2.21.0.windows.1
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45346): https://edk2.groups.io/g/devel/message/45346
Mute This Topic: https://groups.io/mt/32814191/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-