Platform/RPi3: Report device tree

[edk2-devel] [edk2-platforms: PATCH v2 0/1] Platform/RPi3: Report device tree

Posted by Michael Brown 4 years, 8 months ago

On 06/08/2019 18:07, Leif Lindholm wrote:
> Happy with all of this, except for the use of EFI_DEVICE_ERROR.
> 
> Generally, EFI_DEVICE_ERROR is used as an i/o error type status.
> Either EFI_NOT_FOUND, EFI_INVALID_PARAMETER or EFI_OUT_OF_RECOURCES
> would be more appropriate when referring to device-tree manipulation.
> 
> Could you update these and spin a v2 please?

Here you go.  I have switched all of the EFI_DEVICE_ERROR uses to
EFI_NOT_FOUND, because I could not find any more appropriate
EFI_STATUS value to represent "device tree appears to be corrupted".

(EFI_INVALID_PARAMETER seemed misleading to me, since there is nothing
wrong with the parameters provided by the caller.)

Michael Brown (1):
  Platform/RPi3: Report device tree modification errors using Print()

 .../RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c  | 102 ++++++++++++------
 1 file changed, 70 insertions(+), 32 deletions(-)

-- 
2.21.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45247): https://edk2.groups.io/g/devel/message/45247
Mute This Topic: https://groups.io/mt/32805600/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms: PATCH v2 0/1] Platform/RPi3: Report device tree

Posted by Leif Lindholm 4 years, 8 months ago

On Fri, Aug 09, 2019 at 12:16:24AM +0100, Michael Brown wrote:
> On 06/08/2019 18:07, Leif Lindholm wrote:
> > Happy with all of this, except for the use of EFI_DEVICE_ERROR.
> > 
> > Generally, EFI_DEVICE_ERROR is used as an i/o error type status.
> > Either EFI_NOT_FOUND, EFI_INVALID_PARAMETER or EFI_OUT_OF_RECOURCES
> > would be more appropriate when referring to device-tree manipulation.
> > 
> > Could you update these and spin a v2 please?
> 
> Here you go.  I have switched all of the EFI_DEVICE_ERROR uses to
> EFI_NOT_FOUND, because I could not find any more appropriate
> EFI_STATUS value to represent "device tree appears to be corrupted".
> 
> (EFI_INVALID_PARAMETER seemed misleading to me, since there is nothing
> wrong with the parameters provided by the caller.)

Fair point, and agree with the choice.
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as 812b291c5589.

Thanks!

> Michael Brown (1):
>   Platform/RPi3: Report device tree modification errors using Print()
> 
>  .../RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c  | 102 ++++++++++++------
>  1 file changed, 70 insertions(+), 32 deletions(-)
> 
> -- 
> 2.21.0
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45261): https://edk2.groups.io/g/devel/message/45261
Mute This Topic: https://groups.io/mt/32805600/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-