[edk2-devel] [PATCH] MdePkg/BaseUefiDecompressLib: Add missing description for parameter

Zhang, Shenglei posted 1 patch 4 years, 8 months ago
Failed in applying to current master (apply log)
.../BaseUefiDecompressLib/BaseUefiDecompressLibInternals.h       | 1 +
1 file changed, 1 insertion(+)
[edk2-devel] [PATCH] MdePkg/BaseUefiDecompressLib: Add missing description for parameter
Posted by Zhang, Shenglei 4 years, 8 months ago
The description of parameter Version is missing in comments.
So add the description.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 .../BaseUefiDecompressLib/BaseUefiDecompressLibInternals.h       | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals.h b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals.h
index 0bfb50333777..4df3fa388ddb 100644
--- a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals.h
+++ b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals.h
@@ -230,6 +230,7 @@ Decode (
   @param  Scratch     A temporary scratch buffer that is used to perform the decompression.
                       This is an optional parameter that may be NULL if the
                       required scratch buffer size is 0.
+  @param  Version     1 for UEFI Decompress algoruthm, 2 for Tiano Decompess algorithm.
 
   @retval  RETURN_SUCCESS Decompression completed successfully, and
                           the uncompressed buffer is returned in Destination.
-- 
2.18.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44920): https://edk2.groups.io/g/devel/message/44920
Mute This Topic: https://groups.io/mt/32737332/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] MdePkg/BaseUefiDecompressLib: Add missing description for parameter
Posted by Liming Gao 4 years, 8 months ago
Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Zhang, Shenglei
>Sent: Tuesday, August 06, 2019 10:17 AM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
><liming.gao@intel.com>
>Subject: [edk2-devel] [PATCH] MdePkg/BaseUefiDecompressLib: Add missing
>description for parameter
>
>The description of parameter Version is missing in comments.
>So add the description.
>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
>---
> .../BaseUefiDecompressLib/BaseUefiDecompressLibInternals.h       | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git
>a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>index 0bfb50333777..4df3fa388ddb 100644
>---
>a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>+++
>b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>@@ -230,6 +230,7 @@ Decode (
>   @param  Scratch     A temporary scratch buffer that is used to perform the
>decompression.
>                       This is an optional parameter that may be NULL if the
>                       required scratch buffer size is 0.
>+  @param  Version     1 for UEFI Decompress algoruthm, 2 for Tiano
>Decompess algorithm.
>
>   @retval  RETURN_SUCCESS Decompression completed successfully, and
>                           the uncompressed buffer is returned in Destination.
>--
>2.18.0.windows.1
>
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44961): https://edk2.groups.io/g/devel/message/44961
Mute This Topic: https://groups.io/mt/32737332/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] MdePkg/BaseUefiDecompressLib: Add missing description for parameter
Posted by Liming Gao 4 years, 8 months ago
Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Zhang, Shenglei
>Sent: Tuesday, August 06, 2019 10:17 AM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
><liming.gao@intel.com>
>Subject: [edk2-devel] [PATCH] MdePkg/BaseUefiDecompressLib: Add missing
>description for parameter
>
>The description of parameter Version is missing in comments.
>So add the description.
>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
>---
> .../BaseUefiDecompressLib/BaseUefiDecompressLibInternals.h       | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git
>a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>index 0bfb50333777..4df3fa388ddb 100644
>---
>a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>+++
>b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals
>.h
>@@ -230,6 +230,7 @@ Decode (
>   @param  Scratch     A temporary scratch buffer that is used to perform the
>decompression.
>                       This is an optional parameter that may be NULL if the
>                       required scratch buffer size is 0.
>+  @param  Version     1 for UEFI Decompress algoruthm, 2 for Tiano
>Decompess algorithm.
>
>   @retval  RETURN_SUCCESS Decompression completed successfully, and
>                           the uncompressed buffer is returned in Destination.
>--
>2.18.0.windows.1
>
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45094): https://edk2.groups.io/g/devel/message/45094
Mute This Topic: https://groups.io/mt/32737332/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-