1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [Patch v3 0/2] ShellPkg: Fix IA32 build failure in acpiview

Michael D Kinney posted 2 patches 4 years, 8 months ago
Failed in applying to current master (apply log)
.../Parsers/Slit/SlitParser.c                 |  2 +-
ShellPkg/ShellPkg.dsc                         | 22 ++++++++++++++++++-
2 files changed, 22 insertions(+), 2 deletions(-)
[edk2-devel] [Patch v3 0/2] ShellPkg: Fix IA32 build failure in acpiview
Posted by Michael D Kinney 4 years, 8 months ago 
Use BaseLib MultuU64x64() to prevent intrinsics being added on IA32 builds.
Add acpiview to a version of the Shell that is build with ShellPkg.dsc to catch
this type of issue in ShellPkg builds.

Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>

Michael D Kinney (2):
  ShellPkg/AcpiView: Fix IA32 link error
  ShellPkg: Add shell with all commands integrated

 .../Parsers/Slit/SlitParser.c                 |  2 +-
 ShellPkg/ShellPkg.dsc                         | 22 ++++++++++++++++++-
 2 files changed, 22 insertions(+), 2 deletions(-)

-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44875): https://edk2.groups.io/g/devel/message/44875
Mute This Topic: https://groups.io/mt/32697114/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch v3 0/2] ShellPkg: Fix IA32 build failure in acpiview
Posted by Gao, Zhichao 4 years, 8 months ago 
Series: Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: Kinney, Michael D
> Sent: Saturday, August 3, 2019 9:47 AM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Gao, Zhichao <zhichao.gao@intel.com>; Sami Mujawar
> <sami.mujawar@arm.com>
> Subject: [Patch v3 0/2] ShellPkg: Fix IA32 build failure in acpiview
> 
> Use BaseLib MultuU64x64() to prevent intrinsics being added on IA32 builds.
> Add acpiview to a version of the Shell that is build with ShellPkg.dsc to catch
> this type of issue in ShellPkg builds.
> 
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Michael D Kinney (2):
>   ShellPkg/AcpiView: Fix IA32 link error
>   ShellPkg: Add shell with all commands integrated
> 
>  .../Parsers/Slit/SlitParser.c                 |  2 +-
>  ShellPkg/ShellPkg.dsc                         | 22 ++++++++++++++++++-
>  2 files changed, 22 insertions(+), 2 deletions(-)
> 
> --
> 2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44885): https://edk2.groups.io/g/devel/message/44885
Mute This Topic: https://groups.io/mt/32697114/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch v3 0/2] ShellPkg: Fix IA32 build failure in acpiview
Posted by Sami Mujawar 4 years, 8 months ago 
For this patch series.

Tested-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael D Kinney via Groups.Io
Sent: 03 August 2019 02:47 AM
To: devel@edk2.groups.io
Cc: Jaben Carsey <jaben.carsey@intel.com>; Ray Ni <ray.ni@intel.com>; Zhichao Gao <zhichao.gao@intel.com>; Sami Mujawar <Sami.Mujawar@arm.com>
Subject: [edk2-devel] [Patch v3 0/2] ShellPkg: Fix IA32 build failure in acpiview

Use BaseLib MultuU64x64() to prevent intrinsics being added on IA32 builds.
Add acpiview to a version of the Shell that is build with ShellPkg.dsc to catch this type of issue in ShellPkg builds.

Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>

Michael D Kinney (2):
  ShellPkg/AcpiView: Fix IA32 link error
  ShellPkg: Add shell with all commands integrated

 .../Parsers/Slit/SlitParser.c                 |  2 +-
 ShellPkg/ShellPkg.dsc                         | 22 ++++++++++++++++++-
 2 files changed, 22 insertions(+), 2 deletions(-)

--
2.21.0.windows.1




IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44911): https://edk2.groups.io/g/devel/message/44911
Mute This Topic: https://groups.io/mt/32697114/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch v3 0/2] ShellPkg: Fix IA32 build failure in acpiview
Posted by Carsey, Jaben 4 years, 8 months ago 
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

Thanks
-Jaben


> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Sami Mujawar
> Sent: Monday, August 05, 2019 3:48 AM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Gao, Zhichao <zhichao.gao@intel.com>
> Subject: Re: [edk2-devel] [Patch v3 0/2] ShellPkg: Fix IA32 build failure in
> acpiview
> 
> For this patch series.
> 
> Tested-by: Sami Mujawar <sami.mujawar@arm.com>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
> 
> Regards,
> 
> Sami Mujawar
> 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
> D Kinney via Groups.Io
> Sent: 03 August 2019 02:47 AM
> To: devel@edk2.groups.io
> Cc: Jaben Carsey <jaben.carsey@intel.com>; Ray Ni <ray.ni@intel.com>;
> Zhichao Gao <zhichao.gao@intel.com>; Sami Mujawar
> <Sami.Mujawar@arm.com>
> Subject: [edk2-devel] [Patch v3 0/2] ShellPkg: Fix IA32 build failure in
> acpiview
> 
> Use BaseLib MultuU64x64() to prevent intrinsics being added on IA32 builds.
> Add acpiview to a version of the Shell that is build with ShellPkg.dsc to catch
> this type of issue in ShellPkg builds.
> 
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Michael D Kinney (2):
>   ShellPkg/AcpiView: Fix IA32 link error
>   ShellPkg: Add shell with all commands integrated
> 
>  .../Parsers/Slit/SlitParser.c                 |  2 +-
>  ShellPkg/ShellPkg.dsc                         | 22 ++++++++++++++++++-
>  2 files changed, 22 insertions(+), 2 deletions(-)
> 
> --
> 2.21.0.windows.1
> 
> 
> 
> 
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended recipient,
> please notify the sender immediately and do not disclose the contents to any
> other person, use it for any purpose, or store or copy the information in any
> medium. Thank you.
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44914): https://edk2.groups.io/g/devel/message/44914
Mute This Topic: https://groups.io/mt/32697114/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.