[edk2-devel] [PATCH 0/2] Remove S3Lib and RecoveryLib

Zhang, Shenglei posted 2 patches 4 years, 8 months ago
Failed in applying to current master (apply log)
.../PeiRecoveryLibNull/PeiRecoveryLibNull.c   | 28 ---------------
.../Library/PeiS3LibNull/PeiS3LibNull.c       | 29 ----------------
MdeModulePkg/Core/DxeIplPeim/DxeIpl.h         |  2 --
MdeModulePkg/Include/Library/RecoveryLib.h    | 29 ----------------
MdeModulePkg/Include/Library/S3Lib.h          | 28 ---------------
.../PeiRecoveryLibNull/PeiRecoveryLibNull.inf | 33 ------------------
.../PeiRecoveryLibNull/PeiRecoveryLibNull.uni | 18 ----------
.../Library/PeiS3LibNull/PeiS3LibNull.inf     | 34 -------------------
.../Library/PeiS3LibNull/PeiS3LibNull.uni     | 18 ----------
MdeModulePkg/MdeModulePkg.dec                 | 10 ------
MdeModulePkg/MdeModulePkg.dsc                 |  2 --
11 files changed, 231 deletions(-)
delete mode 100644 MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.c
delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.c
delete mode 100644 MdeModulePkg/Include/Library/RecoveryLib.h
delete mode 100644 MdeModulePkg/Include/Library/S3Lib.h
delete mode 100644 MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.inf
delete mode 100644 MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.uni
delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.inf
delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.uni
[edk2-devel] [PATCH 0/2] Remove S3Lib and RecoveryLib
Posted by Zhang, Shenglei 4 years, 8 months ago
S3Lib and RecoveryLib have been deprecated since 2009.
There is no code using AcpiS3ResumeOs() interface in S3Lib and
PeiRecoverFirmware() interface in RecoveryLib.
So they can be removed from edk2 repo.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Shenglei Zhang (2):
  MdeModulePkg: Remove S3Lib.h and PeiS3LibNull
  MdeModulePkg: Remove RecoveryLib.h and PeiRecoveryLibNull

 .../PeiRecoveryLibNull/PeiRecoveryLibNull.c   | 28 ---------------
 .../Library/PeiS3LibNull/PeiS3LibNull.c       | 29 ----------------
 MdeModulePkg/Core/DxeIplPeim/DxeIpl.h         |  2 --
 MdeModulePkg/Include/Library/RecoveryLib.h    | 29 ----------------
 MdeModulePkg/Include/Library/S3Lib.h          | 28 ---------------
 .../PeiRecoveryLibNull/PeiRecoveryLibNull.inf | 33 ------------------
 .../PeiRecoveryLibNull/PeiRecoveryLibNull.uni | 18 ----------
 .../Library/PeiS3LibNull/PeiS3LibNull.inf     | 34 -------------------
 .../Library/PeiS3LibNull/PeiS3LibNull.uni     | 18 ----------
 MdeModulePkg/MdeModulePkg.dec                 | 10 ------
 MdeModulePkg/MdeModulePkg.dsc                 |  2 --
 11 files changed, 231 deletions(-)
 delete mode 100644 MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.c
 delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.c
 delete mode 100644 MdeModulePkg/Include/Library/RecoveryLib.h
 delete mode 100644 MdeModulePkg/Include/Library/S3Lib.h
 delete mode 100644 MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.inf
 delete mode 100644 MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.uni
 delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.inf
 delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.uni

-- 
2.18.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44848): https://edk2.groups.io/g/devel/message/44848
Mute This Topic: https://groups.io/mt/32688084/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/2] Remove S3Lib and RecoveryLib
Posted by Wu, Hao A 4 years, 8 months ago
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Friday, August 02, 2019 2:55 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J; Wu, Hao A
> Subject: [edk2-devel] [PATCH 0/2] Remove S3Lib and RecoveryLib
> 
> S3Lib and RecoveryLib have been deprecated since 2009.
> There is no code using AcpiS3ResumeOs() interface in S3Lib and
> PeiRecoverFirmware() interface in RecoveryLib.
> So they can be removed from edk2 repo.


For the series:
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

And pushed via commits 1702e2ce5a..4ac8ceb5d6.

Best Regards,
Hao Wu


> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Shenglei Zhang (2):
>   MdeModulePkg: Remove S3Lib.h and PeiS3LibNull
>   MdeModulePkg: Remove RecoveryLib.h and PeiRecoveryLibNull
> 
>  .../PeiRecoveryLibNull/PeiRecoveryLibNull.c   | 28 ---------------
>  .../Library/PeiS3LibNull/PeiS3LibNull.c       | 29 ----------------
>  MdeModulePkg/Core/DxeIplPeim/DxeIpl.h         |  2 --
>  MdeModulePkg/Include/Library/RecoveryLib.h    | 29 ----------------
>  MdeModulePkg/Include/Library/S3Lib.h          | 28 ---------------
>  .../PeiRecoveryLibNull/PeiRecoveryLibNull.inf | 33 ------------------
>  .../PeiRecoveryLibNull/PeiRecoveryLibNull.uni | 18 ----------
>  .../Library/PeiS3LibNull/PeiS3LibNull.inf     | 34 -------------------
>  .../Library/PeiS3LibNull/PeiS3LibNull.uni     | 18 ----------
>  MdeModulePkg/MdeModulePkg.dec                 | 10 ------
>  MdeModulePkg/MdeModulePkg.dsc                 |  2 --
>  11 files changed, 231 deletions(-)
>  delete mode 100644
> MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.c
>  delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.c
>  delete mode 100644 MdeModulePkg/Include/Library/RecoveryLib.h
>  delete mode 100644 MdeModulePkg/Include/Library/S3Lib.h
>  delete mode 100644
> MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.inf
>  delete mode 100644
> MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.uni
>  delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.inf
>  delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.uni
> 
> --
> 2.18.0.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44889): https://edk2.groups.io/g/devel/message/44889
Mute This Topic: https://groups.io/mt/32688084/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-