BaseTools/PatchCheck: Fix false positives

[edk2-devel] [Patch 0/3] BaseTools/PatchCheck: Fix false positives

Posted by Michael D Kinney 4 years, 8 months ago

https://bugzilla.tianocore.org/show_bug.cgi?id=2044

* Add '--no-textconv' to 'git show' command to disable binary->text conversion.
* Ignore blank lines in patch
* Ignore lines with 'copy from ' and 'copy to ' prefixes

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>

Michael D Kinney (3):
  BaseTools/PatchCheck: Ignore blank lines in diff
  BaseTools/PatchCheck: Add copy from/to keywords
  BaseTools/PatchCheck: Disable text conversion in 'git show'

 BaseTools/Scripts/PatchCheck.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44817): https://edk2.groups.io/g/devel/message/44817
Mute This Topic: https://groups.io/mt/32685491/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch 0/3] BaseTools/PatchCheck: Fix false positives

Posted by Liming Gao 4 years, 8 months ago

Mike:
  For this patch set, I am OK for those changes. Reviewed-by: Liming Gao <liming.gao@intel.com>

  But, I see there are some discussion on patch 3. After we make the conclusion, you can push it. 
  
Thanks
Liming
>-----Original Message-----
>From: Kinney, Michael D
>Sent: Friday, August 02, 2019 8:13 AM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
><liming.gao@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>
>Subject: [Patch 0/3] BaseTools/PatchCheck: Fix false positives
>
>https://bugzilla.tianocore.org/show_bug.cgi?id=2044
>
>* Add '--no-textconv' to 'git show' command to disable binary->text
>conversion.
>* Ignore blank lines in patch
>* Ignore lines with 'copy from ' and 'copy to ' prefixes
>
>Cc: Bob Feng <bob.c.feng@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Jordan Justen <jordan.l.justen@intel.com>
>Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
>
>Michael D Kinney (3):
>  BaseTools/PatchCheck: Ignore blank lines in diff
>  BaseTools/PatchCheck: Add copy from/to keywords
>  BaseTools/PatchCheck: Disable text conversion in 'git show'
>
> BaseTools/Scripts/PatchCheck.py | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>--
>2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45000): https://edk2.groups.io/g/devel/message/45000
Mute This Topic: https://groups.io/mt/32685491/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch 0/3] BaseTools/PatchCheck: Fix false positives

Posted by Jordan Justen 4 years, 8 months ago

On 2019-08-01 17:13:11, Michael D Kinney wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=2044
> 
> * Add '--no-textconv' to 'git show' command to disable binary->text conversion.
> * Ignore blank lines in patch
> * Ignore lines with 'copy from ' and 'copy to ' prefixes
> 
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Michael D Kinney (3):
>   BaseTools/PatchCheck: Ignore blank lines in diff
>   BaseTools/PatchCheck: Add copy from/to keywords

patches 1 and 2: Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

>   BaseTools/PatchCheck: Disable text conversion in 'git show'
> 
>  BaseTools/Scripts/PatchCheck.py | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> -- 
> 2.21.0.windows.1
> 
> 
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44865): https://edk2.groups.io/g/devel/message/44865
Mute This Topic: https://groups.io/mt/32685491/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch 0/3] BaseTools/PatchCheck: Fix false positives

Posted by Bob Feng 4 years, 8 months ago

For the patch set,
Reviewed-by: Bob Feng <bob.c.feng@intel.com>

-----Original Message-----
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Michael D Kinney
Sent: Friday, August 2, 2019 8:13 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>
Subject: [edk2-devel] [Patch 0/3] BaseTools/PatchCheck: Fix false positives

https://bugzilla.tianocore.org/show_bug.cgi?id=2044

* Add '--no-textconv' to 'git show' command to disable binary->text conversion.
* Ignore blank lines in patch
* Ignore lines with 'copy from ' and 'copy to ' prefixes

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>

Michael D Kinney (3):
  BaseTools/PatchCheck: Ignore blank lines in diff
  BaseTools/PatchCheck: Add copy from/to keywords
  BaseTools/PatchCheck: Disable text conversion in 'git show'

 BaseTools/Scripts/PatchCheck.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

-- 
2.21.0.windows.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44854): https://edk2.groups.io/g/devel/message/44854
Mute This Topic: https://groups.io/mt/32685491/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-