Prevent buffer overruns in acpiview table parsers

[edk2-devel] [PATCH v1 0/6] Prevent buffer overruns in acpiview table parsers

Posted by Krzysztof Koch 4 years, 8 months ago

This patch series makes minor modifications to a number of ACPI table
parsers with a goal to minimize the risk of buffer overruns. Some of
these overruns can be caused by invalid ACPI table data.

Changes can be seet at: https://github.com/KrzysztofKoch1/edk2/tree/612_prevent_buffer_overruns_v1

Krzysztof Koch (6):
  ShellPkg: acpiview: DBG2: Prevent buffer overruns
  ShellPkg: acpiview: GTDT: Prevent buffer overruns
  ShellPkg: acpiview: IORT: Prevent buffer overruns
  ShellPkg: acpiview: MADT: Prevent buffer overruns
  ShellPkg: acpiview: PPTT: Prevent buffer overruns
  ShellPkg: acpiview: SRAT: Prevent buffer overruns

 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c | 141 ++++++++++-----
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c | 147 +++++++--------
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | 191 +++++++++++---------
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c |   2 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c |  38 ++--
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c |  14 +-
 6 files changed, 314 insertions(+), 219 deletions(-)

--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44752): https://edk2.groups.io/g/devel/message/44752
Mute This Topic: https://groups.io/mt/32676829/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 0/6] Prevent buffer overruns in acpiview table parsers

Posted by Sami Mujawar 4 years, 8 months ago

For this patch series.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

-----Original Message-----
From: Krzysztof Koch <krzysztof.koch@arm.com> 
Sent: 01 August 2019 09:44 AM
To: devel@edk2.groups.io
Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; Sami Mujawar <Sami.Mujawar@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; nd <nd@arm.com>
Subject: [PATCH v1 0/6] Prevent buffer overruns in acpiview table parsers

This patch series makes minor modifications to a number of ACPI table parsers with a goal to minimize the risk of buffer overruns. Some of these overruns can be caused by invalid ACPI table data.

Changes can be seet at: https://github.com/KrzysztofKoch1/edk2/tree/612_prevent_buffer_overruns_v1

Krzysztof Koch (6):
  ShellPkg: acpiview: DBG2: Prevent buffer overruns
  ShellPkg: acpiview: GTDT: Prevent buffer overruns
  ShellPkg: acpiview: IORT: Prevent buffer overruns
  ShellPkg: acpiview: MADT: Prevent buffer overruns
  ShellPkg: acpiview: PPTT: Prevent buffer overruns
  ShellPkg: acpiview: SRAT: Prevent buffer overruns

 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c | 141 ++++++++++-----  ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c | 147 +++++++--------  ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | 191 +++++++++++---------
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c |   2 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c |  38 ++--  ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c |  14 +-
 6 files changed, 314 insertions(+), 219 deletions(-)

--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44991): https://edk2.groups.io/g/devel/message/44991
Mute This Topic: https://groups.io/mt/32676829/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 0/6] Prevent buffer overruns in acpiview table parsers

Posted by Gao, Zhichao 4 years, 8 months ago

For 3 - 6: Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Krzysztof Koch
> Sent: Thursday, August 1, 2019 4:44 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Gao, Zhichao <zhichao.gao@intel.com>; Sami.Mujawar@arm.com;
> Matteo.Carlini@arm.com; nd@arm.com
> Subject: [edk2-devel] [PATCH v1 0/6] Prevent buffer overruns in acpiview
> table parsers
> 
> This patch series makes minor modifications to a number of ACPI table
> parsers with a goal to minimize the risk of buffer overruns. Some of these
> overruns can be caused by invalid ACPI table data.
> 
> Changes can be seet at:
> https://github.com/KrzysztofKoch1/edk2/tree/612_prevent_buffer_overru
> ns_v1
> 
> Krzysztof Koch (6):
>   ShellPkg: acpiview: DBG2: Prevent buffer overruns
>   ShellPkg: acpiview: GTDT: Prevent buffer overruns
>   ShellPkg: acpiview: IORT: Prevent buffer overruns
>   ShellPkg: acpiview: MADT: Prevent buffer overruns
>   ShellPkg: acpiview: PPTT: Prevent buffer overruns
>   ShellPkg: acpiview: SRAT: Prevent buffer overruns
> 
> 
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c
> | 141 ++++++++++-----
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c
> | 147 +++++++--------
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c |
> 191 +++++++++++---------
> 
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.
> c |   2 +-
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
> |  38 ++--
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c |
> 14 +-
>  6 files changed, 314 insertions(+), 219 deletions(-)
> 
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44938): https://edk2.groups.io/g/devel/message/44938
Mute This Topic: https://groups.io/mt/32676829/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 0/6] Prevent buffer overruns in acpiview table parsers

Posted by Alexei Fedorov 4 years, 8 months ago

Reviewed-by: Alexei Fedorov <Alexei.Fedorov@arm.com>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44777): https://edk2.groups.io/g/devel/message/44777
Mute This Topic: https://groups.io/mt/32676829/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-