Fix coding style issues

[edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Remove trailing white space in SmmMp.h

Posted by Zhang, Shenglei 6 years, 6 months ago

Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
index e0d823a4b1c6..b95ed8c6f836 100644
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
@@ -24,7 +24,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
   @retval EFI_SUCCESS             The number of processors was retrieved successfully
   @retval EFI_INVALID_PARAMETER   NumberOfProcessors is NULL
 **/
-
 EFI_STATUS
 EFIAPI
 SmmMpGetNumberOfProcessors (
-- 
2.18.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44603): https://edk2.groups.io/g/devel/message/44603
Mute This Topic: https://groups.io/mt/32652009/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Remove trailing white space in SmmMp.h

Posted by Laszlo Ersek 6 years, 6 months ago

On 07/30/19 10:37, Zhang, Shenglei wrote:
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
> index e0d823a4b1c6..b95ed8c6f836 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
> @@ -24,7 +24,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>    @retval EFI_SUCCESS             The number of processors was retrieved successfully
>    @retval EFI_INVALID_PARAMETER   NumberOfProcessors is NULL
>  **/
> -
>  EFI_STATUS
>  EFIAPI
>  SmmMpGetNumberOfProcessors (
> 

The patch looks good, but I wonder if we should call this empty line "trailing". It is not at the end of the file, and not at the end of a line. Perhaps:

  UefiCpuPkg/PiSmmCpuDxeSmm: keep function comment and declaration adjacent

(73 characters).

Anyway, I don't feel too strongly about this. Either way:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44632): https://edk2.groups.io/g/devel/message/44632
Mute This Topic: https://groups.io/mt/32652009/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Remove trailing white space in SmmMp.h

Posted by Dong, Eric 6 years, 6 months ago

Agree with Laszlo's comments. This info is more precise for the issue.  Please update the commit message when you push the change.

With the commit message updated, reviewed-by: Eric Dong <eric.dong@intel.com>

Thanks,
Eric
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, July 30, 2019 10:11 PM
> To: devel@edk2.groups.io; Zhang, Shenglei <shenglei.zhang@intel.com>
> Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpuDxeSmm:
> Remove trailing white space in SmmMp.h
> 
> On 07/30/19 10:37, Zhang, Shenglei wrote:
> > Cc: Eric Dong <eric.dong@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > ---
> >  UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
> b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
> > index e0d823a4b1c6..b95ed8c6f836 100644
> > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
> > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
> > @@ -24,7 +24,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> >    @retval EFI_SUCCESS             The number of processors was retrieved
> successfully
> >    @retval EFI_INVALID_PARAMETER   NumberOfProcessors is NULL
> >  **/
> > -
> >  EFI_STATUS
> >  EFIAPI
> >  SmmMpGetNumberOfProcessors (
> >
> 
> The patch looks good, but I wonder if we should call this empty line "trailing".
> It is not at the end of the file, and not at the end of a line. Perhaps:
> 
>   UefiCpuPkg/PiSmmCpuDxeSmm: keep function comment and declaration
> adjacent
> 
> (73 characters).
> 
> Anyway, I don't feel too strongly about this. Either way:
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> Thanks
> Laszlo
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44645): https://edk2.groups.io/g/devel/message/44645
Mute This Topic: https://groups.io/mt/32652009/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-