1. Patchew
  2. EDK2
  3. [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources]
  4. View patch

[edk2-devel] [PATCH 2/4] ArmPlatformPkg: list module-internal header files in INF [Sources]

Laszlo Ersek posted 4 patches 6 years, 6 months ago
[edk2-devel] [PATCH 2/4] ArmPlatformPkg: list module-internal header files in INF [Sources]
Posted by Laszlo Ersek 6 years, 6 months ago 
The BaseTools build feature introduced for TianoCore#1804 / in commit
1fa6699e6cd4 ("BaseTools: Add a checking for Sources section in INF file",
2019-06-10) logs some (non-fatal) warnings about unlisted internal header
files. List those files explicitly.

Note: header files are added in lexicographical order only if the
underlying INF file already keeps the [Sources] and [LibraryClasses]
sections in lexicographical order. Otherwise, header files are added in
rough "logical" order.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf                     | 1 +
 ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf | 1 +
 ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf                         | 1 +
 ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf                        | 1 +
 4 files changed, 4 insertions(+)

diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
index f17a9301a4ac..a647c016878d 100644
--- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
+++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
@@ -17,6 +17,7 @@ [Defines]
   ENTRY_POINT                    = NorFlashInitialise
 
 [Sources.common]
+  NorFlashDxe.h
   NorFlashDxe.c
   NorFlashFvbDxe.c
   NorFlashBlockIoDxe.c
diff --git a/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf b/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf
index 4c62311f5d41..8224617f20ab 100644
--- a/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf
+++ b/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf
@@ -17,6 +17,7 @@ [Defines]
   LIBRARY_CLASS                  = RealTimeClockLib|DXE_RUNTIME_DRIVER
 
 [Sources.common]
+  PL031RealTimeClock.h
   PL031RealTimeClockLib.c
 
 [Packages]
diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf b/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
index 0e112710dcfc..f2ac45d171bc 100644
--- a/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
+++ b/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
@@ -16,6 +16,7 @@ [Defines]
 
 [Sources.common]
   MainMPCore.c
+  PrePeiCore.h
   PrePeiCore.c
 
 [Sources.ARM]
diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf b/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
index c163a818c407..84c319c3679b 100644
--- a/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+++ b/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
@@ -15,6 +15,7 @@ [Defines]
   VERSION_STRING                 = 1.0
 
 [Sources.common]
+  PrePeiCore.h
   PrePeiCore.c
   MainUniCore.c
 
-- 
2.19.1.3.g30247aa5d201



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44058): https://edk2.groups.io/g/devel/message/44058
Mute This Topic: https://groups.io/mt/32529016/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 2/4] ArmPlatformPkg: list module-internal header files in INF [Sources]
Posted by Philippe Mathieu-Daudé 6 years, 6 months ago 
On 7/19/19 6:43 PM, Laszlo Ersek wrote:
> The BaseTools build feature introduced for TianoCore#1804 / in commit
> 1fa6699e6cd4 ("BaseTools: Add a checking for Sources section in INF file",
> 2019-06-10) logs some (non-fatal) warnings about unlisted internal header
> files. List those files explicitly.
> 
> Note: header files are added in lexicographical order only if the
> underlying INF file already keeps the [Sources] and [LibraryClasses]
> sections in lexicographical order. Otherwise, header files are added in
> rough "logical" order.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

> ---
>  ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf                     | 1 +
>  ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf | 1 +
>  ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf                         | 1 +
>  ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf                        | 1 +
>  4 files changed, 4 insertions(+)
> 
> diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
> index f17a9301a4ac..a647c016878d 100644
> --- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
> +++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
> @@ -17,6 +17,7 @@ [Defines]
>    ENTRY_POINT                    = NorFlashInitialise
>  
>  [Sources.common]
> +  NorFlashDxe.h
>    NorFlashDxe.c
>    NorFlashFvbDxe.c
>    NorFlashBlockIoDxe.c
> diff --git a/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf b/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf
> index 4c62311f5d41..8224617f20ab 100644
> --- a/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf
> +++ b/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf
> @@ -17,6 +17,7 @@ [Defines]
>    LIBRARY_CLASS                  = RealTimeClockLib|DXE_RUNTIME_DRIVER
>  
>  [Sources.common]
> +  PL031RealTimeClock.h
>    PL031RealTimeClockLib.c
>  
>  [Packages]
> diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf b/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
> index 0e112710dcfc..f2ac45d171bc 100644
> --- a/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
> +++ b/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
> @@ -16,6 +16,7 @@ [Defines]
>  
>  [Sources.common]
>    MainMPCore.c
> +  PrePeiCore.h
>    PrePeiCore.c
>  
>  [Sources.ARM]
> diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf b/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
> index c163a818c407..84c319c3679b 100644
> --- a/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
> +++ b/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
> @@ -15,6 +15,7 @@ [Defines]
>    VERSION_STRING                 = 1.0
>  
>  [Sources.common]
> +  PrePeiCore.h
>    PrePeiCore.c
>    MainUniCore.c
>  
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44064): https://edk2.groups.io/g/devel/message/44064
Mute This Topic: https://groups.io/mt/32529016/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.