REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1973

CpuFeatures solution introduces a policy which write msr bases
on scope info. With this policy enabled, for the msr which is
package scope, CpuFeature PEIM driver boots hang.
The reason for this failure is current CPU MP Ppi not supports
start bsp and AP at the same time.

This patch serial introduce new API named StartupAllCPUs. And
it add new ppi namded Edkii Mp Services2 Ppi, include EFI MP
Serivces PPI and this new API.

With this new PPi, CPU features PEI solution can start all CPUs
at the same time.

Because this patch only add one new API, i did belew tests:
1. Test StartupAllCpus with timeout == 0 pass.
2. Test StartupAllCpus with timeout != 0 pass.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Chandana Kumar <chandana.c.kumar@intel.com>
Cc: Star Zeng <star.zeng@intel.com>

Eric Dong (5):
  UefiCpuPkg/Include/MpInitLib.h: Add MpInitLibStartupAllCPUs API.
  UefiCpuPkg/MpInitLib: Add MpInitLibStartupAllCPUs API.
  UefiCpuPkg: Add new EDKII_PEI_MP_SERVICES2_PPI
  UefiCpuPkg/CpuMpPei: Produce EDKII_PEI_MP_SERVICES2_PPI.
  UefiCpuPkg/RegisterCpuFeaturesLib: Start all processors
    simultaneously.

 UefiCpuPkg/CpuMpPei/CpuMpPei.c                | 73 ++++++++++++++++--
 UefiCpuPkg/CpuMpPei/CpuMpPei.h                | 35 ++++++++-
 UefiCpuPkg/CpuMpPei/CpuMpPei.inf              |  1 +
 UefiCpuPkg/Include/Library/MpInitLib.h        | 48 ++++++++++++
 UefiCpuPkg/Include/Ppi/EdkiiMpServices2.h     | 72 ++++++++++++++++++
 UefiCpuPkg/Library/MpInitLib/DxeMpLib.c       |  1 +
 UefiCpuPkg/Library/MpInitLib/MpLib.c          | 74 ++++++++++++++++++-
 UefiCpuPkg/Library/MpInitLib/MpLib.h          |  2 +
 UefiCpuPkg/Library/MpInitLib/PeiMpLib.c       |  1 +
 .../PeiRegisterCpuFeaturesLib.c               | 62 ++++++++++++----
 .../PeiRegisterCpuFeaturesLib.inf             |  1 +
 UefiCpuPkg/UefiCpuPkg.dec                     |  3 +
 12 files changed, 347 insertions(+), 26 deletions(-)
 create mode 100644 UefiCpuPkg/Include/Ppi/EdkiiMpServices2.h

-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44016): https://edk2.groups.io/g/devel/message/44016
Mute This Topic: https://groups.io/mt/32524456/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

On 07/19/19 09:28, Eric Dong wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1973
> 
> CpuFeatures solution introduces a policy which write msr bases
> on scope info. With this policy enabled, for the msr which is
> package scope, CpuFeature PEIM driver boots hang.
> The reason for this failure is current CPU MP Ppi not supports
> start bsp and AP at the same time.
> 
> This patch serial introduce new API named StartupAllCPUs. And
> it add new ppi namded Edkii Mp Services2 Ppi, include EFI MP
> Serivces PPI and this new API.
> 
> With this new PPi, CPU features PEI solution can start all CPUs
> at the same time.
> 
> Because this patch only add one new API, i did belew tests:
> 1. Test StartupAllCpus with timeout == 0 pass.
> 2. Test StartupAllCpus with timeout != 0 pass.

I'd like to regression test patches 1 through 4.

It seems like Ray requested code updates for patch #2 and #4. Thus I
prefer to regression test v2, with those requests addressed.

Thanks
Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44040): https://edk2.groups.io/g/devel/message/44040
Mute This Topic: https://groups.io/mt/32524456/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-