1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH v7 0/4] Implement SM3 measured boot

Imran Desai posted 4 patches 4 years, 9 months ago
Failed in applying to current master (apply log)
OvmfPkg/OvmfPkgIa32.dsc                       |   2 +
OvmfPkg/OvmfPkgIa32X64.dsc                    |   2 +
OvmfPkg/OvmfPkgX64.dsc                        |   2 +
SecurityPkg/Include/Library/HashLib.h         |   4 +
.../HashInstanceLibSm3/HashInstanceLibSm3.c   | 150 ++++++++++++++++++
.../HashInstanceLibSm3/HashInstanceLibSm3.inf |  41 +++++
.../HashInstanceLibSm3/HashInstanceLibSm3.uni |  15 ++
.../HashLibBaseCryptoRouterCommon.c           |   1 +
SecurityPkg/SecurityPkg.dec                   |   5 +-
SecurityPkg/SecurityPkg.dsc                   |   3 +
10 files changed, 223 insertions(+), 2 deletions(-)
create mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.c
create mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf
create mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.uni
[edk2-devel] [PATCH v7 0/4] Implement SM3 measured boot
Posted by Imran Desai 4 years, 9 months ago 
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781
GITHUB: https://github.com/idesai/edk2/tree/enable_sm3_measured_boot_v7

EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR
banks. This digest algorithm is part of the China Crypto algorithm suite.
This integration has dependency on the openssl_1_1_1b integration into
edk2.

Delta in v7:
1. Dropped 95a040cff from v6 to address https://edk2.groups.io/g/devel/topic/
32454898?p=,,,20,0,0,0::Created,,sm3,20,2,0,32454898,ct=1&ct=1
2. Relocated SM3 GUID definition from MdePkg to SecurityPkg in 9728b54f4


Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian Wang <jian.j.wang@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Cc: Stefan Berger <stefanb@linux.ibm.com>

Imran Desai (4):
  SecurityPkg: introduce the SM3 digest algorithm
  SecurityPkg/HashLibBaseCryptoRouter: recognize the SM3 digest
    algorithm
  SecurityPkg: set SM3 bit in TPM 2.0 hash mask by default
  OvmfPkg: link SM3 support into Tcg2Pei and Tcg2Dxe

 OvmfPkg/OvmfPkgIa32.dsc                       |   2 +
 OvmfPkg/OvmfPkgIa32X64.dsc                    |   2 +
 OvmfPkg/OvmfPkgX64.dsc                        |   2 +
 SecurityPkg/Include/Library/HashLib.h         |   4 +
 .../HashInstanceLibSm3/HashInstanceLibSm3.c   | 150 ++++++++++++++++++
 .../HashInstanceLibSm3/HashInstanceLibSm3.inf |  41 +++++
 .../HashInstanceLibSm3/HashInstanceLibSm3.uni |  15 ++
 .../HashLibBaseCryptoRouterCommon.c           |   1 +
 SecurityPkg/SecurityPkg.dec                   |   5 +-
 SecurityPkg/SecurityPkg.dsc                   |   3 +
 10 files changed, 223 insertions(+), 2 deletions(-)
 create mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.c
 create mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf
 create mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.uni

-- 
2.17.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43974): https://edk2.groups.io/g/devel/message/43974
Mute This Topic: https://groups.io/mt/32520440/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v7 0/4] Implement SM3 measured boot
Posted by Laszlo Ersek 4 years, 9 months ago 
On 07/19/19 00:53, Imran Desai wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781
> GITHUB: https://github.com/idesai/edk2/tree/enable_sm3_measured_boot_v7
> 
> EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR
> banks. This digest algorithm is part of the China Crypto algorithm suite.
> This integration has dependency on the openssl_1_1_1b integration into
> edk2.
> 
> Delta in v7:
> 1. Dropped 95a040cff from v6 to address https://edk2.groups.io/g/devel/topic/
> 32454898?p=,,,20,0,0,0::Created,,sm3,20,2,0,32454898,ct=1&ct=1
> 2. Relocated SM3 GUID definition from MdePkg to SecurityPkg in 9728b54f4
> 
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian Wang <jian.j.wang@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Stefan Berger <stefanb@linux.ibm.com>
> 
> Imran Desai (4):
>   SecurityPkg: introduce the SM3 digest algorithm
>   SecurityPkg/HashLibBaseCryptoRouter: recognize the SM3 digest
>     algorithm
>   SecurityPkg: set SM3 bit in TPM 2.0 hash mask by default
>   OvmfPkg: link SM3 support into Tcg2Pei and Tcg2Dxe
> 
>  OvmfPkg/OvmfPkgIa32.dsc                       |   2 +
>  OvmfPkg/OvmfPkgIa32X64.dsc                    |   2 +
>  OvmfPkg/OvmfPkgX64.dsc                        |   2 +
>  SecurityPkg/Include/Library/HashLib.h         |   4 +
>  .../HashInstanceLibSm3/HashInstanceLibSm3.c   | 150 ++++++++++++++++++
>  .../HashInstanceLibSm3/HashInstanceLibSm3.inf |  41 +++++
>  .../HashInstanceLibSm3/HashInstanceLibSm3.uni |  15 ++
>  .../HashLibBaseCryptoRouterCommon.c           |   1 +
>  SecurityPkg/SecurityPkg.dec                   |   5 +-
>  SecurityPkg/SecurityPkg.dsc                   |   3 +
>  10 files changed, 223 insertions(+), 2 deletions(-)
>  create mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.c
>  create mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf
>  create mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.uni
> 

Pushed as commit range 296c908c6968..5d3ef15da7c3.

Thanks
Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44039): https://edk2.groups.io/g/devel/message/44039
Mute This Topic: https://groups.io/mt/32520440/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v7 0/4] Implement SM3 measured boot
Posted by Wang, Jian J 4 years, 9 months ago 
Laszlo,

Thanks for pushing the patches. Our internal CI has problem these days and
I haven't got a complete report. It blocked me to do it.

Regards,
Jian


> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Friday, July 19, 2019 8:41 PM
> To: devel@edk2.groups.io; Desai, Imran <imran.desai@intel.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao,
> Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> Justen, Jordan L <jordan.l.justen@intel.com>; Ard Biesheuvel
> <ard.biesheuvel@linaro.org>; Marc-André Lureau
> <marcandre.lureau@redhat.com>; Stefan Berger <stefanb@linux.ibm.com>
> Subject: Re: [edk2-devel] [PATCH v7 0/4] Implement SM3 measured boot
> 
> On 07/19/19 00:53, Imran Desai wrote:
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781
> > GITHUB:
> https://github.com/idesai/edk2/tree/enable_sm3_measured_boot_v7
> >
> > EDK2 Support for SM3 digest algorithm is needed to enable TPM with
> SM3 PCR
> > banks. This digest algorithm is part of the China Crypto algorithm suite.
> > This integration has dependency on the openssl_1_1_1b integration into
> > edk2.
> >
> > Delta in v7:
> > 1. Dropped 95a040cff from v6 to address
> https://edk2.groups.io/g/devel/topic/
> > 32454898?p=,,,20,0,0,0::Created,,sm3,20,2,0,32454898,ct=1&ct=1
> > 2. Relocated SM3 GUID definition from MdePkg to SecurityPkg in
> 9728b54f4
> >
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Chao Zhang <chao.b.zhang@intel.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jian Wang <jian.j.wang@intel.com>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> > Cc: Stefan Berger <stefanb@linux.ibm.com>
> >
> > Imran Desai (4):
> >   SecurityPkg: introduce the SM3 digest algorithm
> >   SecurityPkg/HashLibBaseCryptoRouter: recognize the SM3 digest
> >     algorithm
> >   SecurityPkg: set SM3 bit in TPM 2.0 hash mask by default
> >   OvmfPkg: link SM3 support into Tcg2Pei and Tcg2Dxe
> >
> >  OvmfPkg/OvmfPkgIa32.dsc                       |   2 +
> >  OvmfPkg/OvmfPkgIa32X64.dsc                    |   2 +
> >  OvmfPkg/OvmfPkgX64.dsc                        |   2 +
> >  SecurityPkg/Include/Library/HashLib.h         |   4 +
> >  .../HashInstanceLibSm3/HashInstanceLibSm3.c   | 150
> ++++++++++++++++++
> >  .../HashInstanceLibSm3/HashInstanceLibSm3.inf |  41 +++++
> >  .../HashInstanceLibSm3/HashInstanceLibSm3.uni |  15 ++
> >  .../HashLibBaseCryptoRouterCommon.c           |   1 +
> >  SecurityPkg/SecurityPkg.dec                   |   5 +-
> >  SecurityPkg/SecurityPkg.dsc                   |   3 +
> >  10 files changed, 223 insertions(+), 2 deletions(-)
> >  create mode 100644
> SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.c
> >  create mode 100644
> SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf
> >  create mode 100644
> SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.uni
> >
> 
> Pushed as commit range 296c908c6968..5d3ef15da7c3.
> 
> Thanks
> Laszlo
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44080): https://edk2.groups.io/g/devel/message/44080
Mute This Topic: https://groups.io/mt/32520440/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v7 0/4] Implement SM3 measured boot
Posted by Yao, Jiewen 4 years, 9 months ago 
Patch 1~3, reviewed-by: jiewen.yao@intel.com
Patch 4, acked-by: Jiewen.yao@intel.com


> -----Original Message-----
> From: Desai, Imran
> Sent: Friday, July 19, 2019 6:53 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao,
> Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> Justen, Jordan L <jordan.l.justen@intel.com>; Laszlo Ersek
> <lersek@redhat.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>;
> Marc-André Lureau <marcandre.lureau@redhat.com>; Stefan Berger
> <stefanb@linux.ibm.com>
> Subject: [PATCH v7 0/4] Implement SM3 measured boot
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781
> GITHUB:
> https://github.com/idesai/edk2/tree/enable_sm3_measured_boot_v7
> 
> EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3
> PCR
> banks. This digest algorithm is part of the China Crypto algorithm suite.
> This integration has dependency on the openssl_1_1_1b integration into
> edk2.
> 
> Delta in v7:
> 1. Dropped 95a040cff from v6 to address
> https://edk2.groups.io/g/devel/topic/
> 32454898?p=,,,20,0,0,0::Created,,sm3,20,2,0,32454898,ct=1&ct=1
> 2. Relocated SM3 GUID definition from MdePkg to SecurityPkg in 9728b54f4
> 
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian Wang <jian.j.wang@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Stefan Berger <stefanb@linux.ibm.com>
> 
> Imran Desai (4):
>   SecurityPkg: introduce the SM3 digest algorithm
>   SecurityPkg/HashLibBaseCryptoRouter: recognize the SM3 digest
>     algorithm
>   SecurityPkg: set SM3 bit in TPM 2.0 hash mask by default
>   OvmfPkg: link SM3 support into Tcg2Pei and Tcg2Dxe
> 
>  OvmfPkg/OvmfPkgIa32.dsc                       |   2 +
>  OvmfPkg/OvmfPkgIa32X64.dsc                    |   2 +
>  OvmfPkg/OvmfPkgX64.dsc                        |   2 +
>  SecurityPkg/Include/Library/HashLib.h         |   4 +
>  .../HashInstanceLibSm3/HashInstanceLibSm3.c   | 150
> ++++++++++++++++++
>  .../HashInstanceLibSm3/HashInstanceLibSm3.inf |  41 +++++
>  .../HashInstanceLibSm3/HashInstanceLibSm3.uni |  15 ++
>  .../HashLibBaseCryptoRouterCommon.c           |   1 +
>  SecurityPkg/SecurityPkg.dec                   |   5 +-
>  SecurityPkg/SecurityPkg.dsc                   |   3 +
>  10 files changed, 223 insertions(+), 2 deletions(-)
>  create mode 100644
> SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.c
>  create mode 100644
> SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf
>  create mode 100644
> SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.uni
> 
> --
> 2.17.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43986): https://edk2.groups.io/g/devel/message/43986
Mute This Topic: https://groups.io/mt/32520440/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v7 0/4] Implement SM3 measured boot
Posted by Wang, Jian J 4 years, 9 months ago 
For patch1-3,
    Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

> -----Original Message-----
> From: Desai, Imran
> Sent: Friday, July 19, 2019 6:53 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao,
> Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> Justen, Jordan L <jordan.l.justen@intel.com>; Laszlo Ersek
> <lersek@redhat.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>; Marc-
> André Lureau <marcandre.lureau@redhat.com>; Stefan Berger
> <stefanb@linux.ibm.com>
> Subject: [PATCH v7 0/4] Implement SM3 measured boot
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781
> GITHUB:
> https://github.com/idesai/edk2/tree/enable_sm3_measured_boot_v7
> 
> EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3
> PCR
> banks. This digest algorithm is part of the China Crypto algorithm suite.
> This integration has dependency on the openssl_1_1_1b integration into
> edk2.
> 
> Delta in v7:
> 1. Dropped 95a040cff from v6 to address
> https://edk2.groups.io/g/devel/topic/
> 32454898?p=,,,20,0,0,0::Created,,sm3,20,2,0,32454898,ct=1&ct=1
> 2. Relocated SM3 GUID definition from MdePkg to SecurityPkg in
> 9728b54f4
> 
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian Wang <jian.j.wang@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Stefan Berger <stefanb@linux.ibm.com>
> 
> Imran Desai (4):
>   SecurityPkg: introduce the SM3 digest algorithm
>   SecurityPkg/HashLibBaseCryptoRouter: recognize the SM3 digest
>     algorithm
>   SecurityPkg: set SM3 bit in TPM 2.0 hash mask by default
>   OvmfPkg: link SM3 support into Tcg2Pei and Tcg2Dxe
> 
>  OvmfPkg/OvmfPkgIa32.dsc                       |   2 +
>  OvmfPkg/OvmfPkgIa32X64.dsc                    |   2 +
>  OvmfPkg/OvmfPkgX64.dsc                        |   2 +
>  SecurityPkg/Include/Library/HashLib.h         |   4 +
>  .../HashInstanceLibSm3/HashInstanceLibSm3.c   | 150
> ++++++++++++++++++
>  .../HashInstanceLibSm3/HashInstanceLibSm3.inf |  41 +++++
>  .../HashInstanceLibSm3/HashInstanceLibSm3.uni |  15 ++
>  .../HashLibBaseCryptoRouterCommon.c           |   1 +
>  SecurityPkg/SecurityPkg.dec                   |   5 +-
>  SecurityPkg/SecurityPkg.dsc                   |   3 +
>  10 files changed, 223 insertions(+), 2 deletions(-)
>  create mode 100644
> SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.c
>  create mode 100644
> SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf
>  create mode 100644
> SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.uni
> 
> --
> 2.17.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43996): https://edk2.groups.io/g/devel/message/43996
Mute This Topic: https://groups.io/mt/32520440/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.