Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.c | 44 +++++++++++--------- 1 file changed, 25 insertions(+), 19 deletions(-)
Networking applications (e.g. iPXE) might experience failures when submitting a bulk IN for the NIC's RX endpoint, because the bulk IN (correctly) times out when no received packet is waiting, but DwUsbHostDxe.c treats this as a fatal error. With these patches, iPXE is able to successfully download a 128MB test file via HTTP. Michael Brown (3): Platform/RPi3: Use Wait4Bit return value consistently Platform/RPi3: Gracefully disable USB channel after a timeout Platform/RPi3: Reduce debug noise when using a USB network device Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.c | 44 +++++++++++--------- 1 file changed, 25 insertions(+), 19 deletions(-) -- 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43877): https://edk2.groups.io/g/devel/message/43877 Mute This Topic: https://groups.io/mt/32502331/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi Pete, On Wed, Jul 17, 2019 at 12:46:42PM +0100, Pete Batard wrote: > Networking applications (e.g. iPXE) might experience failures when submitting > a bulk IN for the NIC's RX endpoint, because the bulk IN (correctly) times out > when no received packet is waiting, but DwUsbHostDxe.c treats this as a fatal > error. > > With these patches, iPXE is able to successfully download a 128MB test file > via HTTP. The patches look good, and I don't mind you upstreaming Michael's code, *but* I don't want patches submitted with anyone other than the contributor's Signed-off-by:. (It's the equivalent of saying "Yeah, Michael says he's OK with https://developercertificate.org/, and of no actual use.) (If patches are modified after contribution, but before being pushed, then then additional contributions can be reflected with additional Signed-off-bys. Make sense?) The From: tag ensures he still retains authorship. Are you OK with me dropping Michael's Signed-off-by before pushing? Best Regards, Leif > Michael Brown (3): > Platform/RPi3: Use Wait4Bit return value consistently > Platform/RPi3: Gracefully disable USB channel after a timeout > Platform/RPi3: Reduce debug noise when using a USB network device > > Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.c | 44 +++++++++++--------- > 1 file changed, 25 insertions(+), 19 deletions(-) > > -- > 2.21.0.windows.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44038): https://edk2.groups.io/g/devel/message/44038 Mute This Topic: https://groups.io/mt/32502331/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On 19/07/2019 12:53, Leif Lindholm wrote: > The patches look good, and I don't mind you upstreaming Michael's > code, *but* I don't want patches submitted with anyone other than the > contributor's Signed-off-by:. (It's the equivalent of saying "Yeah, > Michael says he's OK with https://developercertificate.org/, and of no > actual use.) Sorry; this is almost certainly my fault. My Signed-off-by was present in the original patches that I sent to Pete, and Pete kindly offered to take care of upstreaming the patches for me. For the avoidance of any doubt: I definitely agree to the statements in https://developercertificate.org/. I am happy for you to either drop or retain my Signed-off-by before pushing, as you see fit. Many thanks, Michael -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44048): https://edk2.groups.io/g/devel/message/44048 Mute This Topic: https://groups.io/mt/32502331/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Fri, Jul 19, 2019 at 04:22:10PM +0100, Michael Brown wrote: > On 19/07/2019 12:53, Leif Lindholm wrote: > > The patches look good, and I don't mind you upstreaming Michael's > > code, *but* I don't want patches submitted with anyone other than the > > contributor's Signed-off-by:. (It's the equivalent of saying "Yeah, > > Michael says he's OK with https://developercertificate.org/, and of no > > actual use.) > > Sorry; this is almost certainly my fault. Well, there is nothing *wrong* with that - only there is no value in second-hand signed-off-bys. > My Signed-off-by was present in > the original patches that I sent to Pete, and Pete kindly offered to take > care of upstreaming the patches for me. For the avoidance of any doubt: I > definitely agree to the statements in https://developercertificate.org/. Glad to hear it :) This means I *could* have included them, but... > I am happy for you to either drop or retain my Signed-off-by before pushing, > as you see fit. ...to reduce confusion, I dropped them before pushing - but you're still set as the author. If in future you contribute directly yourself, please keep the Signed-off-by in. Best Regards, Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44061): https://edk2.groups.io/g/devel/message/44061 Mute This Topic: https://groups.io/mt/32502331/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi Leif, On 2019.07.19 12:53, Leif Lindholm wrote: > Hi Pete, > > On Wed, Jul 17, 2019 at 12:46:42PM +0100, Pete Batard wrote: >> Networking applications (e.g. iPXE) might experience failures when submitting >> a bulk IN for the NIC's RX endpoint, because the bulk IN (correctly) times out >> when no received packet is waiting, but DwUsbHostDxe.c treats this as a fatal >> error. >> >> With these patches, iPXE is able to successfully download a 128MB test file >> via HTTP. > > The patches look good, and I don't mind you upstreaming Michael's > code, *but* I don't want patches submitted with anyone other than the > contributor's Signed-off-by:. (It's the equivalent of saying "Yeah, > Michael says he's OK with https://developercertificate.org/, and of no > actual use.) I see. It does make sense, now that you explain it. > (If patches are modified after contribution, but before being pushed, > then then additional contributions can be reflected with additional > Signed-off-bys. Make sense?) > > The From: tag ensures he still retains authorship. > Are you OK with me dropping Michael's Signed-off-by before pushing? That's fine with me. I reviewed these patches and can therefore vouch for them. Regards, /Pete PS: Thanks for pushing the previous series. > > Best Regards, > > Leif > >> Michael Brown (3): >> Platform/RPi3: Use Wait4Bit return value consistently >> Platform/RPi3: Gracefully disable USB channel after a timeout >> Platform/RPi3: Reduce debug noise when using a USB network device >> >> Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.c | 44 +++++++++++--------- >> 1 file changed, 25 insertions(+), 19 deletions(-) >> >> -- >> 2.21.0.windows.1 >> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44049): https://edk2.groups.io/g/devel/message/44049 Mute This Topic: https://groups.io/mt/32502331/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Fri, Jul 19, 2019 at 04:40:48PM +0100, Pete Batard wrote: > > (If patches are modified after contribution, but before being pushed, > > then then additional contributions can be reflected with additional > > Signed-off-bys. Make sense?) > > > > The From: tag ensures he still retains authorship. > > Are you OK with me dropping Michael's Signed-off-by before pushing? > > That's fine with me. I reviewed these patches and can therefore vouch for > them. Cool, thanks. For the series: Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> Pushed as 3542dfdecab1..77dc30a13b13. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44054): https://edk2.groups.io/g/devel/message/44054 Mute This Topic: https://groups.io/mt/32502331/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.