UefiCpuPkg DxeRegisterCpuFeaturesLib: Fix VS2012 build failure

[edk2-devel] [PATCH] UefiCpuPkg DxeRegisterCpuFeaturesLib: Fix VS2012 build failure

Posted by Zeng, Star 4 years, 9 months ago

The new VS2012 build failure is caused by 7a0df26.

xxx\registercpufeatureslib\dxeregistercpufeatureslib.c(258) :
 warning C4701: potentially uninitialized local variable 'MpEvent' used

It is a false positive alarm.
MpEvent is assigned at line 238 and will be used at line 258, both
lines are controlled by "if (CpuFeaturesData->NumberOfCpus > 1)".

This patch initializes MpEvent to suppress incorrect compiler/analyzer
warnings.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 .../RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c      | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
index ffd99046a6cd..f87b2892aaae 100644
--- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
+++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
@@ -229,6 +229,12 @@ CpuFeaturesInitialize (
   OldBspNumber = GetProcessorIndex (CpuFeaturesData);
   CpuFeaturesData->BspNumber = OldBspNumber;
 
+  //
+  //
+  // Initialize MpEvent to suppress incorrect compiler/analyzer warnings.
+  //
+  MpEvent = NULL;
+
   if (CpuFeaturesData->NumberOfCpus > 1) {
     Status = gBS->CreateEvent (
                     EVT_NOTIFY_WAIT,
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43836): https://edk2.groups.io/g/devel/message/43836
Mute This Topic: https://groups.io/mt/32499927/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] UefiCpuPkg DxeRegisterCpuFeaturesLib: Fix VS2012 build failure

Posted by Dong, Eric 4 years, 9 months ago

Reviewed-by: Eric Dong <eric.dong@intel.com>

> -----Original Message-----
> From: Zeng, Star
> Sent: Wednesday, July 17, 2019 11:23 AM
> To: devel@edk2.groups.io
> Cc: Zeng, Star <star.zeng@intel.com>; Laszlo Ersek <lersek@redhat.com>;
> Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Bi, Dandan
> <dandan.bi@intel.com>
> Subject: [PATCH] UefiCpuPkg DxeRegisterCpuFeaturesLib: Fix VS2012 build
> failure
> 
> The new VS2012 build failure is caused by 7a0df26.
> 
> xxx\registercpufeatureslib\dxeregistercpufeatureslib.c(258) :
>  warning C4701: potentially uninitialized local variable 'MpEvent' used
> 
> It is a false positive alarm.
> MpEvent is assigned at line 238 and will be used at line 258, both lines are
> controlled by "if (CpuFeaturesData->NumberOfCpus > 1)".
> 
> This patch initializes MpEvent to suppress incorrect compiler/analyzer
> warnings.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>  .../RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c      | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git
> a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
> b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
> index ffd99046a6cd..f87b2892aaae 100644
> ---
> a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
> +++
> b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLi
> +++ b.c
> @@ -229,6 +229,12 @@ CpuFeaturesInitialize (
>    OldBspNumber = GetProcessorIndex (CpuFeaturesData);
>    CpuFeaturesData->BspNumber = OldBspNumber;
> 
> +  //
> +  //
> +  // Initialize MpEvent to suppress incorrect compiler/analyzer warnings.
> +  //
> +  MpEvent = NULL;
> +
>    if (CpuFeaturesData->NumberOfCpus > 1) {
>      Status = gBS->CreateEvent (
>                      EVT_NOTIFY_WAIT,
> --
> 2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43838): https://edk2.groups.io/g/devel/message/43838
Mute This Topic: https://groups.io/mt/32499927/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-