UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls gBS service.

[edk2-devel] [Patch 0/2] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls gBS service.

Posted by Dong, Eric 4 years, 9 months ago

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1972

AP calls CollectProcessorData() to collect processor info.
CollectProcessorData function finally calls PcdGetSize function to
get DynamicPCD PcdCpuFeaturesSetting value. PcdGetSize will use gBS
which caused ASSERT. 
This patch serial fixes the issue and enhances the related code to avoid
later report this issue again.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Chandana Kumar <chandana.c.kumar@intel.com>
Cc: Star Zeng <star.zeng@intel.com>

Eric Dong (2):
  UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls gBS service.
  UefiCpuPkg/Library/RegisterCpuFeaturesLib: avoid use dynamic PCD.

 .../CpuFeaturesInitialize.c                   |  77 ++++++-------
 .../RegisterCpuFeatures.h                     |  10 +-
 .../RegisterCpuFeaturesLib.c                  | 109 +++++++-----------
 3 files changed, 85 insertions(+), 111 deletions(-)

-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43621): https://edk2.groups.io/g/devel/message/43621
Mute This Topic: https://groups.io/mt/32437606/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch 0/2] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls gBS service.

Posted by Laszlo Ersek 4 years, 9 months ago

On 07/12/19 03:53, Eric Dong wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1972
> 
> AP calls CollectProcessorData() to collect processor info.
> CollectProcessorData function finally calls PcdGetSize function to
> get DynamicPCD PcdCpuFeaturesSetting value. PcdGetSize will use gBS
> which caused ASSERT. 
> This patch serial fixes the issue and enhances the related code to avoid
> later report this issue again.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Chandana Kumar <chandana.c.kumar@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> 
> Eric Dong (2):
>   UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls gBS service.
>   UefiCpuPkg/Library/RegisterCpuFeaturesLib: avoid use dynamic PCD.
> 
>  .../CpuFeaturesInitialize.c                   |  77 ++++++-------
>  .../RegisterCpuFeatures.h                     |  10 +-
>  .../RegisterCpuFeaturesLib.c                  | 109 +++++++-----------
>  3 files changed, 85 insertions(+), 111 deletions(-)
> 

Will have to skip this one too.

Thanks
Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43674): https://edk2.groups.io/g/devel/message/43674
Mute This Topic: https://groups.io/mt/32437606/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-