Readme.md: Change way of cloning edk2 repo

[edk2-devel] [edk2-platforms: PATCH] Readme.md: Change way of cloning edk2 repo

Posted by Wang, Jian J 4 years, 9 months ago

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1910

'--recursive' in cloning edk2 repo might cause failure on machine
behind proxy. It's not actually necessary for edk2. This patch removed
it from git command. A separate command

   $ git submodule update --init

is added to retrieve repo specified via submodule.

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
 Readme.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Readme.md b/Readme.md
index e203795d47..63e59f60b4 100644
--- a/Readme.md
+++ b/Readme.md
@@ -83,7 +83,8 @@ target-specific binutils. These are included with any prepackaged GCC toolchain
    1. [edk2-non-osi](https://github.com/tianocore/edk2-non-osi) (if building
       platforms that need it)
    ```
-   $ git clone https://github.com/tianocore/edk2.git --recursive
+   $ git clone https://github.com/tianocore/edk2.git
+   $ git submodule update --init
    ...
    $ git clone https://github.com/tianocore/edk2-platforms.git
    ...
-- 
2.17.1.windows.2


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43425): https://edk2.groups.io/g/devel/message/43425
Mute This Topic: https://groups.io/mt/32403141/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms: PATCH] Readme.md: Change way of cloning edk2 repo

Posted by Leif Lindholm 4 years, 9 months ago

On Tue, Jul 09, 2019 at 03:21:42PM +0800, Jian J Wang wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1910
> 
> '--recursive' in cloning edk2 repo might cause failure on machine
> behind proxy. It's not actually necessary for edk2. This patch removed
> it from git command. A separate command
> 
>    $ git submodule update --init
> 
> is added to retrieve repo specified via submodule.
> 
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Jian J Wang <jian.j.wang@intel.com>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Can you push it yourself, or would you like me to do it?

> ---
>  Readme.md | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Readme.md b/Readme.md
> index e203795d47..63e59f60b4 100644
> --- a/Readme.md
> +++ b/Readme.md
> @@ -83,7 +83,8 @@ target-specific binutils. These are included with any prepackaged GCC toolchain
>     1. [edk2-non-osi](https://github.com/tianocore/edk2-non-osi) (if building
>        platforms that need it)
>     ```
> -   $ git clone https://github.com/tianocore/edk2.git --recursive
> +   $ git clone https://github.com/tianocore/edk2.git
> +   $ git submodule update --init
>     ...
>     $ git clone https://github.com/tianocore/edk2-platforms.git
>     ...
> -- 
> 2.17.1.windows.2
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43434): https://edk2.groups.io/g/devel/message/43434
Mute This Topic: https://groups.io/mt/32403141/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms: PATCH] Readme.md: Change way of cloning edk2 repo

Posted by Wang, Jian J 4 years, 9 months ago

Leif,

I'll try push first (not sure I have write access right). If I can't, please do it
for me.

Regards,
Jian


> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Leif Lindholm
> Sent: Tuesday, July 09, 2019 5:28 PM
> To: Wang, Jian J <jian.j.wang@intel.com>
> Cc: devel@edk2.groups.io; Ard Biesheuvel <ard.biesheuvel@linaro.org>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms: PATCH] Readme.md: Change way
> of cloning edk2 repo
> 
> On Tue, Jul 09, 2019 at 03:21:42PM +0800, Jian J Wang wrote:
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1910
> >
> > '--recursive' in cloning edk2 repo might cause failure on machine
> > behind proxy. It's not actually necessary for edk2. This patch removed
> > it from git command. A separate command
> >
> >    $ git submodule update --init
> >
> > is added to retrieve repo specified via submodule.
> >
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> 
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> 
> Can you push it yourself, or would you like me to do it?
> 
> > ---
> >  Readme.md | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Readme.md b/Readme.md
> > index e203795d47..63e59f60b4 100644
> > --- a/Readme.md
> > +++ b/Readme.md
> > @@ -83,7 +83,8 @@ target-specific binutils. These are included with any
> prepackaged GCC toolchain
> >     1. [edk2-non-osi](https://github.com/tianocore/edk2-non-osi) (if
> building
> >        platforms that need it)
> >     ```
> > -   $ git clone https://github.com/tianocore/edk2.git --recursive
> > +   $ git clone https://github.com/tianocore/edk2.git
> > +   $ git submodule update --init
> >     ...
> >     $ git clone https://github.com/tianocore/edk2-platforms.git
> >     ...
> > --
> > 2.17.1.windows.2
> >
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43437): https://edk2.groups.io/g/devel/message/43437
Mute This Topic: https://groups.io/mt/32403141/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-