[edk2-devel] [PATCH 2/2] CryptoPkg/OpensslLib: remove clone commands

Wang, Jian J posted 2 patches 6 years, 7 months ago
There is a newer version of this series
[edk2-devel] [PATCH 2/2] CryptoPkg/OpensslLib: remove clone commands
Posted by Wang, Jian J 6 years, 7 months ago
https://bugzilla.tianocore.org/show_bug.cgi?id=1910

edk2/Readme.md has added a section to explain the correct clone
commands for submodules. Detailed steps in the OpenSSL-HOWTO.txt
are removed to avoid any inconsistency.

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
 CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt | 18 ++----------------
 1 file changed, 2 insertions(+), 16 deletions(-)

diff --git a/CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt b/CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt
index db45eb88d1..e52ee27b49 100644
--- a/CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt
+++ b/CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt
@@ -24,22 +24,8 @@ on the cryptography.
 =============================================================================
                       HOW to Install OpenSSL for UEFI Building
 =============================================================================
-  OpenSSL repository was added as one submodule of EDKII project.
-
-  The user can use the following commands to clone both main EDKII repo and
-openssl submodule:
-  1) Add the "--recursive" flag to the git clone command:
-     $ git clone --recursive https://github.com/tianocore/edk2
-or
-  2) Manually initialize and update the submodules after the clone operation
-     on main project:
-     $ git clone https://github.com/tianocore/edk2
-     $ git submodule update --init --recursive
-
-  And use the following combined commands to pull the remote submodule updates
-(e.g. Updating the new supported OpenSSL release tag):
-     $ git pull --recurse-submodules && \
-       git submodule update --recursive
+  OpenSSL repository was added as one submodule of EDKII project. Please
+refer to edk2/Readme.md for how to clone the code.
 
 =============================================================================
                       About process_files.pl
-- 
2.17.1.windows.2


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43424): https://edk2.groups.io/g/devel/message/43424
Mute This Topic: https://groups.io/mt/32402920/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 2/2] CryptoPkg/OpensslLib: remove clone commands
Posted by Leif Lindholm 6 years, 7 months ago
On Tue, Jul 09, 2019 at 02:36:01PM +0800, Jian J Wang wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1910
> 
> edk2/Readme.md has added a section to explain the correct clone
> commands for submodules. Detailed steps in the OpenSSL-HOWTO.txt
> are removed to avoid any inconsistency.
> 
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Jian J Wang <jian.j.wang@intel.com>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---
>  CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt | 18 ++----------------
>  1 file changed, 2 insertions(+), 16 deletions(-)
> 
> diff --git a/CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt b/CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt
> index db45eb88d1..e52ee27b49 100644
> --- a/CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt
> +++ b/CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt
> @@ -24,22 +24,8 @@ on the cryptography.
>  =============================================================================
>                        HOW to Install OpenSSL for UEFI Building
>  =============================================================================
> -  OpenSSL repository was added as one submodule of EDKII project.
> -
> -  The user can use the following commands to clone both main EDKII repo and
> -openssl submodule:
> -  1) Add the "--recursive" flag to the git clone command:
> -     $ git clone --recursive https://github.com/tianocore/edk2
> -or
> -  2) Manually initialize and update the submodules after the clone operation
> -     on main project:
> -     $ git clone https://github.com/tianocore/edk2
> -     $ git submodule update --init --recursive
> -
> -  And use the following combined commands to pull the remote submodule updates
> -(e.g. Updating the new supported OpenSSL release tag):
> -     $ git pull --recurse-submodules && \
> -       git submodule update --recursive
> +  OpenSSL repository was added as one submodule of EDKII project. Please
> +refer to edk2/Readme.md for how to clone the code.
>  
>  =============================================================================
>                        About process_files.pl
> -- 
> 2.17.1.windows.2
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43433): https://edk2.groups.io/g/devel/message/43433
Mute This Topic: https://groups.io/mt/32402920/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-