On Thu, Jul 04, 2019 at 05:51:18PM +0100, Pete Batard wrote:
> v2 to:
> - Break a long line PlatformBm.c.
> - Use a BOOLEAN for the SkipTurbo parameter.
> - Keep already defined gRaspberryPiTokenSpaceGuid.### values as they are.
>
> Note that, as opposed to what was discussed, EFI_VARIABLE_RUNTIME_ACCESS was
> not removed because doing so effectively prevents the custom value to be
> applied in the firmware menu. Without EFI_VARIABLE_RUNTIME_ACCESS you will get
> the following notice when trying to save your changes:
>
> Submit Fail For Form: Chipset Configuration.
> Press D(d) to discard changes for this form, Press G(g) to go to this form
>
> So I guess EFI_VARIABLE_RUNTIME_ACCESS applies to more than OS access.
As I told Pete offline, I wanted to dig into why the RUNTIME_ACCESS
was required, but haven't found the time. And the patches have been
waiting long enough.
For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as e80b3f804cae..3542dfdecab1.
Thanks!
/
> Regards,
>
> /Pete
>
> Pete Batard (2):
> Platform/RPi3: Set the boot option of UEFI Shell as non-active
> Platform/Rpi3: Add custom CPU frequency support
>
> Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.c | 13 +++++++++++-
> Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.inf | 1 +
> Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxeHii.uni | 4 ++++
> Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxeHii.vfr | 22 ++++++++++++++++++++
> Platform/RaspberryPi/RPi3/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 6 ++++--
> Platform/RaspberryPi/RPi3/Include/Protocol/RpiFirmware.h | 3 ++-
> Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBm.c | 3 ++-
> Platform/RaspberryPi/RPi3/RPi3.dec | 1 +
> Platform/RaspberryPi/RPi3/RPi3.dsc | 1 +
> Platform/RaspberryPi/RPi3/Readme.md | 6 +++---
> 10 files changed, 52 insertions(+), 8 deletions(-)
>
> --
> 2.21.0.windows.1
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#44037): https://edk2.groups.io/g/devel/message/44037
Mute This Topic: https://groups.io/mt/32309760/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-