The following changes remove all dependencies on the IntelFrameworkPkg and 
IntelFrameworkModulePkg from the Vlv2TbltDevicePkg platform builds.  These 
changes do depend on updates binaries on the edk2-non-osi repository.

* Vlv2DeviceRefCodePkg: Add gEfiSmmIchnDispatchProtocolGuid
* Vlv2TbltDevicePkg: Reduce Intel Framework dependencies
* Vlv2TbltDevicePkg: Remove unused modules/libraries
* Vlv2TbltDevicePkg: Switch from ISA to SIO modules
* Vlv2TbltDevicePkg: Switch to CPU I/O 2 Protocol
* Vlv2TbltDevicePkg: Remove use of PS/2 Policy Protocol
* Vlv2TbltDevicePkg: Remove use of BIOS ID tools
* Vlv2TbltDevicePkg: Remove use of Data Hub Protocol
* Vlv2TbltDevicePkg: Use PI Spec SMBUS2 PPI
* Vlv2TbltDevicePkg: Switch to MdeModulePkg BdsDxe
* Vlv2TbltDevicePkg: Update boot mode/state behaviors
* Vlv2TbltDevicePkg/PlatformSmm: Switch to PI SMM Protocols
* Vlv2TbltDevicePkg: Change to PI Spec ACPI Table Protocol

Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>

Michael D Kinney (14):
  Vlv2DeviceRefCodePkg: Add gEfiSmmIchnDispatchProtocolGuid
  Vlv2TbltDevicePkg: Reduce Intel Framework dependencies
  Vlv2TbltDevicePkg: Remove unused modules/libraries
  Vlv2TbltDevicePkg: Switch from ISA to SIO modules
  Vlv2TbltDevicePkg: Switch to CPU I/O 2 Protocol
  Vlv2TbltDevicePkg: Remove use of PS/2 Policy Protocol
  Vlv2TbltDevicePkg: Remove use of BIOS ID tools
  Vlv2TbltDevicePkg: Remove use of Data Hub Protocol
  Vlv2TbltDevicePkg: Use PI Spec SMBUS2 PPI
  Vlv2TbltDevicePkg: Switch to MdeModulePkg BdsDxe
  Vlv2TbltDevicePkg: Update boot mode/state behaviors
  Vlv2TbltDevicePkg/PlatformSmm: Switch to PI SMM Protocols
  Vlv2TbltDevicePkg: Change to PI Spec ACPI Table Protocol
  Vlv2TbltDevicePkg/PlatformInitPei: Update MemoryTypeInformation

 .../AcpiPlatform/AcpiPlatform.c               |  137 +-
 .../AcpiPlatform/AcpiPlatform.h               |   11 +-
 .../AcpiPlatform/AcpiPlatform.inf             |   14 +-
 Platform/Intel/Vlv2TbltDevicePkg/BiosIdD.env  |   25 -
 Platform/Intel/Vlv2TbltDevicePkg/BiosIdR.env  |   25 -
 .../Intel/Vlv2TbltDevicePkg/BiosIdx64D.env    |   25 -
 .../Intel/Vlv2TbltDevicePkg/BiosIdx64R.env    |   25 -
 .../BootScriptSaveDxe/BootScriptSaveDxe.inf   |   60 -
 .../InternalBootScriptSave.h                  |  102 -
 .../BootScriptSaveDxe/ScriptSave.c            |  626 ---
 .../Intel/Vlv2TbltDevicePkg/Build_IFWI.bat    |   33 -
 .../Library/FmpDeviceLib/FmpDeviceLib.c       |   12 +-
 .../FspAzaliaConfigData/AzaliaConfig.bin      |  Bin 3708 -> 0 bytes
 .../FspSupport/BootModePei/BootModePei.c      |   42 -
 .../FspSupport/BootModePei/BootModePei.inf    |   40 -
 .../FspHobProcessLibVlv2.c                    |  421 --
 .../FspHobProcessLibVlv2.inf                  |   74 -
 .../FspPlatformSecLibVlv2.c                   |  144 -
 .../FspPlatformSecLibVlv2.inf                 |   82 -
 .../Ia32/AsmSaveSecContext.asm                |   45 -
 .../SecFspPlatformSecLibVlv2/Ia32/Fsp.inc     |   45 -
 .../Ia32/PeiCoreEntry.asm                     |  135 -
 .../Ia32/SecEntry.asm                         |  338 --
 .../SecFspPlatformSecLibVlv2/Ia32/Stack.S     |   71 -
 .../SecFspPlatformSecLibVlv2/Ia32/Stack.asm   |   76 -
 .../SecFspPlatformSecLibVlv2/PlatformInit.c   |   36 -
 .../SecFspPlatformSecLibVlv2/SaveSecContext.c |  108 -
 .../SecGetPerformance.c                       |   83 -
 .../SecPlatformInformation.c                  |   77 -
 .../SecFspPlatformSecLibVlv2/SecRamInitData.c |   16 -
 .../SecTempRamSupport.c                       |  149 -
 .../SecFspPlatformSecLibVlv2/UartInit.c       |  192 -
 Platform/Intel/Vlv2TbltDevicePkg/GenBiosId    |  Bin 12236 -> 0 bytes
 .../Intel/Vlv2TbltDevicePkg/GenBiosId.exe     |  Bin 384000 -> 0 bytes
 .../Vlv2TbltDevicePkg/Include/Guid/BiosId.h   |   30 -
 .../Vlv2TbltDevicePkg/Include/Guid/IdccData.h |  104 -
 .../Vlv2TbltDevicePkg/Include/Guid/ItkData.h  |   18 +-
 .../Include/Guid/PlatformInfo.h               |    9 +-
 .../Include/Library/BiosIdLib.h               |   22 +-
 .../Include/Library/EfiRegTableLib.h          |   51 +-
 .../Include/Protocol/LpcWpc83627Policy.h      |   92 -
 .../Include/Protocol/LpcWpce791Policy.h       |   55 -
 .../Include/Protocol/TpmMp.h                  |  136 -
 .../Include/Protocol/UsbPolicy.h              |  126 -
 .../Library/BiosIdLib/BiosIdLib.c             |  279 +-
 .../Library/BiosIdLib/BiosIdLib.inf           |   21 +-
 .../DxePlatformBootManagerLib/BdsPlatform.c   | 1434 ++++++
 .../DxePlatformBootManagerLib/BdsPlatform.h   |  253 +
 .../DxePlatformBootManagerLib.inf             |   97 +
 .../DxePlatformBootManagerLib/MemoryTest.c    |   83 +
 .../PlatformBootOption.c                      |  559 ++
 .../Library/EfiRegTableLib/EfiRegTableLib.c   |   57 +-
 .../Library/EfiRegTableLib/EfiRegTableLib.inf |   12 +-
 .../Vlv2TbltDevicePkg/Library/I2CLib/I2CLib.c |   46 -
 .../Library/I2CLib/I2CLibNull.inf             |   39 -
 .../Library/I2CLibDxe/I2CLib.c                |  735 ---
 .../Library/I2CLibDxe/I2CLibDxe.inf           |   39 -
 .../Library/I2CLibDxe/I2CRegs.h               |  126 -
 .../Library/I2CLibPei/I2CAccess.h             |   44 -
 .../Library/I2CLibPei/I2CDelayPei.c           |   46 -
 .../Library/I2CLibPei/I2CDelayPei.h           |   30 -
 .../Library/I2CLibPei/I2CIoLibPei.c           |  178 -
 .../Library/I2CLibPei/I2CIoLibPei.h           |  153 -
 .../Library/I2CLibPei/I2CLibPei.c             |  638 ---
 .../Library/I2CLibPei/I2CLibPei.h             |  280 -
 .../Library/I2CLibPei/I2CLibPei.inf           |   40 -
 .../BoardClkGens/BoardClkGens.c               |   23 +-
 .../BoardClkGens/BoardClkGens.h               |    8 +-
 .../MultiPlatformLib/BoardGpios/BoardGpios.c  |   12 +-
 .../MultiPlatformLib/BoardGpios/BoardGpios.h  |    7 +-
 .../MultiPlatformLib/MultiPlatformLib.h       |   11 +-
 .../MultiPlatformLib/MultiPlatformLib.inf     |   11 +-
 .../Library/PlatformBdsLib/BdsPlatform.c      | 3098 ------------
 .../Library/PlatformBdsLib/BdsPlatform.h      |  516 --
 .../Library/PlatformBdsLib/PlatformBdsLib.inf |  128 -
 .../PlatformBdsLib/PlatformBdsStrings.uni     |   30 -
 .../Library/PlatformBdsLib/PlatformData.c     |  306 --
 .../Library/PlatformFspLib/PlatformFspLib.c   |   44 -
 .../Library/PlatformFspLib/PlatformFspLib.inf |   49 -
 .../SerialPortLib/PlatformSerialPortLib.h     |   53 -
 .../Library/SerialPortLib/SerialPortLib.c     |  246 -
 .../Library/SerialPortLib/SerialPortLib.inf   |   52 -
 .../Library/SerialPortLib/SioInit.c           |  127 -
 .../Library/SerialPortLib/SioInit.h           |   62 -
 .../Library/SmbusLib/CommonHeader.h           |   26 -
 .../Library/SmbusLib/SmbusLib.c               |  873 ----
 .../Library/SmbusLib/SmbusLib.inf             |   46 -
 .../Metronome/LegacyMetronome.c               |  185 -
 .../Metronome/LegacyMetronome.h               |   64 -
 .../Vlv2TbltDevicePkg/Metronome/Metronome.inf |   49 -
 .../MonoStatusCode/MonoStatusCode.h           |   47 +-
 .../MonoStatusCode/MonoStatusCode.inf         |    9 +-
 .../Library/GenericBdsLib/BdsBoot.c           | 4490 -----------------
 .../Library/GenericBdsLib/BdsConnect.c        |  429 --
 .../Library/GenericBdsLib/BdsConsole.c        | 1061 ----
 .../Library/GenericBdsLib/BdsMisc.c           | 1575 ------
 .../Library/GenericBdsLib/DevicePath.c        |   27 -
 .../Library/GenericBdsLib/GenericBdsLib.inf   |  143 -
 .../Library/GenericBdsLib/GenericBdsLib.uni   |   19 -
 .../GenericBdsLib/GenericBdsStrings.uni       |   30 -
 .../Library/GenericBdsLib/InternalBdsLib.h    |  173 -
 .../Library/GenericBdsLib/String.c            |   26 -
 .../Library/GenericBdsLib/String.h            |   42 -
 .../PciPlatform/PciPlatform.c                 |    7 +-
 .../PciPlatform/PciPlatform.inf               |    9 +-
 .../Intel/Vlv2TbltDevicePkg/PcuSio/PcuSio.c   |  951 ++++
 .../Intel/Vlv2TbltDevicePkg/PcuSio/PcuSio.h   |  363 ++
 .../Intel/Vlv2TbltDevicePkg/PcuSio/PcuSio.inf |   38 +
 .../PlatformCpuInfoDxe/PlatformCpuInfoDxe.c   |    8 +-
 .../PlatformCpuInfoDxe/PlatformCpuInfoDxe.h   |   17 +-
 .../PlatformCpuInfoDxe/PlatformCpuInfoDxe.inf |    8 +-
 .../Vlv2TbltDevicePkg/PlatformDxe/BoardId.c   |   45 +-
 .../PlatformDxe/ClockControl.c                |   80 +-
 .../PlatformDxe/Configuration.h               |    8 +-
 .../PlatformDxe/IchRegTable.c                 |    8 +-
 .../Vlv2TbltDevicePkg/PlatformDxe/IdccInfo.c  |   72 -
 .../Vlv2TbltDevicePkg/PlatformDxe/Platform.c  |  533 +-
 .../PlatformDxe/PlatformDxe.h                 |  521 +-
 .../PlatformDxe/PlatformDxe.inf               |   28 +-
 .../PlatformDxe/SioPlatformPolicy.c           |   82 -
 .../PlatformGopPolicy/PlatformGopPolicy.inf   |   15 +-
 .../Vlv2TbltDevicePkg/PlatformInitPei/Dimm.c  |  319 --
 .../PlatformInitPei/MemoryCallback.c          |    8 +-
 .../PlatformInitPei/MemoryPeim.c              |   21 +-
 .../PlatformInitPei/PchInitPeim.c             |   10 +-
 .../PlatformInitPei/PlatformEarlyInit.c       |  209 +-
 .../PlatformInitPei/PlatformEarlyInit.h       |   31 +-
 .../PlatformInitPei/PlatformInitPei.inf       |   29 +-
 .../Vlv2TbltDevicePkg/PlatformPei/BootMode.c  |   99 +-
 .../PlatformPei/CommonHeader.h                |   12 +-
 .../PlatformPei/MemoryCallback.c              |    8 +-
 .../Vlv2TbltDevicePkg/PlatformPei/Platform.c  |   24 +-
 .../Vlv2TbltDevicePkg/PlatformPei/Platform.h  |   27 +-
 .../PlatformPei/PlatformPei.inf               |   12 +-
 .../Intel/Vlv2TbltDevicePkg/PlatformPkg.dec   |   28 +-
 .../Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf   |  286 +-
 .../Vlv2TbltDevicePkg/PlatformPkgConfig.dsc   |   22 +-
 .../Vlv2TbltDevicePkg/PlatformPkgGcc.fdf      |  299 +-
 .../Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc   |  561 +-
 .../Vlv2TbltDevicePkg/PlatformPkgIA32.dsc     |  562 +--
 .../Vlv2TbltDevicePkg/PlatformPkgX64.dsc      |  563 +--
 .../PlatformSetupDxe/PlatformSetupDxe.h       |   30 +-
 .../PlatformSetupDxe/PlatformSetupDxe.inf     |   17 +-
 .../PlatformSetupDxe/SetupFunctions.c         |   38 +-
 .../PlatformSetupDxe/SetupInfoRecords.c       |  572 +--
 .../Vlv2TbltDevicePkg/PlatformSmm/Platform.c  |  196 +-
 .../PlatformSmm/PlatformSmm.inf               |   34 +-
 .../Vlv2TbltDevicePkg/PlatformSmm/S3Save.c    |   53 +-
 .../PlatformSmm/SmmPlatform.h                 |  111 +-
 .../PlatformSmm/SmmScriptSave.c               |  252 -
 .../PlatformSmm/SmmScriptSave.h               |   50 -
 .../Vlv2TbltDevicePkg/PpmPolicy/PpmPolicy.inf |    6 +-
 .../SmBiosMiscDxe/CommonHeader.h              |   10 +-
 .../SmBiosMiscDxe/DataHubRecords.h            | 2934 +++++++++++
 .../MiscBaseBoardManufacturerFunction.c       |    8 +-
 .../SmBiosMiscDxe/MiscBiosVendorFunction.c    |    9 +-
 .../SmBiosMiscDxe/MiscMemoryDeviceFunction.c  |  318 +-
 .../SmBiosMiscDxe/MiscOemType0x94Function.c   |   45 +-
 .../SmBiosMiscDxe/MiscProcessorCacheData.c    |   11 +-
 .../MiscProcessorCacheFunction.c              |  273 +-
 .../MiscProcessorInformationFunction.c        |  203 +-
 .../MiscSubclassDriverDataTable.c             |   14 +-
 .../MiscSubclassDriverEntryPoint.c            |   13 +-
 .../MiscSystemManufacturerFunction.c          |   10 +-
 .../SmBiosMiscDxe/SmBiosMiscDxe.inf           |   18 +-
 .../SmmSwDispatch2OnSmmSwDispatchThunk.c      |  459 --
 .../SmmSwDispatch2OnSmmSwDispatchThunk.inf    |   54 -
 .../SmramSaveInfoHandlerSmm.c                 |  164 -
 .../SmramSaveInfoHandlerSmm.inf               |   60 -
 .../Stitch/IFWIHeader/Vacant.bin              |  Bin 3928064 -> 0 bytes
 .../Vlv2TbltDevicePkg/Stitch/IFWIStitch.bat   |  270 -
 .../Stitch/MNW2_Stitch_Config.txt             |   10 -
 .../Intel/Vlv2TbltDevicePkg/UiApp/FrontPage.c |   33 -
 .../Intel/Vlv2TbltDevicePkg/UiApp/UiApp.inf   |   32 -
 .../VlvPlatformInitDxe/IgdOpRegion.c          |   20 +-
 .../VlvPlatformInitDxe/IgdOpRegion.h          |   27 +-
 .../VlvPlatformInitDxe/VlvPlatformInitDxe.inf |   14 +-
 .../Vlv2TbltDevicePkg/Wpce791/LpcDriver.c     |  340 --
 .../Vlv2TbltDevicePkg/Wpce791/LpcDriver.h     |  112 -
 .../Vlv2TbltDevicePkg/Wpce791/LpcIsaAcpi.c    |  366 --
 .../Vlv2TbltDevicePkg/Wpce791/LpcIsaAcpi.h    |  103 -
 .../Intel/Vlv2TbltDevicePkg/Wpce791/LpcSio.c  |  126 -
 .../Intel/Vlv2TbltDevicePkg/Wpce791/LpcSio.h  |  101 -
 .../Vlv2TbltDevicePkg/Wpce791/Wpce791.inf     |   63 -
 Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.bat  |   47 +-
 Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh   |   52 +-
 .../Include/Protocol/SmmIchnDispatch.h        |  183 +
 .../Vlv2DeviceRefCodePkg.dec                  |    5 +-
 188 files changed, 8321 insertions(+), 28666 deletions(-)
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/BiosIdD.env
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/BiosIdR.env
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/BiosIdx64D.env
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/BiosIdx64R.env
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/BootScriptSaveDxe/BootScriptSaveDxe.inf
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/BootScriptSaveDxe/InternalBootScriptSave.h
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/BootScriptSaveDxe/ScriptSave.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspAzaliaConfigData/AzaliaConfig.bin
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/BootModePei/BootModePei.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/BootModePei/BootModePei.inf
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/PeiFspHobProcessLibVlv2/FspHobProcessLibVlv2.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/PeiFspHobProcessLibVlv2/FspHobProcessLibVlv2.inf
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/FspPlatformSecLibVlv2.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/FspPlatformSecLibVlv2.inf
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/Ia32/AsmSaveSecContext.asm
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/Ia32/Fsp.inc
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/Ia32/PeiCoreEntry.asm
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/Ia32/SecEntry.asm
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/Ia32/Stack.S
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/Ia32/Stack.asm
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/PlatformInit.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/SaveSecContext.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/SecGetPerformance.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/SecPlatformInformation.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/SecRamInitData.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/SecTempRamSupport.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/UartInit.c
 delete mode 100755 Platform/Intel/Vlv2TbltDevicePkg/GenBiosId
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/GenBiosId.exe
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Include/Guid/BiosId.h
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Include/Guid/IdccData.h
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Include/Protocol/LpcWpc83627Policy.h
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Include/Protocol/LpcWpce791Policy.h
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Include/Protocol/TpmMp.h
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Include/Protocol/UsbPolicy.h
 create mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/BdsPlatform.c
 create mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/BdsPlatform.h
 create mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/DxePlatformBootManagerLib.inf
 create mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/MemoryTest.c
 create mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/PlatformBootOption.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLib/I2CLib.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLib/I2CLibNull.inf
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibDxe/I2CLib.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibDxe/I2CLibDxe.inf
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibDxe/I2CRegs.h
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CAccess.h
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CDelayPei.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CDelayPei.h
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CIoLibPei.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CIoLibPei.h
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CLibPei.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CLibPei.h
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CLibPei.inf
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.h
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsStrings.uni
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformData.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformFspLib/PlatformFspLib.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformFspLib/PlatformFspLib.inf
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/SerialPortLib/PlatformSerialPortLib.h
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/SerialPortLib/SerialPortLib.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/SerialPortLib/SerialPortLib.inf
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/SerialPortLib/SioInit.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/SerialPortLib/SioInit.h
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/SmbusLib/CommonHeader.h
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/SmbusLib/SmbusLib.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/SmbusLib/SmbusLib.inf
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Metronome/LegacyMetronome.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Metronome/LegacyMetronome.h
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Metronome/Metronome.inf
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/BdsBoot.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/BdsConnect.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/BdsConsole.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/BdsMisc.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/DevicePath.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.uni
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsStrings.uni
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/InternalBdsLib.h
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/String.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/String.h
 create mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PcuSio/PcuSio.c
 create mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PcuSio/PcuSio.h
 create mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PcuSio/PcuSio.inf
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformDxe/IdccInfo.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformDxe/SioPlatformPolicy.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformInitPei/Dimm.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformSmm/SmmScriptSave.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformSmm/SmmScriptSave.h
 create mode 100644 Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRecords.h
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/SmmSwDispatch2OnSmmSwDispatchThunk/SmmSwDispatch2OnSmmSwDispatchThunk.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/SmmSwDispatch2OnSmmSwDispatchThunk/SmmSwDispatch2OnSmmSwDispatchThunk.inf
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/SmramSaveInfoHandlerSmm/SmramSaveInfoHandlerSmm.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/SmramSaveInfoHandlerSmm/SmramSaveInfoHandlerSmm.inf
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Stitch/IFWIHeader/Vacant.bin
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Stitch/IFWIStitch.bat
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Stitch/MNW2_Stitch_Config.txt
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/UiApp/FrontPage.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/UiApp/UiApp.inf
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Wpce791/LpcDriver.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Wpce791/LpcDriver.h
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Wpce791/LpcIsaAcpi.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Wpce791/LpcIsaAcpi.h
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Wpce791/LpcSio.c
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Wpce791/LpcSio.h
 delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Wpce791/Wpce791.inf
 create mode 100644 Silicon/Intel/Vlv2DeviceRefCodePkg/Include/Protocol/SmmIchnDispatch.h

-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43060): https://edk2.groups.io/g/devel/message/43060
Mute This Topic: https://groups.io/mt/32267616/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

On Sun, Jun 30, 2019 at 07:55:39PM -0700,  Michael D Kinney  wrote:
> The following changes remove all dependencies on the IntelFrameworkPkg and 
> IntelFrameworkModulePkg from the Vlv2TbltDevicePkg platform builds.  These 
> changes do depend on updates binaries on the edk2-non-osi repository.
> 
Hi Michael,

I am amending the bash scripts for gcc. The firmware I built is using the
binaries from Development190216 and could boot into Linux successfully with
some workarounds for Wpce791, Bds, and InteFspWrapper. The patches you posted
eliminate those parts I have to work around. 

Just want to know if you need any assistance for the gcc build? I could
rebase my work upon your patches and send them later.

Thanks,

Gary Lin

> * Vlv2DeviceRefCodePkg: Add gEfiSmmIchnDispatchProtocolGuid
> * Vlv2TbltDevicePkg: Reduce Intel Framework dependencies
> * Vlv2TbltDevicePkg: Remove unused modules/libraries
> * Vlv2TbltDevicePkg: Switch from ISA to SIO modules
> * Vlv2TbltDevicePkg: Switch to CPU I/O 2 Protocol
> * Vlv2TbltDevicePkg: Remove use of PS/2 Policy Protocol
> * Vlv2TbltDevicePkg: Remove use of BIOS ID tools
> * Vlv2TbltDevicePkg: Remove use of Data Hub Protocol
> * Vlv2TbltDevicePkg: Use PI Spec SMBUS2 PPI
> * Vlv2TbltDevicePkg: Switch to MdeModulePkg BdsDxe
> * Vlv2TbltDevicePkg: Update boot mode/state behaviors
> * Vlv2TbltDevicePkg/PlatformSmm: Switch to PI SMM Protocols
> * Vlv2TbltDevicePkg: Change to PI Spec ACPI Table Protocol
> 
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Michael D Kinney (14):
>   Vlv2DeviceRefCodePkg: Add gEfiSmmIchnDispatchProtocolGuid
>   Vlv2TbltDevicePkg: Reduce Intel Framework dependencies
>   Vlv2TbltDevicePkg: Remove unused modules/libraries
>   Vlv2TbltDevicePkg: Switch from ISA to SIO modules
>   Vlv2TbltDevicePkg: Switch to CPU I/O 2 Protocol
>   Vlv2TbltDevicePkg: Remove use of PS/2 Policy Protocol
>   Vlv2TbltDevicePkg: Remove use of BIOS ID tools
>   Vlv2TbltDevicePkg: Remove use of Data Hub Protocol
>   Vlv2TbltDevicePkg: Use PI Spec SMBUS2 PPI
>   Vlv2TbltDevicePkg: Switch to MdeModulePkg BdsDxe
>   Vlv2TbltDevicePkg: Update boot mode/state behaviors
>   Vlv2TbltDevicePkg/PlatformSmm: Switch to PI SMM Protocols
>   Vlv2TbltDevicePkg: Change to PI Spec ACPI Table Protocol
>   Vlv2TbltDevicePkg/PlatformInitPei: Update MemoryTypeInformation
> 
>  .../AcpiPlatform/AcpiPlatform.c               |  137 +-
>  .../AcpiPlatform/AcpiPlatform.h               |   11 +-
>  .../AcpiPlatform/AcpiPlatform.inf             |   14 +-
>  Platform/Intel/Vlv2TbltDevicePkg/BiosIdD.env  |   25 -
>  Platform/Intel/Vlv2TbltDevicePkg/BiosIdR.env  |   25 -
>  .../Intel/Vlv2TbltDevicePkg/BiosIdx64D.env    |   25 -
>  .../Intel/Vlv2TbltDevicePkg/BiosIdx64R.env    |   25 -
>  .../BootScriptSaveDxe/BootScriptSaveDxe.inf   |   60 -
>  .../InternalBootScriptSave.h                  |  102 -
>  .../BootScriptSaveDxe/ScriptSave.c            |  626 ---
>  .../Intel/Vlv2TbltDevicePkg/Build_IFWI.bat    |   33 -
>  .../Library/FmpDeviceLib/FmpDeviceLib.c       |   12 +-
>  .../FspAzaliaConfigData/AzaliaConfig.bin      |  Bin 3708 -> 0 bytes
>  .../FspSupport/BootModePei/BootModePei.c      |   42 -
>  .../FspSupport/BootModePei/BootModePei.inf    |   40 -
>  .../FspHobProcessLibVlv2.c                    |  421 --
>  .../FspHobProcessLibVlv2.inf                  |   74 -
>  .../FspPlatformSecLibVlv2.c                   |  144 -
>  .../FspPlatformSecLibVlv2.inf                 |   82 -
>  .../Ia32/AsmSaveSecContext.asm                |   45 -
>  .../SecFspPlatformSecLibVlv2/Ia32/Fsp.inc     |   45 -
>  .../Ia32/PeiCoreEntry.asm                     |  135 -
>  .../Ia32/SecEntry.asm                         |  338 --
>  .../SecFspPlatformSecLibVlv2/Ia32/Stack.S     |   71 -
>  .../SecFspPlatformSecLibVlv2/Ia32/Stack.asm   |   76 -
>  .../SecFspPlatformSecLibVlv2/PlatformInit.c   |   36 -
>  .../SecFspPlatformSecLibVlv2/SaveSecContext.c |  108 -
>  .../SecGetPerformance.c                       |   83 -
>  .../SecPlatformInformation.c                  |   77 -
>  .../SecFspPlatformSecLibVlv2/SecRamInitData.c |   16 -
>  .../SecTempRamSupport.c                       |  149 -
>  .../SecFspPlatformSecLibVlv2/UartInit.c       |  192 -
>  Platform/Intel/Vlv2TbltDevicePkg/GenBiosId    |  Bin 12236 -> 0 bytes
>  .../Intel/Vlv2TbltDevicePkg/GenBiosId.exe     |  Bin 384000 -> 0 bytes
>  .../Vlv2TbltDevicePkg/Include/Guid/BiosId.h   |   30 -
>  .../Vlv2TbltDevicePkg/Include/Guid/IdccData.h |  104 -
>  .../Vlv2TbltDevicePkg/Include/Guid/ItkData.h  |   18 +-
>  .../Include/Guid/PlatformInfo.h               |    9 +-
>  .../Include/Library/BiosIdLib.h               |   22 +-
>  .../Include/Library/EfiRegTableLib.h          |   51 +-
>  .../Include/Protocol/LpcWpc83627Policy.h      |   92 -
>  .../Include/Protocol/LpcWpce791Policy.h       |   55 -
>  .../Include/Protocol/TpmMp.h                  |  136 -
>  .../Include/Protocol/UsbPolicy.h              |  126 -
>  .../Library/BiosIdLib/BiosIdLib.c             |  279 +-
>  .../Library/BiosIdLib/BiosIdLib.inf           |   21 +-
>  .../DxePlatformBootManagerLib/BdsPlatform.c   | 1434 ++++++
>  .../DxePlatformBootManagerLib/BdsPlatform.h   |  253 +
>  .../DxePlatformBootManagerLib.inf             |   97 +
>  .../DxePlatformBootManagerLib/MemoryTest.c    |   83 +
>  .../PlatformBootOption.c                      |  559 ++
>  .../Library/EfiRegTableLib/EfiRegTableLib.c   |   57 +-
>  .../Library/EfiRegTableLib/EfiRegTableLib.inf |   12 +-
>  .../Vlv2TbltDevicePkg/Library/I2CLib/I2CLib.c |   46 -
>  .../Library/I2CLib/I2CLibNull.inf             |   39 -
>  .../Library/I2CLibDxe/I2CLib.c                |  735 ---
>  .../Library/I2CLibDxe/I2CLibDxe.inf           |   39 -
>  .../Library/I2CLibDxe/I2CRegs.h               |  126 -
>  .../Library/I2CLibPei/I2CAccess.h             |   44 -
>  .../Library/I2CLibPei/I2CDelayPei.c           |   46 -
>  .../Library/I2CLibPei/I2CDelayPei.h           |   30 -
>  .../Library/I2CLibPei/I2CIoLibPei.c           |  178 -
>  .../Library/I2CLibPei/I2CIoLibPei.h           |  153 -
>  .../Library/I2CLibPei/I2CLibPei.c             |  638 ---
>  .../Library/I2CLibPei/I2CLibPei.h             |  280 -
>  .../Library/I2CLibPei/I2CLibPei.inf           |   40 -
>  .../BoardClkGens/BoardClkGens.c               |   23 +-
>  .../BoardClkGens/BoardClkGens.h               |    8 +-
>  .../MultiPlatformLib/BoardGpios/BoardGpios.c  |   12 +-
>  .../MultiPlatformLib/BoardGpios/BoardGpios.h  |    7 +-
>  .../MultiPlatformLib/MultiPlatformLib.h       |   11 +-
>  .../MultiPlatformLib/MultiPlatformLib.inf     |   11 +-
>  .../Library/PlatformBdsLib/BdsPlatform.c      | 3098 ------------
>  .../Library/PlatformBdsLib/BdsPlatform.h      |  516 --
>  .../Library/PlatformBdsLib/PlatformBdsLib.inf |  128 -
>  .../PlatformBdsLib/PlatformBdsStrings.uni     |   30 -
>  .../Library/PlatformBdsLib/PlatformData.c     |  306 --
>  .../Library/PlatformFspLib/PlatformFspLib.c   |   44 -
>  .../Library/PlatformFspLib/PlatformFspLib.inf |   49 -
>  .../SerialPortLib/PlatformSerialPortLib.h     |   53 -
>  .../Library/SerialPortLib/SerialPortLib.c     |  246 -
>  .../Library/SerialPortLib/SerialPortLib.inf   |   52 -
>  .../Library/SerialPortLib/SioInit.c           |  127 -
>  .../Library/SerialPortLib/SioInit.h           |   62 -
>  .../Library/SmbusLib/CommonHeader.h           |   26 -
>  .../Library/SmbusLib/SmbusLib.c               |  873 ----
>  .../Library/SmbusLib/SmbusLib.inf             |   46 -
>  .../Metronome/LegacyMetronome.c               |  185 -
>  .../Metronome/LegacyMetronome.h               |   64 -
>  .../Vlv2TbltDevicePkg/Metronome/Metronome.inf |   49 -
>  .../MonoStatusCode/MonoStatusCode.h           |   47 +-
>  .../MonoStatusCode/MonoStatusCode.inf         |    9 +-
>  .../Library/GenericBdsLib/BdsBoot.c           | 4490 -----------------
>  .../Library/GenericBdsLib/BdsConnect.c        |  429 --
>  .../Library/GenericBdsLib/BdsConsole.c        | 1061 ----
>  .../Library/GenericBdsLib/BdsMisc.c           | 1575 ------
>  .../Library/GenericBdsLib/DevicePath.c        |   27 -
>  .../Library/GenericBdsLib/GenericBdsLib.inf   |  143 -
>  .../Library/GenericBdsLib/GenericBdsLib.uni   |   19 -
>  .../GenericBdsLib/GenericBdsStrings.uni       |   30 -
>  .../Library/GenericBdsLib/InternalBdsLib.h    |  173 -
>  .../Library/GenericBdsLib/String.c            |   26 -
>  .../Library/GenericBdsLib/String.h            |   42 -
>  .../PciPlatform/PciPlatform.c                 |    7 +-
>  .../PciPlatform/PciPlatform.inf               |    9 +-
>  .../Intel/Vlv2TbltDevicePkg/PcuSio/PcuSio.c   |  951 ++++
>  .../Intel/Vlv2TbltDevicePkg/PcuSio/PcuSio.h   |  363 ++
>  .../Intel/Vlv2TbltDevicePkg/PcuSio/PcuSio.inf |   38 +
>  .../PlatformCpuInfoDxe/PlatformCpuInfoDxe.c   |    8 +-
>  .../PlatformCpuInfoDxe/PlatformCpuInfoDxe.h   |   17 +-
>  .../PlatformCpuInfoDxe/PlatformCpuInfoDxe.inf |    8 +-
>  .../Vlv2TbltDevicePkg/PlatformDxe/BoardId.c   |   45 +-
>  .../PlatformDxe/ClockControl.c                |   80 +-
>  .../PlatformDxe/Configuration.h               |    8 +-
>  .../PlatformDxe/IchRegTable.c                 |    8 +-
>  .../Vlv2TbltDevicePkg/PlatformDxe/IdccInfo.c  |   72 -
>  .../Vlv2TbltDevicePkg/PlatformDxe/Platform.c  |  533 +-
>  .../PlatformDxe/PlatformDxe.h                 |  521 +-
>  .../PlatformDxe/PlatformDxe.inf               |   28 +-
>  .../PlatformDxe/SioPlatformPolicy.c           |   82 -
>  .../PlatformGopPolicy/PlatformGopPolicy.inf   |   15 +-
>  .../Vlv2TbltDevicePkg/PlatformInitPei/Dimm.c  |  319 --
>  .../PlatformInitPei/MemoryCallback.c          |    8 +-
>  .../PlatformInitPei/MemoryPeim.c              |   21 +-
>  .../PlatformInitPei/PchInitPeim.c             |   10 +-
>  .../PlatformInitPei/PlatformEarlyInit.c       |  209 +-
>  .../PlatformInitPei/PlatformEarlyInit.h       |   31 +-
>  .../PlatformInitPei/PlatformInitPei.inf       |   29 +-
>  .../Vlv2TbltDevicePkg/PlatformPei/BootMode.c  |   99 +-
>  .../PlatformPei/CommonHeader.h                |   12 +-
>  .../PlatformPei/MemoryCallback.c              |    8 +-
>  .../Vlv2TbltDevicePkg/PlatformPei/Platform.c  |   24 +-
>  .../Vlv2TbltDevicePkg/PlatformPei/Platform.h  |   27 +-
>  .../PlatformPei/PlatformPei.inf               |   12 +-
>  .../Intel/Vlv2TbltDevicePkg/PlatformPkg.dec   |   28 +-
>  .../Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf   |  286 +-
>  .../Vlv2TbltDevicePkg/PlatformPkgConfig.dsc   |   22 +-
>  .../Vlv2TbltDevicePkg/PlatformPkgGcc.fdf      |  299 +-
>  .../Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc   |  561 +-
>  .../Vlv2TbltDevicePkg/PlatformPkgIA32.dsc     |  562 +--
>  .../Vlv2TbltDevicePkg/PlatformPkgX64.dsc      |  563 +--
>  .../PlatformSetupDxe/PlatformSetupDxe.h       |   30 +-
>  .../PlatformSetupDxe/PlatformSetupDxe.inf     |   17 +-
>  .../PlatformSetupDxe/SetupFunctions.c         |   38 +-
>  .../PlatformSetupDxe/SetupInfoRecords.c       |  572 +--
>  .../Vlv2TbltDevicePkg/PlatformSmm/Platform.c  |  196 +-
>  .../PlatformSmm/PlatformSmm.inf               |   34 +-
>  .../Vlv2TbltDevicePkg/PlatformSmm/S3Save.c    |   53 +-
>  .../PlatformSmm/SmmPlatform.h                 |  111 +-
>  .../PlatformSmm/SmmScriptSave.c               |  252 -
>  .../PlatformSmm/SmmScriptSave.h               |   50 -
>  .../Vlv2TbltDevicePkg/PpmPolicy/PpmPolicy.inf |    6 +-
>  .../SmBiosMiscDxe/CommonHeader.h              |   10 +-
>  .../SmBiosMiscDxe/DataHubRecords.h            | 2934 +++++++++++
>  .../MiscBaseBoardManufacturerFunction.c       |    8 +-
>  .../SmBiosMiscDxe/MiscBiosVendorFunction.c    |    9 +-
>  .../SmBiosMiscDxe/MiscMemoryDeviceFunction.c  |  318 +-
>  .../SmBiosMiscDxe/MiscOemType0x94Function.c   |   45 +-
>  .../SmBiosMiscDxe/MiscProcessorCacheData.c    |   11 +-
>  .../MiscProcessorCacheFunction.c              |  273 +-
>  .../MiscProcessorInformationFunction.c        |  203 +-
>  .../MiscSubclassDriverDataTable.c             |   14 +-
>  .../MiscSubclassDriverEntryPoint.c            |   13 +-
>  .../MiscSystemManufacturerFunction.c          |   10 +-
>  .../SmBiosMiscDxe/SmBiosMiscDxe.inf           |   18 +-
>  .../SmmSwDispatch2OnSmmSwDispatchThunk.c      |  459 --
>  .../SmmSwDispatch2OnSmmSwDispatchThunk.inf    |   54 -
>  .../SmramSaveInfoHandlerSmm.c                 |  164 -
>  .../SmramSaveInfoHandlerSmm.inf               |   60 -
>  .../Stitch/IFWIHeader/Vacant.bin              |  Bin 3928064 -> 0 bytes
>  .../Vlv2TbltDevicePkg/Stitch/IFWIStitch.bat   |  270 -
>  .../Stitch/MNW2_Stitch_Config.txt             |   10 -
>  .../Intel/Vlv2TbltDevicePkg/UiApp/FrontPage.c |   33 -
>  .../Intel/Vlv2TbltDevicePkg/UiApp/UiApp.inf   |   32 -
>  .../VlvPlatformInitDxe/IgdOpRegion.c          |   20 +-
>  .../VlvPlatformInitDxe/IgdOpRegion.h          |   27 +-
>  .../VlvPlatformInitDxe/VlvPlatformInitDxe.inf |   14 +-
>  .../Vlv2TbltDevicePkg/Wpce791/LpcDriver.c     |  340 --
>  .../Vlv2TbltDevicePkg/Wpce791/LpcDriver.h     |  112 -
>  .../Vlv2TbltDevicePkg/Wpce791/LpcIsaAcpi.c    |  366 --
>  .../Vlv2TbltDevicePkg/Wpce791/LpcIsaAcpi.h    |  103 -
>  .../Intel/Vlv2TbltDevicePkg/Wpce791/LpcSio.c  |  126 -
>  .../Intel/Vlv2TbltDevicePkg/Wpce791/LpcSio.h  |  101 -
>  .../Vlv2TbltDevicePkg/Wpce791/Wpce791.inf     |   63 -
>  Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.bat  |   47 +-
>  Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh   |   52 +-
>  .../Include/Protocol/SmmIchnDispatch.h        |  183 +
>  .../Vlv2DeviceRefCodePkg.dec                  |    5 +-
>  188 files changed, 8321 insertions(+), 28666 deletions(-)
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/BiosIdD.env
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/BiosIdR.env
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/BiosIdx64D.env
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/BiosIdx64R.env
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/BootScriptSaveDxe/BootScriptSaveDxe.inf
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/BootScriptSaveDxe/InternalBootScriptSave.h
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/BootScriptSaveDxe/ScriptSave.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspAzaliaConfigData/AzaliaConfig.bin
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/BootModePei/BootModePei.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/BootModePei/BootModePei.inf
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/PeiFspHobProcessLibVlv2/FspHobProcessLibVlv2.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/PeiFspHobProcessLibVlv2/FspHobProcessLibVlv2.inf
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/FspPlatformSecLibVlv2.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/FspPlatformSecLibVlv2.inf
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/Ia32/AsmSaveSecContext.asm
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/Ia32/Fsp.inc
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/Ia32/PeiCoreEntry.asm
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/Ia32/SecEntry.asm
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/Ia32/Stack.S
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/Ia32/Stack.asm
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/PlatformInit.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/SaveSecContext.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/SecGetPerformance.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/SecPlatformInformation.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/SecRamInitData.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/SecTempRamSupport.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecFspPlatformSecLibVlv2/UartInit.c
>  delete mode 100755 Platform/Intel/Vlv2TbltDevicePkg/GenBiosId
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/GenBiosId.exe
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Include/Guid/BiosId.h
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Include/Guid/IdccData.h
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Include/Protocol/LpcWpc83627Policy.h
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Include/Protocol/LpcWpce791Policy.h
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Include/Protocol/TpmMp.h
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Include/Protocol/UsbPolicy.h
>  create mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/BdsPlatform.c
>  create mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/BdsPlatform.h
>  create mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/DxePlatformBootManagerLib.inf
>  create mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/MemoryTest.c
>  create mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/PlatformBootOption.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLib/I2CLib.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLib/I2CLibNull.inf
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibDxe/I2CLib.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibDxe/I2CLibDxe.inf
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibDxe/I2CRegs.h
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CAccess.h
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CDelayPei.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CDelayPei.h
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CIoLibPei.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CIoLibPei.h
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CLibPei.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CLibPei.h
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CLibPei.inf
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.h
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsStrings.uni
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformData.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformFspLib/PlatformFspLib.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformFspLib/PlatformFspLib.inf
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/SerialPortLib/PlatformSerialPortLib.h
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/SerialPortLib/SerialPortLib.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/SerialPortLib/SerialPortLib.inf
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/SerialPortLib/SioInit.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/SerialPortLib/SioInit.h
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/SmbusLib/CommonHeader.h
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/SmbusLib/SmbusLib.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Library/SmbusLib/SmbusLib.inf
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Metronome/LegacyMetronome.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Metronome/LegacyMetronome.h
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Metronome/Metronome.inf
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/BdsBoot.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/BdsConnect.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/BdsConsole.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/BdsMisc.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/DevicePath.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.uni
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsStrings.uni
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/InternalBdsLib.h
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/String.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/String.h
>  create mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PcuSio/PcuSio.c
>  create mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PcuSio/PcuSio.h
>  create mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PcuSio/PcuSio.inf
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformDxe/IdccInfo.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformDxe/SioPlatformPolicy.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformInitPei/Dimm.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformSmm/SmmScriptSave.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/PlatformSmm/SmmScriptSave.h
>  create mode 100644 Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRecords.h
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/SmmSwDispatch2OnSmmSwDispatchThunk/SmmSwDispatch2OnSmmSwDispatchThunk.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/SmmSwDispatch2OnSmmSwDispatchThunk/SmmSwDispatch2OnSmmSwDispatchThunk.inf
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/SmramSaveInfoHandlerSmm/SmramSaveInfoHandlerSmm.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/SmramSaveInfoHandlerSmm/SmramSaveInfoHandlerSmm.inf
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Stitch/IFWIHeader/Vacant.bin
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Stitch/IFWIStitch.bat
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Stitch/MNW2_Stitch_Config.txt
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/UiApp/FrontPage.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/UiApp/UiApp.inf
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Wpce791/LpcDriver.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Wpce791/LpcDriver.h
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Wpce791/LpcIsaAcpi.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Wpce791/LpcIsaAcpi.h
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Wpce791/LpcSio.c
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Wpce791/LpcSio.h
>  delete mode 100644 Platform/Intel/Vlv2TbltDevicePkg/Wpce791/Wpce791.inf
>  create mode 100644 Silicon/Intel/Vlv2DeviceRefCodePkg/Include/Protocol/SmmIchnDispatch.h
> 
> -- 
> 2.21.0.windows.1
> 
> 
> 
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43083): https://edk2.groups.io/g/devel/message/43083
Mute This Topic: https://groups.io/mt/32267616/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Hi Gary,

I recommend you rebase on top of this series.

I have verified Linux boots and I have been working
on the GCC and Linux build scripts as well. 

Please let me know if you see any issues with this
series applied and I can help get them fixed.

Thanks,

Mike

> -----Original Message-----
> From: Gary Lin [mailto:GLin@suse.com]
> Sent: Sunday, June 30, 2019 9:04 PM
> To: devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> <zailiang.sun@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms Patch 00/14]
> Vlv2TbltDevicePkg: Remove Intel Framework dependencies
> 
> On Sun, Jun 30, 2019 at 07:55:39PM -0700,  Michael D
> Kinney  wrote:
> > The following changes remove all dependencies on the
> IntelFrameworkPkg
> > and IntelFrameworkModulePkg from the Vlv2TbltDevicePkg
> platform
> > builds.  These changes do depend on updates binaries
> on the edk2-non-osi repository.
> >
> Hi Michael,
> 
> I am amending the bash scripts for gcc. The firmware I
> built is using the binaries from Development190216 and
> could boot into Linux successfully with some workarounds
> for Wpce791, Bds, and InteFspWrapper. The patches you
> posted eliminate those parts I have to work around.
> 
> Just want to know if you need any assistance for the gcc
> build? I could rebase my work upon your patches and send
> them later.
> 
> Thanks,
> 
> Gary Lin
> 
> > * Vlv2DeviceRefCodePkg: Add
> gEfiSmmIchnDispatchProtocolGuid
> > * Vlv2TbltDevicePkg: Reduce Intel Framework
> dependencies
> > * Vlv2TbltDevicePkg: Remove unused modules/libraries
> > * Vlv2TbltDevicePkg: Switch from ISA to SIO modules
> > * Vlv2TbltDevicePkg: Switch to CPU I/O 2 Protocol
> > * Vlv2TbltDevicePkg: Remove use of PS/2 Policy
> Protocol
> > * Vlv2TbltDevicePkg: Remove use of BIOS ID tools
> > * Vlv2TbltDevicePkg: Remove use of Data Hub Protocol
> > * Vlv2TbltDevicePkg: Use PI Spec SMBUS2 PPI
> > * Vlv2TbltDevicePkg: Switch to MdeModulePkg BdsDxe
> > * Vlv2TbltDevicePkg: Update boot mode/state behaviors
> > * Vlv2TbltDevicePkg/PlatformSmm: Switch to PI SMM
> Protocols
> > * Vlv2TbltDevicePkg: Change to PI Spec ACPI Table
> Protocol
> >
> > Cc: Zailiang Sun <zailiang.sun@intel.com>
> > Cc: Yi Qian <yi.qian@intel.com>
> > Signed-off-by: Michael D Kinney
> <michael.d.kinney@intel.com>
> >
> > Michael D Kinney (14):
> >   Vlv2DeviceRefCodePkg: Add
> gEfiSmmIchnDispatchProtocolGuid
> >   Vlv2TbltDevicePkg: Reduce Intel Framework
> dependencies
> >   Vlv2TbltDevicePkg: Remove unused modules/libraries
> >   Vlv2TbltDevicePkg: Switch from ISA to SIO modules
> >   Vlv2TbltDevicePkg: Switch to CPU I/O 2 Protocol
> >   Vlv2TbltDevicePkg: Remove use of PS/2 Policy
> Protocol
> >   Vlv2TbltDevicePkg: Remove use of BIOS ID tools
> >   Vlv2TbltDevicePkg: Remove use of Data Hub Protocol
> >   Vlv2TbltDevicePkg: Use PI Spec SMBUS2 PPI
> >   Vlv2TbltDevicePkg: Switch to MdeModulePkg BdsDxe
> >   Vlv2TbltDevicePkg: Update boot mode/state behaviors
> >   Vlv2TbltDevicePkg/PlatformSmm: Switch to PI SMM
> Protocols
> >   Vlv2TbltDevicePkg: Change to PI Spec ACPI Table
> Protocol
> >   Vlv2TbltDevicePkg/PlatformInitPei: Update
> MemoryTypeInformation
> >
> >  .../AcpiPlatform/AcpiPlatform.c               |  137
> +-
> >  .../AcpiPlatform/AcpiPlatform.h               |   11
> +-
> >  .../AcpiPlatform/AcpiPlatform.inf             |   14
> +-
> >  Platform/Intel/Vlv2TbltDevicePkg/BiosIdD.env  |   25
> -
> >  Platform/Intel/Vlv2TbltDevicePkg/BiosIdR.env  |   25
> -
> >  .../Intel/Vlv2TbltDevicePkg/BiosIdx64D.env    |   25
> -
> >  .../Intel/Vlv2TbltDevicePkg/BiosIdx64R.env    |   25
> -
> >  .../BootScriptSaveDxe/BootScriptSaveDxe.inf   |   60
> -
> >  .../InternalBootScriptSave.h                  |  102
> -
> >  .../BootScriptSaveDxe/ScriptSave.c            |  626
> ---
> >  .../Intel/Vlv2TbltDevicePkg/Build_IFWI.bat    |   33
> -
> >  .../Library/FmpDeviceLib/FmpDeviceLib.c       |   12
> +-
> >  .../FspAzaliaConfigData/AzaliaConfig.bin      |  Bin
> 3708 -> 0 bytes
> >  .../FspSupport/BootModePei/BootModePei.c      |   42
> -
> >  .../FspSupport/BootModePei/BootModePei.inf    |   40
> -
> >  .../FspHobProcessLibVlv2.c                    |  421
> --
> >  .../FspHobProcessLibVlv2.inf                  |   74
> -
> >  .../FspPlatformSecLibVlv2.c                   |  144
> -
> >  .../FspPlatformSecLibVlv2.inf                 |   82
> -
> >  .../Ia32/AsmSaveSecContext.asm                |   45
> -
> >  .../SecFspPlatformSecLibVlv2/Ia32/Fsp.inc     |   45
> -
> >  .../Ia32/PeiCoreEntry.asm                     |  135
> -
> >  .../Ia32/SecEntry.asm                         |  338
> --
> >  .../SecFspPlatformSecLibVlv2/Ia32/Stack.S     |   71
> -
> >  .../SecFspPlatformSecLibVlv2/Ia32/Stack.asm   |   76
> -
> >  .../SecFspPlatformSecLibVlv2/PlatformInit.c   |   36
> -
> >  .../SecFspPlatformSecLibVlv2/SaveSecContext.c |  108
> -
> >  .../SecGetPerformance.c                       |   83
> -
> >  .../SecPlatformInformation.c                  |   77
> -
> >  .../SecFspPlatformSecLibVlv2/SecRamInitData.c |   16
> -
> >  .../SecTempRamSupport.c                       |  149
> -
> >  .../SecFspPlatformSecLibVlv2/UartInit.c       |  192
> -
> >  Platform/Intel/Vlv2TbltDevicePkg/GenBiosId    |  Bin
> 12236 -> 0 bytes
> >  .../Intel/Vlv2TbltDevicePkg/GenBiosId.exe     |  Bin
> 384000 -> 0 bytes
> >  .../Vlv2TbltDevicePkg/Include/Guid/BiosId.h   |   30
> -
> >  .../Vlv2TbltDevicePkg/Include/Guid/IdccData.h |  104
> -
> >  .../Vlv2TbltDevicePkg/Include/Guid/ItkData.h  |   18
> +-
> >  .../Include/Guid/PlatformInfo.h               |    9
> +-
> >  .../Include/Library/BiosIdLib.h               |   22
> +-
> >  .../Include/Library/EfiRegTableLib.h          |   51
> +-
> >  .../Include/Protocol/LpcWpc83627Policy.h      |   92
> -
> >  .../Include/Protocol/LpcWpce791Policy.h       |   55
> -
> >  .../Include/Protocol/TpmMp.h                  |  136
> -
> >  .../Include/Protocol/UsbPolicy.h              |  126
> -
> >  .../Library/BiosIdLib/BiosIdLib.c             |  279
> +-
> >  .../Library/BiosIdLib/BiosIdLib.inf           |   21
> +-
> >  .../DxePlatformBootManagerLib/BdsPlatform.c   | 1434
> ++++++
> >  .../DxePlatformBootManagerLib/BdsPlatform.h   |  253
> +
> >  .../DxePlatformBootManagerLib.inf             |   97
> +
> >  .../DxePlatformBootManagerLib/MemoryTest.c    |   83
> +
> >  .../PlatformBootOption.c                      |  559
> ++
> >  .../Library/EfiRegTableLib/EfiRegTableLib.c   |   57
> +-
> >  .../Library/EfiRegTableLib/EfiRegTableLib.inf |   12
> +-
> >  .../Vlv2TbltDevicePkg/Library/I2CLib/I2CLib.c |   46
> -
> >  .../Library/I2CLib/I2CLibNull.inf             |   39
> -
> >  .../Library/I2CLibDxe/I2CLib.c                |  735
> ---
> >  .../Library/I2CLibDxe/I2CLibDxe.inf           |   39
> -
> >  .../Library/I2CLibDxe/I2CRegs.h               |  126
> -
> >  .../Library/I2CLibPei/I2CAccess.h             |   44
> -
> >  .../Library/I2CLibPei/I2CDelayPei.c           |   46
> -
> >  .../Library/I2CLibPei/I2CDelayPei.h           |   30
> -
> >  .../Library/I2CLibPei/I2CIoLibPei.c           |  178
> -
> >  .../Library/I2CLibPei/I2CIoLibPei.h           |  153
> -
> >  .../Library/I2CLibPei/I2CLibPei.c             |  638
> ---
> >  .../Library/I2CLibPei/I2CLibPei.h             |  280
> -
> >  .../Library/I2CLibPei/I2CLibPei.inf           |   40
> -
> >  .../BoardClkGens/BoardClkGens.c               |   23
> +-
> >  .../BoardClkGens/BoardClkGens.h               |    8
> +-
> >  .../MultiPlatformLib/BoardGpios/BoardGpios.c  |   12
> +-
> >  .../MultiPlatformLib/BoardGpios/BoardGpios.h  |    7
> +-
> >  .../MultiPlatformLib/MultiPlatformLib.h       |   11
> +-
> >  .../MultiPlatformLib/MultiPlatformLib.inf     |   11
> +-
> >  .../Library/PlatformBdsLib/BdsPlatform.c      | 3098
> ------------
> >  .../Library/PlatformBdsLib/BdsPlatform.h      |  516
> --
> >  .../Library/PlatformBdsLib/PlatformBdsLib.inf |  128
> -
> >  .../PlatformBdsLib/PlatformBdsStrings.uni     |   30
> -
> >  .../Library/PlatformBdsLib/PlatformData.c     |  306
> --
> >  .../Library/PlatformFspLib/PlatformFspLib.c   |   44
> -
> >  .../Library/PlatformFspLib/PlatformFspLib.inf |   49
> -
> >  .../SerialPortLib/PlatformSerialPortLib.h     |   53
> -
> >  .../Library/SerialPortLib/SerialPortLib.c     |  246
> -
> >  .../Library/SerialPortLib/SerialPortLib.inf   |   52
> -
> >  .../Library/SerialPortLib/SioInit.c           |  127
> -
> >  .../Library/SerialPortLib/SioInit.h           |   62
> -
> >  .../Library/SmbusLib/CommonHeader.h           |   26
> -
> >  .../Library/SmbusLib/SmbusLib.c               |  873
> ----
> >  .../Library/SmbusLib/SmbusLib.inf             |   46
> -
> >  .../Metronome/LegacyMetronome.c               |  185
> -
> >  .../Metronome/LegacyMetronome.h               |   64
> -
> >  .../Vlv2TbltDevicePkg/Metronome/Metronome.inf |   49
> -
> >  .../MonoStatusCode/MonoStatusCode.h           |   47
> +-
> >  .../MonoStatusCode/MonoStatusCode.inf         |    9
> +-
> >  .../Library/GenericBdsLib/BdsBoot.c           | 4490
> -----------------
> >  .../Library/GenericBdsLib/BdsConnect.c        |  429
> --
> >  .../Library/GenericBdsLib/BdsConsole.c        | 1061
> ----
> >  .../Library/GenericBdsLib/BdsMisc.c           | 1575
> ------
> >  .../Library/GenericBdsLib/DevicePath.c        |   27
> -
> >  .../Library/GenericBdsLib/GenericBdsLib.inf   |  143
> -
> >  .../Library/GenericBdsLib/GenericBdsLib.uni   |   19
> -
> >  .../GenericBdsLib/GenericBdsStrings.uni       |   30
> -
> >  .../Library/GenericBdsLib/InternalBdsLib.h    |  173
> -
> >  .../Library/GenericBdsLib/String.c            |   26
> -
> >  .../Library/GenericBdsLib/String.h            |   42
> -
> >  .../PciPlatform/PciPlatform.c                 |    7
> +-
> >  .../PciPlatform/PciPlatform.inf               |    9
> +-
> >  .../Intel/Vlv2TbltDevicePkg/PcuSio/PcuSio.c   |  951
> ++++
> >  .../Intel/Vlv2TbltDevicePkg/PcuSio/PcuSio.h   |  363
> ++
> >  .../Intel/Vlv2TbltDevicePkg/PcuSio/PcuSio.inf |   38
> +
> >  .../PlatformCpuInfoDxe/PlatformCpuInfoDxe.c   |    8
> +-
> >  .../PlatformCpuInfoDxe/PlatformCpuInfoDxe.h   |   17
> +-
> >  .../PlatformCpuInfoDxe/PlatformCpuInfoDxe.inf |    8
> +-
> >  .../Vlv2TbltDevicePkg/PlatformDxe/BoardId.c   |   45
> +-
> >  .../PlatformDxe/ClockControl.c                |   80
> +-
> >  .../PlatformDxe/Configuration.h               |    8
> +-
> >  .../PlatformDxe/IchRegTable.c                 |    8
> +-
> >  .../Vlv2TbltDevicePkg/PlatformDxe/IdccInfo.c  |   72
> -
> >  .../Vlv2TbltDevicePkg/PlatformDxe/Platform.c  |  533
> +-
> >  .../PlatformDxe/PlatformDxe.h                 |  521
> +-
> >  .../PlatformDxe/PlatformDxe.inf               |   28
> +-
> >  .../PlatformDxe/SioPlatformPolicy.c           |   82
> -
> >  .../PlatformGopPolicy/PlatformGopPolicy.inf   |   15
> +-
> >  .../Vlv2TbltDevicePkg/PlatformInitPei/Dimm.c  |  319
> --
> >  .../PlatformInitPei/MemoryCallback.c          |    8
> +-
> >  .../PlatformInitPei/MemoryPeim.c              |   21
> +-
> >  .../PlatformInitPei/PchInitPeim.c             |   10
> +-
> >  .../PlatformInitPei/PlatformEarlyInit.c       |  209
> +-
> >  .../PlatformInitPei/PlatformEarlyInit.h       |   31
> +-
> >  .../PlatformInitPei/PlatformInitPei.inf       |   29
> +-
> >  .../Vlv2TbltDevicePkg/PlatformPei/BootMode.c  |   99
> +-
> >  .../PlatformPei/CommonHeader.h                |   12
> +-
> >  .../PlatformPei/MemoryCallback.c              |    8
> +-
> >  .../Vlv2TbltDevicePkg/PlatformPei/Platform.c  |   24
> +-
> >  .../Vlv2TbltDevicePkg/PlatformPei/Platform.h  |   27
> +-
> >  .../PlatformPei/PlatformPei.inf               |   12
> +-
> >  .../Intel/Vlv2TbltDevicePkg/PlatformPkg.dec   |   28
> +-
> >  .../Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf   |  286
> +-
> >  .../Vlv2TbltDevicePkg/PlatformPkgConfig.dsc   |   22
> +-
> >  .../Vlv2TbltDevicePkg/PlatformPkgGcc.fdf      |  299
> +-
> >  .../Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc   |  561
> +-
> >  .../Vlv2TbltDevicePkg/PlatformPkgIA32.dsc     |  562
> +--
> >  .../Vlv2TbltDevicePkg/PlatformPkgX64.dsc      |  563
> +--
> >  .../PlatformSetupDxe/PlatformSetupDxe.h       |   30
> +-
> >  .../PlatformSetupDxe/PlatformSetupDxe.inf     |   17
> +-
> >  .../PlatformSetupDxe/SetupFunctions.c         |   38
> +-
> >  .../PlatformSetupDxe/SetupInfoRecords.c       |  572
> +--
> >  .../Vlv2TbltDevicePkg/PlatformSmm/Platform.c  |  196
> +-
> >  .../PlatformSmm/PlatformSmm.inf               |   34
> +-
> >  .../Vlv2TbltDevicePkg/PlatformSmm/S3Save.c    |   53
> +-
> >  .../PlatformSmm/SmmPlatform.h                 |  111
> +-
> >  .../PlatformSmm/SmmScriptSave.c               |  252
> -
> >  .../PlatformSmm/SmmScriptSave.h               |   50
> -
> >  .../Vlv2TbltDevicePkg/PpmPolicy/PpmPolicy.inf |    6
> +-
> >  .../SmBiosMiscDxe/CommonHeader.h              |   10
> +-
> >  .../SmBiosMiscDxe/DataHubRecords.h            | 2934
> +++++++++++
> >  .../MiscBaseBoardManufacturerFunction.c       |    8
> +-
> >  .../SmBiosMiscDxe/MiscBiosVendorFunction.c    |    9
> +-
> >  .../SmBiosMiscDxe/MiscMemoryDeviceFunction.c  |  318
> +-
> >  .../SmBiosMiscDxe/MiscOemType0x94Function.c   |   45
> +-
> >  .../SmBiosMiscDxe/MiscProcessorCacheData.c    |   11
> +-
> >  .../MiscProcessorCacheFunction.c              |  273
> +-
> >  .../MiscProcessorInformationFunction.c        |  203
> +-
> >  .../MiscSubclassDriverDataTable.c             |   14
> +-
> >  .../MiscSubclassDriverEntryPoint.c            |   13
> +-
> >  .../MiscSystemManufacturerFunction.c          |   10
> +-
> >  .../SmBiosMiscDxe/SmBiosMiscDxe.inf           |   18
> +-
> >  .../SmmSwDispatch2OnSmmSwDispatchThunk.c      |  459
> --
> >  .../SmmSwDispatch2OnSmmSwDispatchThunk.inf    |   54
> -
> >  .../SmramSaveInfoHandlerSmm.c                 |  164
> -
> >  .../SmramSaveInfoHandlerSmm.inf               |   60
> -
> >  .../Stitch/IFWIHeader/Vacant.bin              |  Bin
> 3928064 -> 0 bytes
> >  .../Vlv2TbltDevicePkg/Stitch/IFWIStitch.bat   |  270
> -
> >  .../Stitch/MNW2_Stitch_Config.txt             |   10
> -
> >  .../Intel/Vlv2TbltDevicePkg/UiApp/FrontPage.c |   33
> -
> >  .../Intel/Vlv2TbltDevicePkg/UiApp/UiApp.inf   |   32
> -
> >  .../VlvPlatformInitDxe/IgdOpRegion.c          |   20
> +-
> >  .../VlvPlatformInitDxe/IgdOpRegion.h          |   27
> +-
> >  .../VlvPlatformInitDxe/VlvPlatformInitDxe.inf |   14
> +-
> >  .../Vlv2TbltDevicePkg/Wpce791/LpcDriver.c     |  340
> --
> >  .../Vlv2TbltDevicePkg/Wpce791/LpcDriver.h     |  112
> -
> >  .../Vlv2TbltDevicePkg/Wpce791/LpcIsaAcpi.c    |  366
> --
> >  .../Vlv2TbltDevicePkg/Wpce791/LpcIsaAcpi.h    |  103
> -
> >  .../Intel/Vlv2TbltDevicePkg/Wpce791/LpcSio.c  |  126
> -
> > .../Intel/Vlv2TbltDevicePkg/Wpce791/LpcSio.h  |  101 -
> >  .../Vlv2TbltDevicePkg/Wpce791/Wpce791.inf     |   63
> -
> >  Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.bat  |   47
> +-
> >  Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh   |   52
> +-
> >  .../Include/Protocol/SmmIchnDispatch.h        |  183
> +
> >  .../Vlv2DeviceRefCodePkg.dec                  |    5
> +-
> >  188 files changed, 8321 insertions(+), 28666
> deletions(-)  delete
> > mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/BiosIdD.env
> >  delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/BiosIdR.env
> >  delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/BiosIdx64D.env
> >  delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/BiosIdx64R.env
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/BootScriptSaveDxe/BootS
> criptSaveDxe.i
> > nf  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/BootScriptSaveDxe/Inter
> nalBootScriptS
> > ave.h  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/BootScriptSaveDxe/Scrip
> tSave.c
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/FspAzaliaConfigData/Aza
> liaConfig.bin
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/FspSupport/BootModePei/
> BootModePei.c
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/FspSupport/BootModePei/
> BootModePei.in
> > f  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/PeiF
> spHobProcessLi
> > bVlv2/FspHobProcessLibVlv2.c  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/PeiF
> spHobProcessLi
> > bVlv2/FspHobProcessLibVlv2.inf  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecF
> spPlatformSecL
> > ibVlv2/FspPlatformSecLibVlv2.c  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecF
> spPlatformSecL
> > ibVlv2/FspPlatformSecLibVlv2.inf  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecF
> spPlatformSecL
> > ibVlv2/Ia32/AsmSaveSecContext.asm  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecF
> spPlatformSecL
> > ibVlv2/Ia32/Fsp.inc  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecF
> spPlatformSecL
> > ibVlv2/Ia32/PeiCoreEntry.asm  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecF
> spPlatformSecL
> > ibVlv2/Ia32/SecEntry.asm  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecF
> spPlatformSecL
> > ibVlv2/Ia32/Stack.S  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecF
> spPlatformSecL
> > ibVlv2/Ia32/Stack.asm  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecF
> spPlatformSecL
> > ibVlv2/PlatformInit.c  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecF
> spPlatformSecL
> > ibVlv2/SaveSecContext.c  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecF
> spPlatformSecL
> > ibVlv2/SecGetPerformance.c  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecF
> spPlatformSecL
> > ibVlv2/SecPlatformInformation.c  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecF
> spPlatformSecL
> > ibVlv2/SecRamInitData.c  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecF
> spPlatformSecL
> > ibVlv2/SecTempRamSupport.c  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/FspSupport/Library/SecF
> spPlatformSecL
> > ibVlv2/UartInit.c  delete mode 100755
> > Platform/Intel/Vlv2TbltDevicePkg/GenBiosId
> >  delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/GenBiosId.exe
> >  delete mode 100644
> > Platform/Intel/Vlv2TbltDevicePkg/Include/Guid/BiosId.h
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Include/Guid/IdccData.h
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Include/Protocol/LpcWpc
> 83627Policy.h
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Include/Protocol/LpcWpc
> e791Policy.h
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Include/Protocol/TpmMp.
> h
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Include/Protocol/UsbPol
> icy.h
> >  create mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBoot
> ManagerLib/Bds
> > Platform.c  create mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBoot
> ManagerLib/Bds
> > Platform.h  create mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBoot
> ManagerLib/Dxe
> > PlatformBootManagerLib.inf  create mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBoot
> ManagerLib/Mem
> > oryTest.c  create mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBoot
> ManagerLib/Pla
> > tformBootOption.c  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLib/I2CLib.c
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLib/I2CLibNu
> ll.inf
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibDxe/I2CLi
> b.c
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibDxe/I2CLi
> bDxe.inf
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibDxe/I2CRe
> gs.h
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CAc
> cess.h
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CDe
> layPei.c
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CDe
> layPei.h
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CIo
> LibPei.c
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CIo
> LibPei.h
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CLi
> bPei.c
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CLi
> bPei.h
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/I2CLibPei/I2CLi
> bPei.inf
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/
> BdsPlatform.c
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/
> BdsPlatform.h
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/
> PlatformBdsLib
> > .inf  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/
> PlatformBdsStr
> > ings.uni  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/
> PlatformData.c
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformFspLib/
> PlatformFspLib
> > .c  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformFspLib/
> PlatformFspLib
> > .inf  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/SerialPortLib/P
> latformSerialP
> > ortLib.h  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/SerialPortLib/S
> erialPortLib.c
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/SerialPortLib/S
> erialPortLib.i
> > nf  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/SerialPortLib/S
> ioInit.c
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/SerialPortLib/S
> ioInit.h
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/SmbusLib/Common
> Header.h
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/SmbusLib/SmbusL
> ib.c
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Library/SmbusLib/SmbusL
> ib.inf
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Metronome/LegacyMetrono
> me.c
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Metronome/LegacyMetrono
> me.h
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Metronome/Metronome.inf
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFramework
> ModulePkg/Libr
> > ary/GenericBdsLib/BdsBoot.c  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFramework
> ModulePkg/Libr
> > ary/GenericBdsLib/BdsConnect.c  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFramework
> ModulePkg/Libr
> > ary/GenericBdsLib/BdsConsole.c  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFramework
> ModulePkg/Libr
> > ary/GenericBdsLib/BdsMisc.c  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFramework
> ModulePkg/Libr
> > ary/GenericBdsLib/DevicePath.c  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFramework
> ModulePkg/Libr
> > ary/GenericBdsLib/GenericBdsLib.inf
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFramework
> ModulePkg/Libr
> > ary/GenericBdsLib/GenericBdsLib.uni
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFramework
> ModulePkg/Libr
> > ary/GenericBdsLib/GenericBdsStrings.uni
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFramework
> ModulePkg/Libr
> > ary/GenericBdsLib/InternalBdsLib.h
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFramework
> ModulePkg/Libr
> > ary/GenericBdsLib/String.c  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFramework
> ModulePkg/Libr
> > ary/GenericBdsLib/String.h  create mode 100644
> > Platform/Intel/Vlv2TbltDevicePkg/PcuSio/PcuSio.c
> >  create mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/PcuSio/PcuSio.h
> >  create mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/PcuSio/PcuSio.inf
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/PlatformDxe/IdccInfo.c
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/PlatformDxe/SioPlatform
> Policy.c
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/PlatformInitPei/Dimm.c
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/PlatformSmm/SmmScriptSa
> ve.c
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/PlatformSmm/SmmScriptSa
> ve.h
> >  create mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRe
> cords.h
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/SmmSwDispatch2OnSmmSwDi
> spatchThunk/Sm
> > mSwDispatch2OnSmmSwDispatchThunk.c
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/SmmSwDispatch2OnSmmSwDi
> spatchThunk/Sm
> > mSwDispatch2OnSmmSwDispatchThunk.inf
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/SmramSaveInfoHandlerSmm
> /SmramSaveInfo
> > HandlerSmm.c  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/SmramSaveInfoHandlerSmm
> /SmramSaveInfo
> > HandlerSmm.inf  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Stitch/IFWIHeader/Vacan
> t.bin
> >  delete mode 100644
> > Platform/Intel/Vlv2TbltDevicePkg/Stitch/IFWIStitch.bat
> >  delete mode 100644
> >
> Platform/Intel/Vlv2TbltDevicePkg/Stitch/MNW2_Stitch_Conf
> ig.txt
> >  delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/UiApp/FrontPage.c
> >  delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/UiApp/UiApp.inf
> >  delete mode 100644
> > Platform/Intel/Vlv2TbltDevicePkg/Wpce791/LpcDriver.c
> >  delete mode 100644
> > Platform/Intel/Vlv2TbltDevicePkg/Wpce791/LpcDriver.h
> >  delete mode 100644
> > Platform/Intel/Vlv2TbltDevicePkg/Wpce791/LpcIsaAcpi.c
> >  delete mode 100644
> > Platform/Intel/Vlv2TbltDevicePkg/Wpce791/LpcIsaAcpi.h
> >  delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Wpce791/LpcSio.c
> >  delete mode 100644
> Platform/Intel/Vlv2TbltDevicePkg/Wpce791/LpcSio.h
> >  delete mode 100644
> > Platform/Intel/Vlv2TbltDevicePkg/Wpce791/Wpce791.inf
> >  create mode 100644
> >
> Silicon/Intel/Vlv2DeviceRefCodePkg/Include/Protocol/SmmI
> chnDispatch.h
> >
> > --
> > 2.21.0.windows.1
> >
> >
> > 
> >
> >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43137): https://edk2.groups.io/g/devel/message/43137
Mute This Topic: https://groups.io/mt/32267616/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

On Mon, Jul 01, 2019 at 11:07:11PM +0000,  Michael D Kinney  wrote:
> Hi Gary,
> 
> I recommend you rebase on top of this series.
> 
> I have verified Linux boots and I have been working
> on the GCC and Linux build scripts as well. 
> 
> Please let me know if you see any issues with this
> series applied and I can help get them fixed.
> 
Hi Mike,

I'm rebasing my patches and they are available in my branch:

https://github.com/lcp/edk2-platforms/commits/vlv2-fixes-wip

It's based on edk2(dcce9cbd48e07fcd11f7ef34cad48faf7bb61e6e)
and edk2-non-osi(de0a6bc19c4ee0468f04e4d37035cdc59558137f).

There are 3 problems I currently encountered, and maybe you can give me
some suggestions.

1. Missing DSDT

When compiling DSDT, iasl failed with this error:

DSDT.iiii   6077:             Or(ShiftLeft(Derefof(Index(CDCT, \_SB.PCI0.GFX0.MCHK.DCFE)), 21),PARM, PARM)                                           
Error    6163 -                                                                      ^ Object is created temporarily in another method and cannot be accessed (\_SB.PCI0.GFX0. MCHK.DCFE)

The code is from Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOGBDA.ASL

I have to comment out the line or iasl won't generate the aml file and
the OS would fail to get DSDT.

My acpica version is 20190509, and I vaguely remember that the older
acpica seems to be more tolerant to this error.

2. Crash at SMBIOS driver

When booting the system, I got the following error:

Loading driver at 0x00078DBA000 EntryPoint=0x00078DBEC3C MiscSubclass.efi
InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF 78FE8D18
ProtectUefiImageCommon - 0x78FE8040
  - 0x0000000078DBA000 - 0x0000000000007B80
PlatformInfoHob->BoardId [0xB0]
GetBiosVersionDateTime :MNW2MAX1.X64.0084.D01 01/01/2019 00:00 
SmbiosAdd: Smbios type 0 with size 0x48 is added to 32-bit table
SmbiosAdd: Smbios type 0 with size 0x48 is added to 64-bit table
SmbiosCreateTable: Initialize 32-bit entry point structure
SmbiosCreateTable() re-allocate SMBIOS 32-bit table
SmbiosCreateTable: Initialize 64-bit entry point structure
SmbiosCreate64BitTable() re-allocate SMBIOS 64-bit table
Create Smbios Manu callback.
!!!! X64 Exception Type - 06(#UD - Invalid Opcode)  CPU Apic ID - 00000000 !!!!
RIP  - 0000000078DBEC26, CS  - 0000000000000038, RFLAGS - 0000000000010206
RAX  - 0000000000000000, RCX - 000000007984A5A0, RDX - 000000007A46E5FF
RBX  - 000000007A46E920, RSP - 000000007A46E8B0, RBP - 0000000078DC0EC0
RSI  - 0000000000000012, RDI - 0000000000000003
R8   - 800000000000000E, R9  - 000000007A46E920, R10 - 0000000078FE8398
R11  - 0000000000000001, R12 - 0000000078FE8798, R13 - 0000000078FE8898
R14  - 0000000078FE8818, R15 - 000000007A46EC60
DS   - 0000000000000030, ES  - 0000000000000030, FS  - 0000000000000030
GS   - 0000000000000030, SS  - 0000000000000030
CR0  - 0000000080010013, CR2 - 0000000000000000, CR3 - 000000007A201000
CR4  - 0000000000000628, CR8 - 0000000000000000
DR0  - 0000000000000000, DR1 - 0000000000000000, DR2 - 0000000000000000
DR3  - 0000000000000000, DR6 - 00000000FFFF0FF8, DR7 - 0000000000000400
GDTR - 0000000079FFDA98 0000000000000047, LDTR - 0000000000000000
IDTR - 0000000079862018 0000000000000FFF,   TR - 0000000000000000
FXSAVE_STATE - 000000007A46E510
!!!! Find image based on IP(0x78DBEC26) /home/gary/git/edk2-workspace/Build/Vlv2TbltDevicePkg/DEBUG_GCC5/X64/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe/DEBUG/MiscSubclass.
dll (ImageBase=0000000078DBA000, EntryPoint=0000000078DBEC3C) !!!!

I disaseembled MiscSubclass.debug and found that the address is a "ud2"
instruction at
SmBiosMiscDxe/MiscBaseBoardManufacturerFunction.c:MiscBaseBoardManufacturer()

After adding a few more debug messages, the system crashed at another
function:
SmBiosMiscDxe/MiscSystemManufacturerFunction.c:AddSmbiosManuCallback()

If I added debug messages to both functions, the system booted
successfully. I currently didn't have any clue on this.

3. The firmware always booted into EFI shell.

I guess something went wrong with BDS. I haven't looked into this issue
yet.

Thanks,

Gary Lin

> Thanks,
> 
> Mike
> 
> > -----Original Message-----
> > From: Gary Lin [mailto:GLin@suse.com]
> > Sent: Sunday, June 30, 2019 9:04 PM
> > To: devel@edk2.groups.io; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > <zailiang.sun@intel.com>
> > Subject: Re: [edk2-devel] [edk2-platforms Patch 00/14]
> > Vlv2TbltDevicePkg: Remove Intel Framework dependencies
> > 
> > On Sun, Jun 30, 2019 at 07:55:39PM -0700,  Michael D
> > Kinney  wrote:
> > > The following changes remove all dependencies on the
> > IntelFrameworkPkg
> > > and IntelFrameworkModulePkg from the Vlv2TbltDevicePkg
> > platform
> > > builds.  These changes do depend on updates binaries
> > on the edk2-non-osi repository.
> > >
> > Hi Michael,
> > 
> > I am amending the bash scripts for gcc. The firmware I
> > built is using the binaries from Development190216 and
> > could boot into Linux successfully with some workarounds
> > for Wpce791, Bds, and InteFspWrapper. The patches you
> > posted eliminate those parts I have to work around.
> > 
> > Just want to know if you need any assistance for the gcc
> > build? I could rebase my work upon your patches and send
> > them later.
> > 
> > Thanks,
> > 
> > Gary Lin
> > 
> 
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43158): https://edk2.groups.io/g/devel/message/43158
Mute This Topic: https://groups.io/mt/32267616/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Hi Gary,

Thanks for the branch.  I have the build working and
have reproduced the SMBIOS issue and am debugging that now.

Mike

> -----Original Message-----
> From: Gary Lin [mailto:GLin@suse.com]
> Sent: Tuesday, July 2, 2019 2:48 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> <zailiang.sun@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms Patch 00/14]
> Vlv2TbltDevicePkg: Remove Intel Framework dependencies
> 
> On Mon, Jul 01, 2019 at 11:07:11PM +0000,  Michael D
> Kinney  wrote:
> > Hi Gary,
> >
> > I recommend you rebase on top of this series.
> >
> > I have verified Linux boots and I have been working on
> the GCC and
> > Linux build scripts as well.
> >
> > Please let me know if you see any issues with this
> series applied and
> > I can help get them fixed.
> >
> Hi Mike,
> 
> I'm rebasing my patches and they are available in my
> branch:
> 
> https://github.com/lcp/edk2-platforms/commits/vlv2-
> fixes-wip
> 
> It's based on
> edk2(dcce9cbd48e07fcd11f7ef34cad48faf7bb61e6e)
> and edk2-non-
> osi(de0a6bc19c4ee0468f04e4d37035cdc59558137f).
> 
> There are 3 problems I currently encountered, and maybe
> you can give me some suggestions.
> 
> 1. Missing DSDT
> 
> When compiling DSDT, iasl failed with this error:
> 
> DSDT.iiii   6077:
> Or(ShiftLeft(Derefof(Index(CDCT,
> \_SB.PCI0.GFX0.MCHK.DCFE)), 21),PARM, PARM)
> Error    6163 -
> ^ Object is created temporarily in another method and
> cannot be accessed (\_SB.PCI0.GFX0. MCHK.DCFE)
> 
> The code is from
> Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOGB
> DA.ASL
> 
> I have to comment out the line or iasl won't generate
> the aml file and the OS would fail to get DSDT.
> 
> My acpica version is 20190509, and I vaguely remember
> that the older acpica seems to be more tolerant to this
> error.
> 
> 2. Crash at SMBIOS driver
> 
> When booting the system, I got the following error:
> 
> Loading driver at 0x00078DBA000 EntryPoint=0x00078DBEC3C
> MiscSubclass.efi
> InstallProtocolInterface: BC62157E-3E33-4FEC-9920-
> 2D3B36D750DF 78FE8D18 ProtectUefiImageCommon -
> 0x78FE8040
>   - 0x0000000078DBA000 - 0x0000000000007B80
> PlatformInfoHob->BoardId [0xB0]
> GetBiosVersionDateTime :MNW2MAX1.X64.0084.D01 01/01/2019
> 00:00
> SmbiosAdd: Smbios type 0 with size 0x48 is added to 32-
> bit table
> SmbiosAdd: Smbios type 0 with size 0x48 is added to 64-
> bit table
> SmbiosCreateTable: Initialize 32-bit entry point
> structure
> SmbiosCreateTable() re-allocate SMBIOS 32-bit table
> SmbiosCreateTable: Initialize 64-bit entry point
> structure
> SmbiosCreate64BitTable() re-allocate SMBIOS 64-bit table
> Create Smbios Manu callback.
> !!!! X64 Exception Type - 06(#UD - Invalid Opcode)  CPU
> Apic ID - 00000000 !!!!
> RIP  - 0000000078DBEC26, CS  - 0000000000000038, RFLAGS
> - 0000000000010206 RAX  - 0000000000000000, RCX -
> 000000007984A5A0, RDX - 000000007A46E5FF RBX  -
> 000000007A46E920, RSP - 000000007A46E8B0, RBP -
> 0000000078DC0EC0 RSI  - 0000000000000012, RDI -
> 0000000000000003
> R8   - 800000000000000E, R9  - 000000007A46E920, R10 -
> 0000000078FE8398
> R11  - 0000000000000001, R12 - 0000000078FE8798, R13 -
> 0000000078FE8898
> R14  - 0000000078FE8818, R15 - 000000007A46EC60
> DS   - 0000000000000030, ES  - 0000000000000030, FS  -
> 0000000000000030
> GS   - 0000000000000030, SS  - 0000000000000030
> CR0  - 0000000080010013, CR2 - 0000000000000000, CR3 -
> 000000007A201000
> CR4  - 0000000000000628, CR8 - 0000000000000000
> DR0  - 0000000000000000, DR1 - 0000000000000000, DR2 -
> 0000000000000000
> DR3  - 0000000000000000, DR6 - 00000000FFFF0FF8, DR7 -
> 0000000000000400 GDTR - 0000000079FFDA98
> 0000000000000047, LDTR - 0000000000000000
> IDTR - 0000000079862018 0000000000000FFF,   TR -
> 0000000000000000
> FXSAVE_STATE - 000000007A46E510
> !!!! Find image based on IP(0x78DBEC26)
> /home/gary/git/edk2-
> workspace/Build/Vlv2TbltDevicePkg/DEBUG_GCC5/X64/Vlv2Tbl
> tDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe/DEBUG/MiscSubclas
> s.
> dll (ImageBase=0000000078DBA000,
> EntryPoint=0000000078DBEC3C) !!!!
> 
> I disaseembled MiscSubclass.debug and found that the
> address is a "ud2"
> instruction at
> SmBiosMiscDxe/MiscBaseBoardManufacturerFunction.c:MiscBa
> seBoardManufacturer()
> 
> After adding a few more debug messages, the system
> crashed at another
> function:
> SmBiosMiscDxe/MiscSystemManufacturerFunction.c:AddSmbios
> ManuCallback()
> 
> If I added debug messages to both functions, the system
> booted successfully. I currently didn't have any clue on
> this.
> 
> 3. The firmware always booted into EFI shell.
> 
> I guess something went wrong with BDS. I haven't looked
> into this issue yet.
> 
> Thanks,
> 
> Gary Lin
> 
> > Thanks,
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: Gary Lin [mailto:GLin@suse.com]
> > > Sent: Sunday, June 30, 2019 9:04 PM
> > > To: devel@edk2.groups.io; Kinney, Michael D
> > > <michael.d.kinney@intel.com>
> > > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > > <zailiang.sun@intel.com>
> > > Subject: Re: [edk2-devel] [edk2-platforms Patch
> 00/14]
> > > Vlv2TbltDevicePkg: Remove Intel Framework
> dependencies
> > >
> > > On Sun, Jun 30, 2019 at 07:55:39PM -0700,  Michael D
> Kinney  wrote:
> > > > The following changes remove all dependencies on
> the
> > > IntelFrameworkPkg
> > > > and IntelFrameworkModulePkg from the
> Vlv2TbltDevicePkg
> > > platform
> > > > builds.  These changes do depend on updates
> binaries
> > > on the edk2-non-osi repository.
> > > >
> > > Hi Michael,
> > >
> > > I am amending the bash scripts for gcc. The firmware
> I built is
> > > using the binaries from Development190216 and could
> boot into Linux
> > > successfully with some workarounds for Wpce791, Bds,
> and
> > > InteFspWrapper. The patches you posted eliminate
> those parts I have
> > > to work around.
> > >
> > > Just want to know if you need any assistance for the
> gcc build? I
> > > could rebase my work upon your patches and send them
> later.
> > >
> > > Thanks,
> > >
> > > Gary Lin
> > >
> > 
> >
> >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43182): https://edk2.groups.io/g/devel/message/43182
Mute This Topic: https://groups.io/mt/32267616/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Hi Gary,

I have posted an update to your patches the removes the setting of WORKSPACE
and accesses all files relative to WORKSPACE in the Linux shell scripts.
It also fixes null pointer bugs in the SmbiosMiscDxe module.

https://github.com/mdkinney/edk2-platforms/tree/Bug_xxx_Vlv2_Linux_And_Smbios_Fixes

With these changes I can boot to the UEFI Shell and to Linux.  Please verify from
your environments.

I see you have added the SDMMC modules, but I do not see that peripheral yet.
That feature looks like it needs some more debug.  We may need to back out those
changes for now.

I agree there are ASL issues.  The ASL code needs to be updated to the 
latest ASL compiler.

Thanks,

Mike

> -----Original Message-----
> From: Kinney, Michael D
> Sent: Tuesday, July 2, 2019 9:50 AM
> To: Gary Lin <GLin@suse.com>; devel@edk2.groups.io;
> Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> <zailiang.sun@intel.com>
> Subject: RE: [edk2-devel] [edk2-platforms Patch 00/14]
> Vlv2TbltDevicePkg: Remove Intel Framework dependencies
> 
> Hi Gary,
> 
> Thanks for the branch.  I have the build working and have
> reproduced the SMBIOS issue and am debugging that now.
> 
> Mike
> 
> > -----Original Message-----
> > From: Gary Lin [mailto:GLin@suse.com]
> > Sent: Tuesday, July 2, 2019 2:48 AM
> > To: devel@edk2.groups.io; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > <zailiang.sun@intel.com>
> > Subject: Re: [edk2-devel] [edk2-platforms Patch 00/14]
> > Vlv2TbltDevicePkg: Remove Intel Framework dependencies
> >
> > On Mon, Jul 01, 2019 at 11:07:11PM +0000,  Michael D
> Kinney  wrote:
> > > Hi Gary,
> > >
> > > I recommend you rebase on top of this series.
> > >
> > > I have verified Linux boots and I have been working
> on
> > the GCC and
> > > Linux build scripts as well.
> > >
> > > Please let me know if you see any issues with this
> > series applied and
> > > I can help get them fixed.
> > >
> > Hi Mike,
> >
> > I'm rebasing my patches and they are available in my
> > branch:
> >
> > https://github.com/lcp/edk2-platforms/commits/vlv2-
> > fixes-wip
> >
> > It's based on
> > edk2(dcce9cbd48e07fcd11f7ef34cad48faf7bb61e6e)
> > and edk2-non-
> > osi(de0a6bc19c4ee0468f04e4d37035cdc59558137f).
> >
> > There are 3 problems I currently encountered, and maybe
> you can give
> > me some suggestions.
> >
> > 1. Missing DSDT
> >
> > When compiling DSDT, iasl failed with this error:
> >
> > DSDT.iiii   6077:
> > Or(ShiftLeft(Derefof(Index(CDCT,
> > \_SB.PCI0.GFX0.MCHK.DCFE)), 21),PARM, PARM)
> > Error    6163 -
> > ^ Object is created temporarily in another method and
> cannot be
> > accessed (\_SB.PCI0.GFX0. MCHK.DCFE)
> >
> > The code is from
> >
> Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOGB
> > DA.ASL
> >
> > I have to comment out the line or iasl won't generate
> the aml file and
> > the OS would fail to get DSDT.
> >
> > My acpica version is 20190509, and I vaguely remember
> that the older
> > acpica seems to be more tolerant to this error.
> >
> > 2. Crash at SMBIOS driver
> >
> > When booting the system, I got the following error:
> >
> > Loading driver at 0x00078DBA000
> EntryPoint=0x00078DBEC3C
> > MiscSubclass.efi
> > InstallProtocolInterface: BC62157E-3E33-4FEC-9920-
> 2D3B36D750DF
> > 78FE8D18 ProtectUefiImageCommon -
> > 0x78FE8040
> >   - 0x0000000078DBA000 - 0x0000000000007B80
> > PlatformInfoHob->BoardId [0xB0]
> > GetBiosVersionDateTime :MNW2MAX1.X64.0084.D01
> 01/01/2019
> > 00:00
> > SmbiosAdd: Smbios type 0 with size 0x48 is added to 32-
> bit table
> > SmbiosAdd: Smbios type 0 with size 0x48 is added to 64-
> bit table
> > SmbiosCreateTable: Initialize 32-bit entry point
> structure
> > SmbiosCreateTable() re-allocate SMBIOS 32-bit table
> > SmbiosCreateTable: Initialize 64-bit entry point
> structure
> > SmbiosCreate64BitTable() re-allocate SMBIOS 64-bit
> table Create Smbios
> > Manu callback.
> > !!!! X64 Exception Type - 06(#UD - Invalid Opcode)  CPU
> Apic ID -
> > 00000000 !!!!
> > RIP  - 0000000078DBEC26, CS  - 0000000000000038, RFLAGS
> > - 0000000000010206 RAX  - 0000000000000000, RCX -
> 000000007984A5A0,
> > RDX - 000000007A46E5FF RBX  - 000000007A46E920, RSP -
> > 000000007A46E8B0, RBP -
> > 0000000078DC0EC0 RSI  - 0000000000000012, RDI -
> > 0000000000000003
> > R8   - 800000000000000E, R9  - 000000007A46E920, R10 -
> > 0000000078FE8398
> > R11  - 0000000000000001, R12 - 0000000078FE8798, R13 -
> > 0000000078FE8898
> > R14  - 0000000078FE8818, R15 - 000000007A46EC60
> > DS   - 0000000000000030, ES  - 0000000000000030, FS  -
> > 0000000000000030
> > GS   - 0000000000000030, SS  - 0000000000000030
> > CR0  - 0000000080010013, CR2 - 0000000000000000, CR3 -
> > 000000007A201000
> > CR4  - 0000000000000628, CR8 - 0000000000000000
> > DR0  - 0000000000000000, DR1 - 0000000000000000, DR2 -
> > 0000000000000000
> > DR3  - 0000000000000000, DR6 - 00000000FFFF0FF8, DR7 -
> > 0000000000000400 GDTR - 0000000079FFDA98
> 0000000000000047, LDTR -
> > 0000000000000000
> > IDTR - 0000000079862018 0000000000000FFF,   TR -
> > 0000000000000000
> > FXSAVE_STATE - 000000007A46E510
> > !!!! Find image based on IP(0x78DBEC26)
> > /home/gary/git/edk2-
> >
> workspace/Build/Vlv2TbltDevicePkg/DEBUG_GCC5/X64/Vlv2Tbl
> >
> tDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe/DEBUG/MiscSubclas
> > s.
> > dll (ImageBase=0000000078DBA000,
> > EntryPoint=0000000078DBEC3C) !!!!
> >
> > I disaseembled MiscSubclass.debug and found that the
> address is a
> > "ud2"
> > instruction at
> >
> SmBiosMiscDxe/MiscBaseBoardManufacturerFunction.c:MiscBa
> > seBoardManufacturer()
> >
> > After adding a few more debug messages, the system
> crashed at another
> > function:
> >
> SmBiosMiscDxe/MiscSystemManufacturerFunction.c:AddSmbios
> > ManuCallback()
> >
> > If I added debug messages to both functions, the system
> booted
> > successfully. I currently didn't have any clue on this.
> >
> > 3. The firmware always booted into EFI shell.
> >
> > I guess something went wrong with BDS. I haven't looked
> into this
> > issue yet.
> >
> > Thanks,
> >
> > Gary Lin
> >
> > > Thanks,
> > >
> > > Mike
> > >
> > > > -----Original Message-----
> > > > From: Gary Lin [mailto:GLin@suse.com]
> > > > Sent: Sunday, June 30, 2019 9:04 PM
> > > > To: devel@edk2.groups.io; Kinney, Michael D
> > > > <michael.d.kinney@intel.com>
> > > > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > > > <zailiang.sun@intel.com>
> > > > Subject: Re: [edk2-devel] [edk2-platforms Patch
> > 00/14]
> > > > Vlv2TbltDevicePkg: Remove Intel Framework
> > dependencies
> > > >
> > > > On Sun, Jun 30, 2019 at 07:55:39PM -0700,  Michael
> D
> > Kinney  wrote:
> > > > > The following changes remove all dependencies on
> > the
> > > > IntelFrameworkPkg
> > > > > and IntelFrameworkModulePkg from the
> > Vlv2TbltDevicePkg
> > > > platform
> > > > > builds.  These changes do depend on updates
> > binaries
> > > > on the edk2-non-osi repository.
> > > > >
> > > > Hi Michael,
> > > >
> > > > I am amending the bash scripts for gcc. The
> firmware
> > I built is
> > > > using the binaries from Development190216 and could
> > boot into Linux
> > > > successfully with some workarounds for Wpce791,
> Bds,
> > and
> > > > InteFspWrapper. The patches you posted eliminate
> > those parts I have
> > > > to work around.
> > > >
> > > > Just want to know if you need any assistance for
> the
> > gcc build? I
> > > > could rebase my work upon your patches and send
> them
> > later.
> > > >
> > > > Thanks,
> > > >
> > > > Gary Lin
> > > >
> > > 
> > >
> > >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43184): https://edk2.groups.io/g/devel/message/43184
Mute This Topic: https://groups.io/mt/32267616/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

On Tue, Jul 02, 2019 at 09:11:06PM +0000,  Kinney, Michael D  wrote:
> Hi Gary,
> 
Hi Mike,

> I have posted an update to your patches the removes the setting of WORKSPACE
> and accesses all files relative to WORKSPACE in the Linux shell scripts.
> It also fixes null pointer bugs in the SmbiosMiscDxe module.
> 
> https://github.com/mdkinney/edk2-platforms/tree/Bug_xxx_Vlv2_Linux_And_Smbios_Fixes
> 
> With these changes I can boot to the UEFI Shell and to Linux.  Please verify from
> your environments.
> 
The fix for SmbiosMiscDxe works for me. Thanks for that!

I pushed another commit to my branch to check WORKSPACE to notify the
user:

https://github.com/lcp/edk2-platforms/commit/fc530689e913e3de25ca2c553d616b9cef28901c

We probably have to update Readme.md later. It's already dated.

> I see you have added the SDMMC modules, but I do not see that peripheral yet.
> That feature looks like it needs some more debug.  We may need to back out those
> changes for now.
> 
I saw the SD card settings in the South Cluster Configuration menu even
without those SDMMC modules, so they are probably from the edk2-non-osi
drivers. However, the SD card didn't work until I added the drivers from
MdeModulePkg, so I need those drivers at least for my Minnowboard Turbot.

Thanks,

Gary Lin

> I agree there are ASL issues.  The ASL code needs to be updated to the 
> latest ASL compiler.
> 
> Thanks,
> 
> Mike
> 
> > -----Original Message-----
> > From: Kinney, Michael D
> > Sent: Tuesday, July 2, 2019 9:50 AM
> > To: Gary Lin <GLin@suse.com>; devel@edk2.groups.io;
> > Kinney, Michael D <michael.d.kinney@intel.com>
> > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > <zailiang.sun@intel.com>
> > Subject: RE: [edk2-devel] [edk2-platforms Patch 00/14]
> > Vlv2TbltDevicePkg: Remove Intel Framework dependencies
> > 
> > Hi Gary,
> > 
> > Thanks for the branch.  I have the build working and have
> > reproduced the SMBIOS issue and am debugging that now.
> > 
> > Mike
> > 
> > > -----Original Message-----
> > > From: Gary Lin [mailto:GLin@suse.com]
> > > Sent: Tuesday, July 2, 2019 2:48 AM
> > > To: devel@edk2.groups.io; Kinney, Michael D
> > > <michael.d.kinney@intel.com>
> > > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > > <zailiang.sun@intel.com>
> > > Subject: Re: [edk2-devel] [edk2-platforms Patch 00/14]
> > > Vlv2TbltDevicePkg: Remove Intel Framework dependencies
> > >
> > > On Mon, Jul 01, 2019 at 11:07:11PM +0000,  Michael D
> > Kinney  wrote:
> > > > Hi Gary,
> > > >
> > > > I recommend you rebase on top of this series.
> > > >
> > > > I have verified Linux boots and I have been working
> > on
> > > the GCC and
> > > > Linux build scripts as well.
> > > >
> > > > Please let me know if you see any issues with this
> > > series applied and
> > > > I can help get them fixed.
> > > >
> > > Hi Mike,
> > >
> > > I'm rebasing my patches and they are available in my
> > > branch:
> > >
> > > https://github.com/lcp/edk2-platforms/commits/vlv2-
> > > fixes-wip
> > >
> > > It's based on
> > > edk2(dcce9cbd48e07fcd11f7ef34cad48faf7bb61e6e)
> > > and edk2-non-
> > > osi(de0a6bc19c4ee0468f04e4d37035cdc59558137f).
> > >
> > > There are 3 problems I currently encountered, and maybe
> > you can give
> > > me some suggestions.
> > >
> > > 1. Missing DSDT
> > >
> > > When compiling DSDT, iasl failed with this error:
> > >
> > > DSDT.iiii   6077:
> > > Or(ShiftLeft(Derefof(Index(CDCT,
> > > \_SB.PCI0.GFX0.MCHK.DCFE)), 21),PARM, PARM)
> > > Error    6163 -
> > > ^ Object is created temporarily in another method and
> > cannot be
> > > accessed (\_SB.PCI0.GFX0. MCHK.DCFE)
> > >
> > > The code is from
> > >
> > Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOGB
> > > DA.ASL
> > >
> > > I have to comment out the line or iasl won't generate
> > the aml file and
> > > the OS would fail to get DSDT.
> > >
> > > My acpica version is 20190509, and I vaguely remember
> > that the older
> > > acpica seems to be more tolerant to this error.
> > >
> > > 2. Crash at SMBIOS driver
> > >
> > > When booting the system, I got the following error:
> > >
> > > Loading driver at 0x00078DBA000
> > EntryPoint=0x00078DBEC3C
> > > MiscSubclass.efi
> > > InstallProtocolInterface: BC62157E-3E33-4FEC-9920-
> > 2D3B36D750DF
> > > 78FE8D18 ProtectUefiImageCommon -
> > > 0x78FE8040
> > >   - 0x0000000078DBA000 - 0x0000000000007B80
> > > PlatformInfoHob->BoardId [0xB0]
> > > GetBiosVersionDateTime :MNW2MAX1.X64.0084.D01
> > 01/01/2019
> > > 00:00
> > > SmbiosAdd: Smbios type 0 with size 0x48 is added to 32-
> > bit table
> > > SmbiosAdd: Smbios type 0 with size 0x48 is added to 64-
> > bit table
> > > SmbiosCreateTable: Initialize 32-bit entry point
> > structure
> > > SmbiosCreateTable() re-allocate SMBIOS 32-bit table
> > > SmbiosCreateTable: Initialize 64-bit entry point
> > structure
> > > SmbiosCreate64BitTable() re-allocate SMBIOS 64-bit
> > table Create Smbios
> > > Manu callback.
> > > !!!! X64 Exception Type - 06(#UD - Invalid Opcode)  CPU
> > Apic ID -
> > > 00000000 !!!!
> > > RIP  - 0000000078DBEC26, CS  - 0000000000000038, RFLAGS
> > > - 0000000000010206 RAX  - 0000000000000000, RCX -
> > 000000007984A5A0,
> > > RDX - 000000007A46E5FF RBX  - 000000007A46E920, RSP -
> > > 000000007A46E8B0, RBP -
> > > 0000000078DC0EC0 RSI  - 0000000000000012, RDI -
> > > 0000000000000003
> > > R8   - 800000000000000E, R9  - 000000007A46E920, R10 -
> > > 0000000078FE8398
> > > R11  - 0000000000000001, R12 - 0000000078FE8798, R13 -
> > > 0000000078FE8898
> > > R14  - 0000000078FE8818, R15 - 000000007A46EC60
> > > DS   - 0000000000000030, ES  - 0000000000000030, FS  -
> > > 0000000000000030
> > > GS   - 0000000000000030, SS  - 0000000000000030
> > > CR0  - 0000000080010013, CR2 - 0000000000000000, CR3 -
> > > 000000007A201000
> > > CR4  - 0000000000000628, CR8 - 0000000000000000
> > > DR0  - 0000000000000000, DR1 - 0000000000000000, DR2 -
> > > 0000000000000000
> > > DR3  - 0000000000000000, DR6 - 00000000FFFF0FF8, DR7 -
> > > 0000000000000400 GDTR - 0000000079FFDA98
> > 0000000000000047, LDTR -
> > > 0000000000000000
> > > IDTR - 0000000079862018 0000000000000FFF,   TR -
> > > 0000000000000000
> > > FXSAVE_STATE - 000000007A46E510
> > > !!!! Find image based on IP(0x78DBEC26)
> > > /home/gary/git/edk2-
> > >
> > workspace/Build/Vlv2TbltDevicePkg/DEBUG_GCC5/X64/Vlv2Tbl
> > >
> > tDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe/DEBUG/MiscSubclas
> > > s.
> > > dll (ImageBase=0000000078DBA000,
> > > EntryPoint=0000000078DBEC3C) !!!!
> > >
> > > I disaseembled MiscSubclass.debug and found that the
> > address is a
> > > "ud2"
> > > instruction at
> > >
> > SmBiosMiscDxe/MiscBaseBoardManufacturerFunction.c:MiscBa
> > > seBoardManufacturer()
> > >
> > > After adding a few more debug messages, the system
> > crashed at another
> > > function:
> > >
> > SmBiosMiscDxe/MiscSystemManufacturerFunction.c:AddSmbios
> > > ManuCallback()
> > >
> > > If I added debug messages to both functions, the system
> > booted
> > > successfully. I currently didn't have any clue on this.
> > >
> > > 3. The firmware always booted into EFI shell.
> > >
> > > I guess something went wrong with BDS. I haven't looked
> > into this
> > > issue yet.
> > >
> > > Thanks,
> > >
> > > Gary Lin
> > >
> > > > Thanks,
> > > >
> > > > Mike
> > > >
> > > > > -----Original Message-----
> > > > > From: Gary Lin [mailto:GLin@suse.com]
> > > > > Sent: Sunday, June 30, 2019 9:04 PM
> > > > > To: devel@edk2.groups.io; Kinney, Michael D
> > > > > <michael.d.kinney@intel.com>
> > > > > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > > > > <zailiang.sun@intel.com>
> > > > > Subject: Re: [edk2-devel] [edk2-platforms Patch
> > > 00/14]
> > > > > Vlv2TbltDevicePkg: Remove Intel Framework
> > > dependencies
> > > > >
> > > > > On Sun, Jun 30, 2019 at 07:55:39PM -0700,  Michael
> > D
> > > Kinney  wrote:
> > > > > > The following changes remove all dependencies on
> > > the
> > > > > IntelFrameworkPkg
> > > > > > and IntelFrameworkModulePkg from the
> > > Vlv2TbltDevicePkg
> > > > > platform
> > > > > > builds.  These changes do depend on updates
> > > binaries
> > > > > on the edk2-non-osi repository.
> > > > > >
> > > > > Hi Michael,
> > > > >
> > > > > I am amending the bash scripts for gcc. The
> > firmware
> > > I built is
> > > > > using the binaries from Development190216 and could
> > > boot into Linux
> > > > > successfully with some workarounds for Wpce791,
> > Bds,
> > > and
> > > > > InteFspWrapper. The patches you posted eliminate
> > > those parts I have
> > > > > to work around.
> > > > >
> > > > > Just want to know if you need any assistance for
> > the
> > > gcc build? I
> > > > > could rebase my work upon your patches and send
> > them
> > > later.
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Gary Lin
> > > > >
> > > > 
> > > >
> > > >
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43195): https://edk2.groups.io/g/devel/message/43195
Mute This Topic: https://groups.io/mt/32267616/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Hi Gary,

I picked up the changes on your branch.  I re-enabled the BIOS ID
Feature and added support for IA32 GCC builds, so the builds
available from Windows and Linux are matched now.

I have posted my updated branch here:

https://github.com/mdkinney/edk2-platforms/tree/Bug_xxx_Vlv2_Linux_And_Smbios_Fixes_V2

I also verified that the SD Card support does work, so I am
keeping that change.

I agree the Readme is out of date.  I will work on that and
add to the branch referenced above tomorrow.

Thanks,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
> On Behalf Of Gary Lin
> Sent: Tuesday, July 2, 2019 8:57 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: devel@edk2.groups.io; Qian, Yi <yi.qian@intel.com>;
> Sun, Zailiang <zailiang.sun@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms Patch 00/14]
> Vlv2TbltDevicePkg: Remove Intel Framework dependencies
> 
> On Tue, Jul 02, 2019 at 09:11:06PM +0000,  Kinney,
> Michael D  wrote:
> > Hi Gary,
> >
> Hi Mike,
> 
> > I have posted an update to your patches the removes the
> setting of
> > WORKSPACE and accesses all files relative to WORKSPACE
> in the Linux shell scripts.
> > It also fixes null pointer bugs in the SmbiosMiscDxe
> module.
> >
> > https://github.com/mdkinney/edk2-
> platforms/tree/Bug_xxx_Vlv2_Linux_And
> > _Smbios_Fixes
> >
> > With these changes I can boot to the UEFI Shell and to
> Linux.  Please
> > verify from your environments.
> >
> The fix for SmbiosMiscDxe works for me. Thanks for that!
> 
> I pushed another commit to my branch to check WORKSPACE
> to notify the
> user:
> 
> https://github.com/lcp/edk2-
> platforms/commit/fc530689e913e3de25ca2c553d616b9cef28901c
> 
> We probably have to update Readme.md later. It's already
> dated.
> 
> > I see you have added the SDMMC modules, but I do not
> see that peripheral yet.
> > That feature looks like it needs some more debug.  We
> may need to back
> > out those changes for now.
> >
> I saw the SD card settings in the South Cluster
> Configuration menu even without those SDMMC modules, so
> they are probably from the edk2-non-osi drivers. However,
> the SD card didn't work until I added the drivers from
> MdeModulePkg, so I need those drivers at least for my
> Minnowboard Turbot.
> 
> Thanks,
> 
> Gary Lin
> 
> > I agree there are ASL issues.  The ASL code needs to be
> updated to the
> > latest ASL compiler.
> >
> > Thanks,
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: Kinney, Michael D
> > > Sent: Tuesday, July 2, 2019 9:50 AM
> > > To: Gary Lin <GLin@suse.com>; devel@edk2.groups.io;
> Kinney, Michael
> > > D <michael.d.kinney@intel.com>
> > > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > > <zailiang.sun@intel.com>
> > > Subject: RE: [edk2-devel] [edk2-platforms Patch
> 00/14]
> > > Vlv2TbltDevicePkg: Remove Intel Framework
> dependencies
> > >
> > > Hi Gary,
> > >
> > > Thanks for the branch.  I have the build working and
> have reproduced
> > > the SMBIOS issue and am debugging that now.
> > >
> > > Mike
> > >
> > > > -----Original Message-----
> > > > From: Gary Lin [mailto:GLin@suse.com]
> > > > Sent: Tuesday, July 2, 2019 2:48 AM
> > > > To: devel@edk2.groups.io; Kinney, Michael D
> > > > <michael.d.kinney@intel.com>
> > > > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > > > <zailiang.sun@intel.com>
> > > > Subject: Re: [edk2-devel] [edk2-platforms Patch
> 00/14]
> > > > Vlv2TbltDevicePkg: Remove Intel Framework
> dependencies
> > > >
> > > > On Mon, Jul 01, 2019 at 11:07:11PM +0000,  Michael
> D
> > > Kinney  wrote:
> > > > > Hi Gary,
> > > > >
> > > > > I recommend you rebase on top of this series.
> > > > >
> > > > > I have verified Linux boots and I have been
> working
> > > on
> > > > the GCC and
> > > > > Linux build scripts as well.
> > > > >
> > > > > Please let me know if you see any issues with
> this
> > > > series applied and
> > > > > I can help get them fixed.
> > > > >
> > > > Hi Mike,
> > > >
> > > > I'm rebasing my patches and they are available in
> my
> > > > branch:
> > > >
> > > > https://github.com/lcp/edk2-platforms/commits/vlv2-
> > > > fixes-wip
> > > >
> > > > It's based on
> > > > edk2(dcce9cbd48e07fcd11f7ef34cad48faf7bb61e6e)
> > > > and edk2-non-
> > > > osi(de0a6bc19c4ee0468f04e4d37035cdc59558137f).
> > > >
> > > > There are 3 problems I currently encountered, and
> maybe
> > > you can give
> > > > me some suggestions.
> > > >
> > > > 1. Missing DSDT
> > > >
> > > > When compiling DSDT, iasl failed with this error:
> > > >
> > > > DSDT.iiii   6077:
> > > > Or(ShiftLeft(Derefof(Index(CDCT,
> > > > \_SB.PCI0.GFX0.MCHK.DCFE)), 21),PARM, PARM)
> > > > Error    6163 -
> > > > ^ Object is created temporarily in another method
> and
> > > cannot be
> > > > accessed (\_SB.PCI0.GFX0. MCHK.DCFE)
> > > >
> > > > The code is from
> > > >
> > >
> Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOGB
> > > > DA.ASL
> > > >
> > > > I have to comment out the line or iasl won't
> generate
> > > the aml file and
> > > > the OS would fail to get DSDT.
> > > >
> > > > My acpica version is 20190509, and I vaguely
> remember
> > > that the older
> > > > acpica seems to be more tolerant to this error.
> > > >
> > > > 2. Crash at SMBIOS driver
> > > >
> > > > When booting the system, I got the following error:
> > > >
> > > > Loading driver at 0x00078DBA000
> > > EntryPoint=0x00078DBEC3C
> > > > MiscSubclass.efi
> > > > InstallProtocolInterface: BC62157E-3E33-4FEC-9920-
> > > 2D3B36D750DF
> > > > 78FE8D18 ProtectUefiImageCommon -
> > > > 0x78FE8040
> > > >   - 0x0000000078DBA000 - 0x0000000000007B80
> > > > PlatformInfoHob->BoardId [0xB0]
> > > > GetBiosVersionDateTime :MNW2MAX1.X64.0084.D01
> > > 01/01/2019
> > > > 00:00
> > > > SmbiosAdd: Smbios type 0 with size 0x48 is added to
> 32-
> > > bit table
> > > > SmbiosAdd: Smbios type 0 with size 0x48 is added to
> 64-
> > > bit table
> > > > SmbiosCreateTable: Initialize 32-bit entry point
> > > structure
> > > > SmbiosCreateTable() re-allocate SMBIOS 32-bit table
> > > > SmbiosCreateTable: Initialize 64-bit entry point
> > > structure
> > > > SmbiosCreate64BitTable() re-allocate SMBIOS 64-bit
> > > table Create Smbios
> > > > Manu callback.
> > > > !!!! X64 Exception Type - 06(#UD - Invalid Opcode)
> CPU
> > > Apic ID -
> > > > 00000000 !!!!
> > > > RIP  - 0000000078DBEC26, CS  - 0000000000000038,
> RFLAGS
> > > > - 0000000000010206 RAX  - 0000000000000000, RCX -
> > > 000000007984A5A0,
> > > > RDX - 000000007A46E5FF RBX  - 000000007A46E920, RSP
> -
> > > > 000000007A46E8B0, RBP -
> > > > 0000000078DC0EC0 RSI  - 0000000000000012, RDI -
> > > > 0000000000000003
> > > > R8   - 800000000000000E, R9  - 000000007A46E920,
> R10 -
> > > > 0000000078FE8398
> > > > R11  - 0000000000000001, R12 - 0000000078FE8798,
> R13 -
> > > > 0000000078FE8898
> > > > R14  - 0000000078FE8818, R15 - 000000007A46EC60
> > > > DS   - 0000000000000030, ES  - 0000000000000030, FS
> -
> > > > 0000000000000030
> > > > GS   - 0000000000000030, SS  - 0000000000000030
> > > > CR0  - 0000000080010013, CR2 - 0000000000000000,
> CR3 -
> > > > 000000007A201000
> > > > CR4  - 0000000000000628, CR8 - 0000000000000000
> > > > DR0  - 0000000000000000, DR1 - 0000000000000000,
> DR2 -
> > > > 0000000000000000
> > > > DR3  - 0000000000000000, DR6 - 00000000FFFF0FF8,
> DR7 -
> > > > 0000000000000400 GDTR - 0000000079FFDA98
> > > 0000000000000047, LDTR -
> > > > 0000000000000000
> > > > IDTR - 0000000079862018 0000000000000FFF,   TR -
> > > > 0000000000000000
> > > > FXSAVE_STATE - 000000007A46E510
> > > > !!!! Find image based on IP(0x78DBEC26)
> > > > /home/gary/git/edk2-
> > > >
> > >
> workspace/Build/Vlv2TbltDevicePkg/DEBUG_GCC5/X64/Vlv2Tbl
> > > >
> > >
> tDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe/DEBUG/MiscSubclas
> > > > s.
> > > > dll (ImageBase=0000000078DBA000,
> > > > EntryPoint=0000000078DBEC3C) !!!!
> > > >
> > > > I disaseembled MiscSubclass.debug and found that
> the
> > > address is a
> > > > "ud2"
> > > > instruction at
> > > >
> > >
> SmBiosMiscDxe/MiscBaseBoardManufacturerFunction.c:MiscBa
> > > > seBoardManufacturer()
> > > >
> > > > After adding a few more debug messages, the system
> > > crashed at another
> > > > function:
> > > >
> > >
> SmBiosMiscDxe/MiscSystemManufacturerFunction.c:AddSmbios
> > > > ManuCallback()
> > > >
> > > > If I added debug messages to both functions, the
> system
> > > booted
> > > > successfully. I currently didn't have any clue on
> this.
> > > >
> > > > 3. The firmware always booted into EFI shell.
> > > >
> > > > I guess something went wrong with BDS. I haven't
> looked
> > > into this
> > > > issue yet.
> > > >
> > > > Thanks,
> > > >
> > > > Gary Lin
> > > >
> > > > > Thanks,
> > > > >
> > > > > Mike
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Gary Lin [mailto:GLin@suse.com]
> > > > > > Sent: Sunday, June 30, 2019 9:04 PM
> > > > > > To: devel@edk2.groups.io; Kinney, Michael D
> > > > > > <michael.d.kinney@intel.com>
> > > > > > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > > > > > <zailiang.sun@intel.com>
> > > > > > Subject: Re: [edk2-devel] [edk2-platforms Patch
> > > > 00/14]
> > > > > > Vlv2TbltDevicePkg: Remove Intel Framework
> > > > dependencies
> > > > > >
> > > > > > On Sun, Jun 30, 2019 at 07:55:39PM -0700,
> Michael
> > > D
> > > > Kinney  wrote:
> > > > > > > The following changes remove all dependencies
> on
> > > > the
> > > > > > IntelFrameworkPkg
> > > > > > > and IntelFrameworkModulePkg from the
> > > > Vlv2TbltDevicePkg
> > > > > > platform
> > > > > > > builds.  These changes do depend on updates
> > > > binaries
> > > > > > on the edk2-non-osi repository.
> > > > > > >
> > > > > > Hi Michael,
> > > > > >
> > > > > > I am amending the bash scripts for gcc. The
> > > firmware
> > > > I built is
> > > > > > using the binaries from Development190216 and
> could
> > > > boot into Linux
> > > > > > successfully with some workarounds for Wpce791,
> > > Bds,
> > > > and
> > > > > > InteFspWrapper. The patches you posted
> eliminate
> > > > those parts I have
> > > > > > to work around.
> > > > > >
> > > > > > Just want to know if you need any assistance
> for
> > > the
> > > > gcc build? I
> > > > > > could rebase my work upon your patches and send
> > > them
> > > > later.
> > > > > >
> > > > > > Thanks,
> > > > > >
> > > > > > Gary Lin
> > > > > >
> > > > >
> > > > >
> > > > >
> >
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43418): https://edk2.groups.io/g/devel/message/43418
Mute This Topic: https://groups.io/mt/32267616/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

On Tue, Jul 09, 2019 at 03:52:37AM +0000,  Michael D Kinney  wrote:
> Hi Gary,
> 
Hi Mike,

> I picked up the changes on your branch.  I re-enabled the BIOS ID
> Feature and added support for IA32 GCC builds, so the builds
> available from Windows and Linux are matched now.
> 
> I have posted my updated branch here:
> 
> https://github.com/mdkinney/edk2-platforms/tree/Bug_xxx_Vlv2_Linux_And_Smbios_Fixes_V2
> 
> I also verified that the SD Card support does work, so I am
> keeping that change.
> 
I tested the branch + my ASL workaround and booted into Linux
successfully.

> I agree the Readme is out of date.  I will work on that and
> add to the branch referenced above tomorrow.
> 
Thanks!

Gary Lin

> Thanks,
> 
> Mike
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
> > On Behalf Of Gary Lin
> > Sent: Tuesday, July 2, 2019 8:57 PM
> > To: Kinney, Michael D <michael.d.kinney@intel.com>
> > Cc: devel@edk2.groups.io; Qian, Yi <yi.qian@intel.com>;
> > Sun, Zailiang <zailiang.sun@intel.com>
> > Subject: Re: [edk2-devel] [edk2-platforms Patch 00/14]
> > Vlv2TbltDevicePkg: Remove Intel Framework dependencies
> > 
> > On Tue, Jul 02, 2019 at 09:11:06PM +0000,  Kinney,
> > Michael D  wrote:
> > > Hi Gary,
> > >
> > Hi Mike,
> > 
> > > I have posted an update to your patches the removes the
> > setting of
> > > WORKSPACE and accesses all files relative to WORKSPACE
> > in the Linux shell scripts.
> > > It also fixes null pointer bugs in the SmbiosMiscDxe
> > module.
> > >
> > > https://github.com/mdkinney/edk2-
> > platforms/tree/Bug_xxx_Vlv2_Linux_And
> > > _Smbios_Fixes
> > >
> > > With these changes I can boot to the UEFI Shell and to
> > Linux.  Please
> > > verify from your environments.
> > >
> > The fix for SmbiosMiscDxe works for me. Thanks for that!
> > 
> > I pushed another commit to my branch to check WORKSPACE
> > to notify the
> > user:
> > 
> > https://github.com/lcp/edk2-
> > platforms/commit/fc530689e913e3de25ca2c553d616b9cef28901c
> > 
> > We probably have to update Readme.md later. It's already
> > dated.
> > 
> > > I see you have added the SDMMC modules, but I do not
> > see that peripheral yet.
> > > That feature looks like it needs some more debug.  We
> > may need to back
> > > out those changes for now.
> > >
> > I saw the SD card settings in the South Cluster
> > Configuration menu even without those SDMMC modules, so
> > they are probably from the edk2-non-osi drivers. However,
> > the SD card didn't work until I added the drivers from
> > MdeModulePkg, so I need those drivers at least for my
> > Minnowboard Turbot.
> > 
> > Thanks,
> > 
> > Gary Lin
> > 
> > > I agree there are ASL issues.  The ASL code needs to be
> > updated to the
> > > latest ASL compiler.
> > >
> > > Thanks,
> > >
> > > Mike
> > >
> > > > -----Original Message-----
> > > > From: Kinney, Michael D
> > > > Sent: Tuesday, July 2, 2019 9:50 AM
> > > > To: Gary Lin <GLin@suse.com>; devel@edk2.groups.io;
> > Kinney, Michael
> > > > D <michael.d.kinney@intel.com>
> > > > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > > > <zailiang.sun@intel.com>
> > > > Subject: RE: [edk2-devel] [edk2-platforms Patch
> > 00/14]
> > > > Vlv2TbltDevicePkg: Remove Intel Framework
> > dependencies
> > > >
> > > > Hi Gary,
> > > >
> > > > Thanks for the branch.  I have the build working and
> > have reproduced
> > > > the SMBIOS issue and am debugging that now.
> > > >
> > > > Mike
> > > >
> > > > > -----Original Message-----
> > > > > From: Gary Lin [mailto:GLin@suse.com]
> > > > > Sent: Tuesday, July 2, 2019 2:48 AM
> > > > > To: devel@edk2.groups.io; Kinney, Michael D
> > > > > <michael.d.kinney@intel.com>
> > > > > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > > > > <zailiang.sun@intel.com>
> > > > > Subject: Re: [edk2-devel] [edk2-platforms Patch
> > 00/14]
> > > > > Vlv2TbltDevicePkg: Remove Intel Framework
> > dependencies
> > > > >
> > > > > On Mon, Jul 01, 2019 at 11:07:11PM +0000,  Michael
> > D
> > > > Kinney  wrote:
> > > > > > Hi Gary,
> > > > > >
> > > > > > I recommend you rebase on top of this series.
> > > > > >
> > > > > > I have verified Linux boots and I have been
> > working
> > > > on
> > > > > the GCC and
> > > > > > Linux build scripts as well.
> > > > > >
> > > > > > Please let me know if you see any issues with
> > this
> > > > > series applied and
> > > > > > I can help get them fixed.
> > > > > >
> > > > > Hi Mike,
> > > > >
> > > > > I'm rebasing my patches and they are available in
> > my
> > > > > branch:
> > > > >
> > > > > https://github.com/lcp/edk2-platforms/commits/vlv2-
> > > > > fixes-wip
> > > > >
> > > > > It's based on
> > > > > edk2(dcce9cbd48e07fcd11f7ef34cad48faf7bb61e6e)
> > > > > and edk2-non-
> > > > > osi(de0a6bc19c4ee0468f04e4d37035cdc59558137f).
> > > > >
> > > > > There are 3 problems I currently encountered, and
> > maybe
> > > > you can give
> > > > > me some suggestions.
> > > > >
> > > > > 1. Missing DSDT
> > > > >
> > > > > When compiling DSDT, iasl failed with this error:
> > > > >
> > > > > DSDT.iiii   6077:
> > > > > Or(ShiftLeft(Derefof(Index(CDCT,
> > > > > \_SB.PCI0.GFX0.MCHK.DCFE)), 21),PARM, PARM)
> > > > > Error    6163 -
> > > > > ^ Object is created temporarily in another method
> > and
> > > > cannot be
> > > > > accessed (\_SB.PCI0.GFX0. MCHK.DCFE)
> > > > >
> > > > > The code is from
> > > > >
> > > >
> > Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOGB
> > > > > DA.ASL
> > > > >
> > > > > I have to comment out the line or iasl won't
> > generate
> > > > the aml file and
> > > > > the OS would fail to get DSDT.
> > > > >
> > > > > My acpica version is 20190509, and I vaguely
> > remember
> > > > that the older
> > > > > acpica seems to be more tolerant to this error.
> > > > >
> > > > > 2. Crash at SMBIOS driver
> > > > >
> > > > > When booting the system, I got the following error:
> > > > >
> > > > > Loading driver at 0x00078DBA000
> > > > EntryPoint=0x00078DBEC3C
> > > > > MiscSubclass.efi
> > > > > InstallProtocolInterface: BC62157E-3E33-4FEC-9920-
> > > > 2D3B36D750DF
> > > > > 78FE8D18 ProtectUefiImageCommon -
> > > > > 0x78FE8040
> > > > >   - 0x0000000078DBA000 - 0x0000000000007B80
> > > > > PlatformInfoHob->BoardId [0xB0]
> > > > > GetBiosVersionDateTime :MNW2MAX1.X64.0084.D01
> > > > 01/01/2019
> > > > > 00:00
> > > > > SmbiosAdd: Smbios type 0 with size 0x48 is added to
> > 32-
> > > > bit table
> > > > > SmbiosAdd: Smbios type 0 with size 0x48 is added to
> > 64-
> > > > bit table
> > > > > SmbiosCreateTable: Initialize 32-bit entry point
> > > > structure
> > > > > SmbiosCreateTable() re-allocate SMBIOS 32-bit table
> > > > > SmbiosCreateTable: Initialize 64-bit entry point
> > > > structure
> > > > > SmbiosCreate64BitTable() re-allocate SMBIOS 64-bit
> > > > table Create Smbios
> > > > > Manu callback.
> > > > > !!!! X64 Exception Type - 06(#UD - Invalid Opcode)
> > CPU
> > > > Apic ID -
> > > > > 00000000 !!!!
> > > > > RIP  - 0000000078DBEC26, CS  - 0000000000000038,
> > RFLAGS
> > > > > - 0000000000010206 RAX  - 0000000000000000, RCX -
> > > > 000000007984A5A0,
> > > > > RDX - 000000007A46E5FF RBX  - 000000007A46E920, RSP
> > -
> > > > > 000000007A46E8B0, RBP -
> > > > > 0000000078DC0EC0 RSI  - 0000000000000012, RDI -
> > > > > 0000000000000003
> > > > > R8   - 800000000000000E, R9  - 000000007A46E920,
> > R10 -
> > > > > 0000000078FE8398
> > > > > R11  - 0000000000000001, R12 - 0000000078FE8798,
> > R13 -
> > > > > 0000000078FE8898
> > > > > R14  - 0000000078FE8818, R15 - 000000007A46EC60
> > > > > DS   - 0000000000000030, ES  - 0000000000000030, FS
> > -
> > > > > 0000000000000030
> > > > > GS   - 0000000000000030, SS  - 0000000000000030
> > > > > CR0  - 0000000080010013, CR2 - 0000000000000000,
> > CR3 -
> > > > > 000000007A201000
> > > > > CR4  - 0000000000000628, CR8 - 0000000000000000
> > > > > DR0  - 0000000000000000, DR1 - 0000000000000000,
> > DR2 -
> > > > > 0000000000000000
> > > > > DR3  - 0000000000000000, DR6 - 00000000FFFF0FF8,
> > DR7 -
> > > > > 0000000000000400 GDTR - 0000000079FFDA98
> > > > 0000000000000047, LDTR -
> > > > > 0000000000000000
> > > > > IDTR - 0000000079862018 0000000000000FFF,   TR -
> > > > > 0000000000000000
> > > > > FXSAVE_STATE - 000000007A46E510
> > > > > !!!! Find image based on IP(0x78DBEC26)
> > > > > /home/gary/git/edk2-
> > > > >
> > > >
> > workspace/Build/Vlv2TbltDevicePkg/DEBUG_GCC5/X64/Vlv2Tbl
> > > > >
> > > >
> > tDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe/DEBUG/MiscSubclas
> > > > > s.
> > > > > dll (ImageBase=0000000078DBA000,
> > > > > EntryPoint=0000000078DBEC3C) !!!!
> > > > >
> > > > > I disaseembled MiscSubclass.debug and found that
> > the
> > > > address is a
> > > > > "ud2"
> > > > > instruction at
> > > > >
> > > >
> > SmBiosMiscDxe/MiscBaseBoardManufacturerFunction.c:MiscBa
> > > > > seBoardManufacturer()
> > > > >
> > > > > After adding a few more debug messages, the system
> > > > crashed at another
> > > > > function:
> > > > >
> > > >
> > SmBiosMiscDxe/MiscSystemManufacturerFunction.c:AddSmbios
> > > > > ManuCallback()
> > > > >
> > > > > If I added debug messages to both functions, the
> > system
> > > > booted
> > > > > successfully. I currently didn't have any clue on
> > this.
> > > > >
> > > > > 3. The firmware always booted into EFI shell.
> > > > >
> > > > > I guess something went wrong with BDS. I haven't
> > looked
> > > > into this
> > > > > issue yet.
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Gary Lin
> > > > >
> > > > > > Thanks,
> > > > > >
> > > > > > Mike
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Gary Lin [mailto:GLin@suse.com]
> > > > > > > Sent: Sunday, June 30, 2019 9:04 PM
> > > > > > > To: devel@edk2.groups.io; Kinney, Michael D
> > > > > > > <michael.d.kinney@intel.com>
> > > > > > > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > > > > > > <zailiang.sun@intel.com>
> > > > > > > Subject: Re: [edk2-devel] [edk2-platforms Patch
> > > > > 00/14]
> > > > > > > Vlv2TbltDevicePkg: Remove Intel Framework
> > > > > dependencies
> > > > > > >
> > > > > > > On Sun, Jun 30, 2019 at 07:55:39PM -0700,
> > Michael
> > > > D
> > > > > Kinney  wrote:
> > > > > > > > The following changes remove all dependencies
> > on
> > > > > the
> > > > > > > IntelFrameworkPkg
> > > > > > > > and IntelFrameworkModulePkg from the
> > > > > Vlv2TbltDevicePkg
> > > > > > > platform
> > > > > > > > builds.  These changes do depend on updates
> > > > > binaries
> > > > > > > on the edk2-non-osi repository.
> > > > > > > >
> > > > > > > Hi Michael,
> > > > > > >
> > > > > > > I am amending the bash scripts for gcc. The
> > > > firmware
> > > > > I built is
> > > > > > > using the binaries from Development190216 and
> > could
> > > > > boot into Linux
> > > > > > > successfully with some workarounds for Wpce791,
> > > > Bds,
> > > > > and
> > > > > > > InteFspWrapper. The patches you posted
> > eliminate
> > > > > those parts I have
> > > > > > > to work around.
> > > > > > >
> > > > > > > Just want to know if you need any assistance
> > for
> > > > the
> > > > > gcc build? I
> > > > > > > could rebase my work upon your patches and send
> > > > them
> > > > > later.
> > > > > > >
> > > > > > > Thanks,
> > > > > > >
> > > > > > > Gary Lin
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > >
> > 
> > 
> 
> 
> 
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43420): https://edk2.groups.io/g/devel/message/43420
Mute This Topic: https://groups.io/mt/32267616/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Hi Gary,

I have pushed 2 more patches to my branch.  One fixes the
ASL issue without removing the code.  The second is a clean
up to all the DSC files and build scripts to make everything
more consistent and remove more unused content.

https://github.com/mdkinney/edk2-platforms/tree/Bug_xxx_Vlv2_Linux_And_Smbios_Fixes_V2

Please test this to make sure it still works.

I will work on the Readme and will review the series to prepare
for sending the patch email review tomorrow.

Thanks for all your help and testing.

Mike

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
> On Behalf Of Gary Lin
> Sent: Monday, July 8, 2019 11:04 PM
> To: devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> <zailiang.sun@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms Patch 00/14]
> Vlv2TbltDevicePkg: Remove Intel Framework dependencies
> 
> On Tue, Jul 09, 2019 at 03:52:37AM +0000,  Michael D
> Kinney  wrote:
> > Hi Gary,
> >
> Hi Mike,
> 
> > I picked up the changes on your branch.  I re-enabled
> the BIOS ID
> > Feature and added support for IA32 GCC builds, so the
> builds available
> > from Windows and Linux are matched now.
> >
> > I have posted my updated branch here:
> >
> > https://github.com/mdkinney/edk2-
> platforms/tree/Bug_xxx_Vlv2_Linux_And
> > _Smbios_Fixes_V2
> >
> > I also verified that the SD Card support does work, so
> I am keeping
> > that change.
> >
> I tested the branch + my ASL workaround and booted into
> Linux successfully.
> 
> > I agree the Readme is out of date.  I will work on that
> and add to the
> > branch referenced above tomorrow.
> >
> Thanks!
> 
> Gary Lin
> 
> > Thanks,
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io
> [mailto:devel@edk2.groups.io] On Behalf
> > > Of Gary Lin
> > > Sent: Tuesday, July 2, 2019 8:57 PM
> > > To: Kinney, Michael D <michael.d.kinney@intel.com>
> > > Cc: devel@edk2.groups.io; Qian, Yi
> <yi.qian@intel.com>; Sun,
> > > Zailiang <zailiang.sun@intel.com>
> > > Subject: Re: [edk2-devel] [edk2-platforms Patch
> 00/14]
> > > Vlv2TbltDevicePkg: Remove Intel Framework
> dependencies
> > >
> > > On Tue, Jul 02, 2019 at 09:11:06PM +0000,  Kinney,
> Michael D  wrote:
> > > > Hi Gary,
> > > >
> > > Hi Mike,
> > >
> > > > I have posted an update to your patches the removes
> the
> > > setting of
> > > > WORKSPACE and accesses all files relative to
> WORKSPACE
> > > in the Linux shell scripts.
> > > > It also fixes null pointer bugs in the
> SmbiosMiscDxe
> > > module.
> > > >
> > > > https://github.com/mdkinney/edk2-
> > > platforms/tree/Bug_xxx_Vlv2_Linux_And
> > > > _Smbios_Fixes
> > > >
> > > > With these changes I can boot to the UEFI Shell and
> to
> > > Linux.  Please
> > > > verify from your environments.
> > > >
> > > The fix for SmbiosMiscDxe works for me. Thanks for
> that!
> > >
> > > I pushed another commit to my branch to check
> WORKSPACE to notify
> > > the
> > > user:
> > >
> > > https://github.com/lcp/edk2-
> > >
> platforms/commit/fc530689e913e3de25ca2c553d616b9cef28901c
> > >
> > > We probably have to update Readme.md later. It's
> already dated.
> > >
> > > > I see you have added the SDMMC modules, but I do
> not
> > > see that peripheral yet.
> > > > That feature looks like it needs some more debug.
> We
> > > may need to back
> > > > out those changes for now.
> > > >
> > > I saw the SD card settings in the South Cluster
> Configuration menu
> > > even without those SDMMC modules, so they are
> probably from the
> > > edk2-non-osi drivers. However, the SD card didn't
> work until I added
> > > the drivers from MdeModulePkg, so I need those
> drivers at least for
> > > my Minnowboard Turbot.
> > >
> > > Thanks,
> > >
> > > Gary Lin
> > >
> > > > I agree there are ASL issues.  The ASL code needs
> to be
> > > updated to the
> > > > latest ASL compiler.
> > > >
> > > > Thanks,
> > > >
> > > > Mike
> > > >
> > > > > -----Original Message-----
> > > > > From: Kinney, Michael D
> > > > > Sent: Tuesday, July 2, 2019 9:50 AM
> > > > > To: Gary Lin <GLin@suse.com>;
> devel@edk2.groups.io;
> > > Kinney, Michael
> > > > > D <michael.d.kinney@intel.com>
> > > > > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > > > > <zailiang.sun@intel.com>
> > > > > Subject: RE: [edk2-devel] [edk2-platforms Patch
> > > 00/14]
> > > > > Vlv2TbltDevicePkg: Remove Intel Framework
> > > dependencies
> > > > >
> > > > > Hi Gary,
> > > > >
> > > > > Thanks for the branch.  I have the build working
> and
> > > have reproduced
> > > > > the SMBIOS issue and am debugging that now.
> > > > >
> > > > > Mike
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Gary Lin [mailto:GLin@suse.com]
> > > > > > Sent: Tuesday, July 2, 2019 2:48 AM
> > > > > > To: devel@edk2.groups.io; Kinney, Michael D
> > > > > > <michael.d.kinney@intel.com>
> > > > > > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > > > > > <zailiang.sun@intel.com>
> > > > > > Subject: Re: [edk2-devel] [edk2-platforms Patch
> > > 00/14]
> > > > > > Vlv2TbltDevicePkg: Remove Intel Framework
> > > dependencies
> > > > > >
> > > > > > On Mon, Jul 01, 2019 at 11:07:11PM +0000,
> Michael
> > > D
> > > > > Kinney  wrote:
> > > > > > > Hi Gary,
> > > > > > >
> > > > > > > I recommend you rebase on top of this series.
> > > > > > >
> > > > > > > I have verified Linux boots and I have been
> > > working
> > > > > on
> > > > > > the GCC and
> > > > > > > Linux build scripts as well.
> > > > > > >
> > > > > > > Please let me know if you see any issues with
> > > this
> > > > > > series applied and
> > > > > > > I can help get them fixed.
> > > > > > >
> > > > > > Hi Mike,
> > > > > >
> > > > > > I'm rebasing my patches and they are available
> in
> > > my
> > > > > > branch:
> > > > > >
> > > > > > https://github.com/lcp/edk2-
> platforms/commits/vlv2-
> > > > > > fixes-wip
> > > > > >
> > > > > > It's based on
> > > > > > edk2(dcce9cbd48e07fcd11f7ef34cad48faf7bb61e6e)
> > > > > > and edk2-non-
> > > > > > osi(de0a6bc19c4ee0468f04e4d37035cdc59558137f).
> > > > > >
> > > > > > There are 3 problems I currently encountered,
> and
> > > maybe
> > > > > you can give
> > > > > > me some suggestions.
> > > > > >
> > > > > > 1. Missing DSDT
> > > > > >
> > > > > > When compiling DSDT, iasl failed with this
> error:
> > > > > >
> > > > > > DSDT.iiii   6077:
> > > > > > Or(ShiftLeft(Derefof(Index(CDCT,
> \_SB.PCI0.GFX0.MCHK.DCFE)),
> > > > > > 21),PARM, PARM)
> > > > > > Error    6163 -
> > > > > > ^ Object is created temporarily in another
> method
> > > and
> > > > > cannot be
> > > > > > accessed (\_SB.PCI0.GFX0. MCHK.DCFE)
> > > > > >
> > > > > > The code is from
> > > > > >
> > > > >
> > >
> Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOGB
> > > > > > DA.ASL
> > > > > >
> > > > > > I have to comment out the line or iasl won't
> > > generate
> > > > > the aml file and
> > > > > > the OS would fail to get DSDT.
> > > > > >
> > > > > > My acpica version is 20190509, and I vaguely
> > > remember
> > > > > that the older
> > > > > > acpica seems to be more tolerant to this error.
> > > > > >
> > > > > > 2. Crash at SMBIOS driver
> > > > > >
> > > > > > When booting the system, I got the following
> error:
> > > > > >
> > > > > > Loading driver at 0x00078DBA000
> > > > > EntryPoint=0x00078DBEC3C
> > > > > > MiscSubclass.efi
> > > > > > InstallProtocolInterface: BC62157E-3E33-4FEC-
> 9920-
> > > > > 2D3B36D750DF
> > > > > > 78FE8D18 ProtectUefiImageCommon -
> > > > > > 0x78FE8040
> > > > > >   - 0x0000000078DBA000 - 0x0000000000007B80
> > > > > > PlatformInfoHob->BoardId [0xB0]
> > > > > > GetBiosVersionDateTime :MNW2MAX1.X64.0084.D01
> > > > > 01/01/2019
> > > > > > 00:00
> > > > > > SmbiosAdd: Smbios type 0 with size 0x48 is
> added to
> > > 32-
> > > > > bit table
> > > > > > SmbiosAdd: Smbios type 0 with size 0x48 is
> added to
> > > 64-
> > > > > bit table
> > > > > > SmbiosCreateTable: Initialize 32-bit entry
> point
> > > > > structure
> > > > > > SmbiosCreateTable() re-allocate SMBIOS 32-bit
> table
> > > > > > SmbiosCreateTable: Initialize 64-bit entry
> point
> > > > > structure
> > > > > > SmbiosCreate64BitTable() re-allocate SMBIOS 64-
> bit
> > > > > table Create Smbios
> > > > > > Manu callback.
> > > > > > !!!! X64 Exception Type - 06(#UD - Invalid
> Opcode)
> > > CPU
> > > > > Apic ID -
> > > > > > 00000000 !!!!
> > > > > > RIP  - 0000000078DBEC26, CS  -
> 0000000000000038,
> > > RFLAGS
> > > > > > - 0000000000010206 RAX  - 0000000000000000, RCX
> -
> > > > > 000000007984A5A0,
> > > > > > RDX - 000000007A46E5FF RBX  - 000000007A46E920,
> RSP
> > > -
> > > > > > 000000007A46E8B0, RBP -
> > > > > > 0000000078DC0EC0 RSI  - 0000000000000012, RDI -
> > > > > > 0000000000000003
> > > > > > R8   - 800000000000000E, R9  -
> 000000007A46E920,
> > > R10 -
> > > > > > 0000000078FE8398
> > > > > > R11  - 0000000000000001, R12 -
> 0000000078FE8798,
> > > R13 -
> > > > > > 0000000078FE8898
> > > > > > R14  - 0000000078FE8818, R15 - 000000007A46EC60
> > > > > > DS   - 0000000000000030, ES  -
> 0000000000000030, FS
> > > -
> > > > > > 0000000000000030
> > > > > > GS   - 0000000000000030, SS  - 0000000000000030
> > > > > > CR0  - 0000000080010013, CR2 -
> 0000000000000000,
> > > CR3 -
> > > > > > 000000007A201000
> > > > > > CR4  - 0000000000000628, CR8 - 0000000000000000
> > > > > > DR0  - 0000000000000000, DR1 -
> 0000000000000000,
> > > DR2 -
> > > > > > 0000000000000000
> > > > > > DR3  - 0000000000000000, DR6 -
> 00000000FFFF0FF8,
> > > DR7 -
> > > > > > 0000000000000400 GDTR - 0000000079FFDA98
> > > > > 0000000000000047, LDTR -
> > > > > > 0000000000000000
> > > > > > IDTR - 0000000079862018 0000000000000FFF,   TR
> -
> > > > > > 0000000000000000
> > > > > > FXSAVE_STATE - 000000007A46E510 !!!! Find image
> based on
> > > > > > IP(0x78DBEC26)
> > > > > > /home/gary/git/edk2-
> > > > > >
> > > > >
> > >
> workspace/Build/Vlv2TbltDevicePkg/DEBUG_GCC5/X64/Vlv2Tbl
> > > > > >
> > > > >
> > >
> tDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe/DEBUG/MiscSubclas
> > > > > > s.
> > > > > > dll (ImageBase=0000000078DBA000,
> > > > > > EntryPoint=0000000078DBEC3C) !!!!
> > > > > >
> > > > > > I disaseembled MiscSubclass.debug and found
> that
> > > the
> > > > > address is a
> > > > > > "ud2"
> > > > > > instruction at
> > > > > >
> > > > >
> > >
> SmBiosMiscDxe/MiscBaseBoardManufacturerFunction.c:MiscBa
> > > > > > seBoardManufacturer()
> > > > > >
> > > > > > After adding a few more debug messages, the
> system
> > > > > crashed at another
> > > > > > function:
> > > > > >
> > > > >
> > >
> SmBiosMiscDxe/MiscSystemManufacturerFunction.c:AddSmbios
> > > > > > ManuCallback()
> > > > > >
> > > > > > If I added debug messages to both functions,
> the
> > > system
> > > > > booted
> > > > > > successfully. I currently didn't have any clue
> on
> > > this.
> > > > > >
> > > > > > 3. The firmware always booted into EFI shell.
> > > > > >
> > > > > > I guess something went wrong with BDS. I
> haven't
> > > looked
> > > > > into this
> > > > > > issue yet.
> > > > > >
> > > > > > Thanks,
> > > > > >
> > > > > > Gary Lin
> > > > > >
> > > > > > > Thanks,
> > > > > > >
> > > > > > > Mike
> > > > > > >
> > > > > > > > -----Original Message-----
> > > > > > > > From: Gary Lin [mailto:GLin@suse.com]
> > > > > > > > Sent: Sunday, June 30, 2019 9:04 PM
> > > > > > > > To: devel@edk2.groups.io; Kinney, Michael D
> > > > > > > > <michael.d.kinney@intel.com>
> > > > > > > > Cc: Qian, Yi <yi.qian@intel.com>; Sun,
> Zailiang
> > > > > > > > <zailiang.sun@intel.com>
> > > > > > > > Subject: Re: [edk2-devel] [edk2-platforms
> Patch
> > > > > > 00/14]
> > > > > > > > Vlv2TbltDevicePkg: Remove Intel Framework
> > > > > > dependencies
> > > > > > > >
> > > > > > > > On Sun, Jun 30, 2019 at 07:55:39PM -0700,
> > > Michael
> > > > > D
> > > > > > Kinney  wrote:
> > > > > > > > > The following changes remove all
> dependencies
> > > on
> > > > > > the
> > > > > > > > IntelFrameworkPkg
> > > > > > > > > and IntelFrameworkModulePkg from the
> > > > > > Vlv2TbltDevicePkg
> > > > > > > > platform
> > > > > > > > > builds.  These changes do depend on
> updates
> > > > > > binaries
> > > > > > > > on the edk2-non-osi repository.
> > > > > > > > >
> > > > > > > > Hi Michael,
> > > > > > > >
> > > > > > > > I am amending the bash scripts for gcc. The
> > > > > firmware
> > > > > > I built is
> > > > > > > > using the binaries from Development190216
> and
> > > could
> > > > > > boot into Linux
> > > > > > > > successfully with some workarounds for
> Wpce791,
> > > > > Bds,
> > > > > > and
> > > > > > > > InteFspWrapper. The patches you posted
> > > eliminate
> > > > > > those parts I have
> > > > > > > > to work around.
> > > > > > > >
> > > > > > > > Just want to know if you need any
> assistance
> > > for
> > > > > the
> > > > > > gcc build? I
> > > > > > > > could rebase my work upon your patches and
> send
> > > > > them
> > > > > > later.
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > >
> > > > > > > > Gary Lin
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > >
> > >
> > >
> >
> >
> >
> >
> >
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43453): https://edk2.groups.io/g/devel/message/43453
Mute This Topic: https://groups.io/mt/32267616/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

On Wed, Jul 10, 2019 at 03:38:01AM +0000,  Michael D Kinney  wrote:
> Hi Gary,
> 
> I have pushed 2 more patches to my branch.  One fixes the
> ASL issue without removing the code.  The second is a clean
> up to all the DSC files and build scripts to make everything
> more consistent and remove more unused content.
> 
> https://github.com/mdkinney/edk2-platforms/tree/Bug_xxx_Vlv2_Linux_And_Smbios_Fixes_V2
> 
> Please test this to make sure it still works.
> 
It works great! I don't need to comment out the problematic line
anymore.

> I will work on the Readme and will review the series to prepare
> for sending the patch email review tomorrow.
> 
> Thanks for all your help and testing.
Thanks for fixing the gcc build :)

Gary Lin

> 
> Mike
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
> > On Behalf Of Gary Lin
> > Sent: Monday, July 8, 2019 11:04 PM
> > To: devel@edk2.groups.io; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > <zailiang.sun@intel.com>
> > Subject: Re: [edk2-devel] [edk2-platforms Patch 00/14]
> > Vlv2TbltDevicePkg: Remove Intel Framework dependencies
> > 
> > On Tue, Jul 09, 2019 at 03:52:37AM +0000,  Michael D
> > Kinney  wrote:
> > > Hi Gary,
> > >
> > Hi Mike,
> > 
> > > I picked up the changes on your branch.  I re-enabled
> > the BIOS ID
> > > Feature and added support for IA32 GCC builds, so the
> > builds available
> > > from Windows and Linux are matched now.
> > >
> > > I have posted my updated branch here:
> > >
> > > https://github.com/mdkinney/edk2-
> > platforms/tree/Bug_xxx_Vlv2_Linux_And
> > > _Smbios_Fixes_V2
> > >
> > > I also verified that the SD Card support does work, so
> > I am keeping
> > > that change.
> > >
> > I tested the branch + my ASL workaround and booted into
> > Linux successfully.
> > 
> > > I agree the Readme is out of date.  I will work on that
> > and add to the
> > > branch referenced above tomorrow.
> > >
> > Thanks!
> > 
> > Gary Lin
> > 
> > > Thanks,
> > >
> > > Mike
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io
> > [mailto:devel@edk2.groups.io] On Behalf
> > > > Of Gary Lin
> > > > Sent: Tuesday, July 2, 2019 8:57 PM
> > > > To: Kinney, Michael D <michael.d.kinney@intel.com>
> > > > Cc: devel@edk2.groups.io; Qian, Yi
> > <yi.qian@intel.com>; Sun,
> > > > Zailiang <zailiang.sun@intel.com>
> > > > Subject: Re: [edk2-devel] [edk2-platforms Patch
> > 00/14]
> > > > Vlv2TbltDevicePkg: Remove Intel Framework
> > dependencies
> > > >
> > > > On Tue, Jul 02, 2019 at 09:11:06PM +0000,  Kinney,
> > Michael D  wrote:
> > > > > Hi Gary,
> > > > >
> > > > Hi Mike,
> > > >
> > > > > I have posted an update to your patches the removes
> > the
> > > > setting of
> > > > > WORKSPACE and accesses all files relative to
> > WORKSPACE
> > > > in the Linux shell scripts.
> > > > > It also fixes null pointer bugs in the
> > SmbiosMiscDxe
> > > > module.
> > > > >
> > > > > https://github.com/mdkinney/edk2-
> > > > platforms/tree/Bug_xxx_Vlv2_Linux_And
> > > > > _Smbios_Fixes
> > > > >
> > > > > With these changes I can boot to the UEFI Shell and
> > to
> > > > Linux.  Please
> > > > > verify from your environments.
> > > > >
> > > > The fix for SmbiosMiscDxe works for me. Thanks for
> > that!
> > > >
> > > > I pushed another commit to my branch to check
> > WORKSPACE to notify
> > > > the
> > > > user:
> > > >
> > > > https://github.com/lcp/edk2-
> > > >
> > platforms/commit/fc530689e913e3de25ca2c553d616b9cef28901c
> > > >
> > > > We probably have to update Readme.md later. It's
> > already dated.
> > > >
> > > > > I see you have added the SDMMC modules, but I do
> > not
> > > > see that peripheral yet.
> > > > > That feature looks like it needs some more debug.
> > We
> > > > may need to back
> > > > > out those changes for now.
> > > > >
> > > > I saw the SD card settings in the South Cluster
> > Configuration menu
> > > > even without those SDMMC modules, so they are
> > probably from the
> > > > edk2-non-osi drivers. However, the SD card didn't
> > work until I added
> > > > the drivers from MdeModulePkg, so I need those
> > drivers at least for
> > > > my Minnowboard Turbot.
> > > >
> > > > Thanks,
> > > >
> > > > Gary Lin
> > > >
> > > > > I agree there are ASL issues.  The ASL code needs
> > to be
> > > > updated to the
> > > > > latest ASL compiler.
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Mike
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Kinney, Michael D
> > > > > > Sent: Tuesday, July 2, 2019 9:50 AM
> > > > > > To: Gary Lin <GLin@suse.com>;
> > devel@edk2.groups.io;
> > > > Kinney, Michael
> > > > > > D <michael.d.kinney@intel.com>
> > > > > > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > > > > > <zailiang.sun@intel.com>
> > > > > > Subject: RE: [edk2-devel] [edk2-platforms Patch
> > > > 00/14]
> > > > > > Vlv2TbltDevicePkg: Remove Intel Framework
> > > > dependencies
> > > > > >
> > > > > > Hi Gary,
> > > > > >
> > > > > > Thanks for the branch.  I have the build working
> > and
> > > > have reproduced
> > > > > > the SMBIOS issue and am debugging that now.
> > > > > >
> > > > > > Mike
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Gary Lin [mailto:GLin@suse.com]
> > > > > > > Sent: Tuesday, July 2, 2019 2:48 AM
> > > > > > > To: devel@edk2.groups.io; Kinney, Michael D
> > > > > > > <michael.d.kinney@intel.com>
> > > > > > > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > > > > > > <zailiang.sun@intel.com>
> > > > > > > Subject: Re: [edk2-devel] [edk2-platforms Patch
> > > > 00/14]
> > > > > > > Vlv2TbltDevicePkg: Remove Intel Framework
> > > > dependencies
> > > > > > >
> > > > > > > On Mon, Jul 01, 2019 at 11:07:11PM +0000,
> > Michael
> > > > D
> > > > > > Kinney  wrote:
> > > > > > > > Hi Gary,
> > > > > > > >
> > > > > > > > I recommend you rebase on top of this series.
> > > > > > > >
> > > > > > > > I have verified Linux boots and I have been
> > > > working
> > > > > > on
> > > > > > > the GCC and
> > > > > > > > Linux build scripts as well.
> > > > > > > >
> > > > > > > > Please let me know if you see any issues with
> > > > this
> > > > > > > series applied and
> > > > > > > > I can help get them fixed.
> > > > > > > >
> > > > > > > Hi Mike,
> > > > > > >
> > > > > > > I'm rebasing my patches and they are available
> > in
> > > > my
> > > > > > > branch:
> > > > > > >
> > > > > > > https://github.com/lcp/edk2-
> > platforms/commits/vlv2-
> > > > > > > fixes-wip
> > > > > > >
> > > > > > > It's based on
> > > > > > > edk2(dcce9cbd48e07fcd11f7ef34cad48faf7bb61e6e)
> > > > > > > and edk2-non-
> > > > > > > osi(de0a6bc19c4ee0468f04e4d37035cdc59558137f).
> > > > > > >
> > > > > > > There are 3 problems I currently encountered,
> > and
> > > > maybe
> > > > > > you can give
> > > > > > > me some suggestions.
> > > > > > >
> > > > > > > 1. Missing DSDT
> > > > > > >
> > > > > > > When compiling DSDT, iasl failed with this
> > error:
> > > > > > >
> > > > > > > DSDT.iiii   6077:
> > > > > > > Or(ShiftLeft(Derefof(Index(CDCT,
> > \_SB.PCI0.GFX0.MCHK.DCFE)),
> > > > > > > 21),PARM, PARM)
> > > > > > > Error    6163 -
> > > > > > > ^ Object is created temporarily in another
> > method
> > > > and
> > > > > > cannot be
> > > > > > > accessed (\_SB.PCI0.GFX0. MCHK.DCFE)
> > > > > > >
> > > > > > > The code is from
> > > > > > >
> > > > > >
> > > >
> > Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOGB
> > > > > > > DA.ASL
> > > > > > >
> > > > > > > I have to comment out the line or iasl won't
> > > > generate
> > > > > > the aml file and
> > > > > > > the OS would fail to get DSDT.
> > > > > > >
> > > > > > > My acpica version is 20190509, and I vaguely
> > > > remember
> > > > > > that the older
> > > > > > > acpica seems to be more tolerant to this error.
> > > > > > >
> > > > > > > 2. Crash at SMBIOS driver
> > > > > > >
> > > > > > > When booting the system, I got the following
> > error:
> > > > > > >
> > > > > > > Loading driver at 0x00078DBA000
> > > > > > EntryPoint=0x00078DBEC3C
> > > > > > > MiscSubclass.efi
> > > > > > > InstallProtocolInterface: BC62157E-3E33-4FEC-
> > 9920-
> > > > > > 2D3B36D750DF
> > > > > > > 78FE8D18 ProtectUefiImageCommon -
> > > > > > > 0x78FE8040
> > > > > > >   - 0x0000000078DBA000 - 0x0000000000007B80
> > > > > > > PlatformInfoHob->BoardId [0xB0]
> > > > > > > GetBiosVersionDateTime :MNW2MAX1.X64.0084.D01
> > > > > > 01/01/2019
> > > > > > > 00:00
> > > > > > > SmbiosAdd: Smbios type 0 with size 0x48 is
> > added to
> > > > 32-
> > > > > > bit table
> > > > > > > SmbiosAdd: Smbios type 0 with size 0x48 is
> > added to
> > > > 64-
> > > > > > bit table
> > > > > > > SmbiosCreateTable: Initialize 32-bit entry
> > point
> > > > > > structure
> > > > > > > SmbiosCreateTable() re-allocate SMBIOS 32-bit
> > table
> > > > > > > SmbiosCreateTable: Initialize 64-bit entry
> > point
> > > > > > structure
> > > > > > > SmbiosCreate64BitTable() re-allocate SMBIOS 64-
> > bit
> > > > > > table Create Smbios
> > > > > > > Manu callback.
> > > > > > > !!!! X64 Exception Type - 06(#UD - Invalid
> > Opcode)
> > > > CPU
> > > > > > Apic ID -
> > > > > > > 00000000 !!!!
> > > > > > > RIP  - 0000000078DBEC26, CS  -
> > 0000000000000038,
> > > > RFLAGS
> > > > > > > - 0000000000010206 RAX  - 0000000000000000, RCX
> > -
> > > > > > 000000007984A5A0,
> > > > > > > RDX - 000000007A46E5FF RBX  - 000000007A46E920,
> > RSP
> > > > -
> > > > > > > 000000007A46E8B0, RBP -
> > > > > > > 0000000078DC0EC0 RSI  - 0000000000000012, RDI -
> > > > > > > 0000000000000003
> > > > > > > R8   - 800000000000000E, R9  -
> > 000000007A46E920,
> > > > R10 -
> > > > > > > 0000000078FE8398
> > > > > > > R11  - 0000000000000001, R12 -
> > 0000000078FE8798,
> > > > R13 -
> > > > > > > 0000000078FE8898
> > > > > > > R14  - 0000000078FE8818, R15 - 000000007A46EC60
> > > > > > > DS   - 0000000000000030, ES  -
> > 0000000000000030, FS
> > > > -
> > > > > > > 0000000000000030
> > > > > > > GS   - 0000000000000030, SS  - 0000000000000030
> > > > > > > CR0  - 0000000080010013, CR2 -
> > 0000000000000000,
> > > > CR3 -
> > > > > > > 000000007A201000
> > > > > > > CR4  - 0000000000000628, CR8 - 0000000000000000
> > > > > > > DR0  - 0000000000000000, DR1 -
> > 0000000000000000,
> > > > DR2 -
> > > > > > > 0000000000000000
> > > > > > > DR3  - 0000000000000000, DR6 -
> > 00000000FFFF0FF8,
> > > > DR7 -
> > > > > > > 0000000000000400 GDTR - 0000000079FFDA98
> > > > > > 0000000000000047, LDTR -
> > > > > > > 0000000000000000
> > > > > > > IDTR - 0000000079862018 0000000000000FFF,   TR
> > -
> > > > > > > 0000000000000000
> > > > > > > FXSAVE_STATE - 000000007A46E510 !!!! Find image
> > based on
> > > > > > > IP(0x78DBEC26)
> > > > > > > /home/gary/git/edk2-
> > > > > > >
> > > > > >
> > > >
> > workspace/Build/Vlv2TbltDevicePkg/DEBUG_GCC5/X64/Vlv2Tbl
> > > > > > >
> > > > > >
> > > >
> > tDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe/DEBUG/MiscSubclas
> > > > > > > s.
> > > > > > > dll (ImageBase=0000000078DBA000,
> > > > > > > EntryPoint=0000000078DBEC3C) !!!!
> > > > > > >
> > > > > > > I disaseembled MiscSubclass.debug and found
> > that
> > > > the
> > > > > > address is a
> > > > > > > "ud2"
> > > > > > > instruction at
> > > > > > >
> > > > > >
> > > >
> > SmBiosMiscDxe/MiscBaseBoardManufacturerFunction.c:MiscBa
> > > > > > > seBoardManufacturer()
> > > > > > >
> > > > > > > After adding a few more debug messages, the
> > system
> > > > > > crashed at another
> > > > > > > function:
> > > > > > >
> > > > > >
> > > >
> > SmBiosMiscDxe/MiscSystemManufacturerFunction.c:AddSmbios
> > > > > > > ManuCallback()
> > > > > > >
> > > > > > > If I added debug messages to both functions,
> > the
> > > > system
> > > > > > booted
> > > > > > > successfully. I currently didn't have any clue
> > on
> > > > this.
> > > > > > >
> > > > > > > 3. The firmware always booted into EFI shell.
> > > > > > >
> > > > > > > I guess something went wrong with BDS. I
> > haven't
> > > > looked
> > > > > > into this
> > > > > > > issue yet.
> > > > > > >
> > > > > > > Thanks,
> > > > > > >
> > > > > > > Gary Lin
> > > > > > >
> > > > > > > > Thanks,
> > > > > > > >
> > > > > > > > Mike
> > > > > > > >
> > > > > > > > > -----Original Message-----
> > > > > > > > > From: Gary Lin [mailto:GLin@suse.com]
> > > > > > > > > Sent: Sunday, June 30, 2019 9:04 PM
> > > > > > > > > To: devel@edk2.groups.io; Kinney, Michael D
> > > > > > > > > <michael.d.kinney@intel.com>
> > > > > > > > > Cc: Qian, Yi <yi.qian@intel.com>; Sun,
> > Zailiang
> > > > > > > > > <zailiang.sun@intel.com>
> > > > > > > > > Subject: Re: [edk2-devel] [edk2-platforms
> > Patch
> > > > > > > 00/14]
> > > > > > > > > Vlv2TbltDevicePkg: Remove Intel Framework
> > > > > > > dependencies
> > > > > > > > >
> > > > > > > > > On Sun, Jun 30, 2019 at 07:55:39PM -0700,
> > > > Michael
> > > > > > D
> > > > > > > Kinney  wrote:
> > > > > > > > > > The following changes remove all
> > dependencies
> > > > on
> > > > > > > the
> > > > > > > > > IntelFrameworkPkg
> > > > > > > > > > and IntelFrameworkModulePkg from the
> > > > > > > Vlv2TbltDevicePkg
> > > > > > > > > platform
> > > > > > > > > > builds.  These changes do depend on
> > updates
> > > > > > > binaries
> > > > > > > > > on the edk2-non-osi repository.
> > > > > > > > > >
> > > > > > > > > Hi Michael,
> > > > > > > > >
> > > > > > > > > I am amending the bash scripts for gcc. The
> > > > > > firmware
> > > > > > > I built is
> > > > > > > > > using the binaries from Development190216
> > and
> > > > could
> > > > > > > boot into Linux
> > > > > > > > > successfully with some workarounds for
> > Wpce791,
> > > > > > Bds,
> > > > > > > and
> > > > > > > > > InteFspWrapper. The patches you posted
> > > > eliminate
> > > > > > > those parts I have
> > > > > > > > > to work around.
> > > > > > > > >
> > > > > > > > > Just want to know if you need any
> > assistance
> > > > for
> > > > > > the
> > > > > > > gcc build? I
> > > > > > > > > could rebase my work upon your patches and
> > send
> > > > > > them
> > > > > > > later.
> > > > > > > > >
> > > > > > > > > Thanks,
> > > > > > > > >
> > > > > > > > > Gary Lin
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
> > >
> > 
> > 
> 
> 
> 
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43454): https://edk2.groups.io/g/devel/message/43454
Mute This Topic: https://groups.io/mt/32267616/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Hi Gary,

I have added 2 more patches.  One to disable capsule generation
for IA32 builds.  There are several places the output directory
is hard coded for X64.  Will require converting the POST_BUILD
scripts to python to make this much better.

The second patch is for the Readme.md.  Please review and
verify the instructions.

Thanks,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
> On Behalf Of Gary Lin
> Sent: Tuesday, July 9, 2019 9:14 PM
> To: devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> <zailiang.sun@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms Patch 00/14]
> Vlv2TbltDevicePkg: Remove Intel Framework dependencies
> 
> On Wed, Jul 10, 2019 at 03:38:01AM +0000,  Michael D
> Kinney  wrote:
> > Hi Gary,
> >
> > I have pushed 2 more patches to my branch.  One fixes
> the ASL issue
> > without removing the code.  The second is a clean up to
> all the DSC
> > files and build scripts to make everything more
> consistent and remove
> > more unused content.
> >
> > https://github.com/mdkinney/edk2-
> platforms/tree/Bug_xxx_Vlv2_Linux_And
> > _Smbios_Fixes_V2
> >
> > Please test this to make sure it still works.
> >
> It works great! I don't need to comment out the
> problematic line anymore.
> 
> > I will work on the Readme and will review the series to
> prepare for
> > sending the patch email review tomorrow.
> >
> > Thanks for all your help and testing.
> Thanks for fixing the gcc build :)
> 
> Gary Lin
> 
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io
> [mailto:devel@edk2.groups.io] On Behalf
> > > Of Gary Lin
> > > Sent: Monday, July 8, 2019 11:04 PM
> > > To: devel@edk2.groups.io; Kinney, Michael D
> > > <michael.d.kinney@intel.com>
> > > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > > <zailiang.sun@intel.com>
> > > Subject: Re: [edk2-devel] [edk2-platforms Patch
> 00/14]
> > > Vlv2TbltDevicePkg: Remove Intel Framework
> dependencies
> > >
> > > On Tue, Jul 09, 2019 at 03:52:37AM +0000,  Michael D
> Kinney  wrote:
> > > > Hi Gary,
> > > >
> > > Hi Mike,
> > >
> > > > I picked up the changes on your branch.  I re-
> enabled
> > > the BIOS ID
> > > > Feature and added support for IA32 GCC builds, so
> the
> > > builds available
> > > > from Windows and Linux are matched now.
> > > >
> > > > I have posted my updated branch here:
> > > >
> > > > https://github.com/mdkinney/edk2-
> > > platforms/tree/Bug_xxx_Vlv2_Linux_And
> > > > _Smbios_Fixes_V2
> > > >
> > > > I also verified that the SD Card support does work,
> so
> > > I am keeping
> > > > that change.
> > > >
> > > I tested the branch + my ASL workaround and booted
> into Linux
> > > successfully.
> > >
> > > > I agree the Readme is out of date.  I will work on
> that
> > > and add to the
> > > > branch referenced above tomorrow.
> > > >
> > > Thanks!
> > >
> > > Gary Lin
> > >
> > > > Thanks,
> > > >
> > > > Mike
> > > >
> > > > > -----Original Message-----
> > > > > From: devel@edk2.groups.io
> > > [mailto:devel@edk2.groups.io] On Behalf
> > > > > Of Gary Lin
> > > > > Sent: Tuesday, July 2, 2019 8:57 PM
> > > > > To: Kinney, Michael D
> <michael.d.kinney@intel.com>
> > > > > Cc: devel@edk2.groups.io; Qian, Yi
> > > <yi.qian@intel.com>; Sun,
> > > > > Zailiang <zailiang.sun@intel.com>
> > > > > Subject: Re: [edk2-devel] [edk2-platforms Patch
> > > 00/14]
> > > > > Vlv2TbltDevicePkg: Remove Intel Framework
> > > dependencies
> > > > >
> > > > > On Tue, Jul 02, 2019 at 09:11:06PM +0000,
> Kinney,
> > > Michael D  wrote:
> > > > > > Hi Gary,
> > > > > >
> > > > > Hi Mike,
> > > > >
> > > > > > I have posted an update to your patches the
> removes
> > > the
> > > > > setting of
> > > > > > WORKSPACE and accesses all files relative to
> > > WORKSPACE
> > > > > in the Linux shell scripts.
> > > > > > It also fixes null pointer bugs in the
> > > SmbiosMiscDxe
> > > > > module.
> > > > > >
> > > > > > https://github.com/mdkinney/edk2-
> > > > > platforms/tree/Bug_xxx_Vlv2_Linux_And
> > > > > > _Smbios_Fixes
> > > > > >
> > > > > > With these changes I can boot to the UEFI Shell
> and
> > > to
> > > > > Linux.  Please
> > > > > > verify from your environments.
> > > > > >
> > > > > The fix for SmbiosMiscDxe works for me. Thanks
> for
> > > that!
> > > > >
> > > > > I pushed another commit to my branch to check
> > > WORKSPACE to notify
> > > > > the
> > > > > user:
> > > > >
> > > > > https://github.com/lcp/edk2-
> > > > >
> > >
> platforms/commit/fc530689e913e3de25ca2c553d616b9cef28901c
> > > > >
> > > > > We probably have to update Readme.md later. It's
> > > already dated.
> > > > >
> > > > > > I see you have added the SDMMC modules, but I
> do
> > > not
> > > > > see that peripheral yet.
> > > > > > That feature looks like it needs some more
> debug.
> > > We
> > > > > may need to back
> > > > > > out those changes for now.
> > > > > >
> > > > > I saw the SD card settings in the South Cluster
> > > Configuration menu
> > > > > even without those SDMMC modules, so they are
> > > probably from the
> > > > > edk2-non-osi drivers. However, the SD card didn't
> > > work until I added
> > > > > the drivers from MdeModulePkg, so I need those
> > > drivers at least for
> > > > > my Minnowboard Turbot.
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Gary Lin
> > > > >
> > > > > > I agree there are ASL issues.  The ASL code
> needs
> > > to be
> > > > > updated to the
> > > > > > latest ASL compiler.
> > > > > >
> > > > > > Thanks,
> > > > > >
> > > > > > Mike
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Kinney, Michael D
> > > > > > > Sent: Tuesday, July 2, 2019 9:50 AM
> > > > > > > To: Gary Lin <GLin@suse.com>;
> > > devel@edk2.groups.io;
> > > > > Kinney, Michael
> > > > > > > D <michael.d.kinney@intel.com>
> > > > > > > Cc: Qian, Yi <yi.qian@intel.com>; Sun,
> Zailiang
> > > > > > > <zailiang.sun@intel.com>
> > > > > > > Subject: RE: [edk2-devel] [edk2-platforms
> Patch
> > > > > 00/14]
> > > > > > > Vlv2TbltDevicePkg: Remove Intel Framework
> > > > > dependencies
> > > > > > >
> > > > > > > Hi Gary,
> > > > > > >
> > > > > > > Thanks for the branch.  I have the build
> working
> > > and
> > > > > have reproduced
> > > > > > > the SMBIOS issue and am debugging that now.
> > > > > > >
> > > > > > > Mike
> > > > > > >
> > > > > > > > -----Original Message-----
> > > > > > > > From: Gary Lin [mailto:GLin@suse.com]
> > > > > > > > Sent: Tuesday, July 2, 2019 2:48 AM
> > > > > > > > To: devel@edk2.groups.io; Kinney, Michael D
> > > > > > > > <michael.d.kinney@intel.com>
> > > > > > > > Cc: Qian, Yi <yi.qian@intel.com>; Sun,
> Zailiang
> > > > > > > > <zailiang.sun@intel.com>
> > > > > > > > Subject: Re: [edk2-devel] [edk2-platforms
> Patch
> > > > > 00/14]
> > > > > > > > Vlv2TbltDevicePkg: Remove Intel Framework
> > > > > dependencies
> > > > > > > >
> > > > > > > > On Mon, Jul 01, 2019 at 11:07:11PM +0000,
> > > Michael
> > > > > D
> > > > > > > Kinney  wrote:
> > > > > > > > > Hi Gary,
> > > > > > > > >
> > > > > > > > > I recommend you rebase on top of this
> series.
> > > > > > > > >
> > > > > > > > > I have verified Linux boots and I have
> been
> > > > > working
> > > > > > > on
> > > > > > > > the GCC and
> > > > > > > > > Linux build scripts as well.
> > > > > > > > >
> > > > > > > > > Please let me know if you see any issues
> with
> > > > > this
> > > > > > > > series applied and
> > > > > > > > > I can help get them fixed.
> > > > > > > > >
> > > > > > > > Hi Mike,
> > > > > > > >
> > > > > > > > I'm rebasing my patches and they are
> available
> > > in
> > > > > my
> > > > > > > > branch:
> > > > > > > >
> > > > > > > > https://github.com/lcp/edk2-
> > > platforms/commits/vlv2-
> > > > > > > > fixes-wip
> > > > > > > >
> > > > > > > > It's based on
> > > > > > > >
> edk2(dcce9cbd48e07fcd11f7ef34cad48faf7bb61e6e)
> > > > > > > > and edk2-non-
> > > > > > > >
> osi(de0a6bc19c4ee0468f04e4d37035cdc59558137f).
> > > > > > > >
> > > > > > > > There are 3 problems I currently
> encountered,
> > > and
> > > > > maybe
> > > > > > > you can give
> > > > > > > > me some suggestions.
> > > > > > > >
> > > > > > > > 1. Missing DSDT
> > > > > > > >
> > > > > > > > When compiling DSDT, iasl failed with this
> > > error:
> > > > > > > >
> > > > > > > > DSDT.iiii   6077:
> > > > > > > > Or(ShiftLeft(Derefof(Index(CDCT,
> > > \_SB.PCI0.GFX0.MCHK.DCFE)),
> > > > > > > > 21),PARM, PARM)
> > > > > > > > Error    6163 -
> > > > > > > > ^ Object is created temporarily in another
> > > method
> > > > > and
> > > > > > > cannot be
> > > > > > > > accessed (\_SB.PCI0.GFX0. MCHK.DCFE)
> > > > > > > >
> > > > > > > > The code is from
> > > > > > > >
> > > > > > >
> > > > >
> > >
> Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOGB
> > > > > > > > DA.ASL
> > > > > > > >
> > > > > > > > I have to comment out the line or iasl
> won't
> > > > > generate
> > > > > > > the aml file and
> > > > > > > > the OS would fail to get DSDT.
> > > > > > > >
> > > > > > > > My acpica version is 20190509, and I
> vaguely
> > > > > remember
> > > > > > > that the older
> > > > > > > > acpica seems to be more tolerant to this
> error.
> > > > > > > >
> > > > > > > > 2. Crash at SMBIOS driver
> > > > > > > >
> > > > > > > > When booting the system, I got the
> following
> > > error:
> > > > > > > >
> > > > > > > > Loading driver at 0x00078DBA000
> > > > > > > EntryPoint=0x00078DBEC3C
> > > > > > > > MiscSubclass.efi
> > > > > > > > InstallProtocolInterface: BC62157E-3E33-
> 4FEC-
> > > 9920-
> > > > > > > 2D3B36D750DF
> > > > > > > > 78FE8D18 ProtectUefiImageCommon -
> > > > > > > > 0x78FE8040
> > > > > > > >   - 0x0000000078DBA000 - 0x0000000000007B80
> > > > > > > > PlatformInfoHob->BoardId [0xB0]
> > > > > > > > GetBiosVersionDateTime
> :MNW2MAX1.X64.0084.D01
> > > > > > > 01/01/2019
> > > > > > > > 00:00
> > > > > > > > SmbiosAdd: Smbios type 0 with size 0x48 is
> > > added to
> > > > > 32-
> > > > > > > bit table
> > > > > > > > SmbiosAdd: Smbios type 0 with size 0x48 is
> > > added to
> > > > > 64-
> > > > > > > bit table
> > > > > > > > SmbiosCreateTable: Initialize 32-bit entry
> > > point
> > > > > > > structure
> > > > > > > > SmbiosCreateTable() re-allocate SMBIOS 32-
> bit
> > > table
> > > > > > > > SmbiosCreateTable: Initialize 64-bit entry
> > > point
> > > > > > > structure
> > > > > > > > SmbiosCreate64BitTable() re-allocate SMBIOS
> 64-
> > > bit
> > > > > > > table Create Smbios
> > > > > > > > Manu callback.
> > > > > > > > !!!! X64 Exception Type - 06(#UD - Invalid
> > > Opcode)
> > > > > CPU
> > > > > > > Apic ID -
> > > > > > > > 00000000 !!!!
> > > > > > > > RIP  - 0000000078DBEC26, CS  -
> > > 0000000000000038,
> > > > > RFLAGS
> > > > > > > > - 0000000000010206 RAX  - 0000000000000000,
> RCX
> > > -
> > > > > > > 000000007984A5A0,
> > > > > > > > RDX - 000000007A46E5FF RBX  -
> 000000007A46E920,
> > > RSP
> > > > > -
> > > > > > > > 000000007A46E8B0, RBP -
> > > > > > > > 0000000078DC0EC0 RSI  - 0000000000000012,
> RDI -
> > > > > > > > 0000000000000003
> > > > > > > > R8   - 800000000000000E, R9  -
> > > 000000007A46E920,
> > > > > R10 -
> > > > > > > > 0000000078FE8398
> > > > > > > > R11  - 0000000000000001, R12 -
> > > 0000000078FE8798,
> > > > > R13 -
> > > > > > > > 0000000078FE8898
> > > > > > > > R14  - 0000000078FE8818, R15 -
> 000000007A46EC60
> > > > > > > > DS   - 0000000000000030, ES  -
> > > 0000000000000030, FS
> > > > > -
> > > > > > > > 0000000000000030
> > > > > > > > GS   - 0000000000000030, SS  -
> 0000000000000030
> > > > > > > > CR0  - 0000000080010013, CR2 -
> > > 0000000000000000,
> > > > > CR3 -
> > > > > > > > 000000007A201000
> > > > > > > > CR4  - 0000000000000628, CR8 -
> 0000000000000000
> > > > > > > > DR0  - 0000000000000000, DR1 -
> > > 0000000000000000,
> > > > > DR2 -
> > > > > > > > 0000000000000000
> > > > > > > > DR3  - 0000000000000000, DR6 -
> > > 00000000FFFF0FF8,
> > > > > DR7 -
> > > > > > > > 0000000000000400 GDTR - 0000000079FFDA98
> > > > > > > 0000000000000047, LDTR -
> > > > > > > > 0000000000000000
> > > > > > > > IDTR - 0000000079862018 0000000000000FFF,
> TR
> > > -
> > > > > > > > 0000000000000000
> > > > > > > > FXSAVE_STATE - 000000007A46E510 !!!! Find
> image
> > > based on
> > > > > > > > IP(0x78DBEC26)
> > > > > > > > /home/gary/git/edk2-
> > > > > > > >
> > > > > > >
> > > > >
> > >
> workspace/Build/Vlv2TbltDevicePkg/DEBUG_GCC5/X64/Vlv2Tbl
> > > > > > > >
> > > > > > >
> > > > >
> > >
> tDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe/DEBUG/MiscSubclas
> > > > > > > > s.
> > > > > > > > dll (ImageBase=0000000078DBA000,
> > > > > > > > EntryPoint=0000000078DBEC3C) !!!!
> > > > > > > >
> > > > > > > > I disaseembled MiscSubclass.debug and found
> > > that
> > > > > the
> > > > > > > address is a
> > > > > > > > "ud2"
> > > > > > > > instruction at
> > > > > > > >
> > > > > > >
> > > > >
> > >
> SmBiosMiscDxe/MiscBaseBoardManufacturerFunction.c:MiscBa
> > > > > > > > seBoardManufacturer()
> > > > > > > >
> > > > > > > > After adding a few more debug messages, the
> > > system
> > > > > > > crashed at another
> > > > > > > > function:
> > > > > > > >
> > > > > > >
> > > > >
> > >
> SmBiosMiscDxe/MiscSystemManufacturerFunction.c:AddSmbios
> > > > > > > > ManuCallback()
> > > > > > > >
> > > > > > > > If I added debug messages to both
> functions,
> > > the
> > > > > system
> > > > > > > booted
> > > > > > > > successfully. I currently didn't have any
> clue
> > > on
> > > > > this.
> > > > > > > >
> > > > > > > > 3. The firmware always booted into EFI
> shell.
> > > > > > > >
> > > > > > > > I guess something went wrong with BDS. I
> > > haven't
> > > > > looked
> > > > > > > into this
> > > > > > > > issue yet.
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > >
> > > > > > > > Gary Lin
> > > > > > > >
> > > > > > > > > Thanks,
> > > > > > > > >
> > > > > > > > > Mike
> > > > > > > > >
> > > > > > > > > > -----Original Message-----
> > > > > > > > > > From: Gary Lin [mailto:GLin@suse.com]
> > > > > > > > > > Sent: Sunday, June 30, 2019 9:04 PM
> > > > > > > > > > To: devel@edk2.groups.io; Kinney,
> Michael D
> > > > > > > > > > <michael.d.kinney@intel.com>
> > > > > > > > > > Cc: Qian, Yi <yi.qian@intel.com>; Sun,
> > > Zailiang
> > > > > > > > > > <zailiang.sun@intel.com>
> > > > > > > > > > Subject: Re: [edk2-devel] [edk2-
> platforms
> > > Patch
> > > > > > > > 00/14]
> > > > > > > > > > Vlv2TbltDevicePkg: Remove Intel
> Framework
> > > > > > > > dependencies
> > > > > > > > > >
> > > > > > > > > > On Sun, Jun 30, 2019 at 07:55:39PM -
> 0700,
> > > > > Michael
> > > > > > > D
> > > > > > > > Kinney  wrote:
> > > > > > > > > > > The following changes remove all
> > > dependencies
> > > > > on
> > > > > > > > the
> > > > > > > > > > IntelFrameworkPkg
> > > > > > > > > > > and IntelFrameworkModulePkg from the
> > > > > > > > Vlv2TbltDevicePkg
> > > > > > > > > > platform
> > > > > > > > > > > builds.  These changes do depend on
> > > updates
> > > > > > > > binaries
> > > > > > > > > > on the edk2-non-osi repository.
> > > > > > > > > > >
> > > > > > > > > > Hi Michael,
> > > > > > > > > >
> > > > > > > > > > I am amending the bash scripts for gcc.
> The
> > > > > > > firmware
> > > > > > > > I built is
> > > > > > > > > > using the binaries from
> Development190216
> > > and
> > > > > could
> > > > > > > > boot into Linux
> > > > > > > > > > successfully with some workarounds for
> > > Wpce791,
> > > > > > > Bds,
> > > > > > > > and
> > > > > > > > > > InteFspWrapper. The patches you posted
> > > > > eliminate
> > > > > > > > those parts I have
> > > > > > > > > > to work around.
> > > > > > > > > >
> > > > > > > > > > Just want to know if you need any
> > > assistance
> > > > > for
> > > > > > > the
> > > > > > > > gcc build? I
> > > > > > > > > > could rebase my work upon your patches
> and
> > > send
> > > > > > > them
> > > > > > > > later.
> > > > > > > > > >
> > > > > > > > > > Thanks,
> > > > > > > > > >
> > > > > > > > > > Gary Lin
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> >
> >
> >
> >
> >
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43455): https://edk2.groups.io/g/devel/message/43455
Mute This Topic: https://groups.io/mt/32267616/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

On Wed, Jul 10, 2019 at 05:01:32AM +0000,  Michael D Kinney  wrote:
> Hi Gary,
> 
> I have added 2 more patches.  One to disable capsule generation
> for IA32 builds.  There are several places the output directory
> is hard coded for X64.  Will require converting the POST_BUILD
> scripts to python to make this much better.
> 
> The second patch is for the Readme.md.  Please review and
> verify the instructions.
I found some typos in the Readme.md:

1. The path to the capsules:

  -    apt-get install libc:i386
  +`Build\Vlv2TbltDevicePkgIA32\RELEASE_VS2015x86\FV\Vlv.ROM`
  +
  +The X64 CapsuleApp and generated UEFI Capsules are in the directory
  +
  +`Build/Vlv2TbltDevicePkg/Capsules`
  +
  +# Linux Pre-requisites
   
   # Download and Build MinnowMax using Linux/GCC

Since it's still in the section of windows, so the path needs the fix:

Build/Vlv2TbltDevicePkg/Capsules => Build\Vlv2TbltDevicePkg\Capsules

2. The name of gcc script:

   Once the environment is setup, the MinnowBoard MAX firmware and capsules can be
   rebuilt using the following commands.
 
  +* Build X64 Debug Image with report file
  +
  +```
  +cd edk2-platforms/Platform/Intel/Vlv2TbltDevicePkg
  +Build_IFWI.bat /m /y MNW2 Debug
  +```
 
  -* Build Debug Image
  +* Build X64 Release Image with build log
 
   ```
  -cd Vlv2TbltDevicePkg
  -./Build_IFWI.sh MNW2 Debug
  +cd edk2-platforms/Platform/Intel/Vlv2TbltDevicePkg
  +Build_IFWI.bat /m /l MNW2 Release
   ```
   
  -* Build Release Image
  +* Build IA32 Debug Image
   
   ```
  -cd Vlv2TbltDevicePkg
  -./Build_IFWI.sh MNW2 Release
  +cd edk2-platforms/Platform/Intel/Vlv2TbltDevicePkg
  +Build_IFWI.bat /m /IA32 MNW2 Debug
   ```

This is the section of Linux, so the build script is Build_IFWI.sh, not
Build_IFWI.bat.

Gary Lin

> 
> Thanks,
> 
> Mike
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
> > On Behalf Of Gary Lin
> > Sent: Tuesday, July 9, 2019 9:14 PM
> > To: devel@edk2.groups.io; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > <zailiang.sun@intel.com>
> > Subject: Re: [edk2-devel] [edk2-platforms Patch 00/14]
> > Vlv2TbltDevicePkg: Remove Intel Framework dependencies
> > 
> > On Wed, Jul 10, 2019 at 03:38:01AM +0000,  Michael D
> > Kinney  wrote:
> > > Hi Gary,
> > >
> > > I have pushed 2 more patches to my branch.  One fixes
> > the ASL issue
> > > without removing the code.  The second is a clean up to
> > all the DSC
> > > files and build scripts to make everything more
> > consistent and remove
> > > more unused content.
> > >
> > > https://github.com/mdkinney/edk2-
> > platforms/tree/Bug_xxx_Vlv2_Linux_And
> > > _Smbios_Fixes_V2
> > >
> > > Please test this to make sure it still works.
> > >
> > It works great! I don't need to comment out the
> > problematic line anymore.
> > 
> > > I will work on the Readme and will review the series to
> > prepare for
> > > sending the patch email review tomorrow.
> > >
> > > Thanks for all your help and testing.
> > Thanks for fixing the gcc build :)
> > 
> > Gary Lin
> > 
> > >
> > > Mike
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io
> > [mailto:devel@edk2.groups.io] On Behalf
> > > > Of Gary Lin
> > > > Sent: Monday, July 8, 2019 11:04 PM
> > > > To: devel@edk2.groups.io; Kinney, Michael D
> > > > <michael.d.kinney@intel.com>
> > > > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > > > <zailiang.sun@intel.com>
> > > > Subject: Re: [edk2-devel] [edk2-platforms Patch
> > 00/14]
> > > > Vlv2TbltDevicePkg: Remove Intel Framework
> > dependencies
> > > >
> > > > On Tue, Jul 09, 2019 at 03:52:37AM +0000,  Michael D
> > Kinney  wrote:
> > > > > Hi Gary,
> > > > >
> > > > Hi Mike,
> > > >
> > > > > I picked up the changes on your branch.  I re-
> > enabled
> > > > the BIOS ID
> > > > > Feature and added support for IA32 GCC builds, so
> > the
> > > > builds available
> > > > > from Windows and Linux are matched now.
> > > > >
> > > > > I have posted my updated branch here:
> > > > >
> > > > > https://github.com/mdkinney/edk2-
> > > > platforms/tree/Bug_xxx_Vlv2_Linux_And
> > > > > _Smbios_Fixes_V2
> > > > >
> > > > > I also verified that the SD Card support does work,
> > so
> > > > I am keeping
> > > > > that change.
> > > > >
> > > > I tested the branch + my ASL workaround and booted
> > into Linux
> > > > successfully.
> > > >
> > > > > I agree the Readme is out of date.  I will work on
> > that
> > > > and add to the
> > > > > branch referenced above tomorrow.
> > > > >
> > > > Thanks!
> > > >
> > > > Gary Lin
> > > >
> > > > > Thanks,
> > > > >
> > > > > Mike
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: devel@edk2.groups.io
> > > > [mailto:devel@edk2.groups.io] On Behalf
> > > > > > Of Gary Lin
> > > > > > Sent: Tuesday, July 2, 2019 8:57 PM
> > > > > > To: Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > > > > > Cc: devel@edk2.groups.io; Qian, Yi
> > > > <yi.qian@intel.com>; Sun,
> > > > > > Zailiang <zailiang.sun@intel.com>
> > > > > > Subject: Re: [edk2-devel] [edk2-platforms Patch
> > > > 00/14]
> > > > > > Vlv2TbltDevicePkg: Remove Intel Framework
> > > > dependencies
> > > > > >
> > > > > > On Tue, Jul 02, 2019 at 09:11:06PM +0000,
> > Kinney,
> > > > Michael D  wrote:
> > > > > > > Hi Gary,
> > > > > > >
> > > > > > Hi Mike,
> > > > > >
> > > > > > > I have posted an update to your patches the
> > removes
> > > > the
> > > > > > setting of
> > > > > > > WORKSPACE and accesses all files relative to
> > > > WORKSPACE
> > > > > > in the Linux shell scripts.
> > > > > > > It also fixes null pointer bugs in the
> > > > SmbiosMiscDxe
> > > > > > module.
> > > > > > >
> > > > > > > https://github.com/mdkinney/edk2-
> > > > > > platforms/tree/Bug_xxx_Vlv2_Linux_And
> > > > > > > _Smbios_Fixes
> > > > > > >
> > > > > > > With these changes I can boot to the UEFI Shell
> > and
> > > > to
> > > > > > Linux.  Please
> > > > > > > verify from your environments.
> > > > > > >
> > > > > > The fix for SmbiosMiscDxe works for me. Thanks
> > for
> > > > that!
> > > > > >
> > > > > > I pushed another commit to my branch to check
> > > > WORKSPACE to notify
> > > > > > the
> > > > > > user:
> > > > > >
> > > > > > https://github.com/lcp/edk2-
> > > > > >
> > > >
> > platforms/commit/fc530689e913e3de25ca2c553d616b9cef28901c
> > > > > >
> > > > > > We probably have to update Readme.md later. It's
> > > > already dated.
> > > > > >
> > > > > > > I see you have added the SDMMC modules, but I
> > do
> > > > not
> > > > > > see that peripheral yet.
> > > > > > > That feature looks like it needs some more
> > debug.
> > > > We
> > > > > > may need to back
> > > > > > > out those changes for now.
> > > > > > >
> > > > > > I saw the SD card settings in the South Cluster
> > > > Configuration menu
> > > > > > even without those SDMMC modules, so they are
> > > > probably from the
> > > > > > edk2-non-osi drivers. However, the SD card didn't
> > > > work until I added
> > > > > > the drivers from MdeModulePkg, so I need those
> > > > drivers at least for
> > > > > > my Minnowboard Turbot.
> > > > > >
> > > > > > Thanks,
> > > > > >
> > > > > > Gary Lin
> > > > > >
> > > > > > > I agree there are ASL issues.  The ASL code
> > needs
> > > > to be
> > > > > > updated to the
> > > > > > > latest ASL compiler.
> > > > > > >
> > > > > > > Thanks,
> > > > > > >
> > > > > > > Mike
> > > > > > >
> > > > > > > > -----Original Message-----
> > > > > > > > From: Kinney, Michael D
> > > > > > > > Sent: Tuesday, July 2, 2019 9:50 AM
> > > > > > > > To: Gary Lin <GLin@suse.com>;
> > > > devel@edk2.groups.io;
> > > > > > Kinney, Michael
> > > > > > > > D <michael.d.kinney@intel.com>
> > > > > > > > Cc: Qian, Yi <yi.qian@intel.com>; Sun,
> > Zailiang
> > > > > > > > <zailiang.sun@intel.com>
> > > > > > > > Subject: RE: [edk2-devel] [edk2-platforms
> > Patch
> > > > > > 00/14]
> > > > > > > > Vlv2TbltDevicePkg: Remove Intel Framework
> > > > > > dependencies
> > > > > > > >
> > > > > > > > Hi Gary,
> > > > > > > >
> > > > > > > > Thanks for the branch.  I have the build
> > working
> > > > and
> > > > > > have reproduced
> > > > > > > > the SMBIOS issue and am debugging that now.
> > > > > > > >
> > > > > > > > Mike
> > > > > > > >
> > > > > > > > > -----Original Message-----
> > > > > > > > > From: Gary Lin [mailto:GLin@suse.com]
> > > > > > > > > Sent: Tuesday, July 2, 2019 2:48 AM
> > > > > > > > > To: devel@edk2.groups.io; Kinney, Michael D
> > > > > > > > > <michael.d.kinney@intel.com>
> > > > > > > > > Cc: Qian, Yi <yi.qian@intel.com>; Sun,
> > Zailiang
> > > > > > > > > <zailiang.sun@intel.com>
> > > > > > > > > Subject: Re: [edk2-devel] [edk2-platforms
> > Patch
> > > > > > 00/14]
> > > > > > > > > Vlv2TbltDevicePkg: Remove Intel Framework
> > > > > > dependencies
> > > > > > > > >
> > > > > > > > > On Mon, Jul 01, 2019 at 11:07:11PM +0000,
> > > > Michael
> > > > > > D
> > > > > > > > Kinney  wrote:
> > > > > > > > > > Hi Gary,
> > > > > > > > > >
> > > > > > > > > > I recommend you rebase on top of this
> > series.
> > > > > > > > > >
> > > > > > > > > > I have verified Linux boots and I have
> > been
> > > > > > working
> > > > > > > > on
> > > > > > > > > the GCC and
> > > > > > > > > > Linux build scripts as well.
> > > > > > > > > >
> > > > > > > > > > Please let me know if you see any issues
> > with
> > > > > > this
> > > > > > > > > series applied and
> > > > > > > > > > I can help get them fixed.
> > > > > > > > > >
> > > > > > > > > Hi Mike,
> > > > > > > > >
> > > > > > > > > I'm rebasing my patches and they are
> > available
> > > > in
> > > > > > my
> > > > > > > > > branch:
> > > > > > > > >
> > > > > > > > > https://github.com/lcp/edk2-
> > > > platforms/commits/vlv2-
> > > > > > > > > fixes-wip
> > > > > > > > >
> > > > > > > > > It's based on
> > > > > > > > >
> > edk2(dcce9cbd48e07fcd11f7ef34cad48faf7bb61e6e)
> > > > > > > > > and edk2-non-
> > > > > > > > >
> > osi(de0a6bc19c4ee0468f04e4d37035cdc59558137f).
> > > > > > > > >
> > > > > > > > > There are 3 problems I currently
> > encountered,
> > > > and
> > > > > > maybe
> > > > > > > > you can give
> > > > > > > > > me some suggestions.
> > > > > > > > >
> > > > > > > > > 1. Missing DSDT
> > > > > > > > >
> > > > > > > > > When compiling DSDT, iasl failed with this
> > > > error:
> > > > > > > > >
> > > > > > > > > DSDT.iiii   6077:
> > > > > > > > > Or(ShiftLeft(Derefof(Index(CDCT,
> > > > \_SB.PCI0.GFX0.MCHK.DCFE)),
> > > > > > > > > 21),PARM, PARM)
> > > > > > > > > Error    6163 -
> > > > > > > > > ^ Object is created temporarily in another
> > > > method
> > > > > > and
> > > > > > > > cannot be
> > > > > > > > > accessed (\_SB.PCI0.GFX0. MCHK.DCFE)
> > > > > > > > >
> > > > > > > > > The code is from
> > > > > > > > >
> > > > > > > >
> > > > > >
> > > >
> > Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOGB
> > > > > > > > > DA.ASL
> > > > > > > > >
> > > > > > > > > I have to comment out the line or iasl
> > won't
> > > > > > generate
> > > > > > > > the aml file and
> > > > > > > > > the OS would fail to get DSDT.
> > > > > > > > >
> > > > > > > > > My acpica version is 20190509, and I
> > vaguely
> > > > > > remember
> > > > > > > > that the older
> > > > > > > > > acpica seems to be more tolerant to this
> > error.
> > > > > > > > >
> > > > > > > > > 2. Crash at SMBIOS driver
> > > > > > > > >
> > > > > > > > > When booting the system, I got the
> > following
> > > > error:
> > > > > > > > >
> > > > > > > > > Loading driver at 0x00078DBA000
> > > > > > > > EntryPoint=0x00078DBEC3C
> > > > > > > > > MiscSubclass.efi
> > > > > > > > > InstallProtocolInterface: BC62157E-3E33-
> > 4FEC-
> > > > 9920-
> > > > > > > > 2D3B36D750DF
> > > > > > > > > 78FE8D18 ProtectUefiImageCommon -
> > > > > > > > > 0x78FE8040
> > > > > > > > >   - 0x0000000078DBA000 - 0x0000000000007B80
> > > > > > > > > PlatformInfoHob->BoardId [0xB0]
> > > > > > > > > GetBiosVersionDateTime
> > :MNW2MAX1.X64.0084.D01
> > > > > > > > 01/01/2019
> > > > > > > > > 00:00
> > > > > > > > > SmbiosAdd: Smbios type 0 with size 0x48 is
> > > > added to
> > > > > > 32-
> > > > > > > > bit table
> > > > > > > > > SmbiosAdd: Smbios type 0 with size 0x48 is
> > > > added to
> > > > > > 64-
> > > > > > > > bit table
> > > > > > > > > SmbiosCreateTable: Initialize 32-bit entry
> > > > point
> > > > > > > > structure
> > > > > > > > > SmbiosCreateTable() re-allocate SMBIOS 32-
> > bit
> > > > table
> > > > > > > > > SmbiosCreateTable: Initialize 64-bit entry
> > > > point
> > > > > > > > structure
> > > > > > > > > SmbiosCreate64BitTable() re-allocate SMBIOS
> > 64-
> > > > bit
> > > > > > > > table Create Smbios
> > > > > > > > > Manu callback.
> > > > > > > > > !!!! X64 Exception Type - 06(#UD - Invalid
> > > > Opcode)
> > > > > > CPU
> > > > > > > > Apic ID -
> > > > > > > > > 00000000 !!!!
> > > > > > > > > RIP  - 0000000078DBEC26, CS  -
> > > > 0000000000000038,
> > > > > > RFLAGS
> > > > > > > > > - 0000000000010206 RAX  - 0000000000000000,
> > RCX
> > > > -
> > > > > > > > 000000007984A5A0,
> > > > > > > > > RDX - 000000007A46E5FF RBX  -
> > 000000007A46E920,
> > > > RSP
> > > > > > -
> > > > > > > > > 000000007A46E8B0, RBP -
> > > > > > > > > 0000000078DC0EC0 RSI  - 0000000000000012,
> > RDI -
> > > > > > > > > 0000000000000003
> > > > > > > > > R8   - 800000000000000E, R9  -
> > > > 000000007A46E920,
> > > > > > R10 -
> > > > > > > > > 0000000078FE8398
> > > > > > > > > R11  - 0000000000000001, R12 -
> > > > 0000000078FE8798,
> > > > > > R13 -
> > > > > > > > > 0000000078FE8898
> > > > > > > > > R14  - 0000000078FE8818, R15 -
> > 000000007A46EC60
> > > > > > > > > DS   - 0000000000000030, ES  -
> > > > 0000000000000030, FS
> > > > > > -
> > > > > > > > > 0000000000000030
> > > > > > > > > GS   - 0000000000000030, SS  -
> > 0000000000000030
> > > > > > > > > CR0  - 0000000080010013, CR2 -
> > > > 0000000000000000,
> > > > > > CR3 -
> > > > > > > > > 000000007A201000
> > > > > > > > > CR4  - 0000000000000628, CR8 -
> > 0000000000000000
> > > > > > > > > DR0  - 0000000000000000, DR1 -
> > > > 0000000000000000,
> > > > > > DR2 -
> > > > > > > > > 0000000000000000
> > > > > > > > > DR3  - 0000000000000000, DR6 -
> > > > 00000000FFFF0FF8,
> > > > > > DR7 -
> > > > > > > > > 0000000000000400 GDTR - 0000000079FFDA98
> > > > > > > > 0000000000000047, LDTR -
> > > > > > > > > 0000000000000000
> > > > > > > > > IDTR - 0000000079862018 0000000000000FFF,
> > TR
> > > > -
> > > > > > > > > 0000000000000000
> > > > > > > > > FXSAVE_STATE - 000000007A46E510 !!!! Find
> > image
> > > > based on
> > > > > > > > > IP(0x78DBEC26)
> > > > > > > > > /home/gary/git/edk2-
> > > > > > > > >
> > > > > > > >
> > > > > >
> > > >
> > workspace/Build/Vlv2TbltDevicePkg/DEBUG_GCC5/X64/Vlv2Tbl
> > > > > > > > >
> > > > > > > >
> > > > > >
> > > >
> > tDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe/DEBUG/MiscSubclas
> > > > > > > > > s.
> > > > > > > > > dll (ImageBase=0000000078DBA000,
> > > > > > > > > EntryPoint=0000000078DBEC3C) !!!!
> > > > > > > > >
> > > > > > > > > I disaseembled MiscSubclass.debug and found
> > > > that
> > > > > > the
> > > > > > > > address is a
> > > > > > > > > "ud2"
> > > > > > > > > instruction at
> > > > > > > > >
> > > > > > > >
> > > > > >
> > > >
> > SmBiosMiscDxe/MiscBaseBoardManufacturerFunction.c:MiscBa
> > > > > > > > > seBoardManufacturer()
> > > > > > > > >
> > > > > > > > > After adding a few more debug messages, the
> > > > system
> > > > > > > > crashed at another
> > > > > > > > > function:
> > > > > > > > >
> > > > > > > >
> > > > > >
> > > >
> > SmBiosMiscDxe/MiscSystemManufacturerFunction.c:AddSmbios
> > > > > > > > > ManuCallback()
> > > > > > > > >
> > > > > > > > > If I added debug messages to both
> > functions,
> > > > the
> > > > > > system
> > > > > > > > booted
> > > > > > > > > successfully. I currently didn't have any
> > clue
> > > > on
> > > > > > this.
> > > > > > > > >
> > > > > > > > > 3. The firmware always booted into EFI
> > shell.
> > > > > > > > >
> > > > > > > > > I guess something went wrong with BDS. I
> > > > haven't
> > > > > > looked
> > > > > > > > into this
> > > > > > > > > issue yet.
> > > > > > > > >
> > > > > > > > > Thanks,
> > > > > > > > >
> > > > > > > > > Gary Lin
> > > > > > > > >
> > > > > > > > > > Thanks,
> > > > > > > > > >
> > > > > > > > > > Mike
> > > > > > > > > >
> > > > > > > > > > > -----Original Message-----
> > > > > > > > > > > From: Gary Lin [mailto:GLin@suse.com]
> > > > > > > > > > > Sent: Sunday, June 30, 2019 9:04 PM
> > > > > > > > > > > To: devel@edk2.groups.io; Kinney,
> > Michael D
> > > > > > > > > > > <michael.d.kinney@intel.com>
> > > > > > > > > > > Cc: Qian, Yi <yi.qian@intel.com>; Sun,
> > > > Zailiang
> > > > > > > > > > > <zailiang.sun@intel.com>
> > > > > > > > > > > Subject: Re: [edk2-devel] [edk2-
> > platforms
> > > > Patch
> > > > > > > > > 00/14]
> > > > > > > > > > > Vlv2TbltDevicePkg: Remove Intel
> > Framework
> > > > > > > > > dependencies
> > > > > > > > > > >
> > > > > > > > > > > On Sun, Jun 30, 2019 at 07:55:39PM -
> > 0700,
> > > > > > Michael
> > > > > > > > D
> > > > > > > > > Kinney  wrote:
> > > > > > > > > > > > The following changes remove all
> > > > dependencies
> > > > > > on
> > > > > > > > > the
> > > > > > > > > > > IntelFrameworkPkg
> > > > > > > > > > > > and IntelFrameworkModulePkg from the
> > > > > > > > > Vlv2TbltDevicePkg
> > > > > > > > > > > platform
> > > > > > > > > > > > builds.  These changes do depend on
> > > > updates
> > > > > > > > > binaries
> > > > > > > > > > > on the edk2-non-osi repository.
> > > > > > > > > > > >
> > > > > > > > > > > Hi Michael,
> > > > > > > > > > >
> > > > > > > > > > > I am amending the bash scripts for gcc.
> > The
> > > > > > > > firmware
> > > > > > > > > I built is
> > > > > > > > > > > using the binaries from
> > Development190216
> > > > and
> > > > > > could
> > > > > > > > > boot into Linux
> > > > > > > > > > > successfully with some workarounds for
> > > > Wpce791,
> > > > > > > > Bds,
> > > > > > > > > and
> > > > > > > > > > > InteFspWrapper. The patches you posted
> > > > > > eliminate
> > > > > > > > > those parts I have
> > > > > > > > > > > to work around.
> > > > > > > > > > >
> > > > > > > > > > > Just want to know if you need any
> > > > assistance
> > > > > > for
> > > > > > > > the
> > > > > > > > > gcc build? I
> > > > > > > > > > > could rebase my work upon your patches
> > and
> > > > send
> > > > > > > > them
> > > > > > > > > later.
> > > > > > > > > > >
> > > > > > > > > > > Thanks,
> > > > > > > > > > >
> > > > > > > > > > > Gary Lin
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
> > >
> > 
> > 
> 
> 
> 
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43459): https://edk2.groups.io/g/devel/message/43459
Mute This Topic: https://groups.io/mt/32267616/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Gary,

Thanks for the feedback.  I fixes these in the patch email review
I sent out today.

Mike

> -----Original Message-----
> From: Gary Lin [mailto:GLin@suse.com]
> Sent: Wednesday, July 10, 2019 12:10 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> <zailiang.sun@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms Patch 00/14]
> Vlv2TbltDevicePkg: Remove Intel Framework dependencies
> 
> On Wed, Jul 10, 2019 at 05:01:32AM +0000,  Michael D
> Kinney  wrote:
> > Hi Gary,
> >
> > I have added 2 more patches.  One to disable capsule
> generation for
> > IA32 builds.  There are several places the output
> directory is hard
> > coded for X64.  Will require converting the POST_BUILD
> scripts to
> > python to make this much better.
> >
> > The second patch is for the Readme.md.  Please review
> and verify the
> > instructions.
> I found some typos in the Readme.md:
> 
> 1. The path to the capsules:
> 
>   -    apt-get install libc:i386
> 
> +`Build\Vlv2TbltDevicePkgIA32\RELEASE_VS2015x86\FV\Vlv.RO
> M`
>   +
>   +The X64 CapsuleApp and generated UEFI Capsules are in
> the directory
>   +
>   +`Build/Vlv2TbltDevicePkg/Capsules`
>   +
>   +# Linux Pre-requisites
> 
>    # Download and Build MinnowMax using Linux/GCC
> 
> Since it's still in the section of windows, so the path
> needs the fix:
> 
> Build/Vlv2TbltDevicePkg/Capsules =>
> Build\Vlv2TbltDevicePkg\Capsules
> 
> 2. The name of gcc script:
> 
>    Once the environment is setup, the MinnowBoard MAX
> firmware and capsules can be
>    rebuilt using the following commands.
> 
>   +* Build X64 Debug Image with report file
>   +
>   +```
>   +cd edk2-platforms/Platform/Intel/Vlv2TbltDevicePkg
>   +Build_IFWI.bat /m /y MNW2 Debug
>   +```
> 
>   -* Build Debug Image
>   +* Build X64 Release Image with build log
> 
>    ```
>   -cd Vlv2TbltDevicePkg
>   -./Build_IFWI.sh MNW2 Debug
>   +cd edk2-platforms/Platform/Intel/Vlv2TbltDevicePkg
>   +Build_IFWI.bat /m /l MNW2 Release
>    ```
> 
>   -* Build Release Image
>   +* Build IA32 Debug Image
> 
>    ```
>   -cd Vlv2TbltDevicePkg
>   -./Build_IFWI.sh MNW2 Release
>   +cd edk2-platforms/Platform/Intel/Vlv2TbltDevicePkg
>   +Build_IFWI.bat /m /IA32 MNW2 Debug
>    ```
> 
> This is the section of Linux, so the build script is
> Build_IFWI.sh, not Build_IFWI.bat.
> 
> Gary Lin
> 
> >
> > Thanks,
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io
> [mailto:devel@edk2.groups.io] On Behalf
> > > Of Gary Lin
> > > Sent: Tuesday, July 9, 2019 9:14 PM
> > > To: devel@edk2.groups.io; Kinney, Michael D
> > > <michael.d.kinney@intel.com>
> > > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > > <zailiang.sun@intel.com>
> > > Subject: Re: [edk2-devel] [edk2-platforms Patch
> 00/14]
> > > Vlv2TbltDevicePkg: Remove Intel Framework
> dependencies
> > >
> > > On Wed, Jul 10, 2019 at 03:38:01AM +0000,  Michael D
> Kinney  wrote:
> > > > Hi Gary,
> > > >
> > > > I have pushed 2 more patches to my branch.  One
> fixes
> > > the ASL issue
> > > > without removing the code.  The second is a clean
> up to
> > > all the DSC
> > > > files and build scripts to make everything more
> > > consistent and remove
> > > > more unused content.
> > > >
> > > > https://github.com/mdkinney/edk2-
> > > platforms/tree/Bug_xxx_Vlv2_Linux_And
> > > > _Smbios_Fixes_V2
> > > >
> > > > Please test this to make sure it still works.
> > > >
> > > It works great! I don't need to comment out the
> problematic line
> > > anymore.
> > >
> > > > I will work on the Readme and will review the
> series to
> > > prepare for
> > > > sending the patch email review tomorrow.
> > > >
> > > > Thanks for all your help and testing.
> > > Thanks for fixing the gcc build :)
> > >
> > > Gary Lin
> > >
> > > >
> > > > Mike
> > > >
> > > > > -----Original Message-----
> > > > > From: devel@edk2.groups.io
> > > [mailto:devel@edk2.groups.io] On Behalf
> > > > > Of Gary Lin
> > > > > Sent: Monday, July 8, 2019 11:04 PM
> > > > > To: devel@edk2.groups.io; Kinney, Michael D
> > > > > <michael.d.kinney@intel.com>
> > > > > Cc: Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> > > > > <zailiang.sun@intel.com>
> > > > > Subject: Re: [edk2-devel] [edk2-platforms Patch
> > > 00/14]
> > > > > Vlv2TbltDevicePkg: Remove Intel Framework
> > > dependencies
> > > > >
> > > > > On Tue, Jul 09, 2019 at 03:52:37AM +0000,
> Michael D
> > > Kinney  wrote:
> > > > > > Hi Gary,
> > > > > >
> > > > > Hi Mike,
> > > > >
> > > > > > I picked up the changes on your branch.  I re-
> > > enabled
> > > > > the BIOS ID
> > > > > > Feature and added support for IA32 GCC builds,
> so
> > > the
> > > > > builds available
> > > > > > from Windows and Linux are matched now.
> > > > > >
> > > > > > I have posted my updated branch here:
> > > > > >
> > > > > > https://github.com/mdkinney/edk2-
> > > > > platforms/tree/Bug_xxx_Vlv2_Linux_And
> > > > > > _Smbios_Fixes_V2
> > > > > >
> > > > > > I also verified that the SD Card support does
> work,
> > > so
> > > > > I am keeping
> > > > > > that change.
> > > > > >
> > > > > I tested the branch + my ASL workaround and
> booted
> > > into Linux
> > > > > successfully.
> > > > >
> > > > > > I agree the Readme is out of date.  I will work
> on
> > > that
> > > > > and add to the
> > > > > > branch referenced above tomorrow.
> > > > > >
> > > > > Thanks!
> > > > >
> > > > > Gary Lin
> > > > >
> > > > > > Thanks,
> > > > > >
> > > > > > Mike
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: devel@edk2.groups.io
> > > > > [mailto:devel@edk2.groups.io] On Behalf
> > > > > > > Of Gary Lin
> > > > > > > Sent: Tuesday, July 2, 2019 8:57 PM
> > > > > > > To: Kinney, Michael D
> > > <michael.d.kinney@intel.com>
> > > > > > > Cc: devel@edk2.groups.io; Qian, Yi
> > > > > <yi.qian@intel.com>; Sun,
> > > > > > > Zailiang <zailiang.sun@intel.com>
> > > > > > > Subject: Re: [edk2-devel] [edk2-platforms
> Patch
> > > > > 00/14]
> > > > > > > Vlv2TbltDevicePkg: Remove Intel Framework
> > > > > dependencies
> > > > > > >
> > > > > > > On Tue, Jul 02, 2019 at 09:11:06PM +0000,
> > > Kinney,
> > > > > Michael D  wrote:
> > > > > > > > Hi Gary,
> > > > > > > >
> > > > > > > Hi Mike,
> > > > > > >
> > > > > > > > I have posted an update to your patches the
> > > removes
> > > > > the
> > > > > > > setting of
> > > > > > > > WORKSPACE and accesses all files relative
> to
> > > > > WORKSPACE
> > > > > > > in the Linux shell scripts.
> > > > > > > > It also fixes null pointer bugs in the
> > > > > SmbiosMiscDxe
> > > > > > > module.
> > > > > > > >
> > > > > > > > https://github.com/mdkinney/edk2-
> > > > > > > platforms/tree/Bug_xxx_Vlv2_Linux_And
> > > > > > > > _Smbios_Fixes
> > > > > > > >
> > > > > > > > With these changes I can boot to the UEFI
> Shell
> > > and
> > > > > to
> > > > > > > Linux.  Please
> > > > > > > > verify from your environments.
> > > > > > > >
> > > > > > > The fix for SmbiosMiscDxe works for me.
> Thanks
> > > for
> > > > > that!
> > > > > > >
> > > > > > > I pushed another commit to my branch to check
> > > > > WORKSPACE to notify
> > > > > > > the
> > > > > > > user:
> > > > > > >
> > > > > > > https://github.com/lcp/edk2-
> > > > > > >
> > > > >
> > >
> platforms/commit/fc530689e913e3de25ca2c553d616b9cef28901c
> > > > > > >
> > > > > > > We probably have to update Readme.md later.
> It's
> > > > > already dated.
> > > > > > >
> > > > > > > > I see you have added the SDMMC modules, but
> I
> > > do
> > > > > not
> > > > > > > see that peripheral yet.
> > > > > > > > That feature looks like it needs some more
> > > debug.
> > > > > We
> > > > > > > may need to back
> > > > > > > > out those changes for now.
> > > > > > > >
> > > > > > > I saw the SD card settings in the South
> Cluster
> > > > > Configuration menu
> > > > > > > even without those SDMMC modules, so they are
> > > > > probably from the
> > > > > > > edk2-non-osi drivers. However, the SD card
> didn't
> > > > > work until I added
> > > > > > > the drivers from MdeModulePkg, so I need
> those
> > > > > drivers at least for
> > > > > > > my Minnowboard Turbot.
> > > > > > >
> > > > > > > Thanks,
> > > > > > >
> > > > > > > Gary Lin
> > > > > > >
> > > > > > > > I agree there are ASL issues.  The ASL code
> > > needs
> > > > > to be
> > > > > > > updated to the
> > > > > > > > latest ASL compiler.
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > >
> > > > > > > > Mike
> > > > > > > >
> > > > > > > > > -----Original Message-----
> > > > > > > > > From: Kinney, Michael D
> > > > > > > > > Sent: Tuesday, July 2, 2019 9:50 AM
> > > > > > > > > To: Gary Lin <GLin@suse.com>;
> > > > > devel@edk2.groups.io;
> > > > > > > Kinney, Michael
> > > > > > > > > D <michael.d.kinney@intel.com>
> > > > > > > > > Cc: Qian, Yi <yi.qian@intel.com>; Sun,
> > > Zailiang
> > > > > > > > > <zailiang.sun@intel.com>
> > > > > > > > > Subject: RE: [edk2-devel] [edk2-platforms
> > > Patch
> > > > > > > 00/14]
> > > > > > > > > Vlv2TbltDevicePkg: Remove Intel Framework
> > > > > > > dependencies
> > > > > > > > >
> > > > > > > > > Hi Gary,
> > > > > > > > >
> > > > > > > > > Thanks for the branch.  I have the build
> > > working
> > > > > and
> > > > > > > have reproduced
> > > > > > > > > the SMBIOS issue and am debugging that
> now.
> > > > > > > > >
> > > > > > > > > Mike
> > > > > > > > >
> > > > > > > > > > -----Original Message-----
> > > > > > > > > > From: Gary Lin [mailto:GLin@suse.com]
> > > > > > > > > > Sent: Tuesday, July 2, 2019 2:48 AM
> > > > > > > > > > To: devel@edk2.groups.io; Kinney,
> Michael D
> > > > > > > > > > <michael.d.kinney@intel.com>
> > > > > > > > > > Cc: Qian, Yi <yi.qian@intel.com>; Sun,
> > > Zailiang
> > > > > > > > > > <zailiang.sun@intel.com>
> > > > > > > > > > Subject: Re: [edk2-devel] [edk2-
> platforms
> > > Patch
> > > > > > > 00/14]
> > > > > > > > > > Vlv2TbltDevicePkg: Remove Intel
> Framework
> > > > > > > dependencies
> > > > > > > > > >
> > > > > > > > > > On Mon, Jul 01, 2019 at 11:07:11PM
> +0000,
> > > > > Michael
> > > > > > > D
> > > > > > > > > Kinney  wrote:
> > > > > > > > > > > Hi Gary,
> > > > > > > > > > >
> > > > > > > > > > > I recommend you rebase on top of this
> > > series.
> > > > > > > > > > >
> > > > > > > > > > > I have verified Linux boots and I
> have
> > > been
> > > > > > > working
> > > > > > > > > on
> > > > > > > > > > the GCC and
> > > > > > > > > > > Linux build scripts as well.
> > > > > > > > > > >
> > > > > > > > > > > Please let me know if you see any
> issues
> > > with
> > > > > > > this
> > > > > > > > > > series applied and
> > > > > > > > > > > I can help get them fixed.
> > > > > > > > > > >
> > > > > > > > > > Hi Mike,
> > > > > > > > > >
> > > > > > > > > > I'm rebasing my patches and they are
> > > available
> > > > > in
> > > > > > > my
> > > > > > > > > > branch:
> > > > > > > > > >
> > > > > > > > > > https://github.com/lcp/edk2-
> > > > > platforms/commits/vlv2-
> > > > > > > > > > fixes-wip
> > > > > > > > > >
> > > > > > > > > > It's based on
> > > > > > > > > >
> > > edk2(dcce9cbd48e07fcd11f7ef34cad48faf7bb61e6e)
> > > > > > > > > > and edk2-non-
> > > > > > > > > >
> > > osi(de0a6bc19c4ee0468f04e4d37035cdc59558137f).
> > > > > > > > > >
> > > > > > > > > > There are 3 problems I currently
> > > encountered,
> > > > > and
> > > > > > > maybe
> > > > > > > > > you can give
> > > > > > > > > > me some suggestions.
> > > > > > > > > >
> > > > > > > > > > 1. Missing DSDT
> > > > > > > > > >
> > > > > > > > > > When compiling DSDT, iasl failed with
> this
> > > > > error:
> > > > > > > > > >
> > > > > > > > > > DSDT.iiii   6077:
> > > > > > > > > > Or(ShiftLeft(Derefof(Index(CDCT,
> > > > > \_SB.PCI0.GFX0.MCHK.DCFE)),
> > > > > > > > > > 21),PARM, PARM)
> > > > > > > > > > Error    6163 -
> > > > > > > > > > ^ Object is created temporarily in
> another
> > > > > method
> > > > > > > and
> > > > > > > > > cannot be
> > > > > > > > > > accessed (\_SB.PCI0.GFX0. MCHK.DCFE)
> > > > > > > > > >
> > > > > > > > > > The code is from
> > > > > > > > > >
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOGB
> > > > > > > > > > DA.ASL
> > > > > > > > > >
> > > > > > > > > > I have to comment out the line or iasl
> > > won't
> > > > > > > generate
> > > > > > > > > the aml file and
> > > > > > > > > > the OS would fail to get DSDT.
> > > > > > > > > >
> > > > > > > > > > My acpica version is 20190509, and I
> > > vaguely
> > > > > > > remember
> > > > > > > > > that the older
> > > > > > > > > > acpica seems to be more tolerant to
> this
> > > error.
> > > > > > > > > >
> > > > > > > > > > 2. Crash at SMBIOS driver
> > > > > > > > > >
> > > > > > > > > > When booting the system, I got the
> > > following
> > > > > error:
> > > > > > > > > >
> > > > > > > > > > Loading driver at 0x00078DBA000
> > > > > > > > > EntryPoint=0x00078DBEC3C
> > > > > > > > > > MiscSubclass.efi
> > > > > > > > > > InstallProtocolInterface: BC62157E-
> 3E33-
> > > 4FEC-
> > > > > 9920-
> > > > > > > > > 2D3B36D750DF
> > > > > > > > > > 78FE8D18 ProtectUefiImageCommon -
> > > > > > > > > > 0x78FE8040
> > > > > > > > > >   - 0x0000000078DBA000 -
> 0x0000000000007B80
> > > > > > > > > > PlatformInfoHob->BoardId [0xB0]
> > > > > > > > > > GetBiosVersionDateTime
> > > :MNW2MAX1.X64.0084.D01
> > > > > > > > > 01/01/2019
> > > > > > > > > > 00:00
> > > > > > > > > > SmbiosAdd: Smbios type 0 with size 0x48
> is
> > > > > added to
> > > > > > > 32-
> > > > > > > > > bit table
> > > > > > > > > > SmbiosAdd: Smbios type 0 with size 0x48
> is
> > > > > added to
> > > > > > > 64-
> > > > > > > > > bit table
> > > > > > > > > > SmbiosCreateTable: Initialize 32-bit
> entry
> > > > > point
> > > > > > > > > structure
> > > > > > > > > > SmbiosCreateTable() re-allocate SMBIOS
> 32-
> > > bit
> > > > > table
> > > > > > > > > > SmbiosCreateTable: Initialize 64-bit
> entry
> > > > > point
> > > > > > > > > structure
> > > > > > > > > > SmbiosCreate64BitTable() re-allocate
> SMBIOS
> > > 64-
> > > > > bit
> > > > > > > > > table Create Smbios
> > > > > > > > > > Manu callback.
> > > > > > > > > > !!!! X64 Exception Type - 06(#UD -
> Invalid
> > > > > Opcode)
> > > > > > > CPU
> > > > > > > > > Apic ID -
> > > > > > > > > > 00000000 !!!!
> > > > > > > > > > RIP  - 0000000078DBEC26, CS  -
> > > > > 0000000000000038,
> > > > > > > RFLAGS
> > > > > > > > > > - 0000000000010206 RAX  -
> 0000000000000000,
> > > RCX
> > > > > -
> > > > > > > > > 000000007984A5A0,
> > > > > > > > > > RDX - 000000007A46E5FF RBX  -
> > > 000000007A46E920,
> > > > > RSP
> > > > > > > -
> > > > > > > > > > 000000007A46E8B0, RBP -
> > > > > > > > > > 0000000078DC0EC0 RSI  -
> 0000000000000012,
> > > RDI -
> > > > > > > > > > 0000000000000003
> > > > > > > > > > R8   - 800000000000000E, R9  -
> > > > > 000000007A46E920,
> > > > > > > R10 -
> > > > > > > > > > 0000000078FE8398
> > > > > > > > > > R11  - 0000000000000001, R12 -
> > > > > 0000000078FE8798,
> > > > > > > R13 -
> > > > > > > > > > 0000000078FE8898
> > > > > > > > > > R14  - 0000000078FE8818, R15 -
> > > 000000007A46EC60
> > > > > > > > > > DS   - 0000000000000030, ES  -
> > > > > 0000000000000030, FS
> > > > > > > -
> > > > > > > > > > 0000000000000030
> > > > > > > > > > GS   - 0000000000000030, SS  -
> > > 0000000000000030
> > > > > > > > > > CR0  - 0000000080010013, CR2 -
> > > > > 0000000000000000,
> > > > > > > CR3 -
> > > > > > > > > > 000000007A201000
> > > > > > > > > > CR4  - 0000000000000628, CR8 -
> > > 0000000000000000
> > > > > > > > > > DR0  - 0000000000000000, DR1 -
> > > > > 0000000000000000,
> > > > > > > DR2 -
> > > > > > > > > > 0000000000000000
> > > > > > > > > > DR3  - 0000000000000000, DR6 -
> > > > > 00000000FFFF0FF8,
> > > > > > > DR7 -
> > > > > > > > > > 0000000000000400 GDTR -
> 0000000079FFDA98
> > > > > > > > > 0000000000000047, LDTR -
> > > > > > > > > > 0000000000000000
> > > > > > > > > > IDTR - 0000000079862018
> 0000000000000FFF,
> > > TR
> > > > > -
> > > > > > > > > > 0000000000000000
> > > > > > > > > > FXSAVE_STATE - 000000007A46E510 !!!!
> Find
> > > image
> > > > > based on
> > > > > > > > > > IP(0x78DBEC26)
> > > > > > > > > > /home/gary/git/edk2-
> > > > > > > > > >
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> workspace/Build/Vlv2TbltDevicePkg/DEBUG_GCC5/X64/Vlv2Tbl
> > > > > > > > > >
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> tDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe/DEBUG/MiscSubclas
> > > > > > > > > > s.
> > > > > > > > > > dll (ImageBase=0000000078DBA000,
> > > > > > > > > > EntryPoint=0000000078DBEC3C) !!!!
> > > > > > > > > >
> > > > > > > > > > I disaseembled MiscSubclass.debug and
> found
> > > > > that
> > > > > > > the
> > > > > > > > > address is a
> > > > > > > > > > "ud2"
> > > > > > > > > > instruction at
> > > > > > > > > >
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> SmBiosMiscDxe/MiscBaseBoardManufacturerFunction.c:MiscBa
> > > > > > > > > > seBoardManufacturer()
> > > > > > > > > >
> > > > > > > > > > After adding a few more debug messages,
> the
> > > > > system
> > > > > > > > > crashed at another
> > > > > > > > > > function:
> > > > > > > > > >
> > > > > > > > >
> > > > > > >
> > > > >
> > >
> SmBiosMiscDxe/MiscSystemManufacturerFunction.c:AddSmbios
> > > > > > > > > > ManuCallback()
> > > > > > > > > >
> > > > > > > > > > If I added debug messages to both
> > > functions,
> > > > > the
> > > > > > > system
> > > > > > > > > booted
> > > > > > > > > > successfully. I currently didn't have
> any
> > > clue
> > > > > on
> > > > > > > this.
> > > > > > > > > >
> > > > > > > > > > 3. The firmware always booted into EFI
> > > shell.
> > > > > > > > > >
> > > > > > > > > > I guess something went wrong with BDS.
> I
> > > > > haven't
> > > > > > > looked
> > > > > > > > > into this
> > > > > > > > > > issue yet.
> > > > > > > > > >
> > > > > > > > > > Thanks,
> > > > > > > > > >
> > > > > > > > > > Gary Lin
> > > > > > > > > >
> > > > > > > > > > > Thanks,
> > > > > > > > > > >
> > > > > > > > > > > Mike
> > > > > > > > > > >
> > > > > > > > > > > > -----Original Message-----
> > > > > > > > > > > > From: Gary Lin
> [mailto:GLin@suse.com]
> > > > > > > > > > > > Sent: Sunday, June 30, 2019 9:04 PM
> > > > > > > > > > > > To: devel@edk2.groups.io; Kinney,
> > > Michael D
> > > > > > > > > > > > <michael.d.kinney@intel.com>
> > > > > > > > > > > > Cc: Qian, Yi <yi.qian@intel.com>;
> Sun,
> > > > > Zailiang
> > > > > > > > > > > > <zailiang.sun@intel.com>
> > > > > > > > > > > > Subject: Re: [edk2-devel] [edk2-
> > > platforms
> > > > > Patch
> > > > > > > > > > 00/14]
> > > > > > > > > > > > Vlv2TbltDevicePkg: Remove Intel
> > > Framework
> > > > > > > > > > dependencies
> > > > > > > > > > > >
> > > > > > > > > > > > On Sun, Jun 30, 2019 at 07:55:39PM
> -
> > > 0700,
> > > > > > > Michael
> > > > > > > > > D
> > > > > > > > > > Kinney  wrote:
> > > > > > > > > > > > > The following changes remove all
> > > > > dependencies
> > > > > > > on
> > > > > > > > > > the
> > > > > > > > > > > > IntelFrameworkPkg
> > > > > > > > > > > > > and IntelFrameworkModulePkg from
> the
> > > > > > > > > > Vlv2TbltDevicePkg
> > > > > > > > > > > > platform
> > > > > > > > > > > > > builds.  These changes do depend
> on
> > > > > updates
> > > > > > > > > > binaries
> > > > > > > > > > > > on the edk2-non-osi repository.
> > > > > > > > > > > > >
> > > > > > > > > > > > Hi Michael,
> > > > > > > > > > > >
> > > > > > > > > > > > I am amending the bash scripts for
> gcc.
> > > The
> > > > > > > > > firmware
> > > > > > > > > > I built is
> > > > > > > > > > > > using the binaries from
> > > Development190216
> > > > > and
> > > > > > > could
> > > > > > > > > > boot into Linux
> > > > > > > > > > > > successfully with some workarounds
> for
> > > > > Wpce791,
> > > > > > > > > Bds,
> > > > > > > > > > and
> > > > > > > > > > > > InteFspWrapper. The patches you
> posted
> > > > > > > eliminate
> > > > > > > > > > those parts I have
> > > > > > > > > > > > to work around.
> > > > > > > > > > > >
> > > > > > > > > > > > Just want to know if you need any
> > > > > assistance
> > > > > > > for
> > > > > > > > > the
> > > > > > > > > > gcc build? I
> > > > > > > > > > > > could rebase my work upon your
> patches
> > > and
> > > > > send
> > > > > > > > > them
> > > > > > > > > > later.
> > > > > > > > > > > >
> > > > > > > > > > > > Thanks,
> > > > > > > > > > > >
> > > > > > > > > > > > Gary Lin
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> >
> >
> > 
> >
> >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43523): https://edk2.groups.io/g/devel/message/43523
Mute This Topic: https://groups.io/mt/32267616/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-