Clean up acpiview input parameters

[edk2-devel] [PATCH v1 0/5] Clean up acpiview input parameters

Posted by Krzysztof Koch 4 years, 10 months ago

The following patches modify the user interface to the Acpiview UEFI
shell tool.

These changes are aimed to simplify interaction with the tool as well
as to remove redundant/non-functional command line parameters.

Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/612_acpiview_flags_fix_v1

Krzysztof Koch (5):
  ShellPkg: acpiview: Remove '/?' from valid command line flags
  ShellPkg: acpiview: Fix '\n\n' printing in Table Checksum reporting
  ShellPkg: acpiview: Allow disabling consistency checks (-q flag)
  ShellPkg: acpiview: Remove '-v' flag from allowed command line args
  ShellPkg: acpiview: Make '-h' option not require a parameter

 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c                    | 14 ++--
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.c               |  6 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c                      | 71 ++++++++++----------
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.h                      | 23 ++++++-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni |  9 +--
 5 files changed, 74 insertions(+), 49 deletions(-)

--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42996): https://edk2.groups.io/g/devel/message/42996
Mute This Topic: https://groups.io/mt/32240028/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 0/5] Clean up acpiview input parameters

Posted by Alexei Fedorov 4 years, 10 months ago

Reviewed-by: Alexei Fedorov <Alexei.Fedorov@arm.com>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43021): https://edk2.groups.io/g/devel/message/43021
Mute This Topic: https://groups.io/mt/32240028/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 0/5] Clean up acpiview input parameters

Posted by Sami Mujawar 4 years, 9 months ago

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

-----Original Message-----
From: Krzysztof Koch <krzysztof.koch@arm.com> 
Sent: 28 June 2019 09:57 AM
To: devel@edk2.groups.io
Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; Sami Mujawar <Sami.Mujawar@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; nd <nd@arm.com>
Subject: [PATCH v1 0/5] Clean up acpiview input parameters

The following patches modify the user interface to the Acpiview UEFI shell tool.

These changes are aimed to simplify interaction with the tool as well as to remove redundant/non-functional command line parameters.

Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/612_acpiview_flags_fix_v1

Krzysztof Koch (5):
  ShellPkg: acpiview: Remove '/?' from valid command line flags
  ShellPkg: acpiview: Fix '\n\n' printing in Table Checksum reporting
  ShellPkg: acpiview: Allow disabling consistency checks (-q flag)
  ShellPkg: acpiview: Remove '-v' flag from allowed command line args
  ShellPkg: acpiview: Make '-h' option not require a parameter

 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c                    | 14 ++--
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.c               |  6 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c                      | 71 ++++++++++----------
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.h                      | 23 ++++++-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni |  9 +--
 5 files changed, 74 insertions(+), 49 deletions(-)

--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43156): https://edk2.groups.io/g/devel/message/43156
Mute This Topic: https://groups.io/mt/32240028/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 0/5] Clean up acpiview input parameters

Posted by Gao, Zhichao 4 years, 9 months ago

Series: Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Krzysztof Koch
> Sent: Friday, June 28, 2019 4:57 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Gao, Zhichao <zhichao.gao@intel.com>; Sami.Mujawar@arm.com;
> Matteo.Carlini@arm.com; nd@arm.com
> Subject: [edk2-devel] [PATCH v1 0/5] Clean up acpiview input parameters
> 
> The following patches modify the user interface to the Acpiview UEFI shell
> tool.
> 
> These changes are aimed to simplify interaction with the tool as well as to
> remove redundant/non-functional command line parameters.
> 
> Changes can be seen at:
> https://github.com/KrzysztofKoch1/edk2/tree/612_acpiview_flags_fix_v1
> 
> Krzysztof Koch (5):
>   ShellPkg: acpiview: Remove '/?' from valid command line flags
>   ShellPkg: acpiview: Fix '\n\n' printing in Table Checksum reporting
>   ShellPkg: acpiview: Allow disabling consistency checks (-q flag)
>   ShellPkg: acpiview: Remove '-v' flag from allowed command line args
>   ShellPkg: acpiview: Make '-h' option not require a parameter
> 
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c                    | 14
> ++--
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.c               |
> 6 +-
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c                      | 71
> ++++++++++----------
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.h                      | 23
> ++++++-
> 
> ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComman
> dLib.uni |  9 +--
>  5 files changed, 74 insertions(+), 49 deletions(-)
> 
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43077): https://edk2.groups.io/g/devel/message/43077
Mute This Topic: https://groups.io/mt/32240028/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-