BaseTools: Separate current CreateAsBuiltInf function into two

[edk2-devel] [Patch 0/2] BaseTools: Separate current CreateAsBuiltInf function into two

Posted by Bob Feng 4 years, 10 months ago

https://bugzilla.tianocore.org/show_bug.cgi?id=1932

In current implementation, there are 2 functions in CreateAsBuiltInf, 
one is create asbuildinf, the other is update build cache. 
They should be separated.

Feng, Bob C (2):
  BaseTools: refine CreateAsBuiltInf function
  BaseTools: Move Build Cache related function out of CreateAsBuiltInf

 BaseTools/Source/Python/AutoGen/AutoGen.py | 73 ++++++++++++++++++++++++++++++++++++++-----------------------------------
 BaseTools/Source/Python/build/build.py     | 26 ++++++++++++++++++++++----
 2 files changed, 60 insertions(+), 39 deletions(-)

-- 
2.20.1.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42725): https://edk2.groups.io/g/devel/message/42725
Mute This Topic: https://groups.io/mt/32187979/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch 0/2] BaseTools: Separate current CreateAsBuiltInf function into two

Posted by Carsey, Jaben 4 years, 10 months ago

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

Much clearer code to see what's actually happening.


> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Bob Feng
> Sent: Sunday, June 23, 2019 6:51 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [Patch 0/2] BaseTools: Separate current
> CreateAsBuiltInf function into two
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=1932
> 
> In current implementation, there are 2 functions in CreateAsBuiltInf,
> one is create asbuildinf, the other is update build cache.
> They should be separated.
> 
> Feng, Bob C (2):
>   BaseTools: refine CreateAsBuiltInf function
>   BaseTools: Move Build Cache related function out of CreateAsBuiltInf
> 
>  BaseTools/Source/Python/AutoGen/AutoGen.py | 73
> ++++++++++++++++++++++++++++++++++++++---------------------------------
> --
>  BaseTools/Source/Python/build/build.py     | 26
> ++++++++++++++++++++++----
>  2 files changed, 60 insertions(+), 39 deletions(-)
> 
> --
> 2.20.1.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42751): https://edk2.groups.io/g/devel/message/42751
Mute This Topic: https://groups.io/mt/32187979/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-