[v5] Use a pcd to control Platform Recovery behavior

[edk2-devel] [PATCH v5 0/2] Use a pcd to control Platform Recovery behavior

Posted by Gao, Zhichao 6 years, 7 months ago

V1:
Add a pcd PcdPlatformRecoverySupport to control the variable
PlatformRecovery#### and the EFI_OS_INDICATIONS_START_PLATFORM_RECOVERY
bit of variable "OsIndicationsSupported".

V2:
While PcdPlatformRecoverySupport is FALSE, do not set a PlatformRecovery####
Variable.
But remain boot from a default file path(such as \EFI\BOOT\BOOTX64.EFI).
Add memory check before build platform default boot option.

V3:
Modify the memory check operation. If fail to allocate memory for the defualt
boot file path, put the system into dead loop to indicate it is unable to boot.

v4:
Add the description of PcdPlatformRecoverySupport in MdeModulePkg.uni
Fix incorrect check of LoadOption. Should check PlatformDefaultBootOption.

v5:
Fix the incorrect string in MdeModulePkg.uni:
Add STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPlatformRecoverySupport_PROMPT
and STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPlatformRecoverySupport_HELP
base on the description in MdeModulePkg.dec file.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>

Bret Barkelew (1):
  MdeModulePkg: Add a pcd to set the OS indications bit

Zhichao Gao (1):
  MdeModulePkg/BdsDxe: Use a pcd to control PlatformRecovery

 MdeModulePkg/MdeModulePkg.dec            |  6 ++
 MdeModulePkg/MdeModulePkg.uni            |  6 ++
 MdeModulePkg/Universal/BdsDxe/BdsDxe.inf |  3 +-
 MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 71 +++++++++++++++---------
 4 files changed, 59 insertions(+), 27 deletions(-)

-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42624): https://edk2.groups.io/g/devel/message/42624
Mute This Topic: https://groups.io/mt/32140505/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v5 0/2] Use a pcd to control Platform Recovery behavior

Posted by Wu, Hao A 6 years, 7 months ago

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Gao, Zhichao
> Sent: Thursday, June 20, 2019 11:44 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan;
> Michael Turner; Bret Barkelew
> Subject: [edk2-devel] [PATCH v5 0/2] Use a pcd to control Platform Recovery
> behavior
> 
> V1:
> Add a pcd PcdPlatformRecoverySupport to control the variable
> PlatformRecovery#### and the
> EFI_OS_INDICATIONS_START_PLATFORM_RECOVERY
> bit of variable "OsIndicationsSupported".
> 
> V2:
> While PcdPlatformRecoverySupport is FALSE, do not set a
> PlatformRecovery####
> Variable.
> But remain boot from a default file path(such as \EFI\BOOT\BOOTX64.EFI).
> Add memory check before build platform default boot option.
> 
> V3:
> Modify the memory check operation. If fail to allocate memory for the
> defualt
> boot file path, put the system into dead loop to indicate it is unable to boot.
> 
> v4:
> Add the description of PcdPlatformRecoverySupport in MdeModulePkg.uni
> Fix incorrect check of LoadOption. Should check PlatformDefaultBootOption.
> 
> v5:
> Fix the incorrect string in MdeModulePkg.uni:
> Add
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPlatformRecoverySupport_PR
> OMPT
> and
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPlatformRecoverySupport_HE
> LP
> base on the description in MdeModulePkg.dec file.


For the series,
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

And I will take Ray's R-B tag from V4 series as well, since V5 series only
addressed a typo in UNI file.

Pushed via commits b7cd36a224..0889500ce1.

Best Regards,
Hao Wu


> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Turner <Michael.Turner@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> 
> Bret Barkelew (1):
>   MdeModulePkg: Add a pcd to set the OS indications bit
> 
> Zhichao Gao (1):
>   MdeModulePkg/BdsDxe: Use a pcd to control PlatformRecovery
> 
>  MdeModulePkg/MdeModulePkg.dec            |  6 ++
>  MdeModulePkg/MdeModulePkg.uni            |  6 ++
>  MdeModulePkg/Universal/BdsDxe/BdsDxe.inf |  3 +-
>  MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 71 +++++++++++++++------
> ---
>  4 files changed, 59 insertions(+), 27 deletions(-)
> 
> --
> 2.21.0.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43101): https://edk2.groups.io/g/devel/message/43101
Mute This Topic: https://groups.io/mt/32140505/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-