SecurityPkg/FvReportPei/FvReportPei.c | 416 ++++++++++++++++++ SecurityPkg/FvReportPei/FvReportPei.h | 122 +++++ SecurityPkg/FvReportPei/FvReportPei.inf | 57 +++ SecurityPkg/FvReportPei/FvReportPei.uni | 14 + .../FvReportPei/FvReportPeiPeiExtra.uni | 12 + .../Ppi/FirmwareVolumeInfoStoredHashFv.h | 62 +++ SecurityPkg/SecurityPkg.dec | 9 + SecurityPkg/SecurityPkg.dsc | 5 + 8 files changed, 697 insertions(+) create mode 100644 SecurityPkg/FvReportPei/FvReportPei.c create mode 100644 SecurityPkg/FvReportPei/FvReportPei.h create mode 100644 SecurityPkg/FvReportPei/FvReportPei.inf create mode 100644 SecurityPkg/FvReportPei/FvReportPei.uni create mode 100644 SecurityPkg/FvReportPei/FvReportPeiPeiExtra.uni create mode 100644 SecurityPkg/Include/Ppi/FirmwareVolumeInfoStoredHashFv.h
>V4: change FV_HASH_FLAG_BOOT_MODE definition >V3: update per Jiewen's comments >V2: fix parameter description error found by ECC https://bugzilla.tianocore.org/show_bug.cgi?id=1617 Cc: Chao Zhang <chao.b.zhang@intel.com> Cc: Jiewen Yao <jiewen.yao@intel.com> Cc: "Hernandez Beltran, Jorge" <jorge.hernandez.beltran@intel.com> Cc: Harry Han <harry.han@intel.com> Jian J Wang (3): SecurityPkg: add definitions for OBB verification SecurityPkg/FvReportPei: implement a common FV verifier and reporter SecurityPkg: add FvReportPei.inf in dsc for build validation SecurityPkg/FvReportPei/FvReportPei.c | 416 ++++++++++++++++++ SecurityPkg/FvReportPei/FvReportPei.h | 122 +++++ SecurityPkg/FvReportPei/FvReportPei.inf | 57 +++ SecurityPkg/FvReportPei/FvReportPei.uni | 14 + .../FvReportPei/FvReportPeiPeiExtra.uni | 12 + .../Ppi/FirmwareVolumeInfoStoredHashFv.h | 62 +++ SecurityPkg/SecurityPkg.dec | 9 + SecurityPkg/SecurityPkg.dsc | 5 + 8 files changed, 697 insertions(+) create mode 100644 SecurityPkg/FvReportPei/FvReportPei.c create mode 100644 SecurityPkg/FvReportPei/FvReportPei.h create mode 100644 SecurityPkg/FvReportPei/FvReportPei.inf create mode 100644 SecurityPkg/FvReportPei/FvReportPei.uni create mode 100644 SecurityPkg/FvReportPei/FvReportPeiPeiExtra.uni create mode 100644 SecurityPkg/Include/Ppi/FirmwareVolumeInfoStoredHashFv.h -- 2.17.1.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42614): https://edk2.groups.io/g/devel/message/42614 Mute This Topic: https://groups.io/mt/32139876/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Thanks Jian. Comment below:
1) My previous comment 8 is NOT addressed.
Please add assert for "StoredHashFvPpi->FvNumber".
if (!EFI_ERROR(Status) && StoredHashFvPpi != NULL && StoredHashFvPpi->FvNumber > 0) {
With that fixed, reviewed-by: Jiewen.yao@intel.com
Thank you
Yao Jiewen
> -----Original Message-----
> From: Wang, Jian J
> Sent: Thursday, June 20, 2019 9:59 AM
> To: devel@edk2.groups.io
> Cc: Zhang, Chao B <chao.b.zhang@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Hernandez Beltran, Jorge
> <jorge.hernandez.beltran@intel.com>; Han, Harry <harry.han@intel.com>
> Subject: [PATCH v4 0/3] Common OBB verification feature
>
> >V4: change FV_HASH_FLAG_BOOT_MODE definition
>
> >V3: update per Jiewen's comments
>
> >V2: fix parameter description error found by ECC
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=1617
>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: "Hernandez Beltran, Jorge" <jorge.hernandez.beltran@intel.com>
> Cc: Harry Han <harry.han@intel.com>
>
> Jian J Wang (3):
> SecurityPkg: add definitions for OBB verification
> SecurityPkg/FvReportPei: implement a common FV verifier and reporter
> SecurityPkg: add FvReportPei.inf in dsc for build validation
>
> SecurityPkg/FvReportPei/FvReportPei.c | 416
> ++++++++++++++++++
> SecurityPkg/FvReportPei/FvReportPei.h | 122 +++++
> SecurityPkg/FvReportPei/FvReportPei.inf | 57 +++
> SecurityPkg/FvReportPei/FvReportPei.uni | 14 +
> .../FvReportPei/FvReportPeiPeiExtra.uni | 12 +
> .../Ppi/FirmwareVolumeInfoStoredHashFv.h | 62 +++
> SecurityPkg/SecurityPkg.dec | 9 +
> SecurityPkg/SecurityPkg.dsc | 5 +
> 8 files changed, 697 insertions(+)
> create mode 100644 SecurityPkg/FvReportPei/FvReportPei.c
> create mode 100644 SecurityPkg/FvReportPei/FvReportPei.h
> create mode 100644 SecurityPkg/FvReportPei/FvReportPei.inf
> create mode 100644 SecurityPkg/FvReportPei/FvReportPei.uni
> create mode 100644 SecurityPkg/FvReportPei/FvReportPeiPeiExtra.uni
> create mode 100644
> SecurityPkg/Include/Ppi/FirmwareVolumeInfoStoredHashFv.h
>
> --
> 2.17.1.windows.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42823): https://edk2.groups.io/g/devel/message/42823
Mute This Topic: https://groups.io/mt/32139876/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Thanks Jiewen. I'll add it with a few code style corrections.
Anyone else has any comments?
Regards,
Jian
> -----Original Message-----
> From: Yao, Jiewen
> Sent: Tuesday, June 25, 2019 10:09 PM
> To: Wang, Jian J <jian.j.wang@intel.com>; devel@edk2.groups.io
> Cc: Zhang, Chao B <chao.b.zhang@intel.com>; Hernandez Beltran, Jorge
> <jorge.hernandez.beltran@intel.com>; Han, Harry <harry.han@intel.com>
> Subject: RE: [PATCH v4 0/3] Common OBB verification feature
>
> Thanks Jian. Comment below:
>
> 1) My previous comment 8 is NOT addressed.
>
> Please add assert for "StoredHashFvPpi->FvNumber".
> if (!EFI_ERROR(Status) && StoredHashFvPpi != NULL && StoredHashFvPpi-
> >FvNumber > 0) {
>
> With that fixed, reviewed-by: Jiewen.yao@intel.com
>
>
> Thank you
> Yao Jiewen
>
>
> > -----Original Message-----
> > From: Wang, Jian J
> > Sent: Thursday, June 20, 2019 9:59 AM
> > To: devel@edk2.groups.io
> > Cc: Zhang, Chao B <chao.b.zhang@intel.com>; Yao, Jiewen
> > <jiewen.yao@intel.com>; Hernandez Beltran, Jorge
> > <jorge.hernandez.beltran@intel.com>; Han, Harry <harry.han@intel.com>
> > Subject: [PATCH v4 0/3] Common OBB verification feature
> >
> > >V4: change FV_HASH_FLAG_BOOT_MODE definition
> >
> > >V3: update per Jiewen's comments
> >
> > >V2: fix parameter description error found by ECC
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=1617
> >
> > Cc: Chao Zhang <chao.b.zhang@intel.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: "Hernandez Beltran, Jorge" <jorge.hernandez.beltran@intel.com>
> > Cc: Harry Han <harry.han@intel.com>
> >
> > Jian J Wang (3):
> > SecurityPkg: add definitions for OBB verification
> > SecurityPkg/FvReportPei: implement a common FV verifier and reporter
> > SecurityPkg: add FvReportPei.inf in dsc for build validation
> >
> > SecurityPkg/FvReportPei/FvReportPei.c | 416
> > ++++++++++++++++++
> > SecurityPkg/FvReportPei/FvReportPei.h | 122 +++++
> > SecurityPkg/FvReportPei/FvReportPei.inf | 57 +++
> > SecurityPkg/FvReportPei/FvReportPei.uni | 14 +
> > .../FvReportPei/FvReportPeiPeiExtra.uni | 12 +
> > .../Ppi/FirmwareVolumeInfoStoredHashFv.h | 62 +++
> > SecurityPkg/SecurityPkg.dec | 9 +
> > SecurityPkg/SecurityPkg.dsc | 5 +
> > 8 files changed, 697 insertions(+)
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.c
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.h
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.inf
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.uni
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPeiPeiExtra.uni
> > create mode 100644
> > SecurityPkg/Include/Ppi/FirmwareVolumeInfoStoredHashFv.h
> >
> > --
> > 2.17.1.windows.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42867): https://edk2.groups.io/g/devel/message/42867
Mute This Topic: https://groups.io/mt/32139876/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Hi Jian:
Patch is good to me. Just one comment for coding style
If (AlgInfo->HashAll (FvBuffer, (UINTN)FvInfo[FvIndex].Length, FvHashValue) == FALSE)
Is it better to be if (!AlgInfo->HashAll (FvBuffer, (UINTN)FvInfo[FvIndex].Length, FvHashValue) ) ?
From: Wang, Jian J
Sent: Wednesday, June 26, 2019 1:34 PM
To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io
Cc: Zhang, Chao B <chao.b.zhang@intel.com>; Hernandez Beltran, Jorge <jorge.hernandez.beltran@intel.com>; Han, Harry <harry.han@intel.com>
Subject: RE: [PATCH v4 0/3] Common OBB verification feature
Thanks Jiewen. I'll add it with a few code style corrections.
Anyone else has any comments?
Regards,
Jian
> -----Original Message-----
> From: Yao, Jiewen
> Sent: Tuesday, June 25, 2019 10:09 PM
> To: Wang, Jian J <jian.j.wang@intel.com<mailto:jian.j.wang@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> Cc: Zhang, Chao B <chao.b.zhang@intel.com<mailto:chao.b.zhang@intel.com>>; Hernandez Beltran, Jorge
> <jorge.hernandez.beltran@intel.com<mailto:jorge.hernandez.beltran@intel.com>>; Han, Harry <harry.han@intel.com<mailto:harry.han@intel.com>>
> Subject: RE: [PATCH v4 0/3] Common OBB verification feature
>
> Thanks Jian. Comment below:
>
> 1) My previous comment 8 is NOT addressed.
>
> Please add assert for "StoredHashFvPpi->FvNumber".
> if (!EFI_ERROR(Status) && StoredHashFvPpi != NULL && StoredHashFvPpi-
> >FvNumber > 0) {
>
> With that fixed, reviewed-by: Jiewen.yao@intel.com<mailto:Jiewen.yao@intel.com>
>
>
> Thank you
> Yao Jiewen
>
>
> > -----Original Message-----
> > From: Wang, Jian J
> > Sent: Thursday, June 20, 2019 9:59 AM
> > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> > Cc: Zhang, Chao B <chao.b.zhang@intel.com<mailto:chao.b.zhang@intel.com>>; Yao, Jiewen
> > <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Hernandez Beltran, Jorge
> > <jorge.hernandez.beltran@intel.com<mailto:jorge.hernandez.beltran@intel.com>>; Han, Harry <harry.han@intel.com<mailto:harry.han@intel.com>>
> > Subject: [PATCH v4 0/3] Common OBB verification feature
> >
> > >V4: change FV_HASH_FLAG_BOOT_MODE definition
> >
> > >V3: update per Jiewen's comments
> >
> > >V2: fix parameter description error found by ECC
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=1617
> >
> > Cc: Chao Zhang <chao.b.zhang@intel.com<mailto:chao.b.zhang@intel.com>>
> > Cc: Jiewen Yao <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
> > Cc: "Hernandez Beltran, Jorge" <jorge.hernandez.beltran@intel.com<mailto:jorge.hernandez.beltran@intel.com>>
> > Cc: Harry Han <harry.han@intel.com<mailto:harry.han@intel.com>>
> >
> > Jian J Wang (3):
> > SecurityPkg: add definitions for OBB verification
> > SecurityPkg/FvReportPei: implement a common FV verifier and reporter
> > SecurityPkg: add FvReportPei.inf in dsc for build validation
> >
> > SecurityPkg/FvReportPei/FvReportPei.c | 416
> > ++++++++++++++++++
> > SecurityPkg/FvReportPei/FvReportPei.h | 122 +++++
> > SecurityPkg/FvReportPei/FvReportPei.inf | 57 +++
> > SecurityPkg/FvReportPei/FvReportPei.uni | 14 +
> > .../FvReportPei/FvReportPeiPeiExtra.uni | 12 +
> > .../Ppi/FirmwareVolumeInfoStoredHashFv.h | 62 +++
> > SecurityPkg/SecurityPkg.dec | 9 +
> > SecurityPkg/SecurityPkg.dsc | 5 +
> > 8 files changed, 697 insertions(+)
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.c
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.h
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.inf
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.uni
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPeiPeiExtra.uni
> > create mode 100644
> > SecurityPkg/Include/Ppi/FirmwareVolumeInfoStoredHashFv.h
> >
> > --
> > 2.17.1.windows.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42874): https://edk2.groups.io/g/devel/message/42874
Mute This Topic: https://groups.io/mt/32139876/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Thanks, Chao. You're right your way is better. I'll update it.
Regards,
Jian
From: Zhang, Chao B
Sent: Wednesday, June 26, 2019 3:29 PM
To: Wang, Jian J <jian.j.wang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io
Cc: Hernandez Beltran, Jorge <jorge.hernandez.beltran@intel.com>; Han, Harry <harry.han@intel.com>
Subject: RE: [PATCH v4 0/3] Common OBB verification feature
Hi Jian:
Patch is good to me. Just one comment for coding style
If (AlgInfo->HashAll (FvBuffer, (UINTN)FvInfo[FvIndex].Length, FvHashValue) == FALSE)
Is it better to be if (!AlgInfo->HashAll (FvBuffer, (UINTN)FvInfo[FvIndex].Length, FvHashValue) ) ?
From: Wang, Jian J
Sent: Wednesday, June 26, 2019 1:34 PM
To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Zhang, Chao B <chao.b.zhang@intel.com<mailto:chao.b.zhang@intel.com>>; Hernandez Beltran, Jorge <jorge.hernandez.beltran@intel.com<mailto:jorge.hernandez.beltran@intel.com>>; Han, Harry <harry.han@intel.com<mailto:harry.han@intel.com>>
Subject: RE: [PATCH v4 0/3] Common OBB verification feature
Thanks Jiewen. I'll add it with a few code style corrections.
Anyone else has any comments?
Regards,
Jian
> -----Original Message-----
> From: Yao, Jiewen
> Sent: Tuesday, June 25, 2019 10:09 PM
> To: Wang, Jian J <jian.j.wang@intel.com<mailto:jian.j.wang@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> Cc: Zhang, Chao B <chao.b.zhang@intel.com<mailto:chao.b.zhang@intel.com>>; Hernandez Beltran, Jorge
> <jorge.hernandez.beltran@intel.com<mailto:jorge.hernandez.beltran@intel.com>>; Han, Harry <harry.han@intel.com<mailto:harry.han@intel.com>>
> Subject: RE: [PATCH v4 0/3] Common OBB verification feature
>
> Thanks Jian. Comment below:
>
> 1) My previous comment 8 is NOT addressed.
>
> Please add assert for "StoredHashFvPpi->FvNumber".
> if (!EFI_ERROR(Status) && StoredHashFvPpi != NULL && StoredHashFvPpi-
> >FvNumber > 0) {
>
> With that fixed, reviewed-by: Jiewen.yao@intel.com<mailto:Jiewen.yao@intel.com>
>
>
> Thank you
> Yao Jiewen
>
>
> > -----Original Message-----
> > From: Wang, Jian J
> > Sent: Thursday, June 20, 2019 9:59 AM
> > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> > Cc: Zhang, Chao B <chao.b.zhang@intel.com<mailto:chao.b.zhang@intel.com>>; Yao, Jiewen
> > <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Hernandez Beltran, Jorge
> > <jorge.hernandez.beltran@intel.com<mailto:jorge.hernandez.beltran@intel.com>>; Han, Harry <harry.han@intel.com<mailto:harry.han@intel.com>>
> > Subject: [PATCH v4 0/3] Common OBB verification feature
> >
> > >V4: change FV_HASH_FLAG_BOOT_MODE definition
> >
> > >V3: update per Jiewen's comments
> >
> > >V2: fix parameter description error found by ECC
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=1617
> >
> > Cc: Chao Zhang <chao.b.zhang@intel.com<mailto:chao.b.zhang@intel.com>>
> > Cc: Jiewen Yao <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
> > Cc: "Hernandez Beltran, Jorge" <jorge.hernandez.beltran@intel.com<mailto:jorge.hernandez.beltran@intel.com>>
> > Cc: Harry Han <harry.han@intel.com<mailto:harry.han@intel.com>>
> >
> > Jian J Wang (3):
> > SecurityPkg: add definitions for OBB verification
> > SecurityPkg/FvReportPei: implement a common FV verifier and reporter
> > SecurityPkg: add FvReportPei.inf in dsc for build validation
> >
> > SecurityPkg/FvReportPei/FvReportPei.c | 416
> > ++++++++++++++++++
> > SecurityPkg/FvReportPei/FvReportPei.h | 122 +++++
> > SecurityPkg/FvReportPei/FvReportPei.inf | 57 +++
> > SecurityPkg/FvReportPei/FvReportPei.uni | 14 +
> > .../FvReportPei/FvReportPeiPeiExtra.uni | 12 +
> > .../Ppi/FirmwareVolumeInfoStoredHashFv.h | 62 +++
> > SecurityPkg/SecurityPkg.dec | 9 +
> > SecurityPkg/SecurityPkg.dsc | 5 +
> > 8 files changed, 697 insertions(+)
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.c
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.h
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.inf
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.uni
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPeiPeiExtra.uni
> > create mode 100644
> > SecurityPkg/Include/Ppi/FirmwareVolumeInfoStoredHashFv.h
> >
> > --
> > 2.17.1.windows.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42875): https://edk2.groups.io/g/devel/message/42875
Mute This Topic: https://groups.io/mt/32139876/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Reviewed-by : Chao Zhang <chao.b.zhang@intel.com>
From: Wang, Jian J
Sent: Wednesday, June 26, 2019 3:44 PM
To: Zhang, Chao B <chao.b.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io
Cc: Hernandez Beltran, Jorge <jorge.hernandez.beltran@intel.com>; Han, Harry <harry.han@intel.com>
Subject: RE: [PATCH v4 0/3] Common OBB verification feature
Thanks, Chao. You're right your way is better. I'll update it.
Regards,
Jian
From: Zhang, Chao B
Sent: Wednesday, June 26, 2019 3:29 PM
To: Wang, Jian J <jian.j.wang@intel.com<mailto:jian.j.wang@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Hernandez Beltran, Jorge <jorge.hernandez.beltran@intel.com<mailto:jorge.hernandez.beltran@intel.com>>; Han, Harry <harry.han@intel.com<mailto:harry.han@intel.com>>
Subject: RE: [PATCH v4 0/3] Common OBB verification feature
Hi Jian:
Patch is good to me. Just one comment for coding style
If (AlgInfo->HashAll (FvBuffer, (UINTN)FvInfo[FvIndex].Length, FvHashValue) == FALSE)
Is it better to be if (!AlgInfo->HashAll (FvBuffer, (UINTN)FvInfo[FvIndex].Length, FvHashValue) ) ?
From: Wang, Jian J
Sent: Wednesday, June 26, 2019 1:34 PM
To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Zhang, Chao B <chao.b.zhang@intel.com<mailto:chao.b.zhang@intel.com>>; Hernandez Beltran, Jorge <jorge.hernandez.beltran@intel.com<mailto:jorge.hernandez.beltran@intel.com>>; Han, Harry <harry.han@intel.com<mailto:harry.han@intel.com>>
Subject: RE: [PATCH v4 0/3] Common OBB verification feature
Thanks Jiewen. I'll add it with a few code style corrections.
Anyone else has any comments?
Regards,
Jian
> -----Original Message-----
> From: Yao, Jiewen
> Sent: Tuesday, June 25, 2019 10:09 PM
> To: Wang, Jian J <jian.j.wang@intel.com<mailto:jian.j.wang@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> Cc: Zhang, Chao B <chao.b.zhang@intel.com<mailto:chao.b.zhang@intel.com>>; Hernandez Beltran, Jorge
> <jorge.hernandez.beltran@intel.com<mailto:jorge.hernandez.beltran@intel.com>>; Han, Harry <harry.han@intel.com<mailto:harry.han@intel.com>>
> Subject: RE: [PATCH v4 0/3] Common OBB verification feature
>
> Thanks Jian. Comment below:
>
> 1) My previous comment 8 is NOT addressed.
>
> Please add assert for "StoredHashFvPpi->FvNumber".
> if (!EFI_ERROR(Status) && StoredHashFvPpi != NULL && StoredHashFvPpi-
> >FvNumber > 0) {
>
> With that fixed, reviewed-by: Jiewen.yao@intel.com<mailto:Jiewen.yao@intel.com>
>
>
> Thank you
> Yao Jiewen
>
>
> > -----Original Message-----
> > From: Wang, Jian J
> > Sent: Thursday, June 20, 2019 9:59 AM
> > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> > Cc: Zhang, Chao B <chao.b.zhang@intel.com<mailto:chao.b.zhang@intel.com>>; Yao, Jiewen
> > <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Hernandez Beltran, Jorge
> > <jorge.hernandez.beltran@intel.com<mailto:jorge.hernandez.beltran@intel.com>>; Han, Harry <harry.han@intel.com<mailto:harry.han@intel.com>>
> > Subject: [PATCH v4 0/3] Common OBB verification feature
> >
> > >V4: change FV_HASH_FLAG_BOOT_MODE definition
> >
> > >V3: update per Jiewen's comments
> >
> > >V2: fix parameter description error found by ECC
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=1617
> >
> > Cc: Chao Zhang <chao.b.zhang@intel.com<mailto:chao.b.zhang@intel.com>>
> > Cc: Jiewen Yao <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
> > Cc: "Hernandez Beltran, Jorge" <jorge.hernandez.beltran@intel.com<mailto:jorge.hernandez.beltran@intel.com>>
> > Cc: Harry Han <harry.han@intel.com<mailto:harry.han@intel.com>>
> >
> > Jian J Wang (3):
> > SecurityPkg: add definitions for OBB verification
> > SecurityPkg/FvReportPei: implement a common FV verifier and reporter
> > SecurityPkg: add FvReportPei.inf in dsc for build validation
> >
> > SecurityPkg/FvReportPei/FvReportPei.c | 416
> > ++++++++++++++++++
> > SecurityPkg/FvReportPei/FvReportPei.h | 122 +++++
> > SecurityPkg/FvReportPei/FvReportPei.inf | 57 +++
> > SecurityPkg/FvReportPei/FvReportPei.uni | 14 +
> > .../FvReportPei/FvReportPeiPeiExtra.uni | 12 +
> > .../Ppi/FirmwareVolumeInfoStoredHashFv.h | 62 +++
> > SecurityPkg/SecurityPkg.dec | 9 +
> > SecurityPkg/SecurityPkg.dsc | 5 +
> > 8 files changed, 697 insertions(+)
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.c
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.h
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.inf
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.uni
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPeiPeiExtra.uni
> > create mode 100644
> > SecurityPkg/Include/Ppi/FirmwareVolumeInfoStoredHashFv.h
> >
> > --
> > 2.17.1.windows.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42878): https://edk2.groups.io/g/devel/message/42878
Mute This Topic: https://groups.io/mt/32139876/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2026 Red Hat, Inc.