Enable new MM MP protocol.

[edk2-devel] [Patch 0/2] Enable new MM MP protocol.

Posted by Dong, Eric 4 years, 10 months ago

PI spec added a new protocol named MM MP protocol. This protocol allows
for better remote queuing of execution of procedures on an AP.
This extends the existing procedures to allow:
1. A function to be called in blocking and non-blocking manner explicitly
2. Allow broadcasts.
3. Allow execution of a procedure when a processor powers up.

This patch serial enable this new protocol.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>

Eric Dong (2):
  MdePkg: Add new MM MP Protocol definition.
  UefiCpuPkg/PiSmmCpuDxeSmm: Enable MM MP Protocol.

 MdePkg/Include/Pi/PiMultiPhase.h             |  16 +
 MdePkg/Include/Protocol/MmMp.h               | 334 +++++++++++++
 MdePkg/Include/Protocol/SmmMp.h              |  44 ++
 MdePkg/MdePkg.dec                            |   6 +
 UefiCpuPkg/PiSmmCpuDxeSmm/MpProtocol.c       | 375 +++++++++++++++
 UefiCpuPkg/PiSmmCpuDxeSmm/MpProtocol.h       | 283 +++++++++++
 UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c        | 468 ++++++++++++++++++-
 UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c   |  11 +
 UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h   | 172 ++++++-
 UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf |   3 +
 10 files changed, 1696 insertions(+), 16 deletions(-)
 create mode 100644 MdePkg/Include/Protocol/MmMp.h
 create mode 100644 MdePkg/Include/Protocol/SmmMp.h
 create mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/MpProtocol.c
 create mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/MpProtocol.h

-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42572): https://edk2.groups.io/g/devel/message/42572
Mute This Topic: https://groups.io/mt/32120261/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch 0/2] Enable new MM MP protocol.

Posted by Laszlo Ersek 4 years, 10 months ago

On 06/19/19 07:51, Dong, Eric wrote:
> PI spec added a new protocol named MM MP protocol. This protocol allows
> for better remote queuing of execution of procedures on an AP.
> This extends the existing procedures to allow:
> 1. A function to be called in blocking and non-blocking manner explicitly
> 2. Allow broadcasts.
> 3. Allow execution of a procedure when a processor powers up.
>
> This patch serial enable this new protocol.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
>
> Eric Dong (2):
>   MdePkg: Add new MM MP Protocol definition.
>   UefiCpuPkg/PiSmmCpuDxeSmm: Enable MM MP Protocol.
>
>  MdePkg/Include/Pi/PiMultiPhase.h             |  16 +
>  MdePkg/Include/Protocol/MmMp.h               | 334 +++++++++++++
>  MdePkg/Include/Protocol/SmmMp.h              |  44 ++
>  MdePkg/MdePkg.dec                            |   6 +
>  UefiCpuPkg/PiSmmCpuDxeSmm/MpProtocol.c       | 375 +++++++++++++++
>  UefiCpuPkg/PiSmmCpuDxeSmm/MpProtocol.h       | 283 +++++++++++
>  UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c        | 468 ++++++++++++++++++-
>  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c   |  11 +
>  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h   | 172 ++++++-
>  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf |   3 +
>  10 files changed, 1696 insertions(+), 16 deletions(-)
>  create mode 100644 MdePkg/Include/Protocol/MmMp.h
>  create mode 100644 MdePkg/Include/Protocol/SmmMp.h
>  create mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/MpProtocol.c
>  create mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/MpProtocol.h
>

I applied this set (for regression testing) on top of commit
f17935321a5b ("MdeModulePkg: Add CapsuleOnDiskLoadPei PEIM.",
2019-06-20).


First of all, git-am complained like this:

> Applying: MdePkg: Add new MM MP Protocol definition.
> .git/rebase-apply/patch:374: new blank line at EOF.
> +
> .git/rebase-apply/patch:424: new blank line at EOF.
> +
> warning: 2 lines add whitespace errors.
> Applying: UefiCpuPkg/PiSmmCpuDxeSmm: Enable MM MP Protocol.
> .git/rebase-apply/patch:392: new blank line at EOF.
> +
> .git/rebase-apply/patch:1276: new blank line at EOF.
> +
> warning: 2 lines add whitespace errors.

Please consider removing those empty lines.


Second, the series does not build for me. I'll describe the issue under
the affected patch.

Thanks,
Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42657): https://edk2.groups.io/g/devel/message/42657
Mute This Topic: https://groups.io/mt/32120261/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch 0/2] Enable new MM MP protocol.

Posted by Liming Gao 4 years, 10 months ago

Eric:
  Please submit one BZ for it. Seemly, this is a new feature. I will add it into Q3 stable tag feature plan. 

Thanks
Liming
>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Dong, Eric
>Sent: Wednesday, June 19, 2019 1:51 PM
>To: devel@edk2.groups.io
>Cc: Ni, Ray <ray.ni@intel.com>; Laszlo Ersek <lersek@redhat.com>
>Subject: [edk2-devel] [Patch 0/2] Enable new MM MP protocol.
>
>PI spec added a new protocol named MM MP protocol. This protocol allows
>for better remote queuing of execution of procedures on an AP.
>This extends the existing procedures to allow:
>1. A function to be called in blocking and non-blocking manner explicitly
>2. Allow broadcasts.
>3. Allow execution of a procedure when a processor powers up.
>
>This patch serial enable this new protocol.
>
>Cc: Ray Ni <ray.ni@intel.com>
>Cc: Laszlo Ersek <lersek@redhat.com>
>
>Eric Dong (2):
>  MdePkg: Add new MM MP Protocol definition.
>  UefiCpuPkg/PiSmmCpuDxeSmm: Enable MM MP Protocol.
>
> MdePkg/Include/Pi/PiMultiPhase.h             |  16 +
> MdePkg/Include/Protocol/MmMp.h               | 334 +++++++++++++
> MdePkg/Include/Protocol/SmmMp.h              |  44 ++
> MdePkg/MdePkg.dec                            |   6 +
> UefiCpuPkg/PiSmmCpuDxeSmm/MpProtocol.c       | 375 +++++++++++++++
> UefiCpuPkg/PiSmmCpuDxeSmm/MpProtocol.h       | 283 +++++++++++
> UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c        | 468
>++++++++++++++++++-
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c   |  11 +
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h   | 172 ++++++-
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf |   3 +
> 10 files changed, 1696 insertions(+), 16 deletions(-)
> create mode 100644 MdePkg/Include/Protocol/MmMp.h
> create mode 100644 MdePkg/Include/Protocol/SmmMp.h
> create mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/MpProtocol.c
> create mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/MpProtocol.h
>
>--
>2.21.0.windows.1
>
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42859): https://edk2.groups.io/g/devel/message/42859
Mute This Topic: https://groups.io/mt/32120261/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-