1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH] SourceLevelDebugPkg: Add lacking instances for build only

Gao, Zhichao posted 1 patch 4 years, 10 months ago
Failed in applying to current master (apply log)
SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 2 ++
1 file changed, 2 insertions(+)
[edk2-devel] [PATCH] SourceLevelDebugPkg: Add lacking instances for build only
Posted by Gao, Zhichao 4 years, 10 months ago 
From: Bret Barkelew <Bret.Barkelew@microsoft.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1902

Add the lacking instance to the [Components] of dsc file
for build only.

Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Signed-off-by: Zhichao gao <zhichao.gao@intel.com>
---
 SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
index 8be6781296..a1a1b81d03 100644
--- a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
+++ b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
@@ -93,6 +93,8 @@
 ###################################################################################################
 
 [Components.common]
+  SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Dxe.inf
+  SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Pei.inf
   SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.inf
   SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommunicationLibUsb.inf
   SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraActionLibDebug.inf
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42241): https://edk2.groups.io/g/devel/message/42241
Mute This Topic: https://groups.io/mt/32037313/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] SourceLevelDebugPkg: Add lacking instances for build only
Posted by Wu, Hao A 4 years, 10 months ago 
> -----Original Message-----
> From: Gao, Zhichao
> Sent: Wednesday, June 12, 2019 10:40 AM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew; Wu, Hao A; Gao, Liming; Sean Brogan; Michael Turner; Leif
> Lindholm; Gao, Zhichao
> Subject: [PATCH] SourceLevelDebugPkg: Add lacking instances for build only


With a similar suggestion at:
https://edk2.groups.io/g/devel/topic/32037312#42319

handled:
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


> 
> From: Bret Barkelew <Bret.Barkelew@microsoft.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1902
> 
> Add the lacking instance to the [Components] of dsc file
> for build only.
> 
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Turner <Michael.Turner@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Signed-off-by: Zhichao gao <zhichao.gao@intel.com>
> ---
>  SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> index 8be6781296..a1a1b81d03 100644
> --- a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> +++ b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> @@ -93,6 +93,8 @@
> 
> ##########################################################
> #########################################
> 
>  [Components.common]
> +
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommu
> nicationLibUsb3Dxe.inf
> +
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommu
> nicationLibUsb3Pei.inf
> 
> SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.inf
> 
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommun
> icationLibUsb.inf
> 
> SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraActio
> nLibDebug.inf
> --
> 2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42340): https://edk2.groups.io/g/devel/message/42340
Mute This Topic: https://groups.io/mt/32037313/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] SourceLevelDebugPkg: Add lacking instances for build only
Posted by Wu, Hao A 4 years, 10 months ago 
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Thursday, June 13, 2019 4:04 PM
> To: Gao, Zhichao; devel@edk2.groups.io
> Cc: Bret Barkelew; Gao, Liming; Sean Brogan; Michael Turner; Leif Lindholm
> Subject: Re: [edk2-devel] [PATCH] SourceLevelDebugPkg: Add lacking
> instances for build only
> 
> > -----Original Message-----
> > From: Gao, Zhichao
> > Sent: Wednesday, June 12, 2019 10:40 AM
> > To: devel@edk2.groups.io
> > Cc: Bret Barkelew; Wu, Hao A; Gao, Liming; Sean Brogan; Michael Turner;
> Leif
> > Lindholm; Gao, Zhichao
> > Subject: [PATCH] SourceLevelDebugPkg: Add lacking instances for build
> only
> 
> 
> With a similar suggestion at:
> https://edk2.groups.io/g/devel/topic/32037312#42319
> 
> handled:
> Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Pushed via commit 34857c2ff9.

Best Regards,
Hao Wu

> 
> Best Regards,
> Hao Wu
> 
> 
> >
> > From: Bret Barkelew <Bret.Barkelew@microsoft.com>
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1902
> >
> > Add the lacking instance to the [Components] of dsc file
> > for build only.
> >
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Michael Turner <Michael.Turner@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Signed-off-by: Zhichao gao <zhichao.gao@intel.com>
> > ---
> >  SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> > b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> > index 8be6781296..a1a1b81d03 100644
> > --- a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> > +++ b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> > @@ -93,6 +93,8 @@
> >
> >
> ##########################################################
> > #########################################
> >
> >  [Components.common]
> > +
> >
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommu
> > nicationLibUsb3Dxe.inf
> > +
> >
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommu
> > nicationLibUsb3Pei.inf
> >
> >
> SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> > mmunicationLibSerialPort.inf
> >
> >
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommun
> > icationLibUsb.inf
> >
> >
> SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraActio
> > nLibDebug.inf
> > --
> > 2.21.0.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42468): https://edk2.groups.io/g/devel/message/42468
Mute This Topic: https://groups.io/mt/32037313/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.