MdeModulePkg/Universal/CapsulePei/Capsule.h | 1 + .../Universal/CapsulePei/CapsulePei.inf | 1 + .../Universal/CapsulePei/UefiCapsule.c | 356 +++++++++--------- 3 files changed, 190 insertions(+), 168 deletions(-)
v1: Sperate the capsule check function from GetCapsuleDescriptors and name it to AreCapsulesStaged. Rename GetCapsuleDescriptors to GetScatterGatherHeadEntries. And optimize its to remove the duplicated code. V2: Clarify the changes of the patch and descript in the commit message. V3: Add the code change repo location in Mu and add description of the changes on it. Do not need to remain 2 byte for the null-terminate while using UnicodeValueToStringS. V4: Separate the patch into 2 part. first part is changes from MU. Second part is the substantial change on it. V5: Separate the substantial change in 2/2 base on the purpose. Cc: Jian J Wang <jian.j.wang@intel.com> Cc: Hao A Wu <hao.a.wu@intel.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Star Zeng <star.zeng@intel.com> Cc: Liming Gao <liming.gao@intel.com> Cc: Sean Brogan <sean.brogan@microsoft.com> Cc: Michael Turner <Michael.Turner@microsoft.com> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> Cc: Leif Lindholm <leif.lindholm@linaro.org> Bret Barkelew (1): MdeModulePkg/CapsulePei: Optimize the CapsulePei Zhichao Gao (4): MdeMoudlePkg/CapsulePei: Fix coding style issue MdeMoudlePkg/CapsulePei: Optimize AreCapsulesStaged MdeMoudlePkg/CapsulePei: Optimize GetScatterGatherHeadEntries MdeMoudlePkg/CapsulePei: No need to remain space for null-terminate MdeModulePkg/Universal/CapsulePei/Capsule.h | 1 + .../Universal/CapsulePei/CapsulePei.inf | 1 + .../Universal/CapsulePei/UefiCapsule.c | 356 +++++++++--------- 3 files changed, 190 insertions(+), 168 deletions(-) -- 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42054): https://edk2.groups.io/g/devel/message/42054 Mute This Topic: https://groups.io/mt/32001191/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
> -----Original Message----- > From: Gao, Zhichao > Sent: Monday, June 10, 2019 1:21 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan; > Michael Turner; Bret Barkelew; Leif Lindholm > Subject: [PATCH v5 0/5] MdeModulePkg/CapsulePei: Optimize the > CapsulePei > > v1: > Sperate the capsule check function from GetCapsuleDescriptors > and name it to AreCapsulesStaged. > Rename GetCapsuleDescriptors to GetScatterGatherHeadEntries. > And optimize its to remove the duplicated code. > > V2: > Clarify the changes of the patch and descript in the commit > message. > > V3: > Add the code change repo location in Mu and add description of > the changes on it. > Do not need to remain 2 byte for the null-terminate while using > UnicodeValueToStringS. > > V4: > Separate the patch into 2 part. first part is changes from MU. > Second part is the substantial change on it. > > V5: > Separate the substantial change in 2/2 base on the purpose. With the comment from Leif handled, for the series: Reviewed-by: Hao A Wu <hao.a.wu@intel.com> Best Regards, Hao Wu > > Cc: Jian J Wang <jian.j.wang@intel.com> > Cc: Hao A Wu <hao.a.wu@intel.com> > Cc: Ray Ni <ray.ni@intel.com> > Cc: Star Zeng <star.zeng@intel.com> > Cc: Liming Gao <liming.gao@intel.com> > Cc: Sean Brogan <sean.brogan@microsoft.com> > Cc: Michael Turner <Michael.Turner@microsoft.com> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> > Cc: Leif Lindholm <leif.lindholm@linaro.org> > > Bret Barkelew (1): > MdeModulePkg/CapsulePei: Optimize the CapsulePei > > Zhichao Gao (4): > MdeMoudlePkg/CapsulePei: Fix coding style issue > MdeMoudlePkg/CapsulePei: Optimize AreCapsulesStaged > MdeMoudlePkg/CapsulePei: Optimize GetScatterGatherHeadEntries > MdeMoudlePkg/CapsulePei: No need to remain space for null-terminate > > MdeModulePkg/Universal/CapsulePei/Capsule.h | 1 + > .../Universal/CapsulePei/CapsulePei.inf | 1 + > .../Universal/CapsulePei/UefiCapsule.c | 356 +++++++++--------- > 3 files changed, 190 insertions(+), 168 deletions(-) > > -- > 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42337): https://edk2.groups.io/g/devel/message/42337 Mute This Topic: https://groups.io/mt/32001191/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
> -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Thursday, June 13, 2019 3:49 PM > To: Gao, Zhichao; devel@edk2.groups.io > Cc: Wang, Jian J; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan; Michael > Turner; Bret Barkelew; Leif Lindholm > Subject: Re: [edk2-devel] [PATCH v5 0/5] MdeModulePkg/CapsulePei: > Optimize the CapsulePei > > > -----Original Message----- > > From: Gao, Zhichao > > Sent: Monday, June 10, 2019 1:21 PM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan; > > Michael Turner; Bret Barkelew; Leif Lindholm > > Subject: [PATCH v5 0/5] MdeModulePkg/CapsulePei: Optimize the > > CapsulePei > > > > v1: > > Sperate the capsule check function from GetCapsuleDescriptors > > and name it to AreCapsulesStaged. > > Rename GetCapsuleDescriptors to GetScatterGatherHeadEntries. > > And optimize its to remove the duplicated code. > > > > V2: > > Clarify the changes of the patch and descript in the commit > > message. > > > > V3: > > Add the code change repo location in Mu and add description of > > the changes on it. > > Do not need to remain 2 byte for the null-terminate while using > > UnicodeValueToStringS. > > > > V4: > > Separate the patch into 2 part. first part is changes from MU. > > Second part is the substantial change on it. > > > > V5: > > Separate the substantial change in 2/2 base on the purpose. > > > With the comment from Leif handled, for the series: > Reviewed-by: Hao A Wu <hao.a.wu@intel.com> Series pushed via commits ba3aa1c4e7..be5903ad1e. Best Regards, Hao Wu > > Best Regards, > Hao Wu > > > > > > Cc: Jian J Wang <jian.j.wang@intel.com> > > Cc: Hao A Wu <hao.a.wu@intel.com> > > Cc: Ray Ni <ray.ni@intel.com> > > Cc: Star Zeng <star.zeng@intel.com> > > Cc: Liming Gao <liming.gao@intel.com> > > Cc: Sean Brogan <sean.brogan@microsoft.com> > > Cc: Michael Turner <Michael.Turner@microsoft.com> > > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> > > Cc: Leif Lindholm <leif.lindholm@linaro.org> > > > > Bret Barkelew (1): > > MdeModulePkg/CapsulePei: Optimize the CapsulePei > > > > Zhichao Gao (4): > > MdeMoudlePkg/CapsulePei: Fix coding style issue > > MdeMoudlePkg/CapsulePei: Optimize AreCapsulesStaged > > MdeMoudlePkg/CapsulePei: Optimize GetScatterGatherHeadEntries > > MdeMoudlePkg/CapsulePei: No need to remain space for null-terminate > > > > MdeModulePkg/Universal/CapsulePei/Capsule.h | 1 + > > .../Universal/CapsulePei/CapsulePei.inf | 1 + > > .../Universal/CapsulePei/UefiCapsule.c | 356 +++++++++--------- > > 3 files changed, 190 insertions(+), 168 deletions(-) > > > > -- > > 2.21.0.windows.1 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42724): https://edk2.groups.io/g/devel/message/42724 Mute This Topic: https://groups.io/mt/32001191/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.