1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH for-edk2-stable201905] Revert "EmulatorPkg: don't display the cpu current speed"

Laszlo Ersek posted 1 patch 4 years, 10 months ago
Failed in applying to current master (apply log)
MdeModulePkg/Application/UiApp/FrontPage.c | 5 +++++
1 file changed, 5 insertions(+)
[edk2-devel] [PATCH for-edk2-stable201905] Revert "EmulatorPkg: don't display the cpu current speed"
Posted by Laszlo Ersek 4 years, 10 months ago 
This reverts commit 7cea4d71a8a87a93924a07ab32348332f5881ef9.

Said commit was not suitable for pushing during the edk2-stable201905 hard
feature freeze; it was pushed only by mistake. The subject line referenced
EmulatorPkg, but the patch changed MdeModulePkg/UiApp, regressing the
display of the CPU speed from SMBIOS in multiple platforms.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1877
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---

Notes:
    Repo:   https://github.com/lersek/edk2.git
    Branch: revert_cpu_speed_hide

 MdeModulePkg/Application/UiApp/FrontPage.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/MdeModulePkg/Application/UiApp/FrontPage.c b/MdeModulePkg/Application/UiApp/FrontPage.c
index fded7634062a..4b95cccb5cf5 100644
--- a/MdeModulePkg/Application/UiApp/FrontPage.c
+++ b/MdeModulePkg/Application/UiApp/FrontPage.c
@@ -621,6 +621,11 @@ UpdateFrontPageBannerStrings (
         HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN (STR_FRONT_PAGE_CPU_MODEL), NewString, NULL);
         FreePool (NewString);
 
+        ConvertProcessorToString(Type4Record->CurrentSpeed, 6, &NewString);
+        UiCustomizeFrontPageBanner (2, FALSE, &NewString);
+        HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN (STR_FRONT_PAGE_CPU_SPEED), NewString, NULL);
+        FreePool (NewString);
+
         FoundCpu = TRUE;
       }
     }
-- 
2.19.1.3.g30247aa5d201


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41886): https://edk2.groups.io/g/devel/message/41886
Mute This Topic: https://groups.io/mt/31929712/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH for-edk2-stable201905] Revert "EmulatorPkg: don't display the cpu current speed"
Posted by Liming Gao 4 years, 10 months ago 
Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Laszlo Ersek
>Sent: Wednesday, June 05, 2019 2:59 AM
>To: edk2-devel-groups-io <devel@edk2.groups.io>
>Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Wu, Hao A
><hao.a.wu@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming
><liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>; Zeng, Star
><star.zeng@intel.com>
>Subject: [edk2-devel] [PATCH for-edk2-stable201905] Revert "EmulatorPkg:
>don't display the cpu current speed"
>
>This reverts commit 7cea4d71a8a87a93924a07ab32348332f5881ef9.
>
>Said commit was not suitable for pushing during the edk2-stable201905 hard
>feature freeze; it was pushed only by mistake. The subject line referenced
>EmulatorPkg, but the patch changed MdeModulePkg/UiApp, regressing the
>display of the CPU speed from SMBIOS in multiple platforms.
>
>Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>Cc: Hao A Wu <hao.a.wu@intel.com>
>Cc: Jian J Wang <jian.j.wang@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Ray Ni <ray.ni@intel.com>
>Cc: Star Zeng <star.zeng@intel.com>
>Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1877
>Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>---
>
>Notes:
>    Repo:   https://github.com/lersek/edk2.git
>    Branch: revert_cpu_speed_hide
>
> MdeModulePkg/Application/UiApp/FrontPage.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/MdeModulePkg/Application/UiApp/FrontPage.c
>b/MdeModulePkg/Application/UiApp/FrontPage.c
>index fded7634062a..4b95cccb5cf5 100644
>--- a/MdeModulePkg/Application/UiApp/FrontPage.c
>+++ b/MdeModulePkg/Application/UiApp/FrontPage.c
>@@ -621,6 +621,11 @@ UpdateFrontPageBannerStrings (
>         HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN
>(STR_FRONT_PAGE_CPU_MODEL), NewString, NULL);
>         FreePool (NewString);
>
>+        ConvertProcessorToString(Type4Record->CurrentSpeed, 6, &NewString);
>+        UiCustomizeFrontPageBanner (2, FALSE, &NewString);
>+        HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN
>(STR_FRONT_PAGE_CPU_SPEED), NewString, NULL);
>+        FreePool (NewString);
>+
>         FoundCpu = TRUE;
>       }
>     }
>--
>2.19.1.3.g30247aa5d201
>
>
>-=-=-=-=-=-=
>Groups.io Links: You receive all messages sent to this group.
>
>View/Reply Online (#41886): https://edk2.groups.io/g/devel/message/41886
>Mute This Topic: https://groups.io/mt/31929712/1759384
>Group Owner: devel+owner@edk2.groups.io
>Unsubscribe: https://edk2.groups.io/g/devel/unsub  [liming.gao@intel.com]
>-=-=-=-=-=-=


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41898): https://edk2.groups.io/g/devel/message/41898
Mute This Topic: https://groups.io/mt/31929712/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH for-edk2-stable201905] Revert "EmulatorPkg: don't display the cpu current speed"
Posted by Laszlo Ersek 4 years, 10 months ago 
On 06/05/19 02:23, Liming Gao wrote:
> Reviewed-by: Liming Gao <liming.gao@intel.com>

Thanks, patch pushed as commit be689ecc93e5.

Laszlo

>> -----Original Message-----
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>> Laszlo Ersek
>> Sent: Wednesday, June 05, 2019 2:59 AM
>> To: edk2-devel-groups-io <devel@edk2.groups.io>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Wu, Hao A
>> <hao.a.wu@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming
>> <liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>; Zeng, Star
>> <star.zeng@intel.com>
>> Subject: [edk2-devel] [PATCH for-edk2-stable201905] Revert "EmulatorPkg:
>> don't display the cpu current speed"
>>
>> This reverts commit 7cea4d71a8a87a93924a07ab32348332f5881ef9.
>>
>> Said commit was not suitable for pushing during the edk2-stable201905 hard
>> feature freeze; it was pushed only by mistake. The subject line referenced
>> EmulatorPkg, but the patch changed MdeModulePkg/UiApp, regressing the
>> display of the CPU speed from SMBIOS in multiple platforms.
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Hao A Wu <hao.a.wu@intel.com>
>> Cc: Jian J Wang <jian.j.wang@intel.com>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Cc: Ray Ni <ray.ni@intel.com>
>> Cc: Star Zeng <star.zeng@intel.com>
>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1877
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>
>> Notes:
>>    Repo:   https://github.com/lersek/edk2.git
>>    Branch: revert_cpu_speed_hide
>>
>> MdeModulePkg/Application/UiApp/FrontPage.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/MdeModulePkg/Application/UiApp/FrontPage.c
>> b/MdeModulePkg/Application/UiApp/FrontPage.c
>> index fded7634062a..4b95cccb5cf5 100644
>> --- a/MdeModulePkg/Application/UiApp/FrontPage.c
>> +++ b/MdeModulePkg/Application/UiApp/FrontPage.c
>> @@ -621,6 +621,11 @@ UpdateFrontPageBannerStrings (
>>         HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN
>> (STR_FRONT_PAGE_CPU_MODEL), NewString, NULL);
>>         FreePool (NewString);
>>
>> +        ConvertProcessorToString(Type4Record->CurrentSpeed, 6, &NewString);
>> +        UiCustomizeFrontPageBanner (2, FALSE, &NewString);
>> +        HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN
>> (STR_FRONT_PAGE_CPU_SPEED), NewString, NULL);
>> +        FreePool (NewString);
>> +
>>         FoundCpu = TRUE;
>>       }
>>     }
>> --
>> 2.19.1.3.g30247aa5d201
>>
>>
>> -=-=-=-=-=-=
>> Groups.io Links: You receive all messages sent to this group.
>>
>> View/Reply Online (#41886): https://edk2.groups.io/g/devel/message/41886
>> Mute This Topic: https://groups.io/mt/31929712/1759384
>> Group Owner: devel+owner@edk2.groups.io
>> Unsubscribe: https://edk2.groups.io/g/devel/unsub  [liming.gao@intel.com]
>> -=-=-=-=-=-=
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41926): https://edk2.groups.io/g/devel/message/41926
Mute This Topic: https://groups.io/mt/31929712/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.