1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [Patch] edk2: Update additional licenses in Readme.md

Michael D Kinney posted 1 patch 5 years, 5 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
Readme.md | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[edk2-devel] [Patch] edk2: Update additional licenses in Readme.md
Posted by Michael D Kinney 5 years, 5 months ago 
* Remove refrences EdkCompatibilityPkg
* Update link to OpenSSL to https://github.com/openssl/openssl
* Add link to https://github.com/ucb-bar/berkeley-softfloat-3
  for ArmSoftFloatLib

Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 Readme.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Readme.md b/Readme.md
index 1feba16075..d5556e15c6 100644
--- a/Readme.md
+++ b/Readme.md
@@ -12,10 +12,10 @@ contains the following components that are covered by additional licenses:
 * [MdeModulePkg/Library/LzmaCustomDecompressLib](MdeModulePkg/Library/LzmaCustomDecompressLib/LZMA-SDK-README.txt)
 * [IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/Sdk](IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LZMA-SDK-README.txt)
 * [BaseTools/Source/C/VfrCompile/Pccts](BaseTools/Source/C/VfrCompile/Pccts/RIGHTS)
-* [EdkCompatibilityPkg/Other/Maintained/Tools/Pccts](EdkCompatibilityPkg/Other/Maintained/Tools/Pccts/README)
 * [MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma](MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/README)
 * [OvmfPkg](OvmfPkg/License.txt)
-* [CryptoPkg/Library/OpensslLib/openssl](CryptoPkg/Library/OpensslLib/openssl/LICENSE)
+* [CryptoPkg/Library/OpensslLib/openssl](https://github.com/openssl/openssl)
+* [ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3](https://github.com/ucb-bar/berkeley-softfloat-3)
 
 The EDK II Project is composed of packages.  The maintainers for each package
 are listed in [Maintainers.txt](Maintainers.txt).
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41876): https://edk2.groups.io/g/devel/message/41876
Mute This Topic: https://groups.io/mt/31928713/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] edk2: Update additional licenses in Readme.md
Posted by Leif Lindholm 5 years, 5 months ago 
On Tue, Jun 04, 2019 at 10:12:48AM -0700, Michael D Kinney wrote:
> * Remove refrences EdkCompatibilityPkg
> * Update link to OpenSSL to https://github.com/openssl/openssl
> * Add link to https://github.com/ucb-bar/berkeley-softfloat-3
>   for ArmSoftFloatLib

Bikeshed warning:

> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Readme.md | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Readme.md b/Readme.md
> index 1feba16075..d5556e15c6 100644
> --- a/Readme.md
> +++ b/Readme.md
> @@ -12,10 +12,10 @@ contains the following components that are covered by additional licenses:
>  * [MdeModulePkg/Library/LzmaCustomDecompressLib](MdeModulePkg/Library/LzmaCustomDecompressLib/LZMA-SDK-README.txt)
>  * [IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/Sdk](IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LZMA-SDK-README.txt)
>  * [BaseTools/Source/C/VfrCompile/Pccts](BaseTools/Source/C/VfrCompile/Pccts/RIGHTS)
> -* [EdkCompatibilityPkg/Other/Maintained/Tools/Pccts](EdkCompatibilityPkg/Other/Maintained/Tools/Pccts/README)
>  * [MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma](MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/README)
>  * [OvmfPkg](OvmfPkg/License.txt)
> -* [CryptoPkg/Library/OpensslLib/openssl](CryptoPkg/Library/OpensslLib/openssl/LICENSE)
> +* [CryptoPkg/Library/OpensslLib/openssl](https://github.com/openssl/openssl)
> +* [ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3](https://github.com/ucb-bar/berkeley-softfloat-3)

For both of the above, could we point directly to the files in
question rather than pointing only at the repository?
I.e.
https://github.com/openssl/openssl/blob/151333164ece49fdba3fe5c4bbdc3333cd9ae66d/LICENSE
and
https://github.com/ucb-bar/berkeley-softfloat-3/blob/f74b1e48110ac3a27dd49b787d164e55e42d81d1/COPYING.txt

To be updated when updating the submodule base commits, if the license
files have changed in the meantime.

That way we don't end up confusing consumers if upstream relicenses a
later version.

/
    Leif

>  The EDK II Project is composed of packages.  The maintainers for each package
>  are listed in [Maintainers.txt](Maintainers.txt).
> -- 
> 2.21.0.windows.1
> 
> 
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41880): https://edk2.groups.io/g/devel/message/41880
Mute This Topic: https://groups.io/mt/31928713/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] edk2: Update additional licenses in Readme.md
Posted by Michael D Kinney 5 years, 5 months ago 
Leif,

I was wanting to figure out how to do the direct link
to the license material. Thanks for providing that!

I will send V2.

Mike

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
> On Behalf Of Leif Lindholm
> Sent: Tuesday, June 4, 2019 11:00 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [Patch] edk2: Update
> additional licenses in Readme.md
> 
> On Tue, Jun 04, 2019 at 10:12:48AM -0700, Michael D
> Kinney wrote:
> > * Remove refrences EdkCompatibilityPkg
> > * Update link to OpenSSL to
> https://github.com/openssl/openssl
> > * Add link to https://github.com/ucb-bar/berkeley-
> softfloat-3
> >   for ArmSoftFloatLib
> 
> Bikeshed warning:
> 
> > Signed-off-by: Michael D Kinney
> <michael.d.kinney@intel.com>
> > ---
> >  Readme.md | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Readme.md b/Readme.md
> > index 1feba16075..d5556e15c6 100644
> > --- a/Readme.md
> > +++ b/Readme.md
> > @@ -12,10 +12,10 @@ contains the following components
> that are covered by additional licenses:
> >  *
> >
> [MdeModulePkg/Library/LzmaCustomDecompressLib](MdeModule
> Pkg/Library/Lz
> > maCustomDecompressLib/LZMA-SDK-README.txt)
> >  *
> >
> [IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib
> /Sdk](IntelFra
> > meworkModulePkg/Library/LzmaCustomDecompressLib/LZMA-
> SDK-README.txt)
> >  *
> >
> [BaseTools/Source/C/VfrCompile/Pccts](BaseTools/Source/C
> /VfrCompile/Pc
> > cts/RIGHTS)
> > -*
> >
> [EdkCompatibilityPkg/Other/Maintained/Tools/Pccts](EdkCo
> mpatibilityPkg
> > /Other/Maintained/Tools/Pccts/README)
> >  *
> >
> [MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma](
> MdeModulePkg/U
> > niversal/RegularExpressionDxe/Oniguruma/README)
> >  * [OvmfPkg](OvmfPkg/License.txt)
> > -*
> >
> [CryptoPkg/Library/OpensslLib/openssl](CryptoPkg/Library
> /OpensslLib/op
> > enssl/LICENSE)
> > +*
> >
> +[CryptoPkg/Library/OpensslLib/openssl](https://github.c
> om/openssl/ope
> > +nssl)
> > +*
> > +[ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-
> 3](https://github.
> > +com/ucb-bar/berkeley-softfloat-3)
> 
> For both of the above, could we point directly to the
> files in question rather than pointing only at the
> repository?
> I.e.
> https://github.com/openssl/openssl/blob/151333164ece49fd
> ba3fe5c4bbdc3333cd9ae66d/LICENSE
> and
> https://github.com/ucb-bar/berkeley-softfloat-
> 3/blob/f74b1e48110ac3a27dd49b787d164e55e42d81d1/COPYING.
> txt
> 
> To be updated when updating the submodule base commits,
> if the license files have changed in the meantime.
> 
> That way we don't end up confusing consumers if upstream
> relicenses a later version.
> 
> /
>     Leif
> 
> >  The EDK II Project is composed of packages.  The
> maintainers for each
> > package  are listed in
> [Maintainers.txt](Maintainers.txt).
> > --
> > 2.21.0.windows.1
> >
> >
> >
> >
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41881): https://edk2.groups.io/g/devel/message/41881
Mute This Topic: https://groups.io/mt/31928713/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] edk2: Update additional licenses in Readme.md
Posted by Leif Lindholm 5 years, 5 months ago 
:)

For future reference:
- browse to file
- click the "history" button
- click the "<>" button for the top commit ("Browse the repository at
  this point in history")
- browse to the file again

(If someone has a less tedious route I'd appreciate it, but it works.)

/
    Leif

On Tue, Jun 04, 2019 at 06:31:51PM +0000, Kinney, Michael D wrote:
> Leif,
> 
> I was wanting to figure out how to do the direct link
> to the license material. Thanks for providing that!
> 
> I will send V2.
> 
> Mike
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
> > On Behalf Of Leif Lindholm
> > Sent: Tuesday, June 4, 2019 11:00 AM
> > To: devel@edk2.groups.io; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: Re: [edk2-devel] [Patch] edk2: Update
> > additional licenses in Readme.md
> > 
> > On Tue, Jun 04, 2019 at 10:12:48AM -0700, Michael D
> > Kinney wrote:
> > > * Remove refrences EdkCompatibilityPkg
> > > * Update link to OpenSSL to
> > https://github.com/openssl/openssl
> > > * Add link to https://github.com/ucb-bar/berkeley-
> > softfloat-3
> > >   for ArmSoftFloatLib
> > 
> > Bikeshed warning:
> > 
> > > Signed-off-by: Michael D Kinney
> > <michael.d.kinney@intel.com>
> > > ---
> > >  Readme.md | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Readme.md b/Readme.md
> > > index 1feba16075..d5556e15c6 100644
> > > --- a/Readme.md
> > > +++ b/Readme.md
> > > @@ -12,10 +12,10 @@ contains the following components
> > that are covered by additional licenses:
> > >  *
> > >
> > [MdeModulePkg/Library/LzmaCustomDecompressLib](MdeModule
> > Pkg/Library/Lz
> > > maCustomDecompressLib/LZMA-SDK-README.txt)
> > >  *
> > >
> > [IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib
> > /Sdk](IntelFra
> > > meworkModulePkg/Library/LzmaCustomDecompressLib/LZMA-
> > SDK-README.txt)
> > >  *
> > >
> > [BaseTools/Source/C/VfrCompile/Pccts](BaseTools/Source/C
> > /VfrCompile/Pc
> > > cts/RIGHTS)
> > > -*
> > >
> > [EdkCompatibilityPkg/Other/Maintained/Tools/Pccts](EdkCo
> > mpatibilityPkg
> > > /Other/Maintained/Tools/Pccts/README)
> > >  *
> > >
> > [MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma](
> > MdeModulePkg/U
> > > niversal/RegularExpressionDxe/Oniguruma/README)
> > >  * [OvmfPkg](OvmfPkg/License.txt)
> > > -*
> > >
> > [CryptoPkg/Library/OpensslLib/openssl](CryptoPkg/Library
> > /OpensslLib/op
> > > enssl/LICENSE)
> > > +*
> > >
> > +[CryptoPkg/Library/OpensslLib/openssl](https://github.c
> > om/openssl/ope
> > > +nssl)
> > > +*
> > > +[ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-
> > 3](https://github.
> > > +com/ucb-bar/berkeley-softfloat-3)
> > 
> > For both of the above, could we point directly to the
> > files in question rather than pointing only at the
> > repository?
> > I.e.
> > https://github.com/openssl/openssl/blob/151333164ece49fd
> > ba3fe5c4bbdc3333cd9ae66d/LICENSE
> > and
> > https://github.com/ucb-bar/berkeley-softfloat-
> > 3/blob/f74b1e48110ac3a27dd49b787d164e55e42d81d1/COPYING.
> > txt
> > 
> > To be updated when updating the submodule base commits,
> > if the license files have changed in the meantime.
> > 
> > That way we don't end up confusing consumers if upstream
> > relicenses a later version.
> > 
> > /
> >     Leif
> > 
> > >  The EDK II Project is composed of packages.  The
> > maintainers for each
> > > package  are listed in
> > [Maintainers.txt](Maintainers.txt).
> > > --
> > > 2.21.0.windows.1
> > >
> > >
> > >
> > >
> > 
> > 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41884): https://edk2.groups.io/g/devel/message/41884
Mute This Topic: https://groups.io/mt/31928713/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] edk2: Update additional licenses in Readme.md
Posted by Laszlo Ersek 5 years, 5 months ago 
On 06/04/19 19:12, Michael D Kinney wrote:
> * Remove refrences EdkCompatibilityPkg
> * Update link to OpenSSL to https://github.com/openssl/openssl
> * Add link to https://github.com/ucb-bar/berkeley-softfloat-3
>   for ArmSoftFloatLib
> 
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Readme.md | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Readme.md b/Readme.md
> index 1feba16075..d5556e15c6 100644
> --- a/Readme.md
> +++ b/Readme.md
> @@ -12,10 +12,10 @@ contains the following components that are covered by additional licenses:
>  * [MdeModulePkg/Library/LzmaCustomDecompressLib](MdeModulePkg/Library/LzmaCustomDecompressLib/LZMA-SDK-README.txt)
>  * [IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/Sdk](IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LZMA-SDK-README.txt)
>  * [BaseTools/Source/C/VfrCompile/Pccts](BaseTools/Source/C/VfrCompile/Pccts/RIGHTS)
> -* [EdkCompatibilityPkg/Other/Maintained/Tools/Pccts](EdkCompatibilityPkg/Other/Maintained/Tools/Pccts/README)
>  * [MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma](MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/README)
>  * [OvmfPkg](OvmfPkg/License.txt)
> -* [CryptoPkg/Library/OpensslLib/openssl](CryptoPkg/Library/OpensslLib/openssl/LICENSE)
> +* [CryptoPkg/Library/OpensslLib/openssl](https://github.com/openssl/openssl)
> +* [ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3](https://github.com/ucb-bar/berkeley-softfloat-3)
>  
>  The EDK II Project is composed of packages.  The maintainers for each package
>  are listed in [Maintainers.txt](Maintainers.txt).
> 

Please add 1 or 2 sentences to the commit message as to why this change
is useful -- IIUC, the goal is that the links (currently pointing into
submodule trees) become functional in a web browser, when a user looks
at the landing page at <https://github.com/tianocore/edk2/>.

With such a clarification:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

(And I agree this is eligible for pushing during the hard freeze.)

Thanks!
Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41879): https://edk2.groups.io/g/devel/message/41879
Mute This Topic: https://groups.io/mt/31928713/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.