1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [Patch] Maintainers.txt: Remove Network maintainers for MdeModulePkg/Universal/Network

Liming Gao posted 1 patch 4 years, 10 months ago
Failed in applying to current master (apply log)
Maintainers.txt | 2 --
1 file changed, 2 deletions(-)
[edk2-devel] [Patch] Maintainers.txt: Remove Network maintainers for MdeModulePkg/Universal/Network
Posted by Liming Gao 4 years, 10 months ago 
MdeModulePkg/Universal/Network has been moved to NetworkPkg. So,
MdeModulePkg/Universal/Network can be removed in Maintainers.txt.

Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
---
Because MdeModulePkg/Universal/Network has been moved to NetworkPkg,
I suggest to fix Maintainers.txt for 201905 stable tag.

 Maintainers.txt | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Maintainers.txt b/Maintainers.txt
index 010ec31404..3bab8a2db4 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -161,8 +161,6 @@ MdeModulePkg
 W: https://github.com/tianocore/tianocore.github.io/wiki/MdeModulePkg
 M: Jian J Wang <jian.j.wang@intel.com>
 M: Hao A Wu <hao.a.wu@intel.com>
-M: NetworkPkg maintainers
-  (Universal/Network and related libraries, header files)
 R: Ray Ni <ray.ni@intel.com>
   (especially for Bus, Universal/Console, Universal/Disk,
    Universal/BdsDxe and related libraries, header files)
-- 
2.13.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41864): https://edk2.groups.io/g/devel/message/41864
Mute This Topic: https://groups.io/mt/31926799/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] Maintainers.txt: Remove Network maintainers for MdeModulePkg/Universal/Network
Posted by Leif Lindholm 4 years, 10 months ago 
On Tue, Jun 04, 2019 at 10:10:59PM +0800, Liming Gao wrote:
> MdeModulePkg/Universal/Network has been moved to NetworkPkg. So,
> MdeModulePkg/Universal/Network can be removed in Maintainers.txt.
> 
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> Because MdeModulePkg/Universal/Network has been moved to NetworkPkg,
> I suggest to fix Maintainers.txt for 201905 stable tag.

I agree. Since
1) it is not a code fix
and
2) it corrects the maintainership state at the time of the stable tag

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

>  Maintainers.txt | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 010ec31404..3bab8a2db4 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -161,8 +161,6 @@ MdeModulePkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/MdeModulePkg
>  M: Jian J Wang <jian.j.wang@intel.com>
>  M: Hao A Wu <hao.a.wu@intel.com>
> -M: NetworkPkg maintainers
> -  (Universal/Network and related libraries, header files)
>  R: Ray Ni <ray.ni@intel.com>
>    (especially for Bus, Universal/Console, Universal/Disk,
>     Universal/BdsDxe and related libraries, header files)
> -- 
> 2.13.0.windows.1
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41866): https://edk2.groups.io/g/devel/message/41866
Mute This Topic: https://groups.io/mt/31926799/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] Maintainers.txt: Remove Network maintainers for MdeModulePkg/Universal/Network
Posted by Laszlo Ersek 4 years, 10 months ago 
On 06/04/19 16:35, Leif Lindholm wrote:
> On Tue, Jun 04, 2019 at 10:10:59PM +0800, Liming Gao wrote:
>> MdeModulePkg/Universal/Network has been moved to NetworkPkg. So,
>> MdeModulePkg/Universal/Network can be removed in Maintainers.txt.
>>
>> Signed-off-by: Liming Gao <liming.gao@intel.com>
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> ---
>> Because MdeModulePkg/Universal/Network has been moved to NetworkPkg,
>> I suggest to fix Maintainers.txt for 201905 stable tag.
> 
> I agree. Since
> 1) it is not a code fix
> and
> 2) it corrects the maintainership state at the time of the stable tag
> 
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo

>>  Maintainers.txt | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/Maintainers.txt b/Maintainers.txt
>> index 010ec31404..3bab8a2db4 100644
>> --- a/Maintainers.txt
>> +++ b/Maintainers.txt
>> @@ -161,8 +161,6 @@ MdeModulePkg
>>  W: https://github.com/tianocore/tianocore.github.io/wiki/MdeModulePkg
>>  M: Jian J Wang <jian.j.wang@intel.com>
>>  M: Hao A Wu <hao.a.wu@intel.com>
>> -M: NetworkPkg maintainers
>> -  (Universal/Network and related libraries, header files)
>>  R: Ray Ni <ray.ni@intel.com>
>>    (especially for Bus, Universal/Console, Universal/Disk,
>>     Universal/BdsDxe and related libraries, header files)
>> -- 
>> 2.13.0.windows.1
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41875): https://edk2.groups.io/g/devel/message/41875
Mute This Topic: https://groups.io/mt/31926799/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch] Maintainers.txt: Remove Network maintainers for MdeModulePkg/Universal/Network
Posted by Liming Gao 4 years, 10 months ago 
Push @cbfdc1b2df65dee011cf33add1dff88de3d9c46d

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Wednesday, June 5, 2019 12:56 AM
> To: Leif Lindholm <leif.lindholm@linaro.org>; Gao, Liming <liming.gao@intel.com>
> Cc: devel@edk2.groups.io; Andrew Fish <afish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [Patch] Maintainers.txt: Remove Network maintainers for MdeModulePkg/Universal/Network
> 
> On 06/04/19 16:35, Leif Lindholm wrote:
> > On Tue, Jun 04, 2019 at 10:10:59PM +0800, Liming Gao wrote:
> >> MdeModulePkg/Universal/Network has been moved to NetworkPkg. So,
> >> MdeModulePkg/Universal/Network can be removed in Maintainers.txt.
> >>
> >> Signed-off-by: Liming Gao <liming.gao@intel.com>
> >> Cc: Andrew Fish <afish@apple.com>
> >> Cc: Laszlo Ersek <lersek@redhat.com>
> >> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> >> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> >> ---
> >> Because MdeModulePkg/Universal/Network has been moved to NetworkPkg,
> >> I suggest to fix Maintainers.txt for 201905 stable tag.
> >
> > I agree. Since
> > 1) it is not a code fix
> > and
> > 2) it corrects the maintainership state at the time of the stable tag
> >
> > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> Thanks!
> Laszlo
> 
> >>  Maintainers.txt | 2 --
> >>  1 file changed, 2 deletions(-)
> >>
> >> diff --git a/Maintainers.txt b/Maintainers.txt
> >> index 010ec31404..3bab8a2db4 100644
> >> --- a/Maintainers.txt
> >> +++ b/Maintainers.txt
> >> @@ -161,8 +161,6 @@ MdeModulePkg
> >>  W: https://github.com/tianocore/tianocore.github.io/wiki/MdeModulePkg
> >>  M: Jian J Wang <jian.j.wang@intel.com>
> >>  M: Hao A Wu <hao.a.wu@intel.com>
> >> -M: NetworkPkg maintainers
> >> -  (Universal/Network and related libraries, header files)
> >>  R: Ray Ni <ray.ni@intel.com>
> >>    (especially for Bus, Universal/Console, Universal/Disk,
> >>     Universal/BdsDxe and related libraries, header files)
> >> --
> >> 2.13.0.windows.1
> >>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41928): https://edk2.groups.io/g/devel/message/41928
Mute This Topic: https://groups.io/mt/31926799/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.