1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system

Javeed, Ashraf posted 1 patch 4 years, 11 months ago
Failed in applying to current master (apply log)
MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c | 19 +------------------
1 file changed, 1 insertion(+), 18 deletions(-)
[edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system
Posted by Javeed, Ashraf 4 years, 11 months ago 
https://bugzilla.tianocore.org/show_bug.cgi?id=1796
Bug fixed in PciBusDxe\PciLib.c.
Removed the redundant second call to PciSearchDevice sub-routine when the
PCD for the Hot-Plug support is disabled.

Signed-off-by: Ashraf Javeed <Ashraf.javeed@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
---
 MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c | 19 +------------------
 1 file changed, 1 insertion(+), 18 deletions(-)

diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
index f0d9f45c4a..5b55fb5d3b 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
@@ -1114,24 +1114,7 @@ PciScanBus (
         //
         // For PPB
         //
-        if (!FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
-          //
-          // If Hot Plug is not supported,
-          // get the bridge information
-          //
-          Status = PciSearchDevice (
-                    Bridge,
-                    &Pci,
-                    StartBusNumber,
-                    Device,
-                    Func,
-                    &PciDevice
-                    );
-
-          if (EFI_ERROR (Status)) {
-            return Status;
-          }
-        } else {
+        if (FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
           //
           // If Hot Plug is supported,
           // Get the bridge information
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41418): https://edk2.groups.io/g/devel/message/41418
Mute This Topic: https://groups.io/mt/31810004/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system
Posted by Ni, Ray 4 years, 11 months ago 
Reviewed-by: Ray Ni <ray.ni@intel.com>


> -----Original Message-----
> From: Javeed, Ashraf
> Sent: Monday, May 27, 2019 6:24 PM
> To: devel@edk2.groups.io
> Cc: Javeed, Ashraf <ashraf.javeed@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [PATCH] PciBusDxe: duplicate node insertion for every PPB device in
> the system
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=1796
> Bug fixed in PciBusDxe\PciLib.c.
> Removed the redundant second call to PciSearchDevice sub-routine when
> the PCD for the Hot-Plug support is disabled.
> 
> Signed-off-by: Ashraf Javeed <Ashraf.javeed@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c | 19 +------------------
>  1 file changed, 1 insertion(+), 18 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> index f0d9f45c4a..5b55fb5d3b 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> @@ -1114,24 +1114,7 @@ PciScanBus (
>          //
>          // For PPB
>          //
> -        if (!FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> -          //
> -          // If Hot Plug is not supported,
> -          // get the bridge information
> -          //
> -          Status = PciSearchDevice (
> -                    Bridge,
> -                    &Pci,
> -                    StartBusNumber,
> -                    Device,
> -                    Func,
> -                    &PciDevice
> -                    );
> -
> -          if (EFI_ERROR (Status)) {
> -            return Status;
> -          }
> -        } else {
> +        if (FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
>            //
>            // If Hot Plug is supported,
>            // Get the bridge information
> --
> 2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41440): https://edk2.groups.io/g/devel/message/41440
Mute This Topic: https://groups.io/mt/31810004/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system
Posted by Ni, Ray 4 years, 11 months ago 
Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Javeed, Ashraf
> Sent: Monday, May 27, 2019 6:24 PM
> To: devel@edk2.groups.io
> Cc: Javeed, Ashraf <ashraf.javeed@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [PATCH] PciBusDxe: duplicate node insertion for every PPB device in
> the system
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=1796
> Bug fixed in PciBusDxe\PciLib.c.
> Removed the redundant second call to PciSearchDevice sub-routine when
> the PCD for the Hot-Plug support is disabled.
> 
> Signed-off-by: Ashraf Javeed <Ashraf.javeed@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c | 19 +------------------
>  1 file changed, 1 insertion(+), 18 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> index f0d9f45c4a..5b55fb5d3b 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> @@ -1114,24 +1114,7 @@ PciScanBus (
>          //
>          // For PPB
>          //
> -        if (!FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> -          //
> -          // If Hot Plug is not supported,
> -          // get the bridge information
> -          //
> -          Status = PciSearchDevice (
> -                    Bridge,
> -                    &Pci,
> -                    StartBusNumber,
> -                    Device,
> -                    Func,
> -                    &PciDevice
> -                    );
> -
> -          if (EFI_ERROR (Status)) {
> -            return Status;
> -          }
> -        } else {
> +        if (FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
>            //
>            // If Hot Plug is supported,
>            // Get the bridge information
> --
> 2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42504): https://edk2.groups.io/g/devel/message/42504
Mute This Topic: https://groups.io/mt/31810004/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system
Posted by Wu, Hao A 4 years, 11 months ago 
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni,
> Ray
> Sent: Monday, June 17, 2019 5:49 PM
> To: Javeed, Ashraf; devel@edk2.groups.io
> Cc: Wang, Jian J
> Subject: Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for
> every PPB device in the system
> 
> Reviewed-by: Ray Ni <ray.ni@intel.com>

Hello all,

I did not see the origin patch being sent to the mailing list.
Maybe Ashraf has not subscribed the mailing list?

Best Regards,
Hao Wu

> 
> > -----Original Message-----
> > From: Javeed, Ashraf
> > Sent: Monday, May 27, 2019 6:24 PM
> > To: devel@edk2.groups.io
> > Cc: Javeed, Ashraf <ashraf.javeed@intel.com>; Wang, Jian J
> > <jian.j.wang@intel.com>; Ni, Ray <ray.ni@intel.com>
> > Subject: [PATCH] PciBusDxe: duplicate node insertion for every PPB device
> in
> > the system
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=1796
> > Bug fixed in PciBusDxe\PciLib.c.
> > Removed the redundant second call to PciSearchDevice sub-routine when
> > the PCD for the Hot-Plug support is disabled.
> >
> > Signed-off-by: Ashraf Javeed <Ashraf.javeed@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > ---
> >  MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c | 19 +------------------
> >  1 file changed, 1 insertion(+), 18 deletions(-)
> >
> > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > index f0d9f45c4a..5b55fb5d3b 100644
> > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > @@ -1114,24 +1114,7 @@ PciScanBus (
> >          //
> >          // For PPB
> >          //
> > -        if (!FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> > -          //
> > -          // If Hot Plug is not supported,
> > -          // get the bridge information
> > -          //
> > -          Status = PciSearchDevice (
> > -                    Bridge,
> > -                    &Pci,
> > -                    StartBusNumber,
> > -                    Device,
> > -                    Func,
> > -                    &PciDevice
> > -                    );
> > -
> > -          if (EFI_ERROR (Status)) {
> > -            return Status;
> > -          }
> > -        } else {
> > +        if (FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> >            //
> >            // If Hot Plug is supported,
> >            // Get the bridge information
> > --
> > 2.21.0.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42524): https://edk2.groups.io/g/devel/message/42524
Mute This Topic: https://groups.io/mt/31810004/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system
Posted by Wu, Hao A 4 years, 11 months ago 
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Tuesday, June 18, 2019 10:24 AM
> To: devel@edk2.groups.io; Ni, Ray; Javeed, Ashraf
> Cc: Wang, Jian J
> Subject: Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for
> every PPB device in the system
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Ni,
> > Ray
> > Sent: Monday, June 17, 2019 5:49 PM
> > To: Javeed, Ashraf; devel@edk2.groups.io
> > Cc: Wang, Jian J
> > Subject: Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for
> > every PPB device in the system
> >
> > Reviewed-by: Ray Ni <ray.ni@intel.com>
> 
> Hello all,
> 
> I did not see the origin patch being sent to the mailing list.
> Maybe Ashraf has not subscribed the mailing list?

Sorry, saw it at:
https://edk2.groups.io/g/devel/message/41418

Acked-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu

> 
> Best Regards,
> Hao Wu
> 
> >
> > > -----Original Message-----
> > > From: Javeed, Ashraf
> > > Sent: Monday, May 27, 2019 6:24 PM
> > > To: devel@edk2.groups.io
> > > Cc: Javeed, Ashraf <ashraf.javeed@intel.com>; Wang, Jian J
> > > <jian.j.wang@intel.com>; Ni, Ray <ray.ni@intel.com>
> > > Subject: [PATCH] PciBusDxe: duplicate node insertion for every PPB
> device
> > in
> > > the system
> > >
> > > https://bugzilla.tianocore.org/show_bug.cgi?id=1796
> > > Bug fixed in PciBusDxe\PciLib.c.
> > > Removed the redundant second call to PciSearchDevice sub-routine
> when
> > > the PCD for the Hot-Plug support is disabled.
> > >
> > > Signed-off-by: Ashraf Javeed <Ashraf.javeed@intel.com>
> > > Cc: Jian J Wang <jian.j.wang@intel.com>
> > > Cc: Ray Ni <ray.ni@intel.com>
> > > ---
> > >  MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c | 19 +------------------
> > >  1 file changed, 1 insertion(+), 18 deletions(-)
> > >
> > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > > index f0d9f45c4a..5b55fb5d3b 100644
> > > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > > @@ -1114,24 +1114,7 @@ PciScanBus (
> > >          //
> > >          // For PPB
> > >          //
> > > -        if (!FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> > > -          //
> > > -          // If Hot Plug is not supported,
> > > -          // get the bridge information
> > > -          //
> > > -          Status = PciSearchDevice (
> > > -                    Bridge,
> > > -                    &Pci,
> > > -                    StartBusNumber,
> > > -                    Device,
> > > -                    Func,
> > > -                    &PciDevice
> > > -                    );
> > > -
> > > -          if (EFI_ERROR (Status)) {
> > > -            return Status;
> > > -          }
> > > -        } else {
> > > +        if (FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> > >            //
> > >            // If Hot Plug is supported,
> > >            // Get the bridge information
> > > --
> > > 2.21.0.windows.1
> >
> >
> >
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42525): https://edk2.groups.io/g/devel/message/42525
Mute This Topic: https://groups.io/mt/31810004/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system
Posted by Wu, Hao A 4 years, 10 months ago 
> -----Original Message-----
> From: Wu, Hao A
> Sent: Tuesday, June 18, 2019 10:28 AM
> To: devel@edk2.groups.io; Wu, Hao A; Ni, Ray; Javeed, Ashraf
> Cc: Wang, Jian J
> Subject: RE: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for
> every PPB device in the system
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Wu, Hao A
> > Sent: Tuesday, June 18, 2019 10:24 AM
> > To: devel@edk2.groups.io; Ni, Ray; Javeed, Ashraf
> > Cc: Wang, Jian J
> > Subject: Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for
> > every PPB device in the system
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> Of
> > Ni,
> > > Ray
> > > Sent: Monday, June 17, 2019 5:49 PM
> > > To: Javeed, Ashraf; devel@edk2.groups.io
> > > Cc: Wang, Jian J
> > > Subject: Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion
> for
> > > every PPB device in the system
> > >
> > > Reviewed-by: Ray Ni <ray.ni@intel.com>
> >
> > Hello all,
> >
> > I did not see the origin patch being sent to the mailing list.
> > Maybe Ashraf has not subscribed the mailing list?
> 
> Sorry, saw it at:
> https://edk2.groups.io/g/devel/message/41418
> 
> Acked-by: Hao A Wu <hao.a.wu@intel.com>


Pushed via commit 2603fce126.

Best Regards,
Hao Wu


> 
> Best Regards,
> Hao Wu
> 
> >
> > Best Regards,
> > Hao Wu
> >
> > >
> > > > -----Original Message-----
> > > > From: Javeed, Ashraf
> > > > Sent: Monday, May 27, 2019 6:24 PM
> > > > To: devel@edk2.groups.io
> > > > Cc: Javeed, Ashraf <ashraf.javeed@intel.com>; Wang, Jian J
> > > > <jian.j.wang@intel.com>; Ni, Ray <ray.ni@intel.com>
> > > > Subject: [PATCH] PciBusDxe: duplicate node insertion for every PPB
> > device
> > > in
> > > > the system
> > > >
> > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1796
> > > > Bug fixed in PciBusDxe\PciLib.c.
> > > > Removed the redundant second call to PciSearchDevice sub-routine
> > when
> > > > the PCD for the Hot-Plug support is disabled.
> > > >
> > > > Signed-off-by: Ashraf Javeed <Ashraf.javeed@intel.com>
> > > > Cc: Jian J Wang <jian.j.wang@intel.com>
> > > > Cc: Ray Ni <ray.ni@intel.com>
> > > > ---
> > > >  MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c | 19 +------------------
> > > >  1 file changed, 1 insertion(+), 18 deletions(-)
> > > >
> > > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > > > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > > > index f0d9f45c4a..5b55fb5d3b 100644
> > > > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > > > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > > > @@ -1114,24 +1114,7 @@ PciScanBus (
> > > >          //
> > > >          // For PPB
> > > >          //
> > > > -        if (!FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> > > > -          //
> > > > -          // If Hot Plug is not supported,
> > > > -          // get the bridge information
> > > > -          //
> > > > -          Status = PciSearchDevice (
> > > > -                    Bridge,
> > > > -                    &Pci,
> > > > -                    StartBusNumber,
> > > > -                    Device,
> > > > -                    Func,
> > > > -                    &PciDevice
> > > > -                    );
> > > > -
> > > > -          if (EFI_ERROR (Status)) {
> > > > -            return Status;
> > > > -          }
> > > > -        } else {
> > > > +        if (FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> > > >            //
> > > >            // If Hot Plug is supported,
> > > >            // Get the bridge information
> > > > --
> > > > 2.21.0.windows.1
> > >
> > >
> > >
> >
> >
> > 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43105): https://edk2.groups.io/g/devel/message/43105
Mute This Topic: https://groups.io/mt/31810004/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.