[edk2-devel] [PATCH v2 00/10] Duplicate required CSM components for OVMF

Wu, Hao A posted 10 patches 4 years, 11 months ago
Failed in applying to current master (apply log)
OvmfPkg/OvmfPkg.dec                                                 |   68 +
OvmfPkg/OvmfPkgIa32.dsc                                             |   10 +-
OvmfPkg/OvmfPkgIa32X64.dsc                                          |   10 +-
OvmfPkg/OvmfPkgX64.dsc                                              |   10 +-
OvmfPkg/OvmfPkgIa32.fdf                                             |    4 +-
OvmfPkg/OvmfPkgIa32X64.fdf                                          |    4 +-
OvmfPkg/OvmfPkgX64.fdf                                              |    4 +-
OvmfPkg/Csm/BiosThunk/VideoDxe/VideoDxe.inf                         |   78 +
OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosDxe.inf                         |  129 +
OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf           |   62 +
OvmfPkg/Csm/LegacyBootManagerLib/LegacyBootManagerLib.inf           |   57 +
OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h                          |  532 ++++
OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h                 |  459 +++
OvmfPkg/Csm/Include/Framework/BootScript.h                          |   41 +
OvmfPkg/Csm/Include/Framework/DxeCis.h                              |  170 +
OvmfPkg/Csm/Include/Framework/FirmwareVolumeHeader.h                |   79 +
OvmfPkg/Csm/Include/Framework/FirmwareVolumeImageFormat.h           |   32 +
OvmfPkg/Csm/Include/Framework/FrameworkInternalFormRepresentation.h |  397 +++
OvmfPkg/Csm/Include/Framework/Hob.h                                 |   28 +
OvmfPkg/Csm/Include/Framework/StatusCode.h                          |  155 +
OvmfPkg/Csm/Include/FrameworkDxe.h                                  |   26 +
OvmfPkg/Csm/Include/Guid/LegacyBios.h                               |   29 +
OvmfPkg/Csm/Include/Guid/LegacyDevOrder.h                           |   39 +
OvmfPkg/Csm/Include/Protocol/FirmwareVolume.h                       |  340 ++
OvmfPkg/Csm/Include/Protocol/IsaAcpi.h                              |  298 ++
OvmfPkg/Csm/Include/Protocol/IsaIo.h                                |  356 +++
OvmfPkg/Csm/Include/Protocol/LegacyBios.h                           | 1553 +++++++++
OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h                   |  755 +++++
OvmfPkg/Csm/Include/Protocol/LegacyInterrupt.h                      |  122 +
OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h                          |   88 +
OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h                     | 1460 +++++++++
OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.h                |  249 ++
OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.h             |   79 +
OvmfPkg/Csm/LegacyBootManagerLib/InternalLegacyBm.h                 |   60 +
OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c                          | 3289 ++++++++++++++++++++
OvmfPkg/Csm/BiosThunk/VideoDxe/ComponentName.c                      |  306 ++
OvmfPkg/Csm/LegacyBiosDxe/LegacyBbs.c                               |  377 +++
OvmfPkg/Csm/LegacyBiosDxe/LegacyBda.c                               |   62 +
OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c                              | 1214 ++++++++
OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c                       | 2173 +++++++++++++
OvmfPkg/Csm/LegacyBiosDxe/LegacyCmos.c                              |  117 +
OvmfPkg/Csm/LegacyBiosDxe/LegacyIde.c                               |  310 ++
OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c                               | 3083 ++++++++++++++++++
OvmfPkg/Csm/LegacyBiosDxe/LegacySio.c                               |  477 +++
OvmfPkg/Csm/LegacyBiosDxe/Thunk.c                                   |  419 +++
OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.c                | 1505 +++++++++
OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c                         | 1530 +++++++++
Maintainers.txt                                                     |    2 +
OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideoDxe.uni                     |   17 +
OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideoDxeExtra.uni                |   14 +
OvmfPkg/Csm/LegacyBiosDxe/IA32/InterruptTable.nasm                  |   63 +
OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosDxe.uni                         |   16 +
OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosDxeExtra.uni                    |   14 +
OvmfPkg/Csm/LegacyBiosDxe/X64/InterruptTable.nasm                   |   64 +
OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni           |   20 +
OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiStrings.uni       |   43 +
OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.Vfr           |   67 +
OvmfPkg/Csm/LegacyBootManagerLib/LegacyBootManagerLib.uni           |   20 +
58 files changed, 22964 insertions(+), 21 deletions(-)
create mode 100644 OvmfPkg/Csm/BiosThunk/VideoDxe/VideoDxe.inf
create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosDxe.inf
create mode 100644 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf
create mode 100644 OvmfPkg/Csm/LegacyBootManagerLib/LegacyBootManagerLib.inf
create mode 100644 OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h
create mode 100644 OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h
create mode 100644 OvmfPkg/Csm/Include/Framework/BootScript.h
create mode 100644 OvmfPkg/Csm/Include/Framework/DxeCis.h
create mode 100644 OvmfPkg/Csm/Include/Framework/FirmwareVolumeHeader.h
create mode 100644 OvmfPkg/Csm/Include/Framework/FirmwareVolumeImageFormat.h
create mode 100644 OvmfPkg/Csm/Include/Framework/FrameworkInternalFormRepresentation.h
create mode 100644 OvmfPkg/Csm/Include/Framework/Hob.h
create mode 100644 OvmfPkg/Csm/Include/Framework/StatusCode.h
create mode 100644 OvmfPkg/Csm/Include/FrameworkDxe.h
create mode 100644 OvmfPkg/Csm/Include/Guid/LegacyBios.h
create mode 100644 OvmfPkg/Csm/Include/Guid/LegacyDevOrder.h
create mode 100644 OvmfPkg/Csm/Include/Protocol/FirmwareVolume.h
create mode 100644 OvmfPkg/Csm/Include/Protocol/IsaAcpi.h
create mode 100644 OvmfPkg/Csm/Include/Protocol/IsaIo.h
create mode 100644 OvmfPkg/Csm/Include/Protocol/LegacyBios.h
create mode 100644 OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h
create mode 100644 OvmfPkg/Csm/Include/Protocol/LegacyInterrupt.h
create mode 100644 OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h
create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h
create mode 100644 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.h
create mode 100644 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.h
create mode 100644 OvmfPkg/Csm/LegacyBootManagerLib/InternalLegacyBm.h
create mode 100644 OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c
create mode 100644 OvmfPkg/Csm/BiosThunk/VideoDxe/ComponentName.c
create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBbs.c
create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBda.c
create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c
create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c
create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyCmos.c
create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyIde.c
create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c
create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacySio.c
create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/Thunk.c
create mode 100644 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.c
create mode 100644 OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c
create mode 100644 OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideoDxe.uni
create mode 100644 OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideoDxeExtra.uni
create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/IA32/InterruptTable.nasm
create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosDxe.uni
create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosDxeExtra.uni
create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/X64/InterruptTable.nasm
create mode 100644 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni
create mode 100644 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiStrings.uni
create mode 100644 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.Vfr
create mode 100644 OvmfPkg/Csm/LegacyBootManagerLib/LegacyBootManagerLib.uni
[edk2-devel] [PATCH v2 00/10] Duplicate required CSM components for OVMF
Posted by Wu, Hao A 4 years, 11 months ago
'''
Please note that this series will be hold until the edk2-stable201905 is
created.
'''

The series is also available at:
https://github.com/hwu25/edk2/tree/ovmf_csm_v2

V2 changes:

Discussion with David Woodhouse for him to take the reviewer role for the
duplicated CSM components under OvmfPkg:
https://edk2.groups.io/g/devel/topic/31682287#40996

The (new) first patch will update the Maintainers.txt to reflect such
role.


V1 history:

The series will duplicate the CSM components used by the OVMF package from
IntelFrameworkModulePkg & IntelFrameworkPkg.

Verification done for the series:
* Build pass with/without build command option '-D CSM_ENABLE';
* Boot shell pass with the built images.

Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Hao A Wu (10):
  Maintainers.txt: Add maintainer for CSM components in OvmfPkg
  OvmfPkg: Copy the required CSM components from framework packages
  OvmfPkg/OvmfPkg.dec: Add definitions for CSM-related Guid & Protocol
  OvmfPkg/OvmfPkg.dec: Add the new include folder for CSM header files
  OvmfPkg/OvmfPkg.dec: Add PCD definitions used by copied CSM modules
  OvmfPkg/Csm/VideoDxe: Update to make it build for OVMF
  OvmfPkg/Csm/LegacyBiosDxe: Update to make it build for OVMF
  OvmfPkg/Csm/LegacyBootMaintUiLib: Update to make it build for OVMF
  OvmfPkg/Csm/LegacyBootManagerLib: Update to make it build for OVMF
  OvmfPkg: Update DSC/FDF files to consume CSM components in OvmfPkg

 OvmfPkg/OvmfPkg.dec                                                 |   68 +
 OvmfPkg/OvmfPkgIa32.dsc                                             |   10 +-
 OvmfPkg/OvmfPkgIa32X64.dsc                                          |   10 +-
 OvmfPkg/OvmfPkgX64.dsc                                              |   10 +-
 OvmfPkg/OvmfPkgIa32.fdf                                             |    4 +-
 OvmfPkg/OvmfPkgIa32X64.fdf                                          |    4 +-
 OvmfPkg/OvmfPkgX64.fdf                                              |    4 +-
 OvmfPkg/Csm/BiosThunk/VideoDxe/VideoDxe.inf                         |   78 +
 OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosDxe.inf                         |  129 +
 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf           |   62 +
 OvmfPkg/Csm/LegacyBootManagerLib/LegacyBootManagerLib.inf           |   57 +
 OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h                          |  532 ++++
 OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h                 |  459 +++
 OvmfPkg/Csm/Include/Framework/BootScript.h                          |   41 +
 OvmfPkg/Csm/Include/Framework/DxeCis.h                              |  170 +
 OvmfPkg/Csm/Include/Framework/FirmwareVolumeHeader.h                |   79 +
 OvmfPkg/Csm/Include/Framework/FirmwareVolumeImageFormat.h           |   32 +
 OvmfPkg/Csm/Include/Framework/FrameworkInternalFormRepresentation.h |  397 +++
 OvmfPkg/Csm/Include/Framework/Hob.h                                 |   28 +
 OvmfPkg/Csm/Include/Framework/StatusCode.h                          |  155 +
 OvmfPkg/Csm/Include/FrameworkDxe.h                                  |   26 +
 OvmfPkg/Csm/Include/Guid/LegacyBios.h                               |   29 +
 OvmfPkg/Csm/Include/Guid/LegacyDevOrder.h                           |   39 +
 OvmfPkg/Csm/Include/Protocol/FirmwareVolume.h                       |  340 ++
 OvmfPkg/Csm/Include/Protocol/IsaAcpi.h                              |  298 ++
 OvmfPkg/Csm/Include/Protocol/IsaIo.h                                |  356 +++
 OvmfPkg/Csm/Include/Protocol/LegacyBios.h                           | 1553 +++++++++
 OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h                   |  755 +++++
 OvmfPkg/Csm/Include/Protocol/LegacyInterrupt.h                      |  122 +
 OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h                          |   88 +
 OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h                     | 1460 +++++++++
 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.h                |  249 ++
 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.h             |   79 +
 OvmfPkg/Csm/LegacyBootManagerLib/InternalLegacyBm.h                 |   60 +
 OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c                          | 3289 ++++++++++++++++++++
 OvmfPkg/Csm/BiosThunk/VideoDxe/ComponentName.c                      |  306 ++
 OvmfPkg/Csm/LegacyBiosDxe/LegacyBbs.c                               |  377 +++
 OvmfPkg/Csm/LegacyBiosDxe/LegacyBda.c                               |   62 +
 OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c                              | 1214 ++++++++
 OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c                       | 2173 +++++++++++++
 OvmfPkg/Csm/LegacyBiosDxe/LegacyCmos.c                              |  117 +
 OvmfPkg/Csm/LegacyBiosDxe/LegacyIde.c                               |  310 ++
 OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c                               | 3083 ++++++++++++++++++
 OvmfPkg/Csm/LegacyBiosDxe/LegacySio.c                               |  477 +++
 OvmfPkg/Csm/LegacyBiosDxe/Thunk.c                                   |  419 +++
 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.c                | 1505 +++++++++
 OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c                         | 1530 +++++++++
 Maintainers.txt                                                     |    2 +
 OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideoDxe.uni                     |   17 +
 OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideoDxeExtra.uni                |   14 +
 OvmfPkg/Csm/LegacyBiosDxe/IA32/InterruptTable.nasm                  |   63 +
 OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosDxe.uni                         |   16 +
 OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosDxeExtra.uni                    |   14 +
 OvmfPkg/Csm/LegacyBiosDxe/X64/InterruptTable.nasm                   |   64 +
 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni           |   20 +
 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiStrings.uni       |   43 +
 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.Vfr           |   67 +
 OvmfPkg/Csm/LegacyBootManagerLib/LegacyBootManagerLib.uni           |   20 +
 58 files changed, 22964 insertions(+), 21 deletions(-)
 create mode 100644 OvmfPkg/Csm/BiosThunk/VideoDxe/VideoDxe.inf
 create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosDxe.inf
 create mode 100644 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf
 create mode 100644 OvmfPkg/Csm/LegacyBootManagerLib/LegacyBootManagerLib.inf
 create mode 100644 OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h
 create mode 100644 OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h
 create mode 100644 OvmfPkg/Csm/Include/Framework/BootScript.h
 create mode 100644 OvmfPkg/Csm/Include/Framework/DxeCis.h
 create mode 100644 OvmfPkg/Csm/Include/Framework/FirmwareVolumeHeader.h
 create mode 100644 OvmfPkg/Csm/Include/Framework/FirmwareVolumeImageFormat.h
 create mode 100644 OvmfPkg/Csm/Include/Framework/FrameworkInternalFormRepresentation.h
 create mode 100644 OvmfPkg/Csm/Include/Framework/Hob.h
 create mode 100644 OvmfPkg/Csm/Include/Framework/StatusCode.h
 create mode 100644 OvmfPkg/Csm/Include/FrameworkDxe.h
 create mode 100644 OvmfPkg/Csm/Include/Guid/LegacyBios.h
 create mode 100644 OvmfPkg/Csm/Include/Guid/LegacyDevOrder.h
 create mode 100644 OvmfPkg/Csm/Include/Protocol/FirmwareVolume.h
 create mode 100644 OvmfPkg/Csm/Include/Protocol/IsaAcpi.h
 create mode 100644 OvmfPkg/Csm/Include/Protocol/IsaIo.h
 create mode 100644 OvmfPkg/Csm/Include/Protocol/LegacyBios.h
 create mode 100644 OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h
 create mode 100644 OvmfPkg/Csm/Include/Protocol/LegacyInterrupt.h
 create mode 100644 OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h
 create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h
 create mode 100644 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.h
 create mode 100644 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.h
 create mode 100644 OvmfPkg/Csm/LegacyBootManagerLib/InternalLegacyBm.h
 create mode 100644 OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c
 create mode 100644 OvmfPkg/Csm/BiosThunk/VideoDxe/ComponentName.c
 create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBbs.c
 create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBda.c
 create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c
 create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c
 create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyCmos.c
 create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyIde.c
 create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c
 create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacySio.c
 create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/Thunk.c
 create mode 100644 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.c
 create mode 100644 OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c
 create mode 100644 OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideoDxe.uni
 create mode 100644 OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideoDxeExtra.uni
 create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/IA32/InterruptTable.nasm
 create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosDxe.uni
 create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosDxeExtra.uni
 create mode 100644 OvmfPkg/Csm/LegacyBiosDxe/X64/InterruptTable.nasm
 create mode 100644 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni
 create mode 100644 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiStrings.uni
 create mode 100644 OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.Vfr
 create mode 100644 OvmfPkg/Csm/LegacyBootManagerLib/LegacyBootManagerLib.uni

-- 
2.12.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41385): https://edk2.groups.io/g/devel/message/41385
Mute This Topic: https://groups.io/mt/31805475/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 00/10] Duplicate required CSM components for OVMF
Posted by Laszlo Ersek 4 years, 11 months ago
On 05/27/19 05:03, Wu, Hao A wrote:
> '''
> Please note that this series will be hold until the edk2-stable201905 is
> created.
> '''
> 
> The series is also available at:
> https://github.com/hwu25/edk2/tree/ovmf_csm_v2
> 
> V2 changes:
> 
> Discussion with David Woodhouse for him to take the reviewer role for the
> duplicated CSM components under OvmfPkg:
> https://edk2.groups.io/g/devel/topic/31682287#40996
> 
> The (new) first patch will update the Maintainers.txt to reflect such
> role.

As noted earlier, I plan to review this series once David is happy with
it (in particular, with the first patch).

And, the following patch sets all depend on this one, directly or
indirectly:

[edk2-devel] [PATCH v1 0/6] Ovmf: Drop IntelFramework[Module]Pkg dependency
[edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules
[edk2-devel] [RFC][PATCH v1 0/3] Remove IntelFramework[Module]Pkg

Of those, I plan to review at least the OvmfPkg one, once the
dependencies are all in place. Please ping me, should I forget.

(Yesterday I made an effort to set up the inter-BZ deps as well.)

Thanks,
Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41505): https://edk2.groups.io/g/devel/message/41505
Mute This Topic: https://groups.io/mt/31805475/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 00/10] Duplicate required CSM components for OVMF
Posted by Wu, Hao A 4 years, 11 months ago
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, May 28, 2019 7:48 PM
> To: devel@edk2.groups.io; Wu, Hao A
> Cc: David Woodhouse; Ni, Ray; Justen, Jordan L; Ard Biesheuvel
> Subject: Re: [edk2-devel] [PATCH v2 00/10] Duplicate required CSM
> components for OVMF
> 
> On 05/27/19 05:03, Wu, Hao A wrote:
> > '''
> > Please note that this series will be hold until the edk2-stable201905 is
> > created.
> > '''
> >
> > The series is also available at:
> > https://github.com/hwu25/edk2/tree/ovmf_csm_v2
> >
> > V2 changes:
> >
> > Discussion with David Woodhouse for him to take the reviewer role for the
> > duplicated CSM components under OvmfPkg:
> > https://edk2.groups.io/g/devel/topic/31682287#40996
> >
> > The (new) first patch will update the Maintainers.txt to reflect such
> > role.
> 
> As noted earlier, I plan to review this series once David is happy with
> it (in particular, with the first patch).

Sure. I will confirm with David.

Hello David,

Does the patch (1st one of the series), which adds you as the reviewer for
CSM components in OvmfPkg in file Maintainer.txt, seem good to you?

> 
> And, the following patch sets all depend on this one, directly or
> indirectly:
> 
> [edk2-devel] [PATCH v1 0/6] Ovmf: Drop IntelFramework[Module]Pkg
> dependency
> [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework
> modules
> [edk2-devel] [RFC][PATCH v1 0/3] Remove IntelFramework[Module]Pkg
> 
> Of those, I plan to review at least the OvmfPkg one, once the
> dependencies are all in place. Please ping me, should I forget.
> 
> (Yesterday I made an effort to set up the inter-BZ deps as well.)

Yes. I noticed that.
Thanks a lot for setting up the dependencies among those BZs.
I will ping you for the OVMF patches once their requirements are met.

Also, do you expect such BZ dependencies setup should be done by the
submitters (if they are aware of such dependencies) when they files a BZ
tracker?

Best Regards,
Hao Wu

> 
> Thanks,
> Laszlo
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41560): https://edk2.groups.io/g/devel/message/41560
Mute This Topic: https://groups.io/mt/31805475/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 00/10] Duplicate required CSM components for OVMF
Posted by Laszlo Ersek 4 years, 11 months ago
On 05/29/19 03:12, Wu, Hao A wrote:

> Also, do you expect such BZ dependencies setup should be done by the
> submitters (if they are aware of such dependencies) when they files a BZ
> tracker?

It's best to capture the BZ dependencies as soon as someone realizes
that such dependencies exist. If the submitter can already determine the
deps, they are most welcome to set them immediately. Otherwise, whoever
triages the bugs, or the affected package maintainers, or just someone
reading the bugs list, can do it.

Thanks,
Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41803): https://edk2.groups.io/g/devel/message/41803
Mute This Topic: https://groups.io/mt/31805475/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 00/10] Duplicate required CSM components for OVMF
Posted by David Woodhouse 4 years, 10 months ago
On Mon, 2019-05-27 at 11:03 +0800, Hao A Wu wrote:
> '''
> Please note that this series will be hold until the edk2-stable201905 is
> created.
> '''
> 
> The series is also available at:
> https://github.com/hwu25/edk2/tree/ovmf_csm_v2
> 
> V2 changes:
> 
> Discussion with David Woodhouse for him to take the reviewer role for the
> duplicated CSM components under OvmfPkg:
> https://edk2.groups.io/g/devel/topic/31682287#40996
> 
> The (new) first patch will update the Maintainers.txt to reflect such
> role.
> 
> 
> V1 history:
> 
> The series will duplicate the CSM components used by the OVMF package from
> IntelFrameworkModulePkg & IntelFrameworkPkg.
> 
> Verification done for the series:
> * Build pass with/without build command option '-D CSM_ENABLE';
> * Boot shell pass with the built images.
> 
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> 
> Hao A Wu (10):
>   Maintainers.txt: Add maintainer for CSM components in OvmfPkg
>   OvmfPkg: Copy the required CSM components from framework packages
>   OvmfPkg/OvmfPkg.dec: Add definitions for CSM-related Guid & Protocol
>   OvmfPkg/OvmfPkg.dec: Add the new include folder for CSM header files
>   OvmfPkg/OvmfPkg.dec: Add PCD definitions used by copied CSM modules
>   OvmfPkg/Csm/VideoDxe: Update to make it build for OVMF
>   OvmfPkg/Csm/LegacyBiosDxe: Update to make it build for OVMF
>   OvmfPkg/Csm/LegacyBootMaintUiLib: Update to make it build for OVMF
>   OvmfPkg/Csm/LegacyBootManagerLib: Update to make it build for OVMF
>   OvmfPkg: Update DSC/FDF files to consume CSM components in OvmfPkg

I'll submit a [PATCH 11/10] in a moment which makes it actually work
again. With that included, the first ten in the series are

Reviewed-by: David Woodhouse <dwmw2@infradead.org>

Thanks.



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42316): https://edk2.groups.io/g/devel/message/42316
Mute This Topic: https://groups.io/mt/31805475/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 00/10] Duplicate required CSM components for OVMF
Posted by Wu, Hao A 4 years, 10 months ago
Thanks all.
Series pushed via commits 0a35997643..b0663641c9.

Best Regards,
Hao Wu

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> David Woodhouse
> Sent: Thursday, June 13, 2019 5:40 AM
> To: Wu, Hao A; devel@edk2.groups.io
> Cc: Ni, Ray; Justen, Jordan L; Laszlo Ersek; Ard Biesheuvel
> Subject: Re: [edk2-devel] [PATCH v2 00/10] Duplicate required CSM
> components for OVMF
> 
> On Mon, 2019-05-27 at 11:03 +0800, Hao A Wu wrote:
> > '''
> > Please note that this series will be hold until the edk2-stable201905 is
> > created.
> > '''
> >
> > The series is also available at:
> > https://github.com/hwu25/edk2/tree/ovmf_csm_v2
> >
> > V2 changes:
> >
> > Discussion with David Woodhouse for him to take the reviewer role for the
> > duplicated CSM components under OvmfPkg:
> > https://edk2.groups.io/g/devel/topic/31682287#40996
> >
> > The (new) first patch will update the Maintainers.txt to reflect such
> > role.
> >
> >
> > V1 history:
> >
> > The series will duplicate the CSM components used by the OVMF package
> from
> > IntelFrameworkModulePkg & IntelFrameworkPkg.
> >
> > Verification done for the series:
> > * Build pass with/without build command option '-D CSM_ENABLE';
> > * Boot shell pass with the built images.
> >
> > Cc: David Woodhouse <dwmw2@infradead.org>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >
> > Hao A Wu (10):
> >   Maintainers.txt: Add maintainer for CSM components in OvmfPkg
> >   OvmfPkg: Copy the required CSM components from framework packages
> >   OvmfPkg/OvmfPkg.dec: Add definitions for CSM-related Guid & Protocol
> >   OvmfPkg/OvmfPkg.dec: Add the new include folder for CSM header files
> >   OvmfPkg/OvmfPkg.dec: Add PCD definitions used by copied CSM
> modules
> >   OvmfPkg/Csm/VideoDxe: Update to make it build for OVMF
> >   OvmfPkg/Csm/LegacyBiosDxe: Update to make it build for OVMF
> >   OvmfPkg/Csm/LegacyBootMaintUiLib: Update to make it build for OVMF
> >   OvmfPkg/Csm/LegacyBootManagerLib: Update to make it build for OVMF
> >   OvmfPkg: Update DSC/FDF files to consume CSM components in OvmfPkg
> 
> I'll submit a [PATCH 11/10] in a moment which makes it actually work
> again. With that included, the first ten in the series are
> 
> Reviewed-by: David Woodhouse <dwmw2@infradead.org>
> 
> Thanks.
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42409): https://edk2.groups.io/g/devel/message/42409
Mute This Topic: https://groups.io/mt/31805475/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-