BaseTools: Add a checking for Sources section in INF file [Part 0/2]

[edk2-devel] [Patch V3 0/2] BaseTools: Add a checking for Sources section in INF file [Part 0/2]

Posted by Christian Rodriguez 4 years, 11 months ago

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1804

In V3: Seperate checker and hashing into individual patches
       Part 1/2: Contains checker.
       Part 2/2: Contains hash feature alignment.
In V2: Enable check for all builds, move conditional to hash invalidation
In the Edk2 INF spec 3.9, it states, All HII Unicode format files
must be listed in [Sources] section. Add a check to see if [Sources]
section lists all the "source" type files of a module. Performance
impact should be minimal with this patch since information is already
being fetched for Makefile purposes. All other information is already
cached in memory. No extra IO time is needed.

Christian Rodriguez (2):
  BaseTools: Add a checking for Sources section in INF file [Part 1/2]
  BaseTools: Add a checking for Sources section in INF file [Part 2/2]

 BaseTools/Source/Python/AutoGen/AutoGen.py   |  6 +-
 BaseTools/Source/Python/AutoGen/GenMake.py   | 44 +++++++++++++
 BaseTools/Source/Python/Common/GlobalData.py |  3 +-
 BaseTools/Source/Python/build/build.py       | 65 ++++++++++++--------
 4 files changed, 91 insertions(+), 27 deletions(-)

--
2.19.1.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41336): https://edk2.groups.io/g/devel/message/41336
Mute This Topic: https://groups.io/mt/31745160/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch V3 0/2] BaseTools: Add a checking for Sources section in INF file [Part 0/2]

Posted by Liming Gao 4 years, 11 months ago

Christian:
  I have two comments on the commit messages. 

1.  List the change version only in the cover letter. There is no V2, V3 in patch commit message. 
2.  Update patch commit message for this patch change. Don't use Part1, Part2. 

Thanks
Liming
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Christian Rodriguez
> Sent: Friday, May 24, 2019 10:40 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [Patch V3 0/2] BaseTools: Add a checking for Sources section in INF file [Part 0/2]
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1804
> 
> In V3: Seperate checker and hashing into individual patches
>        Part 1/2: Contains checker.
>        Part 2/2: Contains hash feature alignment.
> In V2: Enable check for all builds, move conditional to hash invalidation
> In the Edk2 INF spec 3.9, it states, All HII Unicode format files
> must be listed in [Sources] section. Add a check to see if [Sources]
> section lists all the "source" type files of a module. Performance
> impact should be minimal with this patch since information is already
> being fetched for Makefile purposes. All other information is already
> cached in memory. No extra IO time is needed.
> 
> Christian Rodriguez (2):
>   BaseTools: Add a checking for Sources section in INF file [Part 1/2]
>   BaseTools: Add a checking for Sources section in INF file [Part 2/2]
> 
>  BaseTools/Source/Python/AutoGen/AutoGen.py   |  6 +-
>  BaseTools/Source/Python/AutoGen/GenMake.py   | 44 +++++++++++++
>  BaseTools/Source/Python/Common/GlobalData.py |  3 +-
>  BaseTools/Source/Python/build/build.py       | 65 ++++++++++++--------
>  4 files changed, 91 insertions(+), 27 deletions(-)
> 
> --
> 2.19.1.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41617): https://edk2.groups.io/g/devel/message/41617
Mute This Topic: https://groups.io/mt/31745160/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-