[v1] BaseTools: Remove './SecMain' from 'run' target

[edk2-devel] [Patch 2] BaseTools: Remove './SecMain' from 'run' target

Posted by Bob Feng 4 years, 11 months ago

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1561

This patch is related to commit 9ca1f1
It's to remove the second .SecMain call from 'run' target.

Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
---
 BaseTools/Source/Python/build/build.py | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py
index a8b4ce7375..80ceb98310 100644
--- a/BaseTools/Source/Python/build/build.py
+++ b/BaseTools/Source/Python/build/build.py
@@ -1358,14 +1358,10 @@ class Build():
                 EdkLogger.error("build", COMMAND_FAILURE)
             return True
 
         # run
         if Target == 'run':
-            RunDir = os.path.normpath(os.path.join(AutoGenObject.BuildDir, GlobalData.gGlobalDefines['ARCH']))
-            Command = '.\SecMain'
-            os.chdir(RunDir)
-            LaunchCommand(Command, RunDir)
             return True
 
         # build library
         if Target == 'libraries':
             pass
-- 
2.20.1.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41272): https://edk2.groups.io/g/devel/message/41272
Mute This Topic: https://groups.io/mt/31729074/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch 2] BaseTools: Remove './SecMain' from 'run' target

Posted by Liming Gao 4 years, 11 months ago

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Feng, Bob C
> Sent: Thursday, May 23, 2019 5:07 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [Patch 2] BaseTools: Remove './SecMain' from 'run' target
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1561
> 
> This patch is related to commit 9ca1f1
> It's to remove the second .SecMain call from 'run' target.
> 
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  BaseTools/Source/Python/build/build.py | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py
> index a8b4ce7375..80ceb98310 100644
> --- a/BaseTools/Source/Python/build/build.py
> +++ b/BaseTools/Source/Python/build/build.py
> @@ -1358,14 +1358,10 @@ class Build():
>                  EdkLogger.error("build", COMMAND_FAILURE)
>              return True
> 
>          # run
>          if Target == 'run':
> -            RunDir = os.path.normpath(os.path.join(AutoGenObject.BuildDir, GlobalData.gGlobalDefines['ARCH']))
> -            Command = '.\SecMain'
> -            os.chdir(RunDir)
> -            LaunchCommand(Command, RunDir)
>              return True
> 
>          # build library
>          if Target == 'libraries':
>              pass
> --
> 2.20.1.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41279): https://edk2.groups.io/g/devel/message/41279
Mute This Topic: https://groups.io/mt/31729074/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch 2] BaseTools: Remove './SecMain' from 'run' target

Posted by Michael D Kinney 4 years, 11 months ago

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io
> [mailto:devel@edk2.groups.io] On Behalf Of Bob Feng
> Sent: Thursday, May 23, 2019 2:07 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [edk2-devel] [Patch 2] BaseTools: Remove
> './SecMain' from 'run' target
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1561
> 
> This patch is related to commit 9ca1f1
> It's to remove the second .SecMain call from 'run'
> target.
> 
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  BaseTools/Source/Python/build/build.py | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/BaseTools/Source/Python/build/build.py
> b/BaseTools/Source/Python/build/build.py
> index a8b4ce7375..80ceb98310 100644
> --- a/BaseTools/Source/Python/build/build.py
> +++ b/BaseTools/Source/Python/build/build.py
> @@ -1358,14 +1358,10 @@ class Build():
>                  EdkLogger.error("build",
> COMMAND_FAILURE)
>              return True
> 
>          # run
>          if Target == 'run':
> -            RunDir =
> os.path.normpath(os.path.join(AutoGenObject.BuildDir,
> GlobalData.gGlobalDefines['ARCH']))
> -            Command = '.\SecMain'
> -            os.chdir(RunDir)
> -            LaunchCommand(Command, RunDir)
>              return True
> 
>          # build library
>          if Target == 'libraries':
>              pass
> --
> 2.20.1.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41282): https://edk2.groups.io/g/devel/message/41282
Mute This Topic: https://groups.io/mt/31729074/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-