EDK2: Remove double \r\r

[edk2-devel] [PATCH v3 1/3] SecurityPkg: Remove double \r

Posted by Joe Richey via Groups.Io 6 years, 9 months ago

Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian Wang <jian.j.wang@intel.com>
Signed-off-by: Joe Richey <joerichey@google.com>
---
 SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c
index f101ca1c2001..18b65da756d6 100644
--- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c
+++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c
@@ -1229,7 +1229,7 @@ EFI_STATUS
 OpalDiskUpdateOwnerShip (
   OPAL_DISK        *OpalDisk
   )
-{

+{
   OPAL_SESSION  Session;
 
   if (OpalDisk->MsidLength == 0) {
@@ -1245,7 +1245,7 @@ OpalDiskUpdateOwnerShip (
   Session.MediaId = OpalDisk->MediaId;
   Session.OpalBaseComId = OpalDisk->OpalBaseComId;
 
-  OpalDisk->Owner = OpalUtilDetermineOwnership(&Session, OpalDisk->Msid, OpalDisk->MsidLength);

+  OpalDisk->Owner = OpalUtilDetermineOwnership(&Session, OpalDisk->Msid, OpalDisk->MsidLength);
   return EFI_SUCCESS;
 }
 
-- 
2.21.0.1020.gf2820cf01a-goog


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40429): https://edk2.groups.io/g/devel/message/40429
Mute This Topic: https://groups.io/mt/31577292/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3 1/3] SecurityPkg: Remove double \r

Posted by Zhang, Chao B 6 years, 9 months ago

Reviewed-by : Chao Zhang <chao.b.zhang@intel.com>

-----Original Message-----
From: Joe Richey [mailto:joerichey@google.com] 
Sent: Friday, May 10, 2019 5:37 PM
To: devel@edk2.groups.io
Cc: Zhang, Chao B <chao.b.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>
Subject: [PATCH v3 1/3] SecurityPkg: Remove double \r

Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian Wang <jian.j.wang@intel.com>
Signed-off-by: Joe Richey <joerichey@google.com>
---
 SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c
index f101ca1c2001..18b65da756d6 100644
--- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c
+++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c
@@ -1229,7 +1229,7 @@ EFI_STATUS
 OpalDiskUpdateOwnerShip (
   OPAL_DISK        *OpalDisk
   )
-{

+{
   OPAL_SESSION  Session;
 
   if (OpalDisk->MsidLength == 0) {
@@ -1245,7 +1245,7 @@ OpalDiskUpdateOwnerShip (
   Session.MediaId = OpalDisk->MediaId;
   Session.OpalBaseComId = OpalDisk->OpalBaseComId;
 
-  OpalDisk->Owner = OpalUtilDetermineOwnership(&Session, OpalDisk->Msid, OpalDisk->MsidLength);

+  OpalDisk->Owner = OpalUtilDetermineOwnership(&Session, OpalDisk->Msid, OpalDisk->MsidLength);
   return EFI_SUCCESS;
 }
 
-- 
2.21.0.1020.gf2820cf01a-goog


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40438): https://edk2.groups.io/g/devel/message/40438
Mute This Topic: https://groups.io/mt/31577292/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3 1/3] SecurityPkg: Remove double \r

Posted by Wang, Jian J 6 years, 9 months ago

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

> -----Original Message-----
> From: Joe Richey [mailto:joerichey@google.com]
> Sent: Friday, May 10, 2019 5:37 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Chao B <chao.b.zhang@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>
> Subject: [PATCH v3 1/3] SecurityPkg: Remove double \r
> 
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian Wang <jian.j.wang@intel.com>
> Signed-off-by: Joe Richey <joerichey@google.com>
> ---
>  SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c
> b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c
> index f101ca1c2001..18b65da756d6 100644
> --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c
> +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c
> @@ -1229,7 +1229,7 @@ EFI_STATUS
>  OpalDiskUpdateOwnerShip (
>    OPAL_DISK        *OpalDisk
>    )
> -{
> 
> +{
>    OPAL_SESSION  Session;
> 
>    if (OpalDisk->MsidLength == 0) {
> @@ -1245,7 +1245,7 @@ OpalDiskUpdateOwnerShip (
>    Session.MediaId = OpalDisk->MediaId;
>    Session.OpalBaseComId = OpalDisk->OpalBaseComId;
> 
> -  OpalDisk->Owner = OpalUtilDetermineOwnership(&Session, OpalDisk->Msid,
> OpalDisk->MsidLength);
> 
> +  OpalDisk->Owner = OpalUtilDetermineOwnership(&Session, OpalDisk->Msid,
> OpalDisk->MsidLength);
>    return EFI_SUCCESS;
>  }
> 
> --
> 2.21.0.1020.gf2820cf01a-goog


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40423): https://edk2.groups.io/g/devel/message/40423
Mute This Topic: https://groups.io/mt/31575545/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-