[edk2-devel] [Patch 03/16] Vlv2TbltDevicePkg/AcpiPlatform: Add variable protocols to depex

Michael D Kinney posted 16 patches 6 years, 9 months ago
[edk2-devel] [Patch 03/16] Vlv2TbltDevicePkg/AcpiPlatform: Add variable protocols to depex
Posted by Michael D Kinney 6 years, 9 months ago
Add the arch protocols gEfiVariableArchProtocolGuid and
gEfiVariableWriteArchProtocolGuid to the dependency expression
for the AcpiPlatform module to guarantee that the variables
that AcpiPlatform depends upon are set before they are used by
this module.

Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf b/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf
index 8422985764..c59920db03 100644
--- a/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf
+++ b/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf
@@ -1,10 +1,12 @@
 #
 #
-# Copyright (c)  1999  - 2018, Intel Corporation. All rights reserved
-#                                                                                  

+# Copyright (c)  1999  - 2019, Intel Corporation. All rights reserved
+#
+
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 
-#                                                                                  

+#
+
 #
 #
 #  Module Name:
@@ -79,6 +81,8 @@ [Pcd]
   gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile
 
 [Depex]
+  gEfiVariableArchProtocolGuid        AND
+  gEfiVariableWriteArchProtocolGuid   AND
   gEfiAcpiSupportProtocolGuid AND
   gEfiMpServiceProtocolGuid AND
   gEfiCpuIoProtocolGuid
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40249): https://edk2.groups.io/g/devel/message/40249
Mute This Topic: https://groups.io/mt/31551772/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch 03/16] Vlv2TbltDevicePkg/AcpiPlatform: Add variable protocols to depex
Posted by Sun, Zailiang 6 years, 9 months ago
Reviewed-by: Zailiang Sun <zailiang.sun@intel.com>

> -----Original Message-----
> From: Kinney, Michael D
> Sent: Thursday, May 9, 2019 12:31 PM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>
> Subject: [Patch 03/16] Vlv2TbltDevicePkg/AcpiPlatform: Add variable
> protocols to depex
> 
> Add the arch protocols gEfiVariableArchProtocolGuid and
> gEfiVariableWriteArchProtocolGuid to the dependency expression for the
> AcpiPlatform module to guarantee that the variables that AcpiPlatform
> depends upon are set before they are used by this module.
> 
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf
> b/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf
> index 8422985764..c59920db03 100644
> --- a/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf
> +++ b/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf
> @@ -1,10 +1,12 @@
>  #
>  #
> -# Copyright (c)  1999  - 2018, Intel Corporation. All rights reserved
> -#
> 
> +# Copyright (c)  1999  - 2019, Intel Corporation. All rights reserved #
> +
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> -#
> 
> +#
> +
>  #
>  #
>  #  Module Name:
> @@ -79,6 +81,8 @@ [Pcd]
>    gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile
> 
>  [Depex]
> +  gEfiVariableArchProtocolGuid        AND
> +  gEfiVariableWriteArchProtocolGuid   AND
>    gEfiAcpiSupportProtocolGuid AND
>    gEfiMpServiceProtocolGuid AND
>    gEfiCpuIoProtocolGuid
> --
> 2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40289): https://edk2.groups.io/g/devel/message/40289
Mute This Topic: https://groups.io/mt/31551772/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch 03/16] Vlv2TbltDevicePkg/AcpiPlatform: Add variable protocols to depex
Posted by Qian, Yi 6 years, 9 months ago
Reviewed by Qian, Yi <yi.qian@intel.com>

Thanks
QianYi

-----Original Message-----
From: Kinney, Michael D 
Sent: Thursday, May 9, 2019 12:31 PM
To: devel@edk2.groups.io
Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>
Subject: [Patch 03/16] Vlv2TbltDevicePkg/AcpiPlatform: Add variable protocols to depex

Add the arch protocols gEfiVariableArchProtocolGuid and gEfiVariableWriteArchProtocolGuid to the dependency expression for the AcpiPlatform module to guarantee that the variables that AcpiPlatform depends upon are set before they are used by this module.

Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf b/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf
index 8422985764..c59920db03 100644
--- a/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf
+++ b/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf
@@ -1,10 +1,12 @@
 #
 #
-# Copyright (c)  1999  - 2018, Intel Corporation. All rights reserved
-#                                                                        

+# Copyright (c)  1999  - 2019, Intel Corporation. All rights reserved #
+
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 
-#                                                                        

+#
+
 #
 #
 #  Module Name:
@@ -79,6 +81,8 @@ [Pcd]
   gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile
 
 [Depex]
+  gEfiVariableArchProtocolGuid        AND
+  gEfiVariableWriteArchProtocolGuid   AND
   gEfiAcpiSupportProtocolGuid AND
   gEfiMpServiceProtocolGuid AND
   gEfiCpuIoProtocolGuid
--
2.21.0.windows.1



-- 
Qian Yi

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40338): https://edk2.groups.io/g/devel/message/40338
Mute This Topic: https://groups.io/mt/31551772/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-