[edk2-devel] [Patch] BaseTools: Fix the issue that build report missing Module Size

Bob Feng posted 1 patch 4 years, 11 months ago
Failed in applying to current master (apply log)
BaseTools/Source/Python/build/BuildReport.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[edk2-devel] [Patch] BaseTools: Fix the issue that build report missing Module Size
Posted by Bob Feng 4 years, 11 months ago
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1786

commit b1e27d changed GENFW output folder from DEBUG to OUTPUT,
but that commit missed updating the buildreport.py for FwReportFileName.

This patch is going to fix this issue.

Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
 BaseTools/Source/Python/build/BuildReport.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Source/Python/build/BuildReport.py
index 942631c879..a3eb3b2383 100644
--- a/BaseTools/Source/Python/build/BuildReport.py
+++ b/BaseTools/Source/Python/build/BuildReport.py
@@ -618,11 +618,11 @@ class ModuleReport(object):
     # @param ReportType             The kind of report items in the final report file
     #
     def GenerateReport(self, File, GlobalPcdReport, GlobalPredictionReport, GlobalDepexParser, ReportType):
         FileWrite(File, gSectionStart)
 
-        FwReportFileName = os.path.join(self._BuildDir, "DEBUG", self.ModuleName + ".txt")
+        FwReportFileName = os.path.join(self._BuildDir, "OUTPUT", self.ModuleName + ".txt")
         if os.path.isfile(FwReportFileName):
             try:
                 FileContents = open(FwReportFileName).read()
                 Match = gModuleSizePattern.search(FileContents)
                 if Match:
-- 
2.20.1.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40190): https://edk2.groups.io/g/devel/message/40190
Mute This Topic: https://groups.io/mt/31541596/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch] BaseTools: Fix the issue that build report missing Module Size
Posted by Liming Gao 4 years, 11 months ago
Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Feng, Bob C
> Sent: Wednesday, May 8, 2019 5:47 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [Patch] BaseTools: Fix the issue that build report missing Module Size
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1786
> 
> commit b1e27d changed GENFW output folder from DEBUG to OUTPUT,
> but that commit missed updating the buildreport.py for FwReportFileName.
> 
> This patch is going to fix this issue.
> 
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
>  BaseTools/Source/Python/build/BuildReport.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Source/Python/build/BuildReport.py
> index 942631c879..a3eb3b2383 100644
> --- a/BaseTools/Source/Python/build/BuildReport.py
> +++ b/BaseTools/Source/Python/build/BuildReport.py
> @@ -618,11 +618,11 @@ class ModuleReport(object):
>      # @param ReportType             The kind of report items in the final report file
>      #
>      def GenerateReport(self, File, GlobalPcdReport, GlobalPredictionReport, GlobalDepexParser, ReportType):
>          FileWrite(File, gSectionStart)
> 
> -        FwReportFileName = os.path.join(self._BuildDir, "DEBUG", self.ModuleName + ".txt")
> +        FwReportFileName = os.path.join(self._BuildDir, "OUTPUT", self.ModuleName + ".txt")
>          if os.path.isfile(FwReportFileName):
>              try:
>                  FileContents = open(FwReportFileName).read()
>                  Match = gModuleSizePattern.search(FileContents)
>                  if Match:
> --
> 2.20.1.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40223): https://edk2.groups.io/g/devel/message/40223
Mute This Topic: https://groups.io/mt/31541596/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-