1. Patchew
  2. EDK2
  3. [edk2-devel] [Patch v2 0/3] SecurityPkg/Opal: Change BlockSid policy
  4. View patch

[edk2-devel] [Patch v2 1/3] SecurityPkg/SecurityPkg.dec: Change default value.

Dong, Eric posted 3 patches 6 years, 9 months ago
[edk2-devel] [Patch v2 1/3] SecurityPkg/SecurityPkg.dec: Change default value.
Posted by Dong, Eric 6 years, 9 months ago 
https://bugzilla.tianocore.org/show_bug.cgi?id=1782

Change BlockSID default policy, default enable BlockSid.

Signed-off-by: Eric Dong <eric.dong@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
---
 SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h | 3 ++-
 SecurityPkg/SecurityPkg.dec                           | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
index d9eee7f3e8..8da3deaf86 100644
--- a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
+++ b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
@@ -51,7 +51,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 // Default value
 //
 #define TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_DEFAULT (TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_ENABLE_BLOCK_SID | \
-                                                   TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_DISABLE_BLOCK_SID)
+                                                   TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_DISABLE_BLOCK_SID |\
+                                                   TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_ENABLE_BLOCK_SID)
 
 /**
   Check and execute the pending TPM request.
diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec
index 6e4c4c3a02..3314f1854b 100644
--- a/SecurityPkg/SecurityPkg.dec
+++ b/SecurityPkg/SecurityPkg.dec
@@ -410,7 +410,7 @@
   # PCD can be configured for different settings in different scenarios
   # Default setting is TCG2_BIOS_TPM_MANAGEMENT_FLAG_DEFAULT | TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_DEFAULT
   # @Prompt Initial setting of TCG2 Persistent Firmware Management Flags
-  gEfiSecurityPkgTokenSpaceGuid.PcdTcg2PhysicalPresenceFlags|0x300E2|UINT32|0x0001001B
+  gEfiSecurityPkgTokenSpaceGuid.PcdTcg2PhysicalPresenceFlags|0x700E2|UINT32|0x0001001B
 
   ## Indicate current TPM2 Interrupt Number reported by _CRS control method.<BR><BR>
   # TPM2 Interrupt feature is disabled If the pcd is set to 0.<BR>
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40167): https://edk2.groups.io/g/devel/message/40167
Mute This Topic: https://groups.io/mt/31539610/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch v2 1/3] SecurityPkg/SecurityPkg.dec: Change default value.
Posted by Wu, Hao A 6 years, 9 months ago 
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Dong,
> Eric
> Sent: Wednesday, May 08, 2019 11:02 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A
> Subject: [edk2-devel] [Patch v2 1/3] SecurityPkg/SecurityPkg.dec: Change
> default value.

Just one minor comment, how about changing the title to:
SecurityPkg/SecurityPkg.dec: Change BlockSID default policy

Other than that, the patch is good to me:
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu

> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=1782
> 
> Change BlockSID default policy, default enable BlockSid.
> 
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> ---
>  SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h | 3 ++-
>  SecurityPkg/SecurityPkg.dec                           | 2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> index d9eee7f3e8..8da3deaf86 100644
> --- a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> +++ b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> @@ -51,7 +51,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>  // Default value
>  //
>  #define TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_DEFAULT
> (TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_ENABLE_BL
> OCK_SID | \
> -
> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_DISABLE_BL
> OCK_SID)
> +
> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_DISABLE_BL
> OCK_SID |\
> +
> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_ENABLE_BLOCK_SID)
> 
>  /**
>    Check and execute the pending TPM request.
> diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec
> index 6e4c4c3a02..3314f1854b 100644
> --- a/SecurityPkg/SecurityPkg.dec
> +++ b/SecurityPkg/SecurityPkg.dec
> @@ -410,7 +410,7 @@
>    # PCD can be configured for different settings in different scenarios
>    # Default setting is TCG2_BIOS_TPM_MANAGEMENT_FLAG_DEFAULT |
> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_DEFAULT
>    # @Prompt Initial setting of TCG2 Persistent Firmware Management Flags
> -
> gEfiSecurityPkgTokenSpaceGuid.PcdTcg2PhysicalPresenceFlags|0x300E2|UINT3
> 2|0x0001001B
> +
> gEfiSecurityPkgTokenSpaceGuid.PcdTcg2PhysicalPresenceFlags|0x700E2|UINT3
> 2|0x0001001B
> 
>    ## Indicate current TPM2 Interrupt Number reported by _CRS control
> method.<BR><BR>
>    # TPM2 Interrupt feature is disabled If the pcd is set to 0.<BR>
> --
> 2.21.0.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40226): https://edk2.groups.io/g/devel/message/40226
Mute This Topic: https://groups.io/mt/31539610/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch v2 1/3] SecurityPkg/SecurityPkg.dec: Change default value.
Posted by Laszlo Ersek 6 years, 9 months ago 
On 05/09/19 05:03, Wu, Hao A wrote:
>> -----Original Message-----
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Dong,
>> Eric
>> Sent: Wednesday, May 08, 2019 11:02 AM
>> To: devel@edk2.groups.io
>> Cc: Wu, Hao A
>> Subject: [edk2-devel] [Patch v2 1/3] SecurityPkg/SecurityPkg.dec: Change
>> default value.
> 
> Just one minor comment, how about changing the title to:
> SecurityPkg/SecurityPkg.dec: Change BlockSID default policy

That's an improvement too, thanks.
Laszlo

> 
> Other than that, the patch is good to me:
> Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
> 
> Best Regards,
> Hao Wu
> 
>>
>> https://bugzilla.tianocore.org/show_bug.cgi?id=1782
>>
>> Change BlockSID default policy, default enable BlockSid.
>>
>> Signed-off-by: Eric Dong <eric.dong@intel.com>
>> Cc: Hao Wu <hao.a.wu@intel.com>
>> ---
>>  SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h | 3 ++-
>>  SecurityPkg/SecurityPkg.dec                           | 2 +-
>>  2 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
>> b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
>> index d9eee7f3e8..8da3deaf86 100644
>> --- a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
>> +++ b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
>> @@ -51,7 +51,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>>  // Default value
>>  //
>>  #define TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_DEFAULT
>> (TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_ENABLE_BL
>> OCK_SID | \
>> -
>> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_DISABLE_BL
>> OCK_SID)
>> +
>> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_DISABLE_BL
>> OCK_SID |\
>> +
>> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_ENABLE_BLOCK_SID)
>>
>>  /**
>>    Check and execute the pending TPM request.
>> diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec
>> index 6e4c4c3a02..3314f1854b 100644
>> --- a/SecurityPkg/SecurityPkg.dec
>> +++ b/SecurityPkg/SecurityPkg.dec
>> @@ -410,7 +410,7 @@
>>    # PCD can be configured for different settings in different scenarios
>>    # Default setting is TCG2_BIOS_TPM_MANAGEMENT_FLAG_DEFAULT |
>> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_DEFAULT
>>    # @Prompt Initial setting of TCG2 Persistent Firmware Management Flags
>> -
>> gEfiSecurityPkgTokenSpaceGuid.PcdTcg2PhysicalPresenceFlags|0x300E2|UINT3
>> 2|0x0001001B
>> +
>> gEfiSecurityPkgTokenSpaceGuid.PcdTcg2PhysicalPresenceFlags|0x700E2|UINT3
>> 2|0x0001001B
>>
>>    ## Indicate current TPM2 Interrupt Number reported by _CRS control
>> method.<BR><BR>
>>    # TPM2 Interrupt feature is disabled If the pcd is set to 0.<BR>
>> --
>> 2.21.0.windows.1
>>
>>
>>
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40330): https://edk2.groups.io/g/devel/message/40330
Mute This Topic: https://groups.io/mt/31539610/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch v2 1/3] SecurityPkg/SecurityPkg.dec: Change default value.
Posted by Laszlo Ersek 6 years, 9 months ago 
On 05/08/19 05:01, Dong, Eric wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1782
> 
> Change BlockSID default policy, default enable BlockSid.
> 
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> ---
>  SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h | 3 ++-
>  SecurityPkg/SecurityPkg.dec                           | 2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)

Please change the subject line as follows:

----
SecurityPkg: enable BlockSID in PcdTcg2PhysicalPresenceFlags DEC default
----

no need to resubmit just for this, just pls update the patch before you
push it.

Thanks
Laszlo

> diff --git a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> index d9eee7f3e8..8da3deaf86 100644
> --- a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> +++ b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> @@ -51,7 +51,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>  // Default value
>  //
>  #define TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_DEFAULT (TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_ENABLE_BLOCK_SID | \
> -                                                   TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_DISABLE_BLOCK_SID)
> +                                                   TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_DISABLE_BLOCK_SID |\
> +                                                   TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_ENABLE_BLOCK_SID)
>  
>  /**
>    Check and execute the pending TPM request.
> diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec
> index 6e4c4c3a02..3314f1854b 100644
> --- a/SecurityPkg/SecurityPkg.dec
> +++ b/SecurityPkg/SecurityPkg.dec
> @@ -410,7 +410,7 @@
>    # PCD can be configured for different settings in different scenarios
>    # Default setting is TCG2_BIOS_TPM_MANAGEMENT_FLAG_DEFAULT | TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_DEFAULT
>    # @Prompt Initial setting of TCG2 Persistent Firmware Management Flags
> -  gEfiSecurityPkgTokenSpaceGuid.PcdTcg2PhysicalPresenceFlags|0x300E2|UINT32|0x0001001B
> +  gEfiSecurityPkgTokenSpaceGuid.PcdTcg2PhysicalPresenceFlags|0x700E2|UINT32|0x0001001B
>  
>    ## Indicate current TPM2 Interrupt Number reported by _CRS control method.<BR><BR>
>    # TPM2 Interrupt feature is disabled If the pcd is set to 0.<BR>
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40313): https://edk2.groups.io/g/devel/message/40313
Mute This Topic: https://groups.io/mt/31539610/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch v2 1/3] SecurityPkg/SecurityPkg.dec: Change default value.
Posted by Yao, Jiewen 6 years, 9 months ago 
Hey
When I read https://bugzilla.tianocore.org/show_bug.cgi?id=1782, it says: "Current opal driver send blockSid command at ReadyToBoot event, it should been update to EndOfDxe point. Submit this bz to update the code."

But this patch is to update the default value.

I am very confused.

May I know what is the relationship between this patch and Bugzilla?
Why we need change the default value?


Thank you
Yao Jiewen


> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Thursday, May 9, 2019 2:53 AM
> To: devel@edk2.groups.io; Dong, Eric <eric.dong@intel.com>
> Cc: Wu, Hao A <hao.a.wu@intel.com>
> Subject: Re: [edk2-devel] [Patch v2 1/3] SecurityPkg/SecurityPkg.dec:
> Change default value.
> 
> On 05/08/19 05:01, Dong, Eric wrote:
> > https://bugzilla.tianocore.org/show_bug.cgi?id=1782
> >
> > Change BlockSID default policy, default enable BlockSid.
> >
> > Signed-off-by: Eric Dong <eric.dong@intel.com>
> > Cc: Hao Wu <hao.a.wu@intel.com>
> > ---
> >  SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h | 3 ++-
> >  SecurityPkg/SecurityPkg.dec                           | 2 +-
> >  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> Please change the subject line as follows:
> 
> ----
> SecurityPkg: enable BlockSID in PcdTcg2PhysicalPresenceFlags DEC default
> ----
> 
> no need to resubmit just for this, just pls update the patch before you
> push it.
> 
> Thanks
> Laszlo
> 
> > diff --git a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> > index d9eee7f3e8..8da3deaf86 100644
> > --- a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> > +++ b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> > @@ -51,7 +51,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> >  // Default value
> >  //
> >  #define TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_DEFAULT
> (TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_ENABLE
> _BLOCK_SID | \
> > -
> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_DISABLE_
> BLOCK_SID)
> > +
> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_DISABLE_
> BLOCK_SID |\
> > +
> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_ENABLE_BLOCK_SID)
> >
> >  /**
> >    Check and execute the pending TPM request.
> > diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec
> > index 6e4c4c3a02..3314f1854b 100644
> > --- a/SecurityPkg/SecurityPkg.dec
> > +++ b/SecurityPkg/SecurityPkg.dec
> > @@ -410,7 +410,7 @@
> >    # PCD can be configured for different settings in different scenarios
> >    # Default setting is TCG2_BIOS_TPM_MANAGEMENT_FLAG_DEFAULT
> | TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_DEFAULT
> >    # @Prompt Initial setting of TCG2 Persistent Firmware Management
> Flags
> > -
> gEfiSecurityPkgTokenSpaceGuid.PcdTcg2PhysicalPresenceFlags|0x300E2|UI
> NT32|0x0001001B
> > +
> gEfiSecurityPkgTokenSpaceGuid.PcdTcg2PhysicalPresenceFlags|0x700E2|UI
> NT32|0x0001001B
> >
> >    ## Indicate current TPM2 Interrupt Number reported by _CRS control
> method.<BR><BR>
> >    # TPM2 Interrupt feature is disabled If the pcd is set to 0.<BR>
> >
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40336): https://edk2.groups.io/g/devel/message/40336
Mute This Topic: https://groups.io/mt/31539610/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch v2 1/3] SecurityPkg/SecurityPkg.dec: Change default value.
Posted by Laszlo Ersek 6 years, 9 months ago 
Hi Jiewen,

On 05/09/19 14:41, Yao, Jiewen wrote:
> Hey
> When I read https://bugzilla.tianocore.org/show_bug.cgi?id=1782, it says: "Current opal driver send blockSid command at ReadyToBoot event, it should been update to EndOfDxe point. Submit this bz to update the code."
> 
> But this patch is to update the default value.
> 
> I am very confused.
> 
> May I know what is the relationship between this patch and Bugzilla?
> Why we need change the default value?

I have absolutely no clue -- I only commented because I prefer a patch
subject to state *specifically* what a patch does. "Change default
value" was too vague. (When I commented I hadn't seen Hao Wu's similar
feedback just yet.)

Now, *why* this change is necessary, is totally over my head; I didn't
even begin to think about that.

Thanks
Laszlo

> 
> 
> Thank you
> Yao Jiewen
> 
> 
>> -----Original Message-----
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>> Laszlo Ersek
>> Sent: Thursday, May 9, 2019 2:53 AM
>> To: devel@edk2.groups.io; Dong, Eric <eric.dong@intel.com>
>> Cc: Wu, Hao A <hao.a.wu@intel.com>
>> Subject: Re: [edk2-devel] [Patch v2 1/3] SecurityPkg/SecurityPkg.dec:
>> Change default value.
>>
>> On 05/08/19 05:01, Dong, Eric wrote:
>>> https://bugzilla.tianocore.org/show_bug.cgi?id=1782
>>>
>>> Change BlockSID default policy, default enable BlockSid.
>>>
>>> Signed-off-by: Eric Dong <eric.dong@intel.com>
>>> Cc: Hao Wu <hao.a.wu@intel.com>
>>> ---
>>>  SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h | 3 ++-
>>>  SecurityPkg/SecurityPkg.dec                           | 2 +-
>>>  2 files changed, 3 insertions(+), 2 deletions(-)
>>
>> Please change the subject line as follows:
>>
>> ----
>> SecurityPkg: enable BlockSID in PcdTcg2PhysicalPresenceFlags DEC default
>> ----
>>
>> no need to resubmit just for this, just pls update the patch before you
>> push it.
>>
>> Thanks
>> Laszlo
>>
>>> diff --git a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
>> b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
>>> index d9eee7f3e8..8da3deaf86 100644
>>> --- a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
>>> +++ b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
>>> @@ -51,7 +51,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>>>  // Default value
>>>  //
>>>  #define TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_DEFAULT
>> (TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_ENABLE
>> _BLOCK_SID | \
>>> -
>> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_DISABLE_
>> BLOCK_SID)
>>> +
>> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_DISABLE_
>> BLOCK_SID |\
>>> +
>> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_ENABLE_BLOCK_SID)
>>>
>>>  /**
>>>    Check and execute the pending TPM request.
>>> diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec
>>> index 6e4c4c3a02..3314f1854b 100644
>>> --- a/SecurityPkg/SecurityPkg.dec
>>> +++ b/SecurityPkg/SecurityPkg.dec
>>> @@ -410,7 +410,7 @@
>>>    # PCD can be configured for different settings in different scenarios
>>>    # Default setting is TCG2_BIOS_TPM_MANAGEMENT_FLAG_DEFAULT
>> | TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_DEFAULT
>>>    # @Prompt Initial setting of TCG2 Persistent Firmware Management
>> Flags
>>> -
>> gEfiSecurityPkgTokenSpaceGuid.PcdTcg2PhysicalPresenceFlags|0x300E2|UI
>> NT32|0x0001001B
>>> +
>> gEfiSecurityPkgTokenSpaceGuid.PcdTcg2PhysicalPresenceFlags|0x700E2|UI
>> NT32|0x0001001B
>>>
>>>    ## Indicate current TPM2 Interrupt Number reported by _CRS control
>> method.<BR><BR>
>>>    # TPM2 Interrupt feature is disabled If the pcd is set to 0.<BR>
>>>
>>
>>
>> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40376): https://edk2.groups.io/g/devel/message/40376
Mute This Topic: https://groups.io/mt/31539610/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch v2 1/3] SecurityPkg/SecurityPkg.dec: Change default value.
Posted by Yao, Jiewen 6 years, 9 months ago 
Thanks Laszlo.
Sorry, I do not mean to ask you.
The question is for the original patch submitter.
I just reply the last email in my mail box.

I agree with you that the title should describe *what* code does.
At same time, I prefer to see the commit message on *why* we need do the change.

Thank you
Yao Jiewen


> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Thursday, May 9, 2019 2:27 PM
> To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io; Dong, Eric
> <eric.dong@intel.com>
> Cc: Wu, Hao A <hao.a.wu@intel.com>
> Subject: Re: [edk2-devel] [Patch v2 1/3] SecurityPkg/SecurityPkg.dec:
> Change default value.
> 
> Hi Jiewen,
> 
> On 05/09/19 14:41, Yao, Jiewen wrote:
> > Hey
> > When I read https://bugzilla.tianocore.org/show_bug.cgi?id=1782, it says:
> "Current opal driver send blockSid command at ReadyToBoot event, it
> should been update to EndOfDxe point. Submit this bz to update the code."
> >
> > But this patch is to update the default value.
> >
> > I am very confused.
> >
> > May I know what is the relationship between this patch and Bugzilla?
> > Why we need change the default value?
> 
> I have absolutely no clue -- I only commented because I prefer a patch
> subject to state *specifically* what a patch does. "Change default
> value" was too vague. (When I commented I hadn't seen Hao Wu's similar
> feedback just yet.)
> 
> Now, *why* this change is necessary, is totally over my head; I didn't
> even begin to think about that.
> 
> Thanks
> Laszlo
> 
> >
> >
> > Thank you
> > Yao Jiewen
> >
> >
> >> -----Original Message-----
> >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> Of
> >> Laszlo Ersek
> >> Sent: Thursday, May 9, 2019 2:53 AM
> >> To: devel@edk2.groups.io; Dong, Eric <eric.dong@intel.com>
> >> Cc: Wu, Hao A <hao.a.wu@intel.com>
> >> Subject: Re: [edk2-devel] [Patch v2 1/3] SecurityPkg/SecurityPkg.dec:
> >> Change default value.
> >>
> >> On 05/08/19 05:01, Dong, Eric wrote:
> >>> https://bugzilla.tianocore.org/show_bug.cgi?id=1782
> >>>
> >>> Change BlockSID default policy, default enable BlockSid.
> >>>
> >>> Signed-off-by: Eric Dong <eric.dong@intel.com>
> >>> Cc: Hao Wu <hao.a.wu@intel.com>
> >>> ---
> >>>  SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h | 3 ++-
> >>>  SecurityPkg/SecurityPkg.dec                           | 2 +-
> >>>  2 files changed, 3 insertions(+), 2 deletions(-)
> >>
> >> Please change the subject line as follows:
> >>
> >> ----
> >> SecurityPkg: enable BlockSID in PcdTcg2PhysicalPresenceFlags DEC
> default
> >> ----
> >>
> >> no need to resubmit just for this, just pls update the patch before you
> >> push it.
> >>
> >> Thanks
> >> Laszlo
> >>
> >>> diff --git a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> >> b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> >>> index d9eee7f3e8..8da3deaf86 100644
> >>> --- a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> >>> +++ b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> >>> @@ -51,7 +51,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> >>>  // Default value
> >>>  //
> >>>  #define TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_DEFAULT
> >>
> (TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_ENABLE
> >> _BLOCK_SID | \
> >>> -
> >>
> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_DISABLE_
> >> BLOCK_SID)
> >>> +
> >>
> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_PP_REQUIRED_FOR_DISABLE_
> >> BLOCK_SID |\
> >>> +
> >> TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_ENABLE_BLOCK_SID)
> >>>
> >>>  /**
> >>>    Check and execute the pending TPM request.
> >>> diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec
> >>> index 6e4c4c3a02..3314f1854b 100644
> >>> --- a/SecurityPkg/SecurityPkg.dec
> >>> +++ b/SecurityPkg/SecurityPkg.dec
> >>> @@ -410,7 +410,7 @@
> >>>    # PCD can be configured for different settings in different scenarios
> >>>    # Default setting is
> TCG2_BIOS_TPM_MANAGEMENT_FLAG_DEFAULT
> >> | TCG2_BIOS_STORAGE_MANAGEMENT_FLAG_DEFAULT
> >>>    # @Prompt Initial setting of TCG2 Persistent Firmware Management
> >> Flags
> >>> -
> >>
> gEfiSecurityPkgTokenSpaceGuid.PcdTcg2PhysicalPresenceFlags|0x300E2|UI
> >> NT32|0x0001001B
> >>> +
> >>
> gEfiSecurityPkgTokenSpaceGuid.PcdTcg2PhysicalPresenceFlags|0x700E2|UI
> >> NT32|0x0001001B
> >>>
> >>>    ## Indicate current TPM2 Interrupt Number reported by _CRS
> control
> >> method.<BR><BR>
> >>>    # TPM2 Interrupt feature is disabled If the pcd is set to 0.<BR>
> >>>
> >>
> >>
> >> 
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40379): https://edk2.groups.io/g/devel/message/40379
Mute This Topic: https://groups.io/mt/31539610/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.