[edk2-devel] [Patch V2 1/2] EmulatorPkg: Save the modified order after rebooting

Zhiguang Liu posted 2 patches 6 years, 9 months ago
[edk2-devel] [Patch V2 1/2] EmulatorPkg: Save the modified order after rebooting
Posted by Zhiguang Liu 6 years, 9 months ago
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1650

v2:
Abandon v1, and avoid using memory mapped FV device path
by adding FvNameGuid to EmulatorPkg.fdf file.

v1:
The reason why boot order changed is that everytime Emulator
restarts, the memory mapped address will change.
This patch correct the device path to the right one.

Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
---
 EmulatorPkg/EmulatorPkg.fdf | 1 +
 1 file changed, 1 insertion(+)

diff --git a/EmulatorPkg/EmulatorPkg.fdf b/EmulatorPkg/EmulatorPkg.fdf
index 85197a14ca..c5c69f8a84 100644
--- a/EmulatorPkg/EmulatorPkg.fdf
+++ b/EmulatorPkg/EmulatorPkg.fdf
@@ -80,6 +80,7 @@ DATA = {
 gEmulatorPkgTokenSpaceGuid.PcdEmuFlashNvStorageFtwSpareBase|gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize
 
 [FV.FvRecovery]
+FvNameGuid         = 6D99E806-3D38-42c2-A095-5F4300BFD7DC
 FvAlignment        = 16         #FV alignment and FV attributes setting.
 ERASE_POLARITY     = 1
 MEMORY_MAPPED      = TRUE
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40013): https://edk2.groups.io/g/devel/message/40013
Mute This Topic: https://groups.io/mt/31515768/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch V2 1/2] EmulatorPkg: Save the modified order after rebooting
Posted by Ni, Ray 6 years, 9 months ago
Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Liu, Zhiguang
> Sent: Monday, May 6, 2019 10:06 AM
> To: devel@edk2.groups.io
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
> <afish@apple.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [Patch V2 1/2] EmulatorPkg: Save the modified order after rebooting
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1650
> 
> v2:
> Abandon v1, and avoid using memory mapped FV device path by adding
> FvNameGuid to EmulatorPkg.fdf file.
> 
> v1:
> The reason why boot order changed is that everytime Emulator restarts, the
> memory mapped address will change.
> This patch correct the device path to the right one.
> 
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  EmulatorPkg/EmulatorPkg.fdf | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/EmulatorPkg/EmulatorPkg.fdf b/EmulatorPkg/EmulatorPkg.fdf
> index 85197a14ca..c5c69f8a84 100644
> --- a/EmulatorPkg/EmulatorPkg.fdf
> +++ b/EmulatorPkg/EmulatorPkg.fdf
> @@ -80,6 +80,7 @@ DATA = {
> 
> gEmulatorPkgTokenSpaceGuid.PcdEmuFlashNvStorageFtwSpareBase|gEfiMd
> eModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize
> 
>  [FV.FvRecovery]
> +FvNameGuid         = 6D99E806-3D38-42c2-A095-5F4300BFD7DC
>  FvAlignment        = 16         #FV alignment and FV attributes setting.
>  ERASE_POLARITY     = 1
>  MEMORY_MAPPED      = TRUE
> --
> 2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40018): https://edk2.groups.io/g/devel/message/40018
Mute This Topic: https://groups.io/mt/31515768/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-