IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style.

[edk2-devel] [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style.

Posted by Chiu, Chasel 6 years, 9 months ago

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1730

Internal code quality check failed after this commit:
68d47eea422d64eeb9872b927620f579f4ccfc0f, fixed those
coding style issues.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
---
 IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
index 9f8ce16023..0f8cd69a0e 100644
--- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
+++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
@@ -38,7 +38,7 @@ extern EFI_PEI_NOTIFY_DESCRIPTOR mS3EndOfPeiNotifyDesc;
 extern EFI_GUID                  gFspHobGuid;
 
 /**
-  This function handles S3 resume task at the end of PEI
+  This function handles S3 resume task at the end of PEI.
 
   @param[in] PeiServices    Pointer to PEI Services Table.
   @param[in] NotifyDesc     Pointer to the descriptor for the Notification event that
@@ -62,7 +62,7 @@ EFI_PEI_NOTIFY_DESCRIPTOR mS3EndOfPeiNotifyDesc = {
 };
 
 /**
-  This function handles S3 resume task at the end of PEI
+  This function handles S3 resume task at the end of PEI.
 
   @param[in] PeiServices    Pointer to PEI Services Table.
   @param[in] NotifyDesc     Pointer to the descriptor for the Notification event that
@@ -339,7 +339,7 @@ PeiMemoryDiscoveredNotify (
 }
 
 /**
-  Do FSP initialization in API mode
+  Do FSP initialization in API mode.
 
   @retval EFI_STATUS        Always return EFI_SUCCESS
 **/
@@ -370,7 +370,7 @@ FspsWrapperInitApiMode (
 }
 
 /**
-  Do FSP initialization in Dispatch mode
+  Do FSP initialization in Dispatch mode.
 
   @retval FSP initialization status.
 **/
@@ -399,7 +399,7 @@ FspsWrapperInitDispatchMode (
 }
 
 /**
-  This is the entrypoint of PEIM
+  This is the entrypoint of PEIM.
 
   @param[in] FileHandle  Handle of the file being invoked.
   @param[in] PeiServices Describes the list of possible PEI Services.
-- 
2.13.3.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39365): https://edk2.groups.io/g/devel/message/39365
Mute This Topic: https://groups.io/mt/31272219/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style.

Posted by Philippe Mathieu-Daudé 6 years, 2 months ago

On 4/22/19 12:11 PM, Chiu, Chasel wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1730
> 
> Internal code quality check failed after this commit:
> 68d47eea422d64eeb9872b927620f579f4ccfc0f, fixed those
> coding style issues.
> 
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
> ---
>   IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> index 9f8ce16023..0f8cd69a0e 100644
> --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> @@ -38,7 +38,7 @@ extern EFI_PEI_NOTIFY_DESCRIPTOR mS3EndOfPeiNotifyDesc;
>   extern EFI_GUID                  gFspHobGuid;
>   
>   /**
> -  This function handles S3 resume task at the end of PEI
> +  This function handles S3 resume task at the end of PEI.
>   
>     @param[in] PeiServices    Pointer to PEI Services Table.
>     @param[in] NotifyDesc     Pointer to the descriptor for the Notification event that
> @@ -62,7 +62,7 @@ EFI_PEI_NOTIFY_DESCRIPTOR mS3EndOfPeiNotifyDesc = {
>   };
>   
>   /**
> -  This function handles S3 resume task at the end of PEI
> +  This function handles S3 resume task at the end of PEI.
>   
>     @param[in] PeiServices    Pointer to PEI Services Table.
>     @param[in] NotifyDesc     Pointer to the descriptor for the Notification event that
> @@ -339,7 +339,7 @@ PeiMemoryDiscoveredNotify (
>   }
>   
>   /**
> -  Do FSP initialization in API mode
> +  Do FSP initialization in API mode.
>   
>     @retval EFI_STATUS        Always return EFI_SUCCESS
>   **/
> @@ -370,7 +370,7 @@ FspsWrapperInitApiMode (
>   }
>   
>   /**
> -  Do FSP initialization in Dispatch mode
> +  Do FSP initialization in Dispatch mode.
>   
>     @retval FSP initialization status.
>   **/
> @@ -399,7 +399,7 @@ FspsWrapperInitDispatchMode (
>   }
>   
>   /**
> -  This is the entrypoint of PEIM
> +  This is the entrypoint of PEIM.
>   
>     @param[in] FileHandle  Handle of the file being invoked.
>     @param[in] PeiServices Describes the list of possible PEI Services.
> 

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51582): https://edk2.groups.io/g/devel/message/51582
Mute This Topic: https://groups.io/mt/31272219/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style.

Posted by Nate DeSimone 6 years, 2 months ago

Hi Philippe,

FYI, this patch from Chasel was merged 8 months ago:

https://github.com/tianocore/edk2/commit/00e3e4801467dd73b90a151994fc26ba9b5734d7

Thanks,
Nate

-----Original Message-----
From: Philippe Mathieu-Daudé <philmd@redhat.com> 
Sent: Monday, December 2, 2019 11:20 PM
To: devel@edk2.groups.io; Chiu, Chasel <chasel.chiu@intel.com>
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style.

On 4/22/19 12:11 PM, Chiu, Chasel wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1730
> 
> Internal code quality check failed after this commit:
> 68d47eea422d64eeb9872b927620f579f4ccfc0f, fixed those coding style 
> issues.
> 
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
> ---
>   IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c 
> b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> index 9f8ce16023..0f8cd69a0e 100644
> --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> @@ -38,7 +38,7 @@ extern EFI_PEI_NOTIFY_DESCRIPTOR mS3EndOfPeiNotifyDesc;
>   extern EFI_GUID                  gFspHobGuid;
>   
>   /**
> -  This function handles S3 resume task at the end of PEI
> +  This function handles S3 resume task at the end of PEI.
>   
>     @param[in] PeiServices    Pointer to PEI Services Table.
>     @param[in] NotifyDesc     Pointer to the descriptor for the Notification event that
> @@ -62,7 +62,7 @@ EFI_PEI_NOTIFY_DESCRIPTOR mS3EndOfPeiNotifyDesc = {
>   };
>   
>   /**
> -  This function handles S3 resume task at the end of PEI
> +  This function handles S3 resume task at the end of PEI.
>   
>     @param[in] PeiServices    Pointer to PEI Services Table.
>     @param[in] NotifyDesc     Pointer to the descriptor for the Notification event that
> @@ -339,7 +339,7 @@ PeiMemoryDiscoveredNotify (
>   }
>   
>   /**
> -  Do FSP initialization in API mode
> +  Do FSP initialization in API mode.
>   
>     @retval EFI_STATUS        Always return EFI_SUCCESS
>   **/
> @@ -370,7 +370,7 @@ FspsWrapperInitApiMode (
>   }
>   
>   /**
> -  Do FSP initialization in Dispatch mode
> +  Do FSP initialization in Dispatch mode.
>   
>     @retval FSP initialization status.
>   **/
> @@ -399,7 +399,7 @@ FspsWrapperInitDispatchMode (
>   }
>   
>   /**
> -  This is the entrypoint of PEIM
> +  This is the entrypoint of PEIM.
>   
>     @param[in] FileHandle  Handle of the file being invoked.
>     @param[in] PeiServices Describes the list of possible PEI Services.
> 

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#51691): https://edk2.groups.io/g/devel/message/51691
Mute This Topic: https://groups.io/mt/31272219/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style.

Posted by Zeng, Star 6 years, 9 months ago

Reviewed-by: Star Zeng <star.zeng@intel.com>

-----Original Message-----
From: Chiu, Chasel 
Sent: Monday, April 22, 2019 6:12 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1730

Internal code quality check failed after this commit:
68d47eea422d64eeb9872b927620f579f4ccfc0f, fixed those coding style issues.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
---
 IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
index 9f8ce16023..0f8cd69a0e 100644
--- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
+++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
@@ -38,7 +38,7 @@ extern EFI_PEI_NOTIFY_DESCRIPTOR mS3EndOfPeiNotifyDesc;
 extern EFI_GUID                  gFspHobGuid;
 
 /**
-  This function handles S3 resume task at the end of PEI
+  This function handles S3 resume task at the end of PEI.
 
   @param[in] PeiServices    Pointer to PEI Services Table.
   @param[in] NotifyDesc     Pointer to the descriptor for the Notification event that
@@ -62,7 +62,7 @@ EFI_PEI_NOTIFY_DESCRIPTOR mS3EndOfPeiNotifyDesc = {  };
 
 /**
-  This function handles S3 resume task at the end of PEI
+  This function handles S3 resume task at the end of PEI.
 
   @param[in] PeiServices    Pointer to PEI Services Table.
   @param[in] NotifyDesc     Pointer to the descriptor for the Notification event that
@@ -339,7 +339,7 @@ PeiMemoryDiscoveredNotify (  }
 
 /**
-  Do FSP initialization in API mode
+  Do FSP initialization in API mode.
 
   @retval EFI_STATUS        Always return EFI_SUCCESS
 **/
@@ -370,7 +370,7 @@ FspsWrapperInitApiMode (  }
 
 /**
-  Do FSP initialization in Dispatch mode
+  Do FSP initialization in Dispatch mode.
 
   @retval FSP initialization status.
 **/
@@ -399,7 +399,7 @@ FspsWrapperInitDispatchMode (  }
 
 /**
-  This is the entrypoint of PEIM
+  This is the entrypoint of PEIM.
 
   @param[in] FileHandle  Handle of the file being invoked.
   @param[in] PeiServices Describes the list of possible PEI Services.
--
2.13.3.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39366): https://edk2.groups.io/g/devel/message/39366
Mute This Topic: https://groups.io/mt/31272219/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-