[edk2] [PATCH v2 0/5] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller

Laszlo Ersek posted 5 patches 17 weeks ago
Failed in applying to current master (apply log)
BaseTools/Source/C/Makefiles/footer.makefile |  2 +-
BaseTools/Source/C/Makefiles/header.makefile | 16 +++++++++++++---
BaseTools/Source/C/VfrCompile/GNUmakefile    | 11 +++++++----
3 files changed, 21 insertions(+), 8 deletions(-)

[edk2] [PATCH v2 0/5] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller

Posted by Laszlo Ersek 17 weeks ago
Repo:   https://github.com/lersek/edk2.git
Branch: extra_flags_rhbz1540244_v2

Version 1 of this set was posted at

  http://mid.mail-archive.com/20180726004415.13381-1-lersek@redhat.com
  https://lists.01.org/pipermail/edk2-devel/2018-July/027606.html

In version 2 (i.e., this version), the PCCTS tools (the "dlg" lexer
generator and the "antlr" parser generator) are not modified. Relative
to v1:

- "[PATCH 4/6] BaseTools/Pccts: clean up antlr and dlg makefiles" has
  been dropped,

- the "BaseTools/Source/C/VfrCompile/Pccts" hunks have been removed from
  "[PATCH 5/6] BaseTools/Source/C: take EXTRA_OPTFLAGS from the caller"
  and "[PATCH 6/6] BaseTools/Source/C: take EXTRA_LDFLAGS from the
  caller".

In other words, v2 is a proper subset of v1, so that PCCTS is left
alone.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>

Thanks!
Laszlo

Laszlo Ersek (5):
  BaseTools/footer.makefile: expand BUILD_CFLAGS last for C files too
  BaseTools/header.makefile: remove "-c" from BUILD_CFLAGS
  BaseTools/Source/C: split "-O2" to BUILD_OPTFLAGS
  BaseTools/Source/C: take EXTRA_OPTFLAGS from the caller
  BaseTools/Source/C: take EXTRA_LDFLAGS from the caller

 BaseTools/Source/C/Makefiles/footer.makefile |  2 +-
 BaseTools/Source/C/Makefiles/header.makefile | 16 +++++++++++++---
 BaseTools/Source/C/VfrCompile/GNUmakefile    | 11 +++++++----
 3 files changed, 21 insertions(+), 8 deletions(-)

-- 
2.14.1.3.gb7cf6e02401b

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 0/5] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller

Posted by Laszlo Ersek 17 weeks ago
Hi Liming,

On 08/09/18 15:22, Laszlo Ersek wrote:
> Repo:   https://github.com/lersek/edk2.git
> Branch: extra_flags_rhbz1540244_v2
> 
> Version 1 of this set was posted at
> 
>   http://mid.mail-archive.com/20180726004415.13381-1-lersek@redhat.com
>   https://lists.01.org/pipermail/edk2-devel/2018-July/027606.html
> 
> In version 2 (i.e., this version), the PCCTS tools (the "dlg" lexer
> generator and the "antlr" parser generator) are not modified. Relative
> to v1:
> 
> - "[PATCH 4/6] BaseTools/Pccts: clean up antlr and dlg makefiles" has
>   been dropped,
> 
> - the "BaseTools/Source/C/VfrCompile/Pccts" hunks have been removed from
>   "[PATCH 5/6] BaseTools/Source/C: take EXTRA_OPTFLAGS from the caller"
>   and "[PATCH 6/6] BaseTools/Source/C: take EXTRA_LDFLAGS from the
>   caller".
> 
> In other words, v2 is a proper subset of v1, so that PCCTS is left
> alone.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>

do you have any comments on patches #4 and #5?

Thanks,
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 0/5] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller

Posted by Gao, Liming 17 weeks ago
Laszlo:
  The patch is good. Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Wednesday, August 15, 2018 10:19 AM
> To: Gao, Liming <liming.gao@intel.com>
> Cc: edk2-devel-01 <edk2-devel@lists.01.org>
> Subject: Re: [edk2] [PATCH v2 0/5] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller
> 
> Hi Liming,
> 
> On 08/09/18 15:22, Laszlo Ersek wrote:
> > Repo:   https://github.com/lersek/edk2.git
> > Branch: extra_flags_rhbz1540244_v2
> >
> > Version 1 of this set was posted at
> >
> >   http://mid.mail-archive.com/20180726004415.13381-1-lersek@redhat.com
> >   https://lists.01.org/pipermail/edk2-devel/2018-July/027606.html
> >
> > In version 2 (i.e., this version), the PCCTS tools (the "dlg" lexer
> > generator and the "antlr" parser generator) are not modified. Relative
> > to v1:
> >
> > - "[PATCH 4/6] BaseTools/Pccts: clean up antlr and dlg makefiles" has
> >   been dropped,
> >
> > - the "BaseTools/Source/C/VfrCompile/Pccts" hunks have been removed from
> >   "[PATCH 5/6] BaseTools/Source/C: take EXTRA_OPTFLAGS from the caller"
> >   and "[PATCH 6/6] BaseTools/Source/C: take EXTRA_LDFLAGS from the
> >   caller".
> >
> > In other words, v2 is a proper subset of v1, so that PCCTS is left
> > alone.
> >
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> 
> do you have any comments on patches #4 and #5?
> 
> Thanks,
> Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 0/5] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller

Posted by Laszlo Ersek 16 weeks ago
On 08/15/18 19:37, Gao, Liming wrote:
> Laszlo:
>   The patch is good. Reviewed-by: Liming Gao <liming.gao@intel.com>

Thanks!

Pushed as commit range 9becf2f0759e..81502cee20ac.

Laszlo

> 
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>> Sent: Wednesday, August 15, 2018 10:19 AM
>> To: Gao, Liming <liming.gao@intel.com>
>> Cc: edk2-devel-01 <edk2-devel@lists.01.org>
>> Subject: Re: [edk2] [PATCH v2 0/5] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller
>>
>> Hi Liming,
>>
>> On 08/09/18 15:22, Laszlo Ersek wrote:
>>> Repo:   https://github.com/lersek/edk2.git
>>> Branch: extra_flags_rhbz1540244_v2
>>>
>>> Version 1 of this set was posted at
>>>
>>>   http://mid.mail-archive.com/20180726004415.13381-1-lersek@redhat.com
>>>   https://lists.01.org/pipermail/edk2-devel/2018-July/027606.html
>>>
>>> In version 2 (i.e., this version), the PCCTS tools (the "dlg" lexer
>>> generator and the "antlr" parser generator) are not modified. Relative
>>> to v1:
>>>
>>> - "[PATCH 4/6] BaseTools/Pccts: clean up antlr and dlg makefiles" has
>>>   been dropped,
>>>
>>> - the "BaseTools/Source/C/VfrCompile/Pccts" hunks have been removed from
>>>   "[PATCH 5/6] BaseTools/Source/C: take EXTRA_OPTFLAGS from the caller"
>>>   and "[PATCH 6/6] BaseTools/Source/C: take EXTRA_LDFLAGS from the
>>>   caller".
>>>
>>> In other words, v2 is a proper subset of v1, so that PCCTS is left
>>> alone.
>>>
>>> Cc: Liming Gao <liming.gao@intel.com>
>>> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
>>
>> do you have any comments on patches #4 and #5?
>>
>> Thanks,
>> Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel