Avoid possible NULL ptr dereference

[edk2] [PATCH 0/2] Avoid possible NULL ptr dereference

Posted by Hao Wu 5 years, 8 months ago

Cc: Jiewen Yao <jiewen.yao@intel.com>

Hao Wu (2):
  MdePkg/SmmMemLib: Avoid possible NULL ptr dereference
  UefiCpuPkg/PiSmmCpuDxeSmm: Avoid possible NULL ptr dereference

 MdePkg/Library/SmmMemLib/SmmMemLib.c               | 2 +-
 UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.12.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 0/2] Avoid possible NULL ptr dereference

Posted by Yao, Jiewen 5 years, 8 months ago

Seems good.

It might be better to use "if (!EFI_ERROR (Status) && (MemoryAttributesTable != NULL)) {"

Reviewed-by: Jiewen.yao@intel.com


> -----Original Message-----
> From: Wu, Hao A
> Sent: Monday, July 30, 2018 1:37 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [PATCH 0/2] Avoid possible NULL ptr dereference
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> 
> Hao Wu (2):
>   MdePkg/SmmMemLib: Avoid possible NULL ptr dereference
>   UefiCpuPkg/PiSmmCpuDxeSmm: Avoid possible NULL ptr dereference
> 
>  MdePkg/Library/SmmMemLib/SmmMemLib.c               | 2 +-
>  UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> --
> 2.12.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 0/2] Avoid possible NULL ptr dereference

Posted by Wu, Hao A 5 years, 8 months ago

> -----Original Message-----
> From: Yao, Jiewen
> Sent: Monday, July 30, 2018 3:25 PM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Yao, Jiewen
> Subject: RE: [PATCH 0/2] Avoid possible NULL ptr dereference
> 
> Seems good.
> 
> It might be better to use "if (!EFI_ERROR (Status) &&
> (MemoryAttributesTable != NULL)) {"

Yes. I will update the it when pushing the patch.

Best Regards,
Hao Wu

> 
> Reviewed-by: Jiewen.yao@intel.com
> 
> 
> > -----Original Message-----
> > From: Wu, Hao A
> > Sent: Monday, July 30, 2018 1:37 PM
> > To: edk2-devel@lists.01.org
> > Cc: Wu, Hao A <hao.a.wu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
> > Subject: [PATCH 0/2] Avoid possible NULL ptr dereference
> >
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> >
> > Hao Wu (2):
> >   MdePkg/SmmMemLib: Avoid possible NULL ptr dereference
> >   UefiCpuPkg/PiSmmCpuDxeSmm: Avoid possible NULL ptr dereference
> >
> >  MdePkg/Library/SmmMemLib/SmmMemLib.c               | 2 +-
> >  UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > --
> > 2.12.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel