ShellPkg/Dp: Cumulate the perf data of "DB:Stop"

[edk2] [patch] ShellPkg/Dp: Cumulate the perf data of "DB:Stop"

Posted by Dandan Bi 5 years, 9 months ago

Currently DP tool will cumulate the performance data for
Driver Binding Support/Start, will count the number they
appears, and record the maximum/minimum time value...
Now add Driver Binding Stop performance data to the
cumulative data to keep consistency.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
index 213f6057c9..2c094b63c9 100644
--- a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
+++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
@@ -71,11 +71,12 @@ UINTN               mMeasurementNum    = 0;
 /// Items for which to gather cumulative statistics.
 PERF_CUM_DATA CumData[] = {
   PERF_INIT_CUM_DATA (LOAD_IMAGE_TOK),
   PERF_INIT_CUM_DATA (START_IMAGE_TOK),
   PERF_INIT_CUM_DATA (DRIVERBINDING_START_TOK),
-  PERF_INIT_CUM_DATA (DRIVERBINDING_SUPPORT_TOK)
+  PERF_INIT_CUM_DATA (DRIVERBINDING_SUPPORT_TOK),
+  PERF_INIT_CUM_DATA (DRIVERBINDING_STOP_TOK)
 };
 
 /// Number of items for which we are gathering cumulative statistics.
 UINT32 const      NumCum = sizeof(CumData) / sizeof(PERF_CUM_DATA);
 
-- 
2.14.3.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [patch] ShellPkg/Dp: Cumulate the perf data of "DB:Stop"

Posted by Carsey, Jaben 5 years, 9 months ago

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: Bi, Dandan
> Sent: Thursday, July 19, 2018 12:08 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>; Carsey, Jaben
> <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [patch] ShellPkg/Dp: Cumulate the perf data of "DB:Stop"
> Importance: High
> 
> Currently DP tool will cumulate the performance data for
> Driver Binding Support/Start, will count the number they
> appears, and record the maximum/minimum time value...
> Now add Driver Binding Stop performance data to the
> cumulative data to keep consistency.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
> b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
> index 213f6057c9..2c094b63c9 100644
> --- a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
> +++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
> @@ -71,11 +71,12 @@ UINTN               mMeasurementNum    = 0;
>  /// Items for which to gather cumulative statistics.
>  PERF_CUM_DATA CumData[] = {
>    PERF_INIT_CUM_DATA (LOAD_IMAGE_TOK),
>    PERF_INIT_CUM_DATA (START_IMAGE_TOK),
>    PERF_INIT_CUM_DATA (DRIVERBINDING_START_TOK),
> -  PERF_INIT_CUM_DATA (DRIVERBINDING_SUPPORT_TOK)
> +  PERF_INIT_CUM_DATA (DRIVERBINDING_SUPPORT_TOK),
> +  PERF_INIT_CUM_DATA (DRIVERBINDING_STOP_TOK)
>  };
> 
>  /// Number of items for which we are gathering cumulative statistics.
>  UINT32 const      NumCum = sizeof(CumData) / sizeof(PERF_CUM_DATA);
> 
> --
> 2.14.3.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel